Remove value check from formHook; other elements can use value hook

diff --git a/src/attributes.js b/src/attributes.js
index 4d16447068902f46a2c6133ed345cbd9db45ae34..c207a001c5f57db397f9976d488070ee674b7cce 100644 (file)
--- a/src/attributes.js
+++ b/src/attributes.js
@@ -495,9 +495,6 @@ if ( !jQuery.support.getSetAttribute ) {
        formHook = jQuery.attrHooks.name = jQuery.attrHooks.value = jQuery.valHooks.button = {
                get: function( elem, name ) {
                        var ret;
-                       if ( name === "value" && !jQuery.nodeName( elem, "button" ) ) {
-                               return elem.getAttribute( name );
-                       }
                        ret = elem.getAttributeNode( name );
                        // Return undefined if nodeValue is empty string
                        return ret && ret.nodeValue !== "" ?

diff --git a/test/unit/attributes.js b/test/unit/attributes.js
index 37e93d0a1e91c8449394d1e9fc65bfdf515036ce..ce7775d1d3b912f63fa3a6cd41890fd6c30d3719 100644 (file)
--- a/test/unit/attributes.js
+++ b/test/unit/attributes.js
@@ -144,7 +144,7 @@ test("attr(Hash)", function() {
 });
 
 test("attr(String, Object)", function() {
-       expect(58);
+       expect(59);
 
        var div = jQuery("div").attr("foo", "bar"),
                fail = false;
@@ -244,6 +244,8 @@ test("attr(String, Object)", function() {
        table.attr("cellspacing", "2");
        equals( table[0].cellSpacing, "2", "Check cellspacing is correctly set" );
 
+       equals( jQuery("#area1").attr("value"), undefined, "Value attribute retrieved correctly on textarea." );
+
        // for #1070
        jQuery("#name").attr("someAttr", "0");
        equals( jQuery("#name").attr("someAttr"), "0", "Set attribute to a string of \"0\"" );