Fix quality flaws

diff --git a/sonar-server/src/main/java/org/sonar/server/issue/CommentAction.java b/sonar-server/src/main/java/org/sonar/server/issue/CommentAction.java
index cb12690cb26dffb0e6a3c7baf04af5942cc777fd..8550c60b2a32603fd67831a1dc8b644a2436db44 100644 (file)
--- a/sonar-server/src/main/java/org/sonar/server/issue/CommentAction.java
+++ b/sonar-server/src/main/java/org/sonar/server/issue/CommentAction.java
@@ -45,7 +45,8 @@ public class CommentAction extends Action implements ServerComponent {
 
   @Override
   public boolean verify(Map<String, Object> properties, List<Issue> issues, UserSession userSession) {
-    return comment(properties) != null;
+    comment(properties);
+    return true;
   }
 
   @Override

diff --git a/sonar-server/src/main/java/org/sonar/server/issue/SetSeverityAction.java b/sonar-server/src/main/java/org/sonar/server/issue/SetSeverityAction.java
index 4a5ea4c82f1addebd47bb7af202e76575d758ce0..ab9ab82c97369d65a3893527a2fc79d8aeea4190 100644 (file)
--- a/sonar-server/src/main/java/org/sonar/server/issue/SetSeverityAction.java
+++ b/sonar-server/src/main/java/org/sonar/server/issue/SetSeverityAction.java
@@ -46,7 +46,8 @@ public class SetSeverityAction extends Action implements ServerComponent {
 
   @Override
   public boolean verify(Map<String, Object> properties, List<Issue> issues, UserSession userSession) {
-    return severity(properties) != null;
+    severity(properties);
+    return true;
   }
 
   @Override

diff --git a/sonar-server/src/main/java/org/sonar/server/issue/TransitionAction.java b/sonar-server/src/main/java/org/sonar/server/issue/TransitionAction.java
index cc949f993dcc9ab0bcefdeeb08f46fb34ae1a026..16da057468a839c397bf6f7923988261a0953ea5 100644 (file)
--- a/sonar-server/src/main/java/org/sonar/server/issue/TransitionAction.java
+++ b/sonar-server/src/main/java/org/sonar/server/issue/TransitionAction.java
@@ -43,7 +43,8 @@ public class TransitionAction extends Action implements ServerComponent {
 
   @Override
   public boolean verify(Map<String, Object> properties, List<Issue> issues, UserSession userSession) {
-    return transition(properties) != null;
+    transition(properties);
+    return true;
   }
 
   @Override