Title can be empty when creating tag only (#23917) (#23961)

Backport #23917 by @Zettat123

Fixes #23809

Make the title not required. If the title is empty when creating release
(not tag), an error message will be displayed.

![image](https://user-images.githubusercontent.com/15528715/229761056-c52e338b-5f25-4d7d-bb44-2cb0304abcee.png)

Co-authored-by: Zettat123 <zettat123@gmail.com>

diff --git a/options/locale/locale_en-US.ini b/options/locale/locale_en-US.ini
index 081ffb7abf299ec44e8c90b7ee03d8ada6f48d25..5154aadb68c89bc60c449a9fe96fe7ad642dacb1 100644 (file)
--- a/options/locale/locale_en-US.ini
+++ b/options/locale/locale_en-US.ini
@@ -2288,6 +2288,7 @@ release.tag_name = Tag name
 release.target = Target
 release.tag_helper = Choose an existing tag or create a new tag.
 release.title = Title
+release.title_empty = Title cannot be empty.
 release.content = Content
 release.prerelease_desc = Mark as Pre-Release
 release.prerelease_helper = Mark this release unsuitable for production use.

diff --git a/routers/web/repo/release.go b/routers/web/repo/release.go
index e969fdc5ab377096f4a6720f219fccd7eb7b01ac..63c8797fe56a408f21e5e1e2bc51189b5ebd6a8c 100644 (file)
--- a/routers/web/repo/release.go
+++ b/routers/web/repo/release.go
@@ -357,6 +357,12 @@ func NewReleasePost(ctx *context.Context) {
                return
        }
 
+       // Title of release cannot be empty
+       if len(form.TagOnly) == 0 && len(form.Title) == 0 {
+               ctx.RenderWithErr(ctx.Tr("repo.release.title_empty"), tplReleaseNew, &form)
+               return
+       }
+
        var attachmentUUIDs []string
        if setting.Attachment.Enabled {
                attachmentUUIDs = form.Files

diff --git a/services/forms/repo_form.go b/services/forms/repo_form.go
index e9645b5ab737b6ce542c526ea299a7bfd1f25d71..a08f9bc9e434dd59c094e39774e4bd4b391857ec 100644 (file)
--- a/services/forms/repo_form.go
+++ b/services/forms/repo_form.go
@@ -693,7 +693,7 @@ type UpdateAllowEditsForm struct {
 type NewReleaseForm struct {
        TagName    string `binding:"Required;GitRefName;MaxSize(255)"`
        Target     string `form:"tag_target" binding:"Required;MaxSize(255)"`
-       Title      string `binding:"Required;MaxSize(255)"`
+       Title      string `binding:"MaxSize(255)"`
        Content    string
        Draft      string
        TagOnly    string

diff --git a/templates/repo/release/new.tmpl b/templates/repo/release/new.tmpl
index 37d7ca032196e5020dd137bfb84d42037092b15a..0cac6705224d61ff6b0c6d18518cbe648ad87749 100644 (file)
--- a/templates/repo/release/new.tmpl
+++ b/templates/repo/release/new.tmpl
@@ -42,7 +42,7 @@
                        <div class="eleven wide column">
                                <div class="field {{if .Err_Title}}error{{end}}">
                                        <label>{{.locale.Tr "repo.release.title"}}</label>
-                                       <input name="title" placeholder="{{.locale.Tr "repo.release.title"}}" value="{{.title}}" autofocus required maxlength="255">
+                                       <input name="title" placeholder="{{.locale.Tr "repo.release.title"}}" value="{{.title}}" autofocus maxlength="255">
                                </div>
                                <div class="field content-editor">
                                        <label>{{.locale.Tr "repo.release.content"}}</label>