Do not log passwords in debug mode

Signed-off-by: Anna Larch <anna@nextcloud.com>

diff --git a/apps/user_ldap/lib/LDAP.php b/apps/user_ldap/lib/LDAP.php
index 41a6f651f3bf0e9cf4a7fd5a10e724d4927b272f..454350ba0957085360223ab7a41ac1d3ba859228 100644 (file)
--- a/apps/user_ldap/lib/LDAP.php
+++ b/apps/user_ldap/lib/LDAP.php
@@ -33,6 +33,7 @@
  */
 namespace OCA\User_LDAP;
 
+use OCP\IConfig;
 use OCP\Profiler\IProfiler;
 use OC\ServerNotAvailableException;
 use OCA\User_LDAP\DataCollector\LdapDataCollector;
@@ -317,6 +318,14 @@ class LDAP implements ILDAPWrapper {
 
        private function preFunctionCall(string $functionName, array $args): void {
                $this->curArgs = $args;
+               if(strcasecmp($functionName, 'ldap_bind') === 0) {
+                       // The arguments are not key value pairs
+                       // \OCA\User_LDAP\LDAP::bind passes 3 arguments, the 3rd being the pw
+                       // Remove it via direct array access for now, although a better solution could be found mebbe?
+                       // @link https://github.com/nextcloud/server/issues/38461
+                       $args[2] = IConfig::SENSITIVE_VALUE;
+               }
+
                $this->logger->debug('Calling LDAP function {func} with parameters {args}', [
                        'app' => 'user_ldap',
                        'func' => $functionName,