]> source.dussan.org Git - gitblit.git/commitdiff
Ensure repository is closed after processing a pages request
authorJames Moger <james.moger@gitblit.com>
Wed, 23 Apr 2014 16:55:45 +0000 (12:55 -0400)
committerJames Moger <james.moger@gitblit.com>
Wed, 23 Apr 2014 16:55:45 +0000 (12:55 -0400)
src/main/java/com/gitblit/servlet/PagesServlet.java

index 1d767deffaf69ba1619ba2f9dae346f5827862e7..7e48f8e2082655e7185842760bcbabf25d2c2298 100644 (file)
@@ -157,7 +157,6 @@ public class PagesServlet extends DaggerServlet {
                                                "# Error\nSorry, the repository {0} does not have a **gh-pages** branch!",\r
                                                repository);\r
                                error(response, mkd);\r
-                               r.close();\r
                                return;\r
                        }\r
 \r
@@ -309,10 +308,10 @@ public class PagesServlet extends DaggerServlet {
                                logger.error("Failed to write page to client", t);\r
                        }\r
 \r
-                       // close the repository\r
-                       r.close();\r
                } catch (Throwable t) {\r
                        logger.error("Failed to write page to client", t);\r
+               } finally {\r
+                       r.close();\r
                }\r
        }\r
 \r