findbugs fixes - ME_MUTABLE_ENUM_FIELD

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749116 13f79535-47bb-0310-9956-ffa450edef68

diff --git a/src/java/org/apache/poi/sl/usermodel/PresetColor.java b/src/java/org/apache/poi/sl/usermodel/PresetColor.java
index 72e9fc661fd74f0a02c23e7088fb7312f84e4e13..f78dbca4064b1728bacf9a34e56f0bee95cb5018 100644 (file)
--- a/src/java/org/apache/poi/sl/usermodel/PresetColor.java
+++ b/src/java/org/apache/poi/sl/usermodel/PresetColor.java
@@ -247,9 +247,9 @@ public enum PresetColor {
     MenuHighlight           (0xff3399ff, 174, "menuHighlight")\r
     ;\r
 \r
-    public Color color;\r
-    public int nativeId;\r
-    public String ooxmlId;\r
+    public final Color color;\r
+    public final int nativeId;\r
+    public final String ooxmlId;\r
 \r
     PresetColor(Integer rgb, int nativeId, String ooxmlId) {\r
         this.color = (rgb == null) ? null : new Color(rgb, true);\r

diff --git a/src/java/org/apache/poi/ss/usermodel/ConditionalFormattingThreshold.java b/src/java/org/apache/poi/ss/usermodel/ConditionalFormattingThreshold.java
index 8f2ecaf52629247bdbdd51761d73ebab099da9f3..a5e52b1b3ab69849f74dd4c28a34e6a28c954cd3 100644 (file)
--- a/src/java/org/apache/poi/ss/usermodel/ConditionalFormattingThreshold.java
+++ b/src/java/org/apache/poi/ss/usermodel/ConditionalFormattingThreshold.java
@@ -43,7 +43,7 @@ public interface ConditionalFormattingThreshold {
         FORMULA(7, "formula");\r
         \r
         /** Numeric ID of the type */\r
-        public int id;\r
+        public final int id;\r
         /** Name (system) of the type */\r
         public final String name;\r
         \r

diff --git a/src/scratchpad/src/org/apache/poi/hwmf/record/HwmfFill.java b/src/scratchpad/src/org/apache/poi/hwmf/record/HwmfFill.java
index 2dabb069fdf76fe8c9fa38160a4b4762599e5dbc..e13164f348abf3bbb944b3cfac5f5e5c7bbeec99 100644 (file)
--- a/src/scratchpad/src/org/apache/poi/hwmf/record/HwmfFill.java
+++ b/src/scratchpad/src/org/apache/poi/hwmf/record/HwmfFill.java
@@ -57,7 +57,7 @@ public class HwmfFill {
         ;\r
 \r
 \r
-        int flag;\r
+        public final int flag;\r
         ColorUsage(int flag) {\r
             this.flag = flag;\r
         }\r
@@ -208,8 +208,8 @@ public class HwmfFill {
              */\r
             WINDING(0x0002, Path2D.WIND_NON_ZERO);\r
 \r
-            public int wmfFlag;\r
-            public int awtFlag;\r
+            public final int wmfFlag;\r
+            public final int awtFlag;\r
             HwmfPolyfillMode(int wmfFlag, int awtFlag) {\r
                 this.wmfFlag = wmfFlag;\r
                 this.awtFlag = awtFlag;\r

diff --git a/src/scratchpad/src/org/apache/poi/hwmf/record/HwmfPenStyle.java b/src/scratchpad/src/org/apache/poi/hwmf/record/HwmfPenStyle.java
index fb2ce122e138ab4a365792b5860da6a477816230..a881c44035fb6134d987b7bfaf51bef0c431fceb 100644 (file)
--- a/src/scratchpad/src/org/apache/poi/hwmf/record/HwmfPenStyle.java
+++ b/src/scratchpad/src/org/apache/poi/hwmf/record/HwmfPenStyle.java
@@ -41,8 +41,8 @@ public class HwmfPenStyle implements Cloneable {
         /** Line ends at end point*/\r
         FLAT(2, BasicStroke.CAP_BUTT);        \r
 \r
-        public int wmfFlag;\r
-        public int awtFlag;\r
+        public final int wmfFlag;\r
+        public final int awtFlag;\r
         HwmfLineCap(int wmfFlag, int awtFlag) {\r
             this.wmfFlag = wmfFlag;\r
             this.awtFlag = awtFlag;\r
@@ -67,8 +67,8 @@ public class HwmfPenStyle implements Cloneable {
          */\r
         MITER(2, BasicStroke.JOIN_MITER);\r
 \r
-        public int wmfFlag;\r
-        public int awtFlag;\r
+        public final int wmfFlag;\r
+        public final int awtFlag;\r
         HwmfLineJoin(int wmfFlag, int awtFlag) {\r
             this.wmfFlag = wmfFlag;\r
             this.awtFlag = awtFlag;\r
@@ -121,8 +121,8 @@ public class HwmfPenStyle implements Cloneable {
         USERSTYLE(0x0007, null);\r
         \r
 \r
-        public int wmfFlag;\r
-        public float[] dashes;\r
+        public final int wmfFlag;\r
+        public final float[] dashes;\r
         HwmfLineDash(int wmfFlag, float... dashes) {\r
             this.wmfFlag = wmfFlag;\r
             this.dashes = dashes;\r

diff --git a/src/scratchpad/src/org/apache/poi/hwmf/record/HwmfRecordType.java b/src/scratchpad/src/org/apache/poi/hwmf/record/HwmfRecordType.java
index db40bb6f8c29803dcf12bc20c36724f845e0635e..edc2e6f4d856bc15122059616dc4c00dba3bb8a5 100644 (file)
--- a/src/scratchpad/src/org/apache/poi/hwmf/record/HwmfRecordType.java
+++ b/src/scratchpad/src/org/apache/poi/hwmf/record/HwmfRecordType.java
@@ -95,8 +95,8 @@ public enum HwmfRecordType {
     ,textOut(0x0521, HwmfText.WmfTextOut.class)\r
     ;\r
     \r
-    public int id;\r
-    public Class<? extends HwmfRecord> clazz;\r
+    public final int id;\r
+    public final Class<? extends HwmfRecord> clazz;\r
     \r
     HwmfRecordType(int id, Class<? extends HwmfRecord> clazz) {\r
         this.id = id;\r