]> source.dussan.org Git - gitblit.git/commitdiff
[findbugs] Fix missing 'throw' on plugin installation failure
authorJames Moger <james.moger@gitblit.com>
Fri, 18 Apr 2014 00:31:41 +0000 (20:31 -0400)
committerJames Moger <james.moger@gitblit.com>
Fri, 18 Apr 2014 03:07:45 +0000 (23:07 -0400)
src/main/java/com/gitblit/transport/ssh/commands/PluginDispatcher.java

index 62b135763194f8624db29c13a975e7f06722a60e..6f8f95ae6785535b302aef2a0b7e3978df4c4310 100644 (file)
@@ -518,7 +518,7 @@ public class PluginDispatcher extends DispatchCommand {
                                        if (gitblit.installPlugin(urlOrId, !disableChecksum)) {
                                                stdout.println(String.format("Installed %s", urlOrId));
                                        } else {
-                                               new UnloggedFailure(1, String.format("Failed to install %s", urlOrId));
+                                               throw new UnloggedFailure(1, String.format("Failed to install %s", urlOrId));
                                        }
                                } else {
                                        PluginRelease pr = gitblit.lookupRelease(urlOrId, version);