Backport #32247 by @lunny
Fix #31996
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
// RenameUser renames a user
func RenameUser(ctx context.Context, u *user_model.User, newUserName string) error {
+ if newUserName == u.Name {
+ return nil
+ }
+
// Non-local users are not allowed to change their username.
if !u.IsOrganization() && !u.IsLocal() {
return user_model.ErrUserIsNotLocal{
}
}
- if newUserName == u.Name {
- return nil
- }
-
if err := user_model.IsUsableUsername(newUserName); err != nil {
return err
}