Remove CSRF check from code integrity rescan

Did not find a way to get a valid token from SetupCheck

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

diff --git a/apps/settings/lib/Controller/CheckSetupController.php b/apps/settings/lib/Controller/CheckSetupController.php
index 7e865785522b80b5b89f6f093e1cb9a6b0ee24d5..eb6664c5e472d04ff4b509eb64118d18044a7996 100644 (file)
--- a/apps/settings/lib/Controller/CheckSetupController.php
+++ b/apps/settings/lib/Controller/CheckSetupController.php
@@ -234,6 +234,7 @@ class CheckSetupController extends Controller {
        }
 
        /**
+        * @NoCSRFRequired
         * @return RedirectResponse
         * @AuthorizedAdminSetting(settings=OCA\Settings\Settings\Admin\Overview)
         */

diff --git a/apps/settings/lib/SetupChecks/CodeIntegrity.php b/apps/settings/lib/SetupChecks/CodeIntegrity.php
index f5882be888f6f5fb5a3e40c5720396667e8c1c2e..20ecf5360b7a021cc4fc3da0bce1f38d61437277 100644 (file)
--- a/apps/settings/lib/SetupChecks/CodeIntegrity.php
+++ b/apps/settings/lib/SetupChecks/CodeIntegrity.php
@@ -53,7 +53,6 @@ class CodeIntegrity implements ISetupCheck {
                } elseif ($this->checker->hasPassedCheck()) {
                        return SetupResult::success($this->l10n->t('No altered files'));
                } else {
-                       // FIXME: If setup check can link to settings pages this should link to /settings/integrity/failed and /settings/integrity/rescan?requesttoken=TOKEN
                        return SetupResult::error(
                                $this->l10n->t('Some files have not passed the integrity check. {link1} {link2}'),
                                $this->urlGenerator->linkToDocs('admin-code-integrity'),
@@ -68,7 +67,6 @@ class CodeIntegrity implements ISetupCheck {
                                                'type' => 'highlight',
                                                'id' => 'rescanFailedIntegrityCheck',
                                                'name' => 'Rescan…',
-                                               //, ['requesttoken' => '']?
                                                'link' => $this->urlGenerator->linkToRoute('settings.CheckSetup.rescanFailedIntegrityCheck'),
                                        ],
                                ],