PackWriter: Refactor object writing loop

This simple refactoring makes it easier to pre-process each of the
object lists before its handed into the actual write routine.

Change-Id: Iea95e5ecbc7374f6bcbb43d1c75285f4f564d09d
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>

diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/storage/pack/PackWriter.java b/org.eclipse.jgit/src/org/eclipse/jgit/storage/pack/PackWriter.java
index e9eb366f60d1d927d4e38eb1c63991b224b8b5ba..2a5caf854c420616ebd9aa7bbbfdcb31bfb87749 100644 (file)
--- a/org.eclipse.jgit/src/org/eclipse/jgit/storage/pack/PackWriter.java
+++ b/org.eclipse.jgit/src/org/eclipse/jgit/storage/pack/PackWriter.java
@@ -977,14 +977,17 @@ public class PackWriter {
        }
 
        private void writeObjects(PackOutputStream out) throws IOException {
+               for (List<ObjectToPack> list : objectsLists)
+                               writeObjects(out, list);
+       }
+
+       private void writeObjects(PackOutputStream out, List<ObjectToPack> list)
+                       throws IOException {
                if (reuseSupport != null) {
-                       for (List<ObjectToPack> list : objectsLists)
-                               reuseSupport.writeObjects(out, list);
+                       reuseSupport.writeObjects(out, list);
                } else {
-                       for (List<ObjectToPack> list : objectsLists) {
-                               for (ObjectToPack otp : list)
-                                       out.writeObject(otp);
-                       }
+                       for (ObjectToPack otp : list)
+                               out.writeObject(otp);
                }
        }