]> source.dussan.org Git - redmine.git/commitdiff
use symbol instead of string for 'position' in db migrate (#24013)
authorToshi MARUYAMA <marutosijp2@yahoo.co.jp>
Mon, 28 Nov 2016 06:21:11 +0000 (06:21 +0000)
committerToshi MARUYAMA <marutosijp2@yahoo.co.jp>
Mon, 28 Nov 2016 06:21:11 +0000 (06:21 +0000)
git-svn-id: http://svn.redmine.org/redmine/trunk@16009 e93f8b46-1217-0410-a6f0-8f06a7374b81

db/migrate/072_add_enumerations_position.rb
db/migrate/078_add_custom_fields_position.rb
db/migrate/20141029181824_remove_issue_statuses_is_default.rb

index cf5646cf9f92ef6732c6df3ccc06259af3b09f77..2834abef123b83183381479f5c9b22017ae85c91 100644 (file)
@@ -4,7 +4,7 @@ class AddEnumerationsPosition < ActiveRecord::Migration
     Enumeration.all.group_by(&:opt).each do |opt, enums|
       enums.each_with_index do |enum, i|
         # do not call model callbacks
-        Enumeration.where({:id => enum.id}).update_all("position = #{i+1}")
+        Enumeration.where({:id => enum.id}).update_all(:position => (i+1))
       end
     end
   end
index ef940eb02dfc188eeb37efdcaa595f5639f2974a..a03db46182acf88f13e84eb4bf7fe4930f2f28f2 100644 (file)
@@ -4,7 +4,7 @@ class AddCustomFieldsPosition < ActiveRecord::Migration
     CustomField.all.group_by(&:type).each  do |t, fields|
       fields.each_with_index do |field, i|
         # do not call model callbacks
-        CustomField.where({:id => field.id}).update_all("position = #{i+1}")
+        CustomField.where({:id => field.id}).update_all(:position => (i+1))
       end
     end
   end
index 62785d37a06a46c8028f233ae80cd3662c77f388..c5c813d62c2552f3d83a1f1a7d0faa2b489f50fb 100644 (file)
@@ -6,7 +6,7 @@ class RemoveIssueStatusesIsDefault < ActiveRecord::Migration
   def down
     add_column :issue_statuses, :is_default, :boolean, :null => false, :default => false
     # Restores the first status as default
-    default_status_id = IssueStatus.order("position").pluck(:id).first
+    default_status_id = IssueStatus.order(:position).pluck(:id).first
     IssueStatus.where(:id => default_status_id).update_all(:is_default => true)
   end
 end