]> source.dussan.org Git - nextcloud-server.git/commitdiff
Clear generated avatar caches 38143/head
authorjld3103 <jld3103yt@gmail.com>
Tue, 9 May 2023 10:27:46 +0000 (12:27 +0200)
committerjld3103 <jld3103yt@gmail.com>
Mon, 15 May 2023 16:18:21 +0000 (18:18 +0200)
Signed-off-by: jld3103 <jld3103yt@gmail.com>
lib/private/Repair/ClearGeneratedAvatarCache.php
tests/lib/Repair/ClearGeneratedAvatarCacheTest.php

index 844bf6cf346f934fe1575d29a8f4bd8cc9671b0c..fb3b42847dcc6cf193ced79c866ae52f18c3c361 100644 (file)
@@ -42,7 +42,7 @@ class ClearGeneratedAvatarCache implements IRepairStep {
        }
 
        public function getName(): string {
-               return 'Clear every generated avatar on major updates';
+               return 'Clear every generated avatar';
        }
 
        /**
@@ -51,8 +51,9 @@ class ClearGeneratedAvatarCache implements IRepairStep {
        private function shouldRun(): bool {
                $versionFromBeforeUpdate = $this->config->getSystemValueString('version', '0.0.0.0');
 
-               // was added to 25.0.0.10
-               return version_compare($versionFromBeforeUpdate, '25.0.0.10', '<=');
+               // This job only runs if the server was on a version lower than or equal to 27.0.0 before the upgrade.
+               // To clear the avatar cache again, bump the version to the currently released version (and change the operator to <= if it's not the master branch) and wait for the next release.
+               return version_compare($versionFromBeforeUpdate, '27.0.0', '<');
        }
 
        public function run(IOutput $output): void {
index 44fc709c72af340490e150efbc94e5fa82d18ae7..0e3347cd5ac5f66f3be83711ef46c51340aa243e 100644 (file)
@@ -61,7 +61,7 @@ class ClearGeneratedAvatarCacheTest extends \Test\TestCase {
                        ['15.0.0.3', true],
                        ['13.0.5.2', true],
                        ['12.0.0.0', true],
-                       ['26.0.0.1', false],
+                       ['26.0.0.1', true],
                        ['15.0.0.2', true],
                        ['13.0.0.0', true],
                        ['27.0.0.5', false]