*/
public class CommonsLogger extends POILogger
{
- private static LogFactory _creator = LogFactory.getFactory();
+ private static final LogFactory _creator = LogFactory.getFactory();
private Log log = null;
@Override
* @param obj1 The object to log.
*/
@Override
- public void log(final int level, final Object obj1)
+ protected void log(final int level, final Object obj1)
{
+ // FIXME: What happens if level is in between two levels (an even number)?
+ // Should this be `if (level >= FATAL) ...`?
if(level==FATAL)
{
if(log.isFatalEnabled())
* @param exception An exception to be logged
*/
@Override
- public void log(final int level, final Object obj1,
+ protected void log(final int level, final Object obj1,
final Throwable exception)
{
+ // FIXME: What happens if level is in between two levels (an even number)?
+ // Should this be `if (level >= FATAL) ...`?
if(level==FATAL)
{
if(log.isFatalEnabled())
@Override
public boolean check(final int level)
{
+ // FIXME: What happens if level is in between two levels (an even number)?
+ // Should this be `if (level >= FATAL) ...`?
if(level==FATAL)
{
if(log.isFatalEnabled())
*/
@Override
- protected void log(final int level, final Object obj1) {
+ protected void _log(final int level, final Object obj1) {
// do nothing
}
* @param exception An exception to be logged
*/
@Override
- protected void log(int level, Object obj1, final Throwable exception) {
+ protected void _log(int level, Object obj1, final Throwable exception) {
// do nothing
}
* @param level One of DEBUG, INFO, WARN, ERROR, FATAL
* @param obj1 The object to log. This is converted to a string.
*/
- abstract protected void log(int level, Object obj1);
+ abstract protected void _log(int level, Object obj1);
/**
* Log a message
* @param obj1 The object to log. This is converted to a string.
* @param exception An exception to be logged
*/
- abstract protected void log(int level, Object obj1, final Throwable exception);
+ abstract protected void _log(int level, Object obj1, final Throwable exception);
/**
// somehow this ambiguity works and doesn't lead to a loop,
// but it's confusing ...
if (lastEx == null) {
- log(level, msg);
+ _log(level, msg);
} else {
- log(level, msg, lastEx);
+ _log(level, msg, lastEx);
}
}
}
* @param obj1 The object to log.
*/
@Override
- public void log(final int level, final Object obj1)
+ protected void _log(final int level, final Object obj1)
{
- log(level, obj1, null);
+ _log(level, obj1, null);
}
/**
*/
@Override
@SuppressForbidden("uses printStackTrace")
- public void log(final int level, final Object obj1,
+ protected void _log(final int level, final Object obj1,
final Throwable exception) {
if (check(level)) {
System.out.println("[" + _cat + "]" + LEVEL_STRINGS_SHORT[Math.min(LEVEL_STRINGS_SHORT.length-1, level)] + " " + obj1);
* POILogger which logs into an ArrayList, so that
* tests can see what got logged
*/
+@Internal
public class DummyPOILogger extends POILogger {
public List<String>logged = new ArrayList<String>();
public void initialize(String cat) {}
@Override
- public void log(int level, Object obj1) {
+ protected void _log(int level, Object obj1) {
logged.add(level + " - " + obj1);
}
@Override
- public void log(int level, Object obj1, Throwable exception) {
+ protected void _log(int level, Object obj1, Throwable exception) {
logged.add(level + " - " + obj1 + " - " + exception);
}
}
}
@Override
- public void log(int level, Object obj1) {
+ protected void _log(int level, Object obj1) {
lastLog = (obj1 == null) ? "" : obj1.toString();
lastEx = null;
}
@Override
- public void log(int level, Object obj1, Throwable exception) {
+ protected void _log(int level, Object obj1, Throwable exception) {
lastLog = (obj1 == null) ? "" : obj1.toString();
lastEx = exception;
}