[github-347] make some inner classes static to save memory. Thanks to XenoAmess....

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1902749 13f79535-47bb-0310-9956-ffa450edef68

diff --git a/poi-ooxml/src/main/java/org/apache/poi/xddf/usermodel/chart/XDDFChartData.java b/poi-ooxml/src/main/java/org/apache/poi/xddf/usermodel/chart/XDDFChartData.java
index a88c0e50ec8cfd7fbd6cac8ff651c894d63a4ab2..4669e2e70753cc591aebadb73af2716d0f78aa55 100644 (file)
--- a/poi-ooxml/src/main/java/org/apache/poi/xddf/usermodel/chart/XDDFChartData.java
+++ b/poi-ooxml/src/main/java/org/apache/poi/xddf/usermodel/chart/XDDFChartData.java
@@ -142,7 +142,7 @@ public abstract class XDDFChartData {
     public abstract XDDFChartData.Series addSeries(XDDFDataSource<?> category,
             XDDFNumericalDataSource<? extends Number> values);
 
-    public abstract class Series {
+    public abstract static class Series {
         protected abstract CTSerTx getSeriesText();
 
         public abstract void setShowLeaderLines(boolean showLeaderLines);

diff --git a/poi-ooxml/src/test/java/org/apache/poi/xssf/eventusermodel/TestXSSFBReader.java b/poi-ooxml/src/test/java/org/apache/poi/xssf/eventusermodel/TestXSSFBReader.java
index 2d6e57e049e11d15fea9f34714eeb65a2fcb2857..3fa96264f0dc6c51ea8c1b4414952fb1bc079f85 100644 (file)
--- a/poi-ooxml/src/test/java/org/apache/poi/xssf/eventusermodel/TestXSSFBReader.java
+++ b/poi-ooxml/src/test/java/org/apache/poi/xssf/eventusermodel/TestXSSFBReader.java
@@ -165,7 +165,7 @@ class TestXSSFBReader {
     }
 
 
-    private class TestSheetHandler implements XSSFSheetXMLHandler.SheetContentsHandler {
+    private static class TestSheetHandler implements XSSFSheetXMLHandler.SheetContentsHandler {
         private final StringBuilder sb = new StringBuilder();
 
         void startSheet(String sheetName) {

diff --git a/poi/src/main/java/org/apache/poi/hssf/usermodel/HSSFChart.java b/poi/src/main/java/org/apache/poi/hssf/usermodel/HSSFChart.java
index 38266f409d885fa071fbb781f3a483597845e4ba..c8e9aabd74c12ed36fb8b88fd61f297eb0e6618a 100644 (file)
--- a/poi/src/main/java/org/apache/poi/hssf/usermodel/HSSFChart.java
+++ b/poi/src/main/java/org/apache/poi/hssf/usermodel/HSSFChart.java
@@ -1120,7 +1120,7 @@ public final class HSSFChart {
                 }
             }
 
-            linkedDataRecord.setFormulaOfLink(ptgList.toArray(new Ptg[0]));
+            linkedDataRecord.setFormulaOfLink(ptgList.toArray(Ptg.EMPTY_PTG_ARRAY));
 
             return rowCount * colCount;
         }