Add Issues.componentById() helper

diff --git a/sonar-ws-client/src/main/java/org/sonar/wsclient/issue/Issues.java b/sonar-ws-client/src/main/java/org/sonar/wsclient/issue/Issues.java
index 7e6fc88e20395ea478974c0d7c66f9891bd89b77..0b7de9482266d9d08343fe388125e4dba6c234ec 100644 (file)
--- a/sonar-ws-client/src/main/java/org/sonar/wsclient/issue/Issues.java
+++ b/sonar-ws-client/src/main/java/org/sonar/wsclient/issue/Issues.java
@@ -51,6 +51,9 @@ public interface Issues {
   @CheckForNull
   Component component(Issue issue);
 
+  @CheckForNull
+  Component componentById(long id);
+
   Collection<Component> projects();
 
   @CheckForNull

diff --git a/sonar-ws-client/src/main/java/org/sonar/wsclient/issue/internal/DefaultIssues.java b/sonar-ws-client/src/main/java/org/sonar/wsclient/issue/internal/DefaultIssues.java
index e4693e370e47aa7b57d49463368d80513597e01f..2b76fa74634c3d465194a820f613d3ddac6787db 100644 (file)
--- a/sonar-ws-client/src/main/java/org/sonar/wsclient/issue/internal/DefaultIssues.java
+++ b/sonar-ws-client/src/main/java/org/sonar/wsclient/issue/internal/DefaultIssues.java
@@ -40,7 +40,7 @@ public class DefaultIssues implements Issues {
   private final List<Issue> list = new ArrayList<Issue>();
   private final Map<String, Rule> rulesByKey = new HashMap<String, Rule>();
   private final Map<String, User> usersByKey = new HashMap<String, User>();
-  private final Map<String, Component> componentsByKey = new HashMap<String, Component>();
+  private final Map<Long, Component> componentsById = new HashMap<Long, Component>();
   private final Map<String, Component> projectsByKey = new HashMap<String, Component>();
   private final Map<String, ActionPlan> actionPlansByKey = new HashMap<String, ActionPlan>();
   private Paging paging;
@@ -72,12 +72,17 @@ public class DefaultIssues implements Issues {
   }
 
   public Collection<Component> components() {
-    return componentsByKey.values();
+    return componentsById.values();
   }
 
   @CheckForNull
   public Component component(Issue issue) {
-    return componentsByKey.get(issue.componentKey());
+    return componentsById.get(issue.componentId());
+  }
+
+  @CheckForNull
+  public Component componentById(long id) {
+    return componentsById.get(id);
   }
 
   public Collection<Component> projects() {
@@ -128,7 +133,7 @@ public class DefaultIssues implements Issues {
   }
 
   DefaultIssues addComponent(Component c) {
-    componentsByKey.put(c.key(), c);
+    componentsById.put(c.id(), c);
     return this;
   }
 

diff --git a/sonar-ws-client/src/test/java/org/sonar/wsclient/issue/internal/IssueJsonParserTest.java b/sonar-ws-client/src/test/java/org/sonar/wsclient/issue/internal/IssueJsonParserTest.java
index 2ea31630d82b64a2f35756b1e15e839642a26412..5e5948fcc6a5316046045a31f18fb193cbfb91da 100644 (file)
--- a/sonar-ws-client/src/test/java/org/sonar/wsclient/issue/internal/IssueJsonParserTest.java
+++ b/sonar-ws-client/src/test/java/org/sonar/wsclient/issue/internal/IssueJsonParserTest.java
@@ -167,6 +167,8 @@ public class IssueJsonParserTest {
     assertThat(component.longName()).isEqualTo("org.struts.Action");
     assertThat(component.subProjectId()).isEqualTo(2L);
     assertThat(component.projectId()).isEqualTo(1L);
+
+    assertThat(issues.componentById(10).key()).isEqualTo("struts:Action.java");
   }
 
   @Test