Do not fail hard on new user mail error

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

diff --git a/apps/provisioning_api/lib/Controller/UsersController.php b/apps/provisioning_api/lib/Controller/UsersController.php
index 93b5d62db36db78fd0fa6deef64d4908384fc929..1fa1f1fa5b367844d513990805a582e00f9bec09 100644 (file)
--- a/apps/provisioning_api/lib/Controller/UsersController.php
+++ b/apps/provisioning_api/lib/Controller/UsersController.php
@@ -328,12 +328,13 @@ class UsersController extends AUserData {
                                        $emailTemplate = $this->newUserMailHelper->generateTemplate($newUser, $generatePasswordResetToken);
                                        $this->newUserMailHelper->sendMail($newUser, $emailTemplate);
                                } catch (\Exception $e) {
+                                       // Mail could be failing hard or just be plain not configured
+                                       // Logging error as it is the hardest of the two
                                        $this->logger->logException($e, [
-                                               'message' => "Can't send new user mail to $email",
+                                               'message' => "Unable to send the invitation mail to $email",
                                                'level' => ILogger::ERROR,
                                                'app' => 'ocs_api',
                                        ]);
-                                       throw new OCSException('Unable to send the invitation mail', 109);
                                }
                        }