Skip a bunch of useless "UPDATE repositories SET extra_info = ..." queries when navig...

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8658 e93f8b46-1217-0410-a6f0-8f06a7374b81

diff --git a/app/models/repository.rb b/app/models/repository.rb
index 00acbb540a5a104f7c8f047c7c091c2be84cd371..02d9fc6c8be565972643e7aacad5bcb14ad04d63 100644 (file)
--- a/app/models/repository.rb
+++ b/app/models/repository.rb
@@ -101,9 +101,13 @@ class Repository < ActiveRecord::Base
   end
 
   def scm
-    @scm ||= self.scm_adapter.new(url, root_url,
+    unless @scm
+      @scm = self.scm_adapter.new(url, root_url,
                                   login, password, path_encoding)
-    update_attribute(:root_url, @scm.root_url) if root_url.blank?
+      if root_url.blank? && @scm.root_url.present?
+        update_attribute(:root_url, @scm.root_url)
+      end
+    end
     @scm
   end