]> source.dussan.org Git - jquery.git/commitdiff
Revert "Adding in backwards-compatiblity support for jQuery().bind/unbind/trigger...
authorjeresig <jeresig@gmail.com>
Mon, 11 Jan 2010 18:48:40 +0000 (13:48 -0500)
committerjeresig <jeresig@gmail.com>
Mon, 11 Jan 2010 18:48:40 +0000 (13:48 -0500)
This reverts commit e9d5947b4abbc052046585227892da0adcd56caf.

src/event.js
test/unit/event.js

index 6871327d144955107a10923395177776216f4633..c28e3704f9cfb319a974ac389dc651ceb5a698ef 100644 (file)
@@ -755,7 +755,6 @@ jQuery.each(["bind", "one"], function( i, name ) {
                        for ( var key in type ) {
                                this[ name ](key, data, type[key], fn);
                        }
-
                        return this;
                }
                
@@ -770,17 +769,11 @@ jQuery.each(["bind", "one"], function( i, name ) {
                        return fn.apply( this, arguments );
                }) : fn;
 
-               if ( type === "unload" && name !== "one" ) {
-                       this.one( type, data, fn, thisObject );
-
-               } else {
-                       // Deprecated: Please don't expect an empty jQuery set to bind to document
-                       (!this.selector && !this.context ? jQuery(document) : this).each(function() {
+               return type === "unload" && name !== "one" ?
+                       this.one( type, data, fn, thisObject ) :
+                       this.each(function() {
                                jQuery.event.add( this, type, handler, data );
                        });
-               }
-
-               return this;
        };
 });
 
@@ -794,20 +787,14 @@ jQuery.fn.extend({
                        return this;
                }
 
-               // Deprecated: Please don't expect an empty jQuery set to bind to document
-               (!this.selector && !this.context ? jQuery(document) : this).each(function() {
+               return this.each(function() {
                        jQuery.event.remove( this, type, fn );
                });
-
-               return this;
        },
        trigger: function( type, data ) {
-               // Deprecated: Please don't expect an empty jQuery set to bind to document
-               (!this.selector && !this.context ? jQuery(document) : this).each(function() {
+               return this.each(function() {
                        jQuery.event.trigger( type, data, this );
                });
-
-               return this;
        },
 
        triggerHandler: function( type, data ) {
index 7111bb556c24c99624014b4c07dfc7f5776da19a..8a9e48b02343e57ddfc5a88a17dd4c8937184cbf 100644 (file)
@@ -118,19 +118,6 @@ test("bind(), trigger change on select", function() {
        }).trigger('change');
 });
 
-test("bind/unbind/trigger on empty jQuery set", function() {
-       expect(1);
-
-       jQuery().bind("test", function(){
-               equals( this, document, "Handler triggered and bound on document." );
-       });
-
-       jQuery().trigger("test");
-
-       jQuery().unbind("test");
-       jQuery().trigger("test");
-});
-
 test("bind(), namespaced events, cloned events", function() {
        expect(6);