SshTestGitServer: : ensure UploadPack is closed to fix resource leak

Change-Id: Ib766f1d56b3ca7940c593ebfe0ac68fc5028a11c

diff --git a/org.eclipse.jgit.junit.ssh/src/org/eclipse/jgit/junit/ssh/SshTestGitServer.java b/org.eclipse.jgit.junit.ssh/src/org/eclipse/jgit/junit/ssh/SshTestGitServer.java
index 4fe98f8683416f2715c399f50548191defeb7432..5d043ffc3af70e56f6d50457465bb2347c09a25d 100644 (file)
--- a/org.eclipse.jgit.junit.ssh/src/org/eclipse/jgit/junit/ssh/SshTestGitServer.java
+++ b/org.eclipse.jgit.junit.ssh/src/org/eclipse/jgit/junit/ssh/SshTestGitServer.java
@@ -480,13 +480,13 @@ public class SshTestGitServer {
 
                @Override
                public void run() {
-                       UploadPack uploadPack = new UploadPack(repository);
-                       String gitProtocol = getEnvironment().getEnv().get("GIT_PROTOCOL");
-                       if (gitProtocol != null) {
-                               uploadPack
-                                               .setExtraParameters(Collections.singleton(gitProtocol));
-                       }
-                       try {
+                       try (UploadPack uploadPack = new UploadPack(repository)) {
+                               String gitProtocol = getEnvironment().getEnv()
+                                               .get("GIT_PROTOCOL");
+                               if (gitProtocol != null) {
+                                       uploadPack.setExtraParameters(
+                                                       Collections.singleton(gitProtocol));
+                               }
                                uploadPack.upload(getInputStream(), getOutputStream(),
                                                getErrorStream());
                                onExit(0);