SONAR-10154 Stream when writing protobuf message

diff --git a/server/sonar-server/src/main/java/org/sonar/server/ws/WsUtils.java b/server/sonar-server/src/main/java/org/sonar/server/ws/WsUtils.java
index 186880e6802872a294236120e5d2a3b5f3a24685..d028f4879fa039f22523ee06a6e46793db6af583 100644 (file)
--- a/server/sonar-server/src/main/java/org/sonar/server/ws/WsUtils.java
+++ b/server/sonar-server/src/main/java/org/sonar/server/ws/WsUtils.java
@@ -52,7 +52,7 @@ public class WsUtils {
         msg.writeTo(output);
       } else {
         response.stream().setMediaType(JSON);
-        try (JsonWriter writer = JsonWriter.of(new CacheWriter(new OutputStreamWriter(output, UTF_8)))) {
+        try (JsonWriter writer = JsonWriter.of(new OutputStreamWriter(output, UTF_8))) {
           ProtobufJsonFormat.write(msg, writer);
         }
       }

diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/server/ws/Response.java b/sonar-plugin-api/src/main/java/org/sonar/api/server/ws/Response.java
index 87720afbe802b3e31254b6a9eb691a4ade6d445e..eff1334819e2f39e1edf38c2355d1c6dd75eeb56 100644 (file)
--- a/sonar-plugin-api/src/main/java/org/sonar/api/server/ws/Response.java
+++ b/sonar-plugin-api/src/main/java/org/sonar/api/server/ws/Response.java
@@ -41,11 +41,14 @@ public interface Response {
      */
     Stream setStatus(int httpStatus);
 
+    /**
+     * Response stream. Beware that proper error recovery is not possible.
+     */
     OutputStream output();
   }
 
   /**
-   * Non streamable {@link JsonWriter}. Response is written when resource is closed.
+   * Non streamable {@link JsonWriter}. Response is effectively written when closing the resource.
    */
   JsonWriter newJsonWriter();