Fix quality flaws

diff --git a/server/sonar-db-migration/src/test/java/org/sonar/server/platform/db/migration/version/v72/PopulateHashMethodOnUsersTest.java b/server/sonar-db-migration/src/test/java/org/sonar/server/platform/db/migration/version/v72/PopulateHashMethodOnUsersTest.java
index 254e9da4f07992ef914b61e394bff983c864aa20..3ce76a5f286dbc07b60548d5eb28d35b2f959a9a 100644 (file)
--- a/server/sonar-db-migration/src/test/java/org/sonar/server/platform/db/migration/version/v72/PopulateHashMethodOnUsersTest.java
+++ b/server/sonar-db-migration/src/test/java/org/sonar/server/platform/db/migration/version/v72/PopulateHashMethodOnUsersTest.java
@@ -35,7 +35,6 @@ import static org.assertj.core.api.Assertions.assertThat;
 
 public class PopulateHashMethodOnUsersTest {
 
-  private static final long PAST = 5_000_000_000L;
   private static final long NOW = 10_000_000_000L;
 
   @Rule

diff --git a/server/sonar-server/src/main/java/org/sonar/server/authentication/LocalAuthentication.java b/server/sonar-server/src/main/java/org/sonar/server/authentication/LocalAuthentication.java
index c7efae31e9faf924a667da01733db15fa54900f5..73fef18b235546e34493a37776f0d6ebb4e6401f 100644 (file)
--- a/server/sonar-server/src/main/java/org/sonar/server/authentication/LocalAuthentication.java
+++ b/server/sonar-server/src/main/java/org/sonar/server/authentication/LocalAuthentication.java
@@ -172,7 +172,7 @@ public class LocalAuthentication {
         .setSalt(salt);
     }
 
-    private String hash(String salt, String password) {
+    private static String hash(String salt, String password) {
       return DigestUtils.sha1Hex("--" + salt + "--" + password + "--");
     }
   }

diff --git a/server/sonar-server/src/main/java/org/sonar/server/user/UserUpdater.java b/server/sonar-server/src/main/java/org/sonar/server/user/UserUpdater.java
index f1ec17669f41b5a2eba8444040841dd4ea5c2ca1..cdfc0b80716debdab4cc9b5274ee0b713e5be6c6 100644 (file)
--- a/server/sonar-server/src/main/java/org/sonar/server/user/UserUpdater.java
+++ b/server/sonar-server/src/main/java/org/sonar/server/user/UserUpdater.java
@@ -21,7 +21,6 @@ package org.sonar.server.user;
 
 import com.google.common.base.Joiner;
 import com.google.common.base.Strings;
-import java.security.SecureRandom;
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.HashSet;

diff --git a/tests/src/test/java/org/sonarqube/tests/organization/RootUserTest.java b/tests/src/test/java/org/sonarqube/tests/organization/RootUserTest.java
index 2622d2f1963cf09b4c87139e07c3632b08f11f2f..ae3fe5a1ae4194f7e5cf060717b45e5e1cbf5a97 100644 (file)
--- a/tests/src/test/java/org/sonarqube/tests/organization/RootUserTest.java
+++ b/tests/src/test/java/org/sonarqube/tests/organization/RootUserTest.java
@@ -20,7 +20,6 @@
 package org.sonarqube.tests.organization;
 
 import com.sonar.orchestrator.Orchestrator;
-import java.sql.SQLException;
 import org.junit.ClassRule;
 import org.junit.Rule;
 import org.junit.Test;