]> source.dussan.org Git - jgit.git/commitdiff
Fix resource leak in ChangeIdUtil 00/45100/1
authorMatthias Sohn <matthias.sohn@sap.com>
Wed, 1 Apr 2015 23:30:14 +0000 (01:30 +0200)
committerMatthias Sohn <matthias.sohn@sap.com>
Wed, 1 Apr 2015 23:30:14 +0000 (01:30 +0200)
Change-Id: I5cb3e9c7e167248697932933eef925c446514683
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
org.eclipse.jgit/src/org/eclipse/jgit/util/ChangeIdUtil.java

index 35850dcaacb9f480693fc43be48afb993676c235..35fc99e54e32dc5a56483efb523fb83000410418 100644 (file)
@@ -115,8 +115,10 @@ public class ChangeIdUtil {
                b.append(committer.toExternalString());
                b.append("\n\n"); //$NON-NLS-1$
                b.append(cleanMessage);
-               return new ObjectInserter.Formatter().idFor(Constants.OBJ_COMMIT, //
-                               b.toString().getBytes(Constants.CHARACTER_ENCODING));
+               try (ObjectInserter f = new ObjectInserter.Formatter()) {
+                       return f.idFor(Constants.OBJ_COMMIT, //
+                                       b.toString().getBytes(Constants.CHARACTER_ENCODING));
+               }
        }
 
        private static final Pattern issuePattern = Pattern