]> source.dussan.org Git - jgit.git/commitdiff
HttpClientTests: Use assertEquals to assert about response code 71/127971/2
authorDavid Pursehouse <david.pursehouse@gmail.com>
Fri, 24 Aug 2018 02:18:47 +0000 (11:18 +0900)
committerDavid Pursehouse <david.pursehouse@gmail.com>
Sat, 25 Aug 2018 05:16:30 +0000 (14:16 +0900)
The current usage of assertThat causes a warning in Eclipse:

  "The expression of type int is boxed into Integer".

Replace it with assertEquals which does not cause this warning, and is
consistent with how such assertions are done in other tests.

Change-Id: Id3de3548353bf6be069b6ede89c605d094b6d3f4
Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>
org.eclipse.jgit.http.test/tst/org/eclipse/jgit/http/test/HttpClientTests.java

index 61f272c4cd06758734e58b8c1c648d4ef6725fc2..ed3860ed65b0c299ee87df9d329e6ae65c273f73 100644 (file)
@@ -367,7 +367,7 @@ public class HttpClientTests extends HttpTestCase {
                c.setRequestMethod("GET");
                c.setRequestProperty("Git-Protocol", "version=2");
                c.connect();
-               assertThat(c.getResponseCode(), is(200));
+               assertEquals(200, c.getResponseCode());
 
                PacketLineIn pckIn = new PacketLineIn(c.getInputStream());
 
@@ -388,7 +388,7 @@ public class HttpClientTests extends HttpTestCase {
                c.setRequestMethod("GET");
                c.setRequestProperty("Git-Protocol", "version=2");
                c.connect();
-               assertThat(c.getResponseCode(), is(200));
+               assertEquals(200, c.getResponseCode());
 
                PacketLineIn pckIn = new PacketLineIn(c.getInputStream());
                assertThat(pckIn.readString(), is("version 2"));
@@ -434,6 +434,6 @@ public class HttpClientTests extends HttpTestCase {
                        assertTrue(s.matches("[0-9a-f]{40} [A-Za-z/]*"));
                }
 
-               assertThat(c.getResponseCode(), is(200));
+               assertEquals(200, c.getResponseCode());
        }
 }