Add missing test on measure filters

diff --git a/sonar-core/src/main/java/org/sonar/core/measure/MeasureFilterEngine.java b/sonar-core/src/main/java/org/sonar/core/measure/MeasureFilterEngine.java
index 97146643ce95eb157ea5d3b9ee07485b5664bcfc..3bbe897320290b3bb72cbf93d8aad8051c152fe8 100644 (file)
--- a/sonar-core/src/main/java/org/sonar/core/measure/MeasureFilterEngine.java
+++ b/sonar-core/src/main/java/org/sonar/core/measure/MeasureFilterEngine.java
@@ -57,12 +57,13 @@ public class MeasureFilterEngine implements ServerComponent {
       MeasureFilter filter = factory.create(filterMap);
       List<MeasureFilterRow> rows = executor.execute(filter, context);
       result.setRows(rows);
-      result.setDurationInMs(System.currentTimeMillis() - start);
       log(context, result, logger);
 
     } catch (Exception e) {
       result.setError(MeasureFilterResult.Error.UNKNOWN);
       logger.error("Fail to execute measure filter: " + context, e);
+    } finally {
+      result.setDurationInMs(System.currentTimeMillis() - start);
     }
     return result;
   }

diff --git a/sonar-core/src/test/java/org/sonar/core/measure/MeasureFilterEngineTest.java b/sonar-core/src/test/java/org/sonar/core/measure/MeasureFilterEngineTest.java
index 95a4e8fc9929c33825d29571924b6dae8e4a7474..dc58aeb536407f85faad93132f414bde58b56d7a 100644 (file)
--- a/sonar-core/src/test/java/org/sonar/core/measure/MeasureFilterEngineTest.java
+++ b/sonar-core/src/test/java/org/sonar/core/measure/MeasureFilterEngineTest.java
@@ -75,5 +75,7 @@ public class MeasureFilterEngineTest {
 
     assertThat(result.isSuccess()).isFalse();
     assertThat(result.getError()).isEqualTo(MeasureFilterResult.Error.UNKNOWN);
+    assertThat(result.getDurationInMs()).isGreaterThan(0L);
+    assertThat(result.getRows()).isNull();
   }
 }