Avoid arbitrary format strings upon calling fail() function (#7112)

diff --git a/cmd/serv.go b/cmd/serv.go
index aa068d4cf693fb3106aa9cecf17742aefbd09a59..0b0a4e8efba78ce03b0b661fdfad01f45eae647a 100644 (file)
--- a/cmd/serv.go
+++ b/cmd/serv.go
@@ -53,7 +53,7 @@ func checkLFSVersion() {
                //Needs at least git v2.1.2
                binVersion, err := git.BinVersion()
                if err != nil {
-                       fail(fmt.Sprintf("Error retrieving git version: %v", err), fmt.Sprintf("Error retrieving git version: %v", err))
+                       fail("LFS server error", "Error retrieving git version: %v", err)
                }
 
                if !version.Compare(binVersion, "2.1.2", ">=") {
@@ -199,12 +199,12 @@ func runServ(c *cli.Context) error {
                if private.IsErrServCommand(err) {
                        errServCommand := err.(private.ErrServCommand)
                        if errServCommand.StatusCode != http.StatusInternalServerError {
-                               fail("Unauthorized", errServCommand.Error())
+                               fail("Unauthorized", "%s", errServCommand.Error())
                        } else {
-                               fail("Internal Server Error", errServCommand.Error())
+                               fail("Internal Server Error", "%s", errServCommand.Error())
                        }
                }
-               fail("Internal Server Error", err.Error())
+               fail("Internal Server Error", "%s", err.Error())
        }
        os.Setenv(models.EnvRepoIsWiki, strconv.FormatBool(results.IsWiki))
        os.Setenv(models.EnvRepoName, results.RepoName)