]> source.dussan.org Git - redmine.git/commitdiff
Use content_tag helper.
authorJean-Philippe Lang <jp_lang@yahoo.fr>
Sun, 13 May 2012 08:47:54 +0000 (08:47 +0000)
committerJean-Philippe Lang <jp_lang@yahoo.fr>
Sun, 13 May 2012 08:47:54 +0000 (08:47 +0000)
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9682 e93f8b46-1217-0410-a6f0-8f06a7374b81

app/helpers/custom_fields_helper.rb

index 789d527b5c9b275d50c1286f60467357d830a5aa..fb4e519383b9c45c4edc3e169377a029a04e5dcd 100644 (file)
@@ -55,13 +55,13 @@ module CustomFieldsHelper
       unless custom_field.multiple?
         if custom_field.is_required?
           unless custom_field.default_value.present?
-            blank_option = "<option value=\"\">--- #{l(:actionview_instancetag_blank_option)} ---</option>"
+            blank_option = content_tag('option', "--- #{l(:actionview_instancetag_blank_option)} ---", :value => '')
           end
         else
-          blank_option = '<option></option>'
+          blank_option = content_tag('option')
         end
       end
-      s = select_tag(field_name, blank_option.html_safe + options_for_select(custom_field.possible_values_options(custom_value.customized), custom_value.value),
+      s = select_tag(field_name, blank_option + options_for_select(custom_field.possible_values_options(custom_value.customized), custom_value.value),
         tag_options.merge(:multiple => custom_field.multiple?))
       if custom_field.multiple?
         s << hidden_field_tag(field_name, '')