feat(settings): add big file upload setup checks

Signed-off-by: skjnldsv <skjnldsv@protonmail.com>

diff --git a/apps/settings/composer/composer/autoload_classmap.php b/apps/settings/composer/composer/autoload_classmap.php
index 79ea28b66d0be03ae0d262c6fe58f640edcf4b00..968953f52ee6c75db08316717c231d15daeb4c26 100644 (file)
--- a/apps/settings/composer/composer/autoload_classmap.php
+++ b/apps/settings/composer/composer/autoload_classmap.php
@@ -115,6 +115,7 @@ return array(
     'OCA\\Settings\\SetupChecks\\PhpDisabledFunctions' => $baseDir . '/../lib/SetupChecks/PhpDisabledFunctions.php',
     'OCA\\Settings\\SetupChecks\\PhpFreetypeSupport' => $baseDir . '/../lib/SetupChecks/PhpFreetypeSupport.php',
     'OCA\\Settings\\SetupChecks\\PhpGetEnv' => $baseDir . '/../lib/SetupChecks/PhpGetEnv.php',
+    'OCA\\Settings\\SetupChecks\\PhpMaxFileSize' => $baseDir . '/../lib/SetupChecks/PhpMaxFileSize.php',
     'OCA\\Settings\\SetupChecks\\PhpMemoryLimit' => $baseDir . '/../lib/SetupChecks/PhpMemoryLimit.php',
     'OCA\\Settings\\SetupChecks\\PhpModules' => $baseDir . '/../lib/SetupChecks/PhpModules.php',
     'OCA\\Settings\\SetupChecks\\PhpOpcacheSetup' => $baseDir . '/../lib/SetupChecks/PhpOpcacheSetup.php',

diff --git a/apps/settings/composer/composer/autoload_static.php b/apps/settings/composer/composer/autoload_static.php
index c7e06f2e359dfbdf34a3c3eb93a861d27537dd15..24a99a863810514b738c3422c54f614a3c193b89 100644 (file)
--- a/apps/settings/composer/composer/autoload_static.php
+++ b/apps/settings/composer/composer/autoload_static.php
@@ -130,6 +130,7 @@ class ComposerStaticInitSettings
         'OCA\\Settings\\SetupChecks\\PhpDisabledFunctions' => __DIR__ . '/..' . '/../lib/SetupChecks/PhpDisabledFunctions.php',
         'OCA\\Settings\\SetupChecks\\PhpFreetypeSupport' => __DIR__ . '/..' . '/../lib/SetupChecks/PhpFreetypeSupport.php',
         'OCA\\Settings\\SetupChecks\\PhpGetEnv' => __DIR__ . '/..' . '/../lib/SetupChecks/PhpGetEnv.php',
+        'OCA\\Settings\\SetupChecks\\PhpMaxFileSize' => __DIR__ . '/..' . '/../lib/SetupChecks/PhpMaxFileSize.php',
         'OCA\\Settings\\SetupChecks\\PhpMemoryLimit' => __DIR__ . '/..' . '/../lib/SetupChecks/PhpMemoryLimit.php',
         'OCA\\Settings\\SetupChecks\\PhpModules' => __DIR__ . '/..' . '/../lib/SetupChecks/PhpModules.php',
         'OCA\\Settings\\SetupChecks\\PhpOpcacheSetup' => __DIR__ . '/..' . '/../lib/SetupChecks/PhpOpcacheSetup.php',

diff --git a/apps/settings/lib/AppInfo/Application.php b/apps/settings/lib/AppInfo/Application.php
index 688e6ebbed5cd08bf8e3aa08a91771f696d777de..124915efe7f67bdcdc38038a48361363798b30c4 100644 (file)
--- a/apps/settings/lib/AppInfo/Application.php
+++ b/apps/settings/lib/AppInfo/Application.php
@@ -58,6 +58,7 @@ use OCA\Settings\SetupChecks\PhpDefaultCharset;
 use OCA\Settings\SetupChecks\PhpDisabledFunctions;
 use OCA\Settings\SetupChecks\PhpFreetypeSupport;
 use OCA\Settings\SetupChecks\PhpGetEnv;
+use OCA\Settings\SetupChecks\PhpMaxFileSize;
 use OCA\Settings\SetupChecks\PhpMemoryLimit;
 use OCA\Settings\SetupChecks\PhpModules;
 use OCA\Settings\SetupChecks\PhpOpcacheSetup;
@@ -203,6 +204,7 @@ class Application extends App implements IBootstrap {
                $context->registerSetupCheck(PhpFreetypeSupport::class);
                $context->registerSetupCheck(PhpApcuConfig::class);
                $context->registerSetupCheck(PhpGetEnv::class);
+               $context->registerSetupCheck(PhpMaxFileSize::class);
                $context->registerSetupCheck(PhpMemoryLimit::class);
                $context->registerSetupCheck(PhpModules::class);
                $context->registerSetupCheck(PhpOpcacheSetup::class);

diff --git a/apps/settings/lib/SetupChecks/PhpMaxFileSize.php b/apps/settings/lib/SetupChecks/PhpMaxFileSize.php
new file mode 100644 (file)
index 0000000..942a840
--- /dev/null
+++ b/apps/settings/lib/SetupChecks/PhpMaxFileSize.php
@@ -0,0 +1,80 @@
+<?php
+
+declare(strict_types=1);
+
+/**
+ * SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+
+namespace OCA\Settings\SetupChecks;
+
+use bantu\IniGetWrapper\IniGetWrapper;
+use OCP\IL10N;
+use OCP\IURLGenerator;
+use OCP\SetupCheck\ISetupCheck;
+use OCP\SetupCheck\SetupResult;
+use OCP\Util;
+
+class PhpMaxFileSize implements ISetupCheck {
+       public function __construct(
+               private IL10N $l10n,
+               private IURLGenerator $urlGenerator,
+               private IniGetWrapper $iniGetWrapper,
+       ) {
+       }
+
+       public function getCategory(): string {
+               return 'php';
+       }
+
+       public function getName(): string {
+               return $this->l10n->t('PHP file size upload limit');
+       }
+
+       public function run(): SetupResult {
+               $upload_max_filesize = Util::computerFileSize((string)$this->iniGetWrapper->getString('upload_max_filesize'));
+               $post_max_size = Util::computerFileSize((string)$this->iniGetWrapper->getString('post_max_size'));
+               $max_input_time = (int)$this->iniGetWrapper->getString('max_input_time');
+               $max_execution_time = (int)$this->iniGetWrapper->getString('max_execution_time');
+
+               $warnings = [];
+               $recommendedSize = 16 * 1024 * 1024 * 1024;
+               $recommendedTime = 3600;
+
+               // Check if the PHP upload limit is too low
+               if ($upload_max_filesize < $recommendedSize) {
+                       $warnings[] = $this->l10n->t('The PHP upload_max_filesize is too low. A size of at least %1$s is recommended. Current value: %2$s.', [
+                               Util::humanFileSize($recommendedSize),
+                               Util::humanFileSize($upload_max_filesize),
+                       ]);
+               }
+               if ($post_max_size < $recommendedSize) {
+                       $warnings[] = $this->l10n->t('The PHP post_max_size is too low. A size of at least %1$s is recommended. Current value: %2$s.', [
+                               Util::humanFileSize($recommendedSize),
+                               Util::humanFileSize($post_max_size),
+                       ]);
+               }
+
+               // Check if the PHP execution time is too low
+               if ($max_input_time < $recommendedTime && $max_input_time !== -1) {
+                       $warnings[] = $this->l10n->t('The PHP max_input_time is too low. A time of at least %1$s is recommended. Current value: %2$s.', [
+                               $recommendedTime,
+                               $max_input_time,
+                       ]);
+               }
+
+               if ($max_execution_time < $recommendedTime && $max_execution_time !== -1) {
+                       $warnings[] = $this->l10n->t('The PHP max_execution_time is too low. A time of at least %1$s is recommended. Current value: %2$s.', [
+                               $recommendedTime,
+                               $max_execution_time,
+                       ]);
+               }
+
+               if (!empty($warnings)) {
+                       return SetupResult::warning(join(' ', $warnings), $this->urlGenerator->linkToDocs('admin-big-file-upload'));
+               }
+
+               return SetupResult::success();
+       }
+}