Fixed: Check All / Uncheck All in Email Settings doesn't work (#1180).

git-svn-id: http://redmine.rubyforge.org/svn/trunk@1429 e93f8b46-1217-0410-a6f0-8f06a7374b81

diff --git a/app/views/settings/_notifications.rhtml b/app/views/settings/_notifications.rhtml
index ac32138533bfcdb09cad751d45d735d884e5f591..1a472d606a931155c8b8c4ce4d2a41b568825a80 100644 (file)
--- a/app/views/settings/_notifications.rhtml
+++ b/app/views/settings/_notifications.rhtml
@@ -9,13 +9,13 @@
 <%= hidden_field_tag 'settings[bcc_recipients]', 0 %></p>
 </div>
 
-<fieldset class="box"><legend><%=l(:text_select_mail_notifications)%></legend>
+<fieldset class="box" id="notified_events"><legend><%=l(:text_select_mail_notifications)%></legend>
 <% @notifiables.each do |notifiable| %>
   <label><%= check_box_tag 'settings[notified_events][]', notifiable, Setting.notified_events.include?(notifiable) %>
   <%= l_or_humanize(notifiable) %></label><br />
 <% end %>
 <%= hidden_field_tag 'settings[notified_events][]', '' %>
-<p><%= check_all_links('mail-options-form') %></p>
+<p><%= check_all_links('notified_events') %></p>
 </fieldset>
 
 <fieldset class="box"><legend><%= l(:setting_emails_footer) %></legend>

diff --git a/public/javascripts/application.js b/public/javascripts/application.js
index 4e88498423ca90cd5d5bdbc3579898d0b2769793..f3d771a10e077a6273b302b7912a40cda3d94cb3 100644 (file)
--- a/public/javascripts/application.js
+++ b/public/javascripts/application.js
@@ -2,10 +2,10 @@
    Copyright (C) 2006-2008  Jean-Philippe Lang */
 
 function checkAll (id, checked) {
-       var el = document.getElementById(id);
-       for (var i = 0; i < el.elements.length; i++) {
-    if (el.elements[i].disabled==false) {
-      el.elements[i].checked = checked;
+       var els = Element.descendants(id);
+       for (var i = 0; i < els.length; i++) {
+    if (els[i].disabled==false) {
+      els[i].checked = checked;
     }
        }
 }