]> source.dussan.org Git - gitea.git/commitdiff
Migration code: errors are not to be forgotten
authorPeter Smit <peter@smitmail.eu>
Thu, 22 Jan 2015 13:01:45 +0000 (15:01 +0200)
committerPeter Smit <peter@smitmail.eu>
Thu, 22 Jan 2015 13:01:45 +0000 (15:01 +0200)
models/migrations/migrations.go

index e51bc3c876ac114edbcdfaace9978f8c35676454..3586e5d0b6427c148564a7b7e13c34fb76599bb1 100644 (file)
@@ -20,7 +20,9 @@ var migrations = []migration{}
 
 // Migrate database to current version
 func Migrate(x *xorm.Engine) error {
-       x.Sync(new(Version))
+       if err := x.Sync(new(Version)); err != nil {
+               return err
+       }
 
        currentVersion := &Version{Id: 1}
        has, err := x.Get(currentVersion)
@@ -39,7 +41,9 @@ func Migrate(x *xorm.Engine) error {
                        return err
                }
                currentVersion.Version = v + int64(i) + 1
-               x.Id(1).Update(currentVersion)
+               if _, err = x.Id(1).Update(currentVersion); err != nil {
+                       return err
+               }
        }
        return nil
 }