+++ /dev/null
--Djava.awt.headless=true
\ No newline at end of file
+++ /dev/null
-<?xml version="1.0" encoding="UTF-8"?>
-<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
- <modelVersion>4.0.0</modelVersion>
- <parent>
- <groupId>org.codehaus.sonar</groupId>
- <artifactId>sonar</artifactId>
- <version>3.4-SNAPSHOT</version>
- <relativePath>../..</relativePath>
- </parent>
- <groupId>org.codehaus.sonar.plugins</groupId>
- <artifactId>sonar-findbugs-plugin</artifactId>
- <packaging>sonar-plugin</packaging>
- <name>Sonar :: Plugins :: Findbugs</name>
- <description>FindBugs is a program that uses static analysis to look for bugs in Java code. It can detect a variety of common coding mistakes, including thread synchronization problems, misuse of API methods.</description>
-
- <properties>
- <findbugs.version>2.0.1</findbugs.version>
- </properties>
-
- <dependencies>
- <!--
- !!! ORDER OF DEPENDENCIES IS IMPORTANT !!!
- FindBugs should be first
- -->
-
- <dependency>
- <groupId>com.google.code.findbugs</groupId>
- <artifactId>findbugs</artifactId>
- <version>${findbugs.version}</version>
- <exclusions>
- <exclusion>
- <groupId>jdom</groupId>
- <artifactId>jdom</artifactId>
- </exclusion>
- <exclusion>
- <groupId>xml-apis</groupId>
- <artifactId>xml-apis</artifactId>
- </exclusion>
- <exclusion>
- <groupId>xerces</groupId>
- <artifactId>xercesImpl</artifactId>
- </exclusion>
- <exclusion>
- <groupId>xom</groupId>
- <artifactId>xom</artifactId>
- </exclusion>
- </exclusions>
- </dependency>
-
- <dependency>
- <groupId>org.codehaus.sonar</groupId>
- <artifactId>sonar-plugin-api</artifactId>
- <scope>provided</scope>
- <exclusions>
- <!-- allows to package dom4j into plugin -->
- <exclusion>
- <groupId>dom4j</groupId>
- <artifactId>dom4j</artifactId>
- </exclusion>
- </exclusions>
- </dependency>
-
- <!-- TODO http://jira.codehaus.org/browse/SONAR-2011
- We need following dependency, otherwise we will receive compilation error
- -->
- <dependency>
- <groupId>org.apache.maven</groupId>
- <artifactId>maven-project</artifactId>
- <scope>provided</scope>
- </dependency>
-
- <!-- unit tests -->
- <dependency>
- <groupId>org.codehaus.sonar</groupId>
- <artifactId>sonar-testing-harness</artifactId>
- <scope>test</scope>
- </dependency>
- </dependencies>
-
- <build>
- <resources>
- <resource>
- <directory>src/main/resources</directory>
- <filtering>true</filtering>
- </resource>
- </resources>
-
- <testResources>
- <testResource>
- <directory>${basedir}/src/main/resources</directory>
- </testResource>
- <testResource>
- <directory>${basedir}/src/test/resources</directory>
- </testResource>
- </testResources>
-
- <plugins>
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-dependency-plugin</artifactId>
- <executions>
- <execution>
- <id>copy-dependencies</id>
- <phase>process-resources</phase>
- <goals>
- <goal>copy-dependencies</goal>
- </goals>
- <configuration>
- <outputDirectory>${project.build.outputDirectory}</outputDirectory>
- <includeArtifactIds>annotations,jsr305</includeArtifactIds>
- </configuration>
- </execution>
- </executions>
- </plugin>
- <plugin>
- <groupId>org.codehaus.sonar</groupId>
- <artifactId>sonar-packaging-maven-plugin</artifactId>
- <configuration>
- <pluginName>Findbugs</pluginName>
- <pluginDescription><![CDATA[Analyze Java code with <a href="http://findbugs.sourceforge.net/">Findbugs</a> ${findbugs.version}.]]></pluginDescription>
- <pluginClass>org.sonar.plugins.findbugs.FindbugsPlugin</pluginClass>
- <useChildFirstClassLoader>true</useChildFirstClassLoader>
- </configuration>
- </plugin>
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-enforcer-plugin</artifactId>
- <executions>
- <execution>
- <id>enforce-plugin-size</id>
- <goals>
- <goal>enforce</goal>
- </goals>
- <phase>verify</phase>
- <configuration>
- <rules>
- <requireFilesSize>
- <maxsize>4800000</maxsize>
- <minsize>4600000</minsize>
- <files>
- <file>${project.build.directory}/${project.build.finalName}.jar</file>
- </files>
- </requireFilesSize>
- </rules>
- </configuration>
- </execution>
- </executions>
- </plugin>
- </plugins>
- </build>
-</project>
+++ /dev/null
-/*
- * Sonar, open source software quality management tool.
- * Copyright (C) 2008-2012 SonarSource
- * mailto:contact AT sonarsource DOT com
- *
- * Sonar is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * Sonar is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with Sonar; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02
- */
-package org.sonar.plugins.findbugs;
-
-import org.apache.commons.lang.StringUtils;
-import org.sonar.api.resources.Java;
-
-public final class FindbugsAntConverter {
-
- private FindbugsAntConverter() {
- }
-
- /**
- * Convert the exclusion ant pattern to a java regexp accepted by findbugs
- * exclusion file
- *
- * @param exclusion ant pattern to convert
- * @return Exclusion pattern for findbugs
- */
- public static String antToJavaRegexpConvertor(String exclusion) {
- StringBuilder builder = new StringBuilder("~");
- int offset = 0;
- // First **/ or */ is optional
- if (exclusion.startsWith("**/")) {
- builder.append("(.*\\.)?");
- offset += 3;
- } else if (exclusion.startsWith("*/")) {
- builder.append("([^\\\\^\\s]*\\.)?");
- offset += 2;
- }
- for (String suffix : Java.SUFFIXES) {
- exclusion = StringUtils.removeEndIgnoreCase(exclusion, "." + suffix);
- }
-
- char[] array = exclusion.toCharArray();
- for (int i = offset; i < array.length; i++) {
- char c = array[i];
- if (c == '?') {
- builder.append('.');
- } else if (c == '*') {
- if (i + 1 < array.length && array[i + 1] == '*') {
- builder.append(".*");
- i++;
- } else {
- builder.append("[^\\\\^\\s]*");
- }
- } else if (c == '/') {
- builder.append("\\.");
- } else {
- builder.append(c);
- }
- }
- return builder.toString();
- }
-}
+++ /dev/null
-/*
- * Sonar, open source software quality management tool.
- * Copyright (C) 2008-2012 SonarSource
- * mailto:contact AT sonarsource DOT com
- *
- * Sonar is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * Sonar is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with Sonar; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02
- */
-package org.sonar.plugins.findbugs;
-
-import java.util.HashMap;
-import java.util.Map;
-
-public final class FindbugsCategory {
- private static final Map<String, String> FINDBUGS_TO_SONAR = new HashMap<String, String>();
-
- static {
- FINDBUGS_TO_SONAR.put("BAD_PRACTICE", "Bad practice");
- FINDBUGS_TO_SONAR.put("CORRECTNESS", "Correctness");
- FINDBUGS_TO_SONAR.put("MT_CORRECTNESS", "Multithreaded correctness");
- FINDBUGS_TO_SONAR.put("I18N", "Internationalization");
- FINDBUGS_TO_SONAR.put("EXPERIMENTAL", "Experimental");
- FINDBUGS_TO_SONAR.put("MALICIOUS_CODE", "Malicious code");
- FINDBUGS_TO_SONAR.put("PERFORMANCE", "Performance");
- FINDBUGS_TO_SONAR.put("SECURITY", "Security");
- FINDBUGS_TO_SONAR.put("STYLE", "Style");
- }
-
- public static String findbugsToSonar(String findbugsCategKey) {
- return FINDBUGS_TO_SONAR.get(findbugsCategKey);
- }
-
- private FindbugsCategory() {
- }
-}
+++ /dev/null
-/*
- * Sonar, open source software quality management tool.
- * Copyright (C) 2008-2012 SonarSource
- * mailto:contact AT sonarsource DOT com
- *
- * Sonar is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * Sonar is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with Sonar; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02
- */
-package org.sonar.plugins.findbugs;
-
-import com.google.common.annotations.VisibleForTesting;
-import org.apache.commons.io.FileUtils;
-import org.apache.commons.io.IOUtils;
-import org.apache.commons.lang.StringUtils;
-import org.sonar.api.BatchExtension;
-import org.sonar.api.CoreProperties;
-import org.sonar.api.batch.ProjectClasspath;
-import org.sonar.api.config.Settings;
-import org.sonar.api.profiles.RulesProfile;
-import org.sonar.api.resources.Project;
-import org.sonar.api.utils.SonarException;
-import org.sonar.plugins.findbugs.xml.ClassFilter;
-import org.sonar.plugins.findbugs.xml.FindBugsFilter;
-import org.sonar.plugins.findbugs.xml.Match;
-
-import java.io.File;
-import java.io.IOException;
-import java.io.InputStream;
-import java.io.OutputStream;
-import java.io.StringWriter;
-import java.util.ArrayList;
-import java.util.List;
-import java.util.Locale;
-
-/**
- * @since 2.4
- */
-public class FindbugsConfiguration implements BatchExtension {
-
- private final Project project;
- private final Settings settings;
- private final RulesProfile profile;
- private final FindbugsProfileExporter exporter;
- private final ProjectClasspath projectClasspath;
-
- public FindbugsConfiguration(Project project, Settings settings, RulesProfile profile, FindbugsProfileExporter exporter, ProjectClasspath classpath) {
- this.project = project;
- this.settings = settings;
- this.profile = profile;
- this.exporter = exporter;
- this.projectClasspath = classpath;
- }
-
- public File getTargetXMLReport() {
- return new File(project.getFileSystem().getSonarWorkingDirectory(), "findbugs-result.xml");
- }
-
- public edu.umd.cs.findbugs.Project getFindbugsProject() {
- File classesDir = project.getFileSystem().getBuildOutputDir();
- if (classesDir == null || !classesDir.exists()) {
- throw new SonarException("Findbugs needs sources to be compiled. "
- + "Please build project before executing sonar and check the location of compiled classes.");
- }
-
- edu.umd.cs.findbugs.Project findbugsProject = new edu.umd.cs.findbugs.Project();
- for (File dir : project.getFileSystem().getSourceDirs()) {
- findbugsProject.addSourceDir(dir.getAbsolutePath());
- }
- findbugsProject.addFile(classesDir.getAbsolutePath());
- for (File file : projectClasspath.getElements()) {
- if (!file.equals(classesDir)) {
- findbugsProject.addAuxClasspathEntry(file.getAbsolutePath());
- }
- }
- findbugsProject.addAuxClasspathEntry(annotationsLib.getAbsolutePath());
- findbugsProject.addAuxClasspathEntry(jsr305Lib.getAbsolutePath());
- findbugsProject.setCurrentWorkingDirectory(project.getFileSystem().getBuildDir());
- return findbugsProject;
- }
-
- @VisibleForTesting
- File saveIncludeConfigXml() throws IOException {
- StringWriter conf = new StringWriter();
- exporter.exportProfile(profile, conf);
- return project.getFileSystem().writeToWorkingDirectory(conf.toString(), "findbugs-include.xml");
- }
-
- @VisibleForTesting
- File saveExcludeConfigXml() throws IOException {
- FindBugsFilter findBugsFilter = new FindBugsFilter();
- if (project.getExclusionPatterns() != null) {
- for (String exclusion : project.getExclusionPatterns()) {
- ClassFilter classFilter = new ClassFilter(FindbugsAntConverter.antToJavaRegexpConvertor(exclusion));
- findBugsFilter.addMatch(new Match(classFilter));
- }
- }
- return project.getFileSystem().writeToWorkingDirectory(findBugsFilter.toXml(), "findbugs-exclude.xml");
- }
-
- @VisibleForTesting
- List<File> getExcludesFilters() {
- List<File> result = new ArrayList<File>();
- String[] filters = settings.getStringArray(FindbugsConstants.EXCLUDES_FILTERS_PROPERTY);
- for (String excludesFilterPath : filters) {
- excludesFilterPath = StringUtils.trim(excludesFilterPath);
- if (StringUtils.isNotBlank(excludesFilterPath)) {
- result.add(project.getFileSystem().resolvePath(excludesFilterPath));
- }
- }
- return result;
- }
-
- public String getEffort() {
- return StringUtils.lowerCase(settings.getString(CoreProperties.FINDBUGS_EFFORT_PROPERTY));
- }
-
- public String getConfidenceLevel() {
- return StringUtils.lowerCase(settings.getString(CoreProperties.FINDBUGS_CONFIDENCE_LEVEL_PROPERTY));
- }
-
- public long getTimeout() {
- return settings.getLong(CoreProperties.FINDBUGS_TIMEOUT_PROPERTY);
- }
-
- public Locale getLocale() {
- return new Locale(settings.getString(CoreProperties.CORE_VIOLATION_LOCALE_PROPERTY));
- }
-
- private File jsr305Lib;
- private File annotationsLib;
-
- /**
- * Invoked by PicoContainer to extract additional FindBugs libraries into temporary files.
- */
- public void start() {
- jsr305Lib = copyLib("/jsr305-" + FindbugsVersion.getVersion() + ".jar");
- annotationsLib = copyLib("/annotations-" + FindbugsVersion.getVersion() + ".jar");
- }
-
- /**
- * Invoked by PicoContainer to remove temporary files.
- */
- public void stop() {
- jsr305Lib.delete();
- annotationsLib.delete();
- }
-
- private File copyLib(String name) {
- try {
- InputStream is = getClass().getResourceAsStream(name);
- File temp = File.createTempFile("findbugs", ".jar");
- OutputStream os = FileUtils.openOutputStream(temp);
- IOUtils.copy(is, os);
- return temp;
- } catch (IOException e) {
- throw new SonarException(e);
- }
- }
-
-}
+++ /dev/null
-/*
- * Sonar, open source software quality management tool.
- * Copyright (C) 2008-2012 SonarSource
- * mailto:contact AT sonarsource DOT com
- *
- * Sonar is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * Sonar is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with Sonar; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02
- */
-package org.sonar.plugins.findbugs;
-
-import org.sonar.api.CoreProperties;
-
-public final class FindbugsConstants {
-
- public static final String REPOSITORY_KEY = CoreProperties.FINDBUGS_PLUGIN;
- public static final String REPOSITORY_NAME = "Findbugs";
- public static final String PLUGIN_NAME = "Findbugs";
- public static final String PLUGIN_KEY = CoreProperties.FINDBUGS_PLUGIN;
-
- /**
- * @since 2.10
- */
- public static final String EXCLUDES_FILTERS_PROPERTY = "sonar.findbugs.excludesFilters";
-
- private FindbugsConstants() {
- }
-}
+++ /dev/null
-/*
- * Sonar, open source software quality management tool.
- * Copyright (C) 2008-2012 SonarSource
- * mailto:contact AT sonarsource DOT com
- *
- * Sonar is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * Sonar is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with Sonar; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02
- */
-package org.sonar.plugins.findbugs;
-
-import com.google.common.collect.Lists;
-import edu.umd.cs.findbugs.*;
-import edu.umd.cs.findbugs.config.UserPreferences;
-import edu.umd.cs.findbugs.plugins.DuplicatePluginIdException;
-import org.apache.commons.io.FileUtils;
-import org.apache.commons.io.IOUtils;
-import org.apache.commons.lang.StringUtils;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-import org.sonar.api.BatchExtension;
-import org.sonar.api.utils.SonarException;
-import org.sonar.api.utils.TimeProfiler;
-
-import java.io.File;
-import java.io.IOException;
-import java.io.OutputStream;
-import java.io.PrintStream;
-import java.net.URL;
-import java.util.*;
-import java.util.concurrent.Callable;
-import java.util.concurrent.ExecutorService;
-import java.util.concurrent.Executors;
-import java.util.concurrent.TimeUnit;
-
-/**
- * @since 2.4
- */
-public class FindbugsExecutor implements BatchExtension {
-
- private static final String FINDBUGS_CORE_PLUGIN_ID = "edu.umd.cs.findbugs.plugins.core";
-
- private static final Logger LOG = LoggerFactory.getLogger(FindbugsExecutor.class);
-
- /** Map of priority level names to their numeric values. */
- private static Map<String, Integer> priorityNameToValueMap = new HashMap<String, Integer>();
- static {
- priorityNameToValueMap.put("high", (Priorities.HIGH_PRIORITY));
- priorityNameToValueMap.put("medium", (Priorities.NORMAL_PRIORITY));
- priorityNameToValueMap.put("low", (Priorities.LOW_PRIORITY));
- priorityNameToValueMap.put("experimental", (Priorities.EXP_PRIORITY));
- }
- private static final Integer DEFAULT_PRIORITY = Priorities.NORMAL_PRIORITY;
-
- private FindbugsConfiguration configuration;
-
- public FindbugsExecutor(FindbugsConfiguration configuration) {
- this.configuration = configuration;
- }
-
- public BugCollection execute() {
- TimeProfiler profiler = new TimeProfiler().start("Execute Findbugs " + FindbugsVersion.getVersion());
- // We keep a handle on the current security manager because FB plays with it and we need to restore it before shutting down the executor
- // service
- SecurityManager currentSecurityManager = System.getSecurityManager();
- ClassLoader initialClassLoader = Thread.currentThread().getContextClassLoader();
- Thread.currentThread().setContextClassLoader(FindBugs2.class.getClassLoader());
-
- // This is a dirty workaround, but unfortunately there is no other way to specify locale for FindBugs - see SONAR-2594
- Locale initialLocale = Locale.getDefault();
- Locale.setDefault(configuration.getLocale());
-
- OutputStream xmlOutput = null;
- Collection<Plugin> customPlugins = null;
- ExecutorService executorService = Executors.newSingleThreadExecutor();
- try {
- final FindBugs2 engine = new FindBugs2();
-
- customPlugins = loadFindbugsPlugins();
-
- disableUpdateChecksOnEveryPlugin();
-
- Project project = configuration.getFindbugsProject();
- engine.setProject(project);
-
- XMLBugReporter xmlBugReporter = new XMLBugReporter(project);
- xmlBugReporter.setPriorityThreshold(determinePriorityThreshold());
- xmlBugReporter.setAddMessages(true);
-
- File xmlReport = configuration.getTargetXMLReport();
- LOG.info("Findbugs output report: " + xmlReport.getAbsolutePath());
- xmlOutput = FileUtils.openOutputStream(xmlReport);
- xmlBugReporter.setOutputStream(new PrintStream(xmlOutput));
-
- engine.setBugReporter(xmlBugReporter);
-
- UserPreferences userPreferences = UserPreferences.createDefaultUserPreferences();
- userPreferences.setEffort(configuration.getEffort());
- engine.setUserPreferences(userPreferences);
-
- engine.addFilter(configuration.saveIncludeConfigXml().getAbsolutePath(), true);
- engine.addFilter(configuration.saveExcludeConfigXml().getAbsolutePath(), false);
-
- for (File filterFile : configuration.getExcludesFilters()) {
- if (filterFile.isFile()) {
- LOG.info("Use filter-file: {}", filterFile);
- engine.addFilter(filterFile.getAbsolutePath(), false);
- } else {
- LOG.warn("FindBugs filter-file not found: {}", filterFile);
- }
- }
-
- engine.setDetectorFactoryCollection(DetectorFactoryCollection.instance());
- engine.setAnalysisFeatureSettings(FindBugs.DEFAULT_EFFORT);
-
- engine.finishSettings();
-
- executorService.submit(new FindbugsTask(engine)).get(configuration.getTimeout(), TimeUnit.MILLISECONDS);
-
- profiler.stop();
-
- return xmlBugReporter.getBugCollection();
- } catch (Exception e) {
- throw new SonarException("Can not execute Findbugs", e);
- } finally {
- // we set back the original security manager BEFORE shutting down the executor service, otherwise there's a problem with Java 5
- System.setSecurityManager(currentSecurityManager);
- resetCustomPluginList(customPlugins);
- executorService.shutdown();
- IOUtils.closeQuietly(xmlOutput);
- Thread.currentThread().setContextClassLoader(initialClassLoader);
- Locale.setDefault(initialLocale);
- }
- }
-
- private Integer determinePriorityThreshold() {
- Integer integer = priorityNameToValueMap.get(configuration.getConfidenceLevel());
- if (integer == null) {
- integer = DEFAULT_PRIORITY;
- }
- return integer;
- }
-
- private static class FindbugsTask implements Callable<Object> {
-
- private FindBugs2 engine;
-
- public FindbugsTask(FindBugs2 engine) {
- this.engine = engine;
- }
-
- public Object call() throws Exception {
- try {
- engine.execute();
- } finally {
- engine.dispose();
- }
- return null;
- }
- }
-
- private Collection<Plugin> loadFindbugsPlugins() {
- ClassLoader contextClassLoader = Thread.currentThread().getContextClassLoader();
-
- List<String> pluginJarPathList = Lists.newArrayList();
- try {
- Enumeration<URL> urls = contextClassLoader.getResources("findbugs.xml");
- while (urls.hasMoreElements()) {
- URL url = urls.nextElement();
- pluginJarPathList.add(StringUtils.removeStart(StringUtils.substringBefore(url.toString(), "!"), "jar:file:"));
- }
- } catch (IOException e) {
- throw new SonarException(e);
- }
-
- List<Plugin> customPluginList = Lists.newArrayList();
- for (String path : pluginJarPathList) {
- try {
- Plugin plugin = Plugin.addCustomPlugin(new File(path).toURI(), contextClassLoader);
- if (plugin != null) {
- customPluginList.add(plugin);
- LOG.info("Found findbugs plugin: " + path);
- }
- } catch (PluginException e) {
- LOG.warn("Failed to load plugin for custom detector: " + path);
- } catch (DuplicatePluginIdException e) {
- // FB Core plugin is always loaded, so we'll get an exception for it always
- if (!FINDBUGS_CORE_PLUGIN_ID.equals(e.getPluginId())) {
- // log only if it's not the FV Core plugin
- LOG.debug("Plugin already loaded: exception ignored: " + e.getMessage());
- }
- }
- }
-
- return customPluginList;
- }
-
- /**
- * Disable the update check for every plugin. See http://findbugs.sourceforge.net/updateChecking.html
- */
- private void disableUpdateChecksOnEveryPlugin() {
- for (Plugin plugin : Plugin.getAllPlugins()) {
- plugin.setMyGlobalOption("noUpdateChecks", "true");
- }
- }
-
- private static void resetCustomPluginList(Collection<Plugin> customPlugins) {
- if (customPlugins != null) {
- for (Plugin plugin : customPlugins) {
- Plugin.removeCustomPlugin(plugin);
- }
- }
- }
-
-}
+++ /dev/null
-/*
- * Sonar, open source software quality management tool.
- * Copyright (C) 2008-2012 SonarSource
- * mailto:contact AT sonarsource DOT com
- *
- * Sonar is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * Sonar is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with Sonar; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02
- */
-package org.sonar.plugins.findbugs;
-
-import org.sonar.api.rules.RulePriority;
-
-public class FindbugsLevelUtils {
-
- public RulePriority from(String priority) {
- if ("1".equals(priority)) {
- return RulePriority.BLOCKER;
- }
- if ("2".equals(priority)) {
- return RulePriority.MAJOR;
- }
- if ("3".equals(priority)) {
- return RulePriority.INFO;
- }
- throw new IllegalArgumentException("Priority not supported: " + priority);
- }
-}
+++ /dev/null
-/*
- * Sonar, open source software quality management tool.
- * Copyright (C) 2008-2012 SonarSource
- * mailto:contact AT sonarsource DOT com
- *
- * Sonar is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * Sonar is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with Sonar; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02
- */
-package org.sonar.plugins.findbugs;
-
-import org.apache.commons.configuration.Configuration;
-import org.sonar.api.batch.Initializer;
-import org.sonar.api.batch.SupportedEnvironment;
-import org.sonar.api.batch.maven.MavenPlugin;
-import org.sonar.api.batch.maven.MavenUtils;
-import org.sonar.api.resources.Java;
-import org.sonar.api.resources.Project;
-
-/**
- * Configures Sonar FindBugs Plugin according to configuration of findbugs-maven-plugin.
- * Supports only "excludeFilterFile".
- *
- * @since 2.10
- */
-@SupportedEnvironment("maven")
-public class FindbugsMavenInitializer extends Initializer {
-
- private static final String FINDBUGS_GROUP_ID = MavenUtils.GROUP_ID_CODEHAUS_MOJO;
- private static final String FINDBUGS_ARTIFACT_ID = "findbugs-maven-plugin";
-
- @Override
- public boolean shouldExecuteOnProject(Project project) {
- return Java.KEY.equals(project.getLanguageKey())
- && !project.getFileSystem().mainFiles(Java.KEY).isEmpty();
- }
-
- @Override
- public void execute(Project project) {
- Configuration conf = project.getConfiguration();
- if (!conf.containsKey(FindbugsConstants.EXCLUDES_FILTERS_PROPERTY)) {
- conf.setProperty(FindbugsConstants.EXCLUDES_FILTERS_PROPERTY, getExcludesFiltersFromPluginConfiguration(project));
- }
- }
-
- private static String getExcludesFiltersFromPluginConfiguration(Project project) {
- MavenPlugin mavenPlugin = MavenPlugin.getPlugin(project.getPom(), FINDBUGS_GROUP_ID, FINDBUGS_ARTIFACT_ID);
- return mavenPlugin != null ? mavenPlugin.getParameter("excludeFilterFile") : null;
- }
-
-}
+++ /dev/null
-/*
- * Sonar, open source software quality management tool.
- * Copyright (C) 2008-2012 SonarSource
- * mailto:contact AT sonarsource DOT com
- *
- * Sonar is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * Sonar is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with Sonar; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02
- */
-package org.sonar.plugins.findbugs;
-
-import com.google.common.collect.ImmutableList;
-import org.sonar.api.CoreProperties;
-import org.sonar.api.Extension;
-import org.sonar.api.Properties;
-import org.sonar.api.Property;
-import org.sonar.api.PropertyType;
-import org.sonar.api.SonarPlugin;
-
-import java.util.List;
-
-@Properties({
- @Property(
- key = CoreProperties.FINDBUGS_EFFORT_PROPERTY,
- defaultValue = CoreProperties.FINDBUGS_EFFORT_DEFAULT_VALUE,
- name = "Effort",
- description = "Effort of the bug finders. Valid values are Min, Default and Max. Setting 'Max' increases precision but also increases " +
- "memory consumption.",
- project = true,
- module = true,
- global = true),
- @Property(
- key = CoreProperties.FINDBUGS_TIMEOUT_PROPERTY,
- defaultValue = CoreProperties.FINDBUGS_TIMEOUT_DEFAULT_VALUE + "",
- name = "Timeout",
- description = "Specifies the amount of time, in milliseconds, that FindBugs may run before it is assumed to be hung and is terminated. " +
- "The default is 600,000 milliseconds, which is ten minutes.",
- project = true,
- module = true,
- global = true,
- type = PropertyType.INTEGER),
- @Property(
- key = FindbugsConstants.EXCLUDES_FILTERS_PROPERTY,
- name = "Excludes Filters",
- description = "Paths to findbugs filter-files with exclusions.",
- project = true,
- module = true,
- global = true,
- multiValues = true),
- @Property(
- key = CoreProperties.FINDBUGS_CONFIDENCE_LEVEL_PROPERTY,
- defaultValue = CoreProperties.FINDBUGS_CONFIDENCE_LEVEL_DEFAULT_VALUE,
- name = "Confidence Level",
- description = "Specifies the confidence threshold (previously called \"priority\") for reporting issues. If set to \"low\", confidence is not used to filter bugs. " +
- "If set to \"medium\" (the default), low confidence issues are supressed. If set to \"high\", only high confidence bugs are reported. ",
- project = true,
- module = true,
- global = true)
-})
-public class FindbugsPlugin extends SonarPlugin {
-
- public List<Class<? extends Extension>> getExtensions() {
- return ImmutableList.of(
- FindbugsSensor.class,
- FindbugsConfiguration.class,
- FindbugsExecutor.class,
- FindbugsRuleRepository.class,
- FindbugsProfileExporter.class,
- FindbugsProfileImporter.class,
- SonarWayWithFindbugsProfile.class,
- FindbugsMavenInitializer.class);
- }
-}
+++ /dev/null
-/*
- * Sonar, open source software quality management tool.
- * Copyright (C) 2008-2012 SonarSource
- * mailto:contact AT sonarsource DOT com
- *
- * Sonar is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * Sonar is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with Sonar; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02
- */
-package org.sonar.plugins.findbugs;
-
-import java.io.IOException;
-import java.io.Writer;
-import java.util.List;
-
-import org.sonar.api.profiles.ProfileExporter;
-import org.sonar.api.profiles.RulesProfile;
-import org.sonar.api.resources.Java;
-import org.sonar.api.rules.ActiveRule;
-import org.sonar.api.utils.SonarException;
-import org.sonar.plugins.findbugs.xml.Bug;
-import org.sonar.plugins.findbugs.xml.FindBugsFilter;
-import org.sonar.plugins.findbugs.xml.Match;
-
-import com.thoughtworks.xstream.XStream;
-
-public class FindbugsProfileExporter extends ProfileExporter {
-
- public FindbugsProfileExporter() {
- super(FindbugsConstants.REPOSITORY_KEY, FindbugsConstants.PLUGIN_NAME);
- setSupportedLanguages(Java.KEY);
- setMimeType("application/xml");
- }
-
- @Override
- public void exportProfile(RulesProfile profile, Writer writer) {
- try {
- FindBugsFilter filter = buildFindbugsFilter(profile.getActiveRulesByRepository(FindbugsConstants.REPOSITORY_KEY));
- XStream xstream = FindBugsFilter.createXStream();
- writer.append("<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n<!-- Generated by Sonar -->\n".concat(xstream.toXML(filter)));
- } catch (IOException e) {
- throw new SonarException("Fail to export the Findbugs profile : " + profile, e);
- }
- }
-
- protected static FindBugsFilter buildFindbugsFilter(List<ActiveRule> activeRules) {
- FindBugsFilter root = new FindBugsFilter();
- for (ActiveRule activeRule : activeRules) {
- if (FindbugsConstants.REPOSITORY_KEY.equals(activeRule.getRepositoryKey())) {
- Match child = new Match();
- child.setBug(new Bug(activeRule.getConfigKey()));
- root.addMatch(child);
- }
- }
- return root;
- }
-}
+++ /dev/null
-/*
- * Sonar, open source software quality management tool.
- * Copyright (C) 2008-2012 SonarSource
- * mailto:contact AT sonarsource DOT com
- *
- * Sonar is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * Sonar is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with Sonar; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02
- */
-package org.sonar.plugins.findbugs;
-
-import java.io.Reader;
-import java.util.Map;
-
-import org.apache.commons.lang.StringUtils;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-import org.sonar.api.profiles.ProfileImporter;
-import org.sonar.api.profiles.RulesProfile;
-import org.sonar.api.resources.Java;
-import org.sonar.api.rules.Rule;
-import org.sonar.api.rules.RuleFinder;
-import org.sonar.api.rules.RulePriority;
-import org.sonar.api.rules.RuleQuery;
-import org.sonar.api.utils.ValidationMessages;
-import org.sonar.plugins.findbugs.xml.FindBugsFilter;
-
-import com.thoughtworks.xstream.XStream;
-
-public class FindbugsProfileImporter extends ProfileImporter {
-
- private final RuleFinder ruleFinder;
- private static final Logger LOG = LoggerFactory.getLogger(FindbugsProfileImporter.class);
-
- public FindbugsProfileImporter(RuleFinder ruleFinder) {
- super(FindbugsConstants.REPOSITORY_KEY, FindbugsConstants.PLUGIN_NAME);
- setSupportedLanguages(Java.KEY);
- this.ruleFinder = ruleFinder;
- }
-
- @Override
- public RulesProfile importProfile(Reader findbugsConf, ValidationMessages messages) {
- RulesProfile profile = RulesProfile.create();
- try {
- XStream xStream = FindBugsFilter.createXStream();
- FindBugsFilter filter = (FindBugsFilter) xStream.fromXML(findbugsConf);
-
- activateRulesByCategory(profile, filter, messages);
- activateRulesByCode(profile, filter, messages);
- activateRulesByPattern(profile, filter, messages);
-
- return profile;
- } catch (Exception e) {
- String errorMessage = "The Findbugs configuration file is not valid";
- messages.addErrorText(errorMessage + " : " + e.getMessage());
- LOG.error(errorMessage, e);
- return profile;
- }
- }
-
- private void activateRulesByPattern(RulesProfile profile, FindBugsFilter filter, ValidationMessages messages) {
- for (Map.Entry<String, RulePriority> patternLevel : filter.getPatternLevels(new FindbugsLevelUtils()).entrySet()) {
- Rule rule = ruleFinder.findByKey(FindbugsConstants.REPOSITORY_KEY, patternLevel.getKey());
- if (rule != null) {
- profile.activateRule(rule, patternLevel.getValue());
- } else {
- messages.addWarningText("Unable to activate unknown rule : '" + patternLevel.getKey() + "'");
- }
- }
- }
-
- private void activateRulesByCode(RulesProfile profile, FindBugsFilter filter, ValidationMessages messages) {
- for (Map.Entry<String, RulePriority> codeLevel : filter.getCodeLevels(new FindbugsLevelUtils()).entrySet()) {
- boolean someRulesHaveBeenActivated = false;
- for (Rule rule : ruleFinder.findAll(RuleQuery.create().withRepositoryKey(FindbugsConstants.REPOSITORY_KEY))) {
- if (rule.getKey().equals(codeLevel.getKey()) || StringUtils.startsWith(rule.getKey(), codeLevel.getKey() + "_")) {
- someRulesHaveBeenActivated = true;
- profile.activateRule(rule, codeLevel.getValue());
- }
- }
- if ( !someRulesHaveBeenActivated) {
- messages.addWarningText("Unable to find any rules associated to code : '" + codeLevel.getKey() + "'");
- }
- }
- }
-
- private void activateRulesByCategory(RulesProfile profile, FindBugsFilter filter, ValidationMessages messages) {
- for (Map.Entry<String, RulePriority> categoryLevel : filter.getCategoryLevels(new FindbugsLevelUtils()).entrySet()) {
- boolean someRulesHaveBeenActivated = false;
- String sonarCateg = FindbugsCategory.findbugsToSonar(categoryLevel.getKey());
- for (Rule rule : ruleFinder.findAll(RuleQuery.create().withRepositoryKey(FindbugsConstants.REPOSITORY_KEY))) {
- if (sonarCateg != null && rule.getName().startsWith(sonarCateg)) {
- someRulesHaveBeenActivated = true;
- profile.activateRule(rule, categoryLevel.getValue());
- }
- }
- if ( !someRulesHaveBeenActivated) {
- messages.addWarningText("Unable to find any rules associated to category : '" + categoryLevel.getKey() + "'");
- }
- }
- }
-}
+++ /dev/null
-/*
- * Sonar, open source software quality management tool.
- * Copyright (C) 2008-2012 SonarSource
- * mailto:contact AT sonarsource DOT com
- *
- * Sonar is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * Sonar is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with Sonar; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02
- */
-package org.sonar.plugins.findbugs;
-
-import com.google.common.collect.Lists;
-import org.sonar.api.platform.ServerFileSystem;
-import org.sonar.api.resources.Java;
-import org.sonar.api.rules.Rule;
-import org.sonar.api.rules.RuleRepository;
-import org.sonar.api.rules.XMLRuleParser;
-
-import java.io.File;
-import java.util.List;
-
-public final class FindbugsRuleRepository extends RuleRepository {
- private final ServerFileSystem fileSystem;
- private final XMLRuleParser xmlRuleParser;
-
- public FindbugsRuleRepository(ServerFileSystem fileSystem, XMLRuleParser xmlRuleParser) {
- super(FindbugsConstants.REPOSITORY_KEY, Java.KEY);
- setName(FindbugsConstants.REPOSITORY_NAME);
- this.fileSystem = fileSystem;
- this.xmlRuleParser = xmlRuleParser;
- }
-
- @Override
- public List<Rule> createRules() {
- List<Rule> rules = Lists.newArrayList();
- rules.addAll(xmlRuleParser.parse(getClass().getResourceAsStream("/org/sonar/plugins/findbugs/rules.xml")));
- for (File userExtensionXml : fileSystem.getExtensions(FindbugsConstants.REPOSITORY_KEY, "xml")) {
- rules.addAll(xmlRuleParser.parse(userExtensionXml));
- }
- return rules;
- }
-}
+++ /dev/null
-/*
- * Sonar, open source software quality management tool.
- * Copyright (C) 2008-2012 SonarSource
- * mailto:contact AT sonarsource DOT com
- *
- * Sonar is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * Sonar is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with Sonar; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02
- */
-package org.sonar.plugins.findbugs;
-
-import edu.umd.cs.findbugs.BugCollection;
-import edu.umd.cs.findbugs.BugInstance;
-import edu.umd.cs.findbugs.SourceLineAnnotation;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-import org.sonar.api.batch.Sensor;
-import org.sonar.api.batch.SensorContext;
-import org.sonar.api.profiles.RulesProfile;
-import org.sonar.api.resources.Java;
-import org.sonar.api.resources.JavaFile;
-import org.sonar.api.resources.Project;
-import org.sonar.api.rules.Rule;
-import org.sonar.api.rules.RuleFinder;
-import org.sonar.api.rules.Violation;
-
-public class FindbugsSensor implements Sensor {
-
- private static final Logger LOG = LoggerFactory.getLogger(FindbugsSensor.class);
-
- private RulesProfile profile;
- private RuleFinder ruleFinder;
- private FindbugsExecutor executor;
-
- public FindbugsSensor(RulesProfile profile, RuleFinder ruleFinder, FindbugsExecutor executor) {
- this.profile = profile;
- this.ruleFinder = ruleFinder;
- this.executor = executor;
- }
-
- public boolean shouldExecuteOnProject(Project project) {
- return Java.KEY.equals(project.getLanguageKey())
- && !project.getFileSystem().mainFiles(Java.KEY).isEmpty()
- && !profile.getActiveRulesByRepository(FindbugsConstants.REPOSITORY_KEY).isEmpty();
- }
-
- public void analyse(Project project, SensorContext context) {
- if (project.getReuseExistingRulesConfig()) {
- LOG.warn("Reusing existing Findbugs configuration not supported any more.");
- }
-
- BugCollection collection = executor.execute();
-
- for (BugInstance bugInstance : collection) {
- SourceLineAnnotation sourceLine = bugInstance.getPrimarySourceLineAnnotation();
- if (sourceLine == null) {
- LOG.warn("No source line for " + bugInstance.getType());
- continue;
- }
-
- Rule rule = ruleFinder.findByKey(FindbugsConstants.REPOSITORY_KEY, bugInstance.getType());
- if (rule == null) {
- // ignore violations from report, if rule not activated in Sonar
- LOG.warn("Findbugs rule '{}' not active in Sonar.", bugInstance.getType());
- continue;
- }
-
- String longMessage = bugInstance.getMessageWithoutPrefix();
- String className = bugInstance.getPrimarySourceLineAnnotation().getClassName();
- int start = bugInstance.getPrimarySourceLineAnnotation().getStartLine();
-
- JavaFile resource = new JavaFile(getSonarJavaFileKey(className));
- if (context.getResource(resource) != null) {
- Violation violation = Violation.create(rule, resource)
- .setLineId(start)
- .setMessage(longMessage);
- context.saveViolation(violation);
- }
- }
- }
-
- private static String getSonarJavaFileKey(String className) {
- if (className.indexOf('$') > -1) {
- return className.substring(0, className.indexOf('$'));
- }
- return className;
- }
-
- @Override
- public String toString() {
- return getClass().getSimpleName();
- }
-
-}
+++ /dev/null
-/*
- * Sonar, open source software quality management tool.
- * Copyright (C) 2008-2012 SonarSource
- * mailto:contact AT sonarsource DOT com
- *
- * Sonar is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * Sonar is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with Sonar; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02
- */
-package org.sonar.plugins.findbugs;
-
-import java.io.IOException;
-import java.io.InputStream;
-import java.util.Properties;
-
-import org.apache.commons.io.IOUtils;
-import org.slf4j.LoggerFactory;
-
-/**
- * @since 2.4
- */
-public enum FindbugsVersion {
- INSTANCE;
-
- private static final String PROPERTIES_PATH = "/org/sonar/plugins/findbugs/findbugs-plugin.properties";
- private String version;
-
- public static String getVersion() {
- return INSTANCE.version;
- }
-
- private FindbugsVersion() {
- InputStream input = getClass().getResourceAsStream(PROPERTIES_PATH);
- try {
- Properties properties = new Properties();
- properties.load(input);
- this.version = properties.getProperty("findbugs.version");
-
- } catch (IOException e) {
- LoggerFactory.getLogger(getClass()).warn("Can not load the Findbugs version from the file " + PROPERTIES_PATH);
- this.version = "";
-
- } finally {
- IOUtils.closeQuietly(input);
- }
- }
-}
+++ /dev/null
-/*
- * Sonar, open source software quality management tool.
- * Copyright (C) 2008-2012 SonarSource
- * mailto:contact AT sonarsource DOT com
- *
- * Sonar is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * Sonar is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with Sonar; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02
- */
-package org.sonar.plugins.findbugs;
-
-import com.google.common.annotations.VisibleForTesting;
-import com.google.common.collect.ImmutableList;
-import com.google.common.collect.Lists;
-import org.codehaus.staxmate.SMInputFactory;
-import org.codehaus.staxmate.in.SMInputCursor;
-import org.sonar.api.utils.SonarException;
-import org.sonar.api.utils.XmlParserException;
-
-import javax.annotation.CheckForNull;
-import javax.xml.stream.XMLInputFactory;
-import javax.xml.stream.XMLStreamException;
-
-import java.io.File;
-import java.util.List;
-
-class FindbugsXmlReportParser {
-
- private final File findbugsXmlReport;
- private final String findbugsXmlReportPath;
-
- public FindbugsXmlReportParser(File findbugsXmlReport) {
- this.findbugsXmlReport = findbugsXmlReport;
- findbugsXmlReportPath = findbugsXmlReport.getAbsolutePath();
- if (!findbugsXmlReport.exists()) {
- throw new SonarException("The findbugs XML report can't be found at '" + findbugsXmlReportPath + "'");
- }
- }
-
- public List<XmlBugInstance> getBugInstances() {
- List<XmlBugInstance> result = Lists.newArrayList();
- try {
- SMInputFactory inf = new SMInputFactory(XMLInputFactory.newInstance());
- SMInputCursor cursor = inf.rootElementCursor(findbugsXmlReport).advance();
- SMInputCursor bugInstanceCursor = cursor.childElementCursor("BugInstance").advance();
- while (bugInstanceCursor.asEvent() != null) {
- XmlBugInstance xmlBugInstance = new XmlBugInstance();
- xmlBugInstance.type = bugInstanceCursor.getAttrValue("type");
- xmlBugInstance.longMessage = "";
- result.add(xmlBugInstance);
-
- ImmutableList.Builder<XmlSourceLineAnnotation> lines = ImmutableList.builder();
- SMInputCursor bugInstanceChildCursor = bugInstanceCursor.childElementCursor().advance();
- while (bugInstanceChildCursor.asEvent() != null) {
- String nodeName = bugInstanceChildCursor.getLocalName();
- if ("LongMessage".equals(nodeName)) {
- xmlBugInstance.longMessage = bugInstanceChildCursor.collectDescendantText();
- } else if ("SourceLine".equals(nodeName)) {
- XmlSourceLineAnnotation xmlSourceLineAnnotation = new XmlSourceLineAnnotation();
- xmlSourceLineAnnotation.parseStart(bugInstanceChildCursor.getAttrValue("start"));
- xmlSourceLineAnnotation.parseEnd(bugInstanceChildCursor.getAttrValue("end"));
- xmlSourceLineAnnotation.parsePrimary(bugInstanceChildCursor.getAttrValue("primary"));
- xmlSourceLineAnnotation.className = bugInstanceChildCursor.getAttrValue("classname");
- lines.add(xmlSourceLineAnnotation);
- }
- bugInstanceChildCursor.advance();
- }
- xmlBugInstance.sourceLines = lines.build();
- bugInstanceCursor.advance();
- }
- cursor.getStreamReader().closeCompletely();
- } catch (XMLStreamException e) {
- throw new XmlParserException("Unable to parse the Findbugs XML Report '" + findbugsXmlReportPath + "'", e);
- }
- return result;
- }
-
- public static class XmlBugInstance {
- private String type;
- private String longMessage;
- private List<XmlSourceLineAnnotation> sourceLines;
-
- public String getType() {
- return type;
- }
-
- public String getLongMessage() {
- return longMessage;
- }
-
- @CheckForNull
- public XmlSourceLineAnnotation getPrimarySourceLine() {
- for (XmlSourceLineAnnotation sourceLine : sourceLines) {
- if (sourceLine.isPrimary()) {
- // According to source code of Findbugs 2.0 - should be exactly one primary
- return sourceLine;
- }
- }
- // As a last resort - return first line
- return sourceLines.isEmpty() ? null : sourceLines.get(0);
- }
-
- }
-
- public static class XmlSourceLineAnnotation {
- private boolean primary;
- private Integer start;
- private Integer end;
- @VisibleForTesting
- protected String className;
-
- public void parseStart(String attrValue) {
- try {
- start = Integer.parseInt(attrValue);
- } catch (NumberFormatException e) {
- start = null;
- }
- }
-
- public void parseEnd(String attrValue) {
- try {
- end = Integer.parseInt(attrValue);
- } catch (NumberFormatException e) {
- end = null;
- }
- }
-
- public void parsePrimary(String attrValue) {
- primary = Boolean.parseBoolean(attrValue);
- }
-
- public boolean isPrimary() {
- return primary;
- }
-
- public Integer getStart() {
- return start;
- }
-
- public Integer getEnd() {
- return end;
- }
-
- public String getClassName() {
- return className;
- }
-
- public String getSonarJavaFileKey() {
- if (className.indexOf('$') > -1) {
- return className.substring(0, className.indexOf('$'));
- }
- return className;
- }
-
- }
-
-}
+++ /dev/null
-/*
- * Sonar, open source software quality management tool.
- * Copyright (C) 2008-2012 SonarSource
- * mailto:contact AT sonarsource DOT com
- *
- * Sonar is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * Sonar is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with Sonar; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02
- */
-package org.sonar.plugins.findbugs;
-
-import java.io.InputStreamReader;
-import java.io.Reader;
-
-import org.sonar.api.profiles.ProfileDefinition;
-import org.sonar.api.profiles.RulesProfile;
-import org.sonar.api.resources.Java;
-import org.sonar.api.utils.ValidationMessages;
-
-public class SonarWayWithFindbugsProfile extends ProfileDefinition {
-
- private FindbugsProfileImporter importer;
-
- public SonarWayWithFindbugsProfile(FindbugsProfileImporter importer) {
- this.importer = importer;
- }
-
- @Override
- public RulesProfile createProfile(ValidationMessages messages) {
- Reader pmdSonarWayProfile = new InputStreamReader(this.getClass().getResourceAsStream(
- "/org/sonar/plugins/findbugs/profile-sonar-way-findbugs.xml"));
- RulesProfile profile = importer.importProfile(pmdSonarWayProfile, messages);
- profile.setLanguage(Java.KEY);
- profile.setName(RulesProfile.SONAR_WAY_FINDBUGS_NAME);
- return profile;
- }
-}
+++ /dev/null
-/*
- * Sonar, open source software quality management tool.
- * Copyright (C) 2008-2012 SonarSource
- * mailto:contact AT sonarsource DOT com
- *
- * Sonar is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * Sonar is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with Sonar; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02
- */
-package org.sonar.plugins.findbugs.xml;
-
-import com.thoughtworks.xstream.annotations.XStreamAlias;
-import com.thoughtworks.xstream.annotations.XStreamAsAttribute;
-
-@XStreamAlias("Bug")
-public class Bug {
-
- @XStreamAsAttribute
- private String code;
-
- @XStreamAsAttribute
- private String category;
-
- @XStreamAsAttribute
- private String pattern;
-
- public Bug() {
- }
-
- public Bug(String pattern) {
- this.pattern = pattern;
- }
-
- public String getPattern() {
- return pattern;
- }
-
- public void setPattern(String pattern) {
- this.pattern = pattern;
- }
-
- public String getCode() {
- return code;
- }
-
- public void setCode(String code) {
- this.code = code;
- }
-
- public String getCategory() {
- return category;
- }
-
- public void setCategory(String category) {
- this.category = category;
- }
-}
+++ /dev/null
-/*
- * Sonar, open source software quality management tool.
- * Copyright (C) 2008-2012 SonarSource
- * mailto:contact AT sonarsource DOT com
- *
- * Sonar is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * Sonar is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with Sonar; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02
- */
-package org.sonar.plugins.findbugs.xml;
-
-import com.thoughtworks.xstream.annotations.XStreamAlias;
-import com.thoughtworks.xstream.annotations.XStreamAsAttribute;
-
-@XStreamAlias("Class")
-public class ClassFilter {
-
- @XStreamAsAttribute
- private String name;
-
- public ClassFilter() {
- }
-
- public ClassFilter(String name) {
- this.name = name;
- }
-
- public String getName() {
- return name;
- }
-
- public void setName(String name) {
- this.name = name;
- }
-}
\ No newline at end of file
+++ /dev/null
-/*
- * Sonar, open source software quality management tool.
- * Copyright (C) 2008-2012 SonarSource
- * mailto:contact AT sonarsource DOT com
- *
- * Sonar is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * Sonar is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with Sonar; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02
- */
-package org.sonar.plugins.findbugs.xml;
-
-import com.thoughtworks.xstream.annotations.XStreamAlias;
-import com.thoughtworks.xstream.annotations.XStreamAsAttribute;
-
-@XStreamAlias("Field")
-public class FieldFilter {
-
- @XStreamAsAttribute
- private String name;
-
- @XStreamAsAttribute
- private String type;
-
-
- public FieldFilter() {
- }
-
- public FieldFilter(String name) {
- this.name = name;
- }
-
- public String getName() {
- return name;
- }
-
- public void setName(String name) {
- this.name = name;
- }
-
- public String getType() {
- return type;
- }
-
- public void setType(String type) {
- this.type = type;
- }
-}
\ No newline at end of file
+++ /dev/null
-/*
- * Sonar, open source software quality management tool.
- * Copyright (C) 2008-2012 SonarSource
- * mailto:contact AT sonarsource DOT com
- *
- * Sonar is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * Sonar is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with Sonar; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02
- */
-package org.sonar.plugins.findbugs.xml;
-
-import com.thoughtworks.xstream.XStream;
-import com.thoughtworks.xstream.annotations.XStreamAlias;
-import com.thoughtworks.xstream.annotations.XStreamImplicit;
-import org.apache.commons.lang.StringUtils;
-import org.sonar.api.rules.RulePriority;
-import org.sonar.plugins.findbugs.FindbugsLevelUtils;
-
-import java.util.*;
-
-@XStreamAlias("FindBugsFilter")
-public class FindBugsFilter {
-
- private static final String PATTERN_SEPARATOR = ",";
- private static final String CODE_SEPARATOR = ",";
- private static final String CATEGORY_SEPARATOR = ",";
-
- @XStreamImplicit
- private List<Match> matchs;
-
- public FindBugsFilter() {
- matchs = new ArrayList<Match>();
- }
-
- public String toXml() {
- XStream xstream = createXStream();
- return xstream.toXML(this);
- }
-
- public List<Match> getMatchs() {
- return matchs;
- }
-
- public List<Match> getChildren() {
- return matchs;
- }
-
- public void setMatchs(List<Match> matchs) {
- this.matchs = matchs;
- }
-
- public void addMatch(Match child) {
- matchs.add(child);
- }
-
- public Map<String, RulePriority> getPatternLevels(FindbugsLevelUtils priorityMapper) {
- BugInfoSplitter splitter = new BugInfoSplitter() {
- public String getSeparator() {
- return PATTERN_SEPARATOR;
- }
-
- public String getVar(Bug bug) {
- return bug.getPattern();
- }
- };
- return processMatches(priorityMapper, splitter);
- }
-
- public Map<String, RulePriority> getCodeLevels(FindbugsLevelUtils priorityMapper) {
- BugInfoSplitter splitter = new BugInfoSplitter() {
- public String getSeparator() {
- return CODE_SEPARATOR;
- }
-
- public String getVar(Bug bug) {
- return bug.getCode();
- }
- };
- return processMatches(priorityMapper, splitter);
- }
-
- public Map<String, RulePriority> getCategoryLevels(FindbugsLevelUtils priorityMapper) {
- BugInfoSplitter splitter = new BugInfoSplitter() {
- public String getSeparator() {
- return CATEGORY_SEPARATOR;
- }
-
- public String getVar(Bug bug) {
- return bug.getCategory();
- }
- };
- return processMatches(priorityMapper, splitter);
- }
-
- private RulePriority getRulePriority(Priority priority, FindbugsLevelUtils priorityMapper) {
- return priority != null ? priorityMapper.from(priority.getValue()) : null;
- }
-
- private Map<String, RulePriority> processMatches(FindbugsLevelUtils priorityMapper, BugInfoSplitter splitter) {
- Map<String, RulePriority> result = new HashMap<String, RulePriority>();
- for (Match child : getChildren()) {
- if (child.getOrs() != null) {
- for (OrFilter orFilter : child.getOrs()) {
- completeLevels(result, orFilter.getBugs(), child.getPriority(), priorityMapper, splitter);
- }
- }
- if (child.getBug() != null) {
- completeLevels(result, Arrays.asList(child.getBug()), child.getPriority(), priorityMapper, splitter);
- }
- }
- return result;
- }
-
- private void completeLevels(Map<String, RulePriority> result, List<Bug> bugs, Priority priority, FindbugsLevelUtils priorityMapper, BugInfoSplitter splitter) {
- if (bugs == null) {
- return;
- }
- RulePriority rulePriority = getRulePriority(priority, priorityMapper);
- for (Bug bug : bugs) {
- String varToSplit = splitter.getVar(bug);
- if (!StringUtils.isBlank(varToSplit)) {
- String[] splitted = StringUtils.split(varToSplit, splitter.getSeparator());
- for (String code : splitted) {
- mapRulePriority(result, rulePriority, code);
- }
- }
- }
- }
-
- private interface BugInfoSplitter {
- String getVar(Bug bug);
-
- String getSeparator();
- }
-
- private void mapRulePriority(Map<String, RulePriority> prioritiesByRule, RulePriority priority, String key) {
- if (prioritiesByRule.containsKey(key) && prioritiesByRule.get(key) != null) {
- if (prioritiesByRule.get(key).compareTo(priority) < 0) {
- prioritiesByRule.put(key, priority);
- }
- } else {
- prioritiesByRule.put(key, priority);
- }
- }
-
- public static XStream createXStream() {
- XStream xstream = new XStream();
- xstream.setClassLoader(FindBugsFilter.class.getClassLoader());
- xstream.processAnnotations(FindBugsFilter.class);
- xstream.processAnnotations(Match.class);
- xstream.processAnnotations(Bug.class);
- xstream.processAnnotations(Priority.class);
- xstream.processAnnotations(ClassFilter.class);
- xstream.processAnnotations(PackageFilter.class);
- xstream.processAnnotations(MethodFilter.class);
- xstream.processAnnotations(FieldFilter.class);
- xstream.processAnnotations(LocalFilter.class);
- xstream.processAnnotations(OrFilter.class);
- return xstream;
- }
-}
+++ /dev/null
-/*
- * Sonar, open source software quality management tool.
- * Copyright (C) 2008-2012 SonarSource
- * mailto:contact AT sonarsource DOT com
- *
- * Sonar is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * Sonar is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with Sonar; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02
- */
-package org.sonar.plugins.findbugs.xml;
-
-import com.thoughtworks.xstream.annotations.XStreamAlias;
-import com.thoughtworks.xstream.annotations.XStreamAsAttribute;
-
-@XStreamAlias("Local")
-public class LocalFilter {
-
- @XStreamAsAttribute
- private String name;
-
- public LocalFilter() {
- }
-
- public LocalFilter(String name) {
- this.name = name;
- }
-
- public String getName() {
- return name;
- }
-
- public void setName(String name) {
- this.name = name;
- }
-}
\ No newline at end of file
+++ /dev/null
-/*
- * Sonar, open source software quality management tool.
- * Copyright (C) 2008-2012 SonarSource
- * mailto:contact AT sonarsource DOT com
- *
- * Sonar is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * Sonar is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with Sonar; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02
- */
-package org.sonar.plugins.findbugs.xml;
-
-import java.util.List;
-
-import com.thoughtworks.xstream.annotations.XStreamAlias;
-import com.thoughtworks.xstream.annotations.XStreamImplicit;
-
-@XStreamAlias("Match")
-public class Match {
-
- @XStreamAlias("Bug")
- private Bug bug;
-
- @XStreamAlias("Priority")
- private Priority priority;
-
- @XStreamAlias("Package")
- private PackageFilter particularPackage;
-
- @XStreamAlias("Class")
- private ClassFilter particularClass;
-
- @XStreamAlias("Method")
- private MethodFilter particularMethod;
-
- @XStreamAlias("Field")
- private FieldFilter particularField;
-
- @XStreamAlias("Local")
- private LocalFilter particularLocal;
-
- @XStreamImplicit(itemFieldName = "Or")
- private List<OrFilter> ors;
-
- public Match() {
- }
-
- public Match(Bug bug, Priority priority) {
- this.bug = bug;
- this.priority = priority;
- }
-
- public Match(Bug bug) {
- this.bug = bug;
- }
-
- public Match(ClassFilter particularClass) {
- this.particularClass = particularClass;
- }
-
- public Bug getBug() {
- return bug;
- }
-
- public void setBug(Bug bug) {
- this.bug = bug;
- }
-
- public Priority getPriority() {
- return priority;
- }
-
- public void setPriority(Priority priority) {
- this.priority = priority;
- }
-
- public PackageFilter getParticularPackage() {
- return particularPackage;
- }
-
- public void setParticularPackage(PackageFilter particularPackage) {
- this.particularPackage = particularPackage;
- }
-
- public ClassFilter getParticularClass() {
- return particularClass;
- }
-
- public void setParticularClass(ClassFilter particularClass) {
- this.particularClass = particularClass;
- }
-
- public MethodFilter getParticularMethod() {
- return particularMethod;
- }
-
- public void setParticularMethod(MethodFilter particularMethod) {
- this.particularMethod = particularMethod;
- }
-
- public FieldFilter getParticularField() {
- return particularField;
- }
-
- public void setParticularField(FieldFilter particularField) {
- this.particularField = particularField;
- }
-
- public LocalFilter getParticularLocal() {
- return particularLocal;
- }
-
- public void setParticularLocal(LocalFilter particularLocal) {
- this.particularLocal = particularLocal;
- }
-
- public List<OrFilter> getOrs() {
- return ors;
- }
-
- public void setOrs(List<OrFilter> ors) {
- this.ors = ors;
- }
-
- public void addDisjunctCombine(OrFilter child) {
- ors.add(child);
- }
-}
+++ /dev/null
-/*
- * Sonar, open source software quality management tool.
- * Copyright (C) 2008-2012 SonarSource
- * mailto:contact AT sonarsource DOT com
- *
- * Sonar is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * Sonar is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with Sonar; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02
- */
-package org.sonar.plugins.findbugs.xml;
-
-import com.thoughtworks.xstream.annotations.XStreamAlias;
-import com.thoughtworks.xstream.annotations.XStreamAsAttribute;
-
-@XStreamAlias("Method")
-public class MethodFilter {
-
- @XStreamAsAttribute
- private String name;
-
- @XStreamAsAttribute
- private String params;
-
- @XStreamAsAttribute
- private String returns;
-
-
- public MethodFilter() {
- }
-
- public MethodFilter(String name) {
- this.name = name;
- }
-
- public String getName() {
- return name;
- }
-
- public void setName(String name) {
- this.name = name;
- }
-
- public String getParams() {
- return params;
- }
-
- public void setParams(String params) {
- this.params = params;
- }
-
- public String getReturns() {
- return returns;
- }
-
- public void setReturns(String returns) {
- this.returns = returns;
- }
-}
\ No newline at end of file
+++ /dev/null
-/*
- * Sonar, open source software quality management tool.
- * Copyright (C) 2008-2012 SonarSource
- * mailto:contact AT sonarsource DOT com
- *
- * Sonar is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * Sonar is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with Sonar; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02
- */
-package org.sonar.plugins.findbugs.xml;
-
-import com.thoughtworks.xstream.annotations.XStreamAlias;
-import com.thoughtworks.xstream.annotations.XStreamImplicit;
-
-import java.util.ArrayList;
-import java.util.List;
-
-
-@XStreamAlias("Or")
-public class OrFilter {
-
- @XStreamImplicit(itemFieldName = "Bug")
- private List<Bug> bugs;
-
- @XStreamImplicit(itemFieldName = "Package")
- private List<PackageFilter> packages;
-
- @XStreamImplicit(itemFieldName = "Class")
- private List<ClassFilter> classes;
-
- @XStreamImplicit(itemFieldName = "Method")
- private List<MethodFilter> methods;
-
- @XStreamImplicit(itemFieldName = "Field")
- private List<FieldFilter> fields;
-
- @XStreamImplicit(itemFieldName = "Local")
- private List<LocalFilter> locals;
-
-
- public OrFilter() {
- bugs = new ArrayList<Bug>();
- packages = new ArrayList<PackageFilter>();
- classes = new ArrayList<ClassFilter>();
- methods = new ArrayList<MethodFilter>();
- fields = new ArrayList<FieldFilter>();
- locals = new ArrayList<LocalFilter>();
- }
-
- public List<Bug> getBugs() {
- return bugs;
- }
-
- public void setBugs(List<Bug> bugs) {
- this.bugs = bugs;
- }
-
- public List<PackageFilter> getPackages() {
- return packages;
- }
-
- public void setPackages(List<PackageFilter> packages) {
- this.packages = packages;
- }
-
- public List<ClassFilter> getClasses() {
- return classes;
- }
-
- public void setClasses(List<ClassFilter> classes) {
- this.classes = classes;
- }
-
- public List<MethodFilter> getMethods() {
- return methods;
- }
-
- public void setMethods(List<MethodFilter> methods) {
- this.methods = methods;
- }
-
- public List<FieldFilter> getFields() {
- return fields;
- }
-
- public void setFields(List<FieldFilter> fields) {
- this.fields = fields;
- }
-
- public List<LocalFilter> getLocals() {
- return locals;
- }
-
- public void setLocals(List<LocalFilter> locals) {
- this.locals = locals;
- }
-}
\ No newline at end of file
+++ /dev/null
-/*
- * Sonar, open source software quality management tool.
- * Copyright (C) 2008-2012 SonarSource
- * mailto:contact AT sonarsource DOT com
- *
- * Sonar is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * Sonar is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with Sonar; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02
- */
-package org.sonar.plugins.findbugs.xml;
-
-import com.thoughtworks.xstream.annotations.XStreamAlias;
-import com.thoughtworks.xstream.annotations.XStreamAsAttribute;
-
-@XStreamAlias("Package")
-public class PackageFilter {
-
- @XStreamAsAttribute
- private String name;
-
- public PackageFilter() {
- }
-
- public PackageFilter(String name) {
- this.name = name;
- }
-
- public String getName() {
- return name;
- }
-
- public void setName(String name) {
- this.name = name;
- }
-}
\ No newline at end of file
+++ /dev/null
-/*
- * Sonar, open source software quality management tool.
- * Copyright (C) 2008-2012 SonarSource
- * mailto:contact AT sonarsource DOT com
- *
- * Sonar is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * Sonar is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with Sonar; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02
- */
-package org.sonar.plugins.findbugs.xml;
-
-import com.thoughtworks.xstream.annotations.XStreamAlias;
-import com.thoughtworks.xstream.annotations.XStreamAsAttribute;
-
-@XStreamAlias("Priority")
-public class Priority {
-
- @XStreamAsAttribute
- private String value;
-
- public Priority() {
- }
-
- public Priority(String value) {
- this.value = value;
- }
-
- public String getValue() {
- return value;
- }
-
- public void setValue(String value) {
- this.value = value;
- }
-
-}
\ No newline at end of file
+++ /dev/null
-rule.findbugs.IMSE_DONT_CATCH_IMSE.name=Bad practice - Dubious catching of IllegalMonitorStateException
-rule.findbugs.BX_BOXING_IMMEDIATELY_UNBOXED.name=Performance - Primitive value is boxed and then immediately unboxed
-rule.findbugs.IJU_SETUP_NO_SUPER.name=Correctness - TestCase defines setUp that doesn't call super.setUp()
-rule.findbugs.TQ_ALWAYS_VALUE_USED_WHERE_NEVER_REQUIRED.name=Correctness - Value annotated as carrying a type qualifier used where a value that must not carry that qualifier is required
-rule.findbugs.TLW_TWO_LOCK_WAIT.name=Multithreaded correctness - Wait with two locks held
-rule.findbugs.RV_01_TO_INT.name=Correctness - Random value from 0 to 1 is coerced to the integer 0
-rule.findbugs.NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE.name=Dodgy - Parameter must be nonnull but is marked as nullable
-rule.findbugs.RV_ABSOLUTE_VALUE_OF_RANDOM_INT.name=Correctness - Bad attempt to compute absolute value of signed 32-bit random integer
-rule.findbugs.EC_INCOMPATIBLE_ARRAY_COMPARE.name=Correctness - equals(...) used to compare incompatible arrays
-rule.findbugs.UL_UNRELEASED_LOCK_EXCEPTION_PATH.name=Multithreaded correctness - Method does not release lock on all exception paths
-rule.findbugs.SE_NONSTATIC_SERIALVERSIONID.name=Bad practice - serialVersionUID isn't static
-rule.findbugs.UCF_USELESS_CONTROL_FLOW.name=Dodgy - Useless control flow
-rule.findbugs.BC_IMPOSSIBLE_CAST.name=Correctness - Impossible cast
-rule.findbugs.XSS_REQUEST_PARAMETER_TO_SEND_ERROR.name=Security - Servlet reflected cross site scripting vulnerability
-rule.findbugs.DM_NEW_FOR_GETCLASS.name=Performance - Method allocates an object, only to get the class object
-rule.findbugs.OBL_UNSATISFIED_OBLIGATION.name=Experimental - Method may fail to clean up stream or resource
-rule.findbugs.UW_UNCOND_WAIT.name=Multithreaded correctness - Unconditional wait
-rule.findbugs.DLS_DEAD_LOCAL_STORE_OF_NULL.name=Dodgy - Dead store of null to local variable
-rule.findbugs.NM_CLASS_NAMING_CONVENTION.name=Class names should start with an upper case letter
-rule.findbugs.RC_REF_COMPARISON_BAD_PRACTICE_BOOLEAN.name=Correctness - Suspicious reference comparison of Boolean values
-rule.findbugs.MWN_MISMATCHED_NOTIFY.name=Multithreaded correctness - Mismatched notify()
-rule.findbugs.NM_VERY_CONFUSING.name=Correctness - Very confusing method names
-rule.findbugs.FI_NULLIFY_SUPER.name=Bad practice - Finalizer nullifies superclass finalizer
-rule.findbugs.MTIA_SUSPECT_STRUTS_INSTANCE_FIELD.name=Dodgy - Class extends Struts Action class and uses instance variables
-rule.findbugs.DM_STRING_CTOR.name=Performance - Method invokes inefficient new String(String) constructor
-rule.findbugs.STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE.name=Multithreaded correctness - Call to static DateFormat
-rule.findbugs.NP_NULL_PARAM_DEREF_NONVIRTUAL.name=Correctness - Non-virtual method call passes null for nonnull parameter
-rule.findbugs.FI_EMPTY.name=Bad practice - Empty finalizer should be deleted
-rule.findbugs.CD_CIRCULAR_DEPENDENCY.name=Experimental - Test for circular dependencies among classes
-rule.findbugs.EC_UNRELATED_TYPES.name=Correctness - Call to equals() comparing different types
-rule.findbugs.EI_EXPOSE_STATIC_REP2.name=Malicious code vulnerability - May expose internal static state by storing a mutable object into a static field
-rule.findbugs.DMI_INVOKING_TOSTRING_ON_ANONYMOUS_ARRAY.name=Correctness - Invocation of toString on an anonymous array
-rule.findbugs.SIC_INNER_SHOULD_BE_STATIC_ANON.name=Performance - Could be refactored into a named static inner class
-rule.findbugs.STI_INTERRUPTED_ON_UNKNOWNTHREAD.name=Correctness - Static Thread.interrupted() method invoked on thread instance
-rule.findbugs.CN_IDIOM_NO_SUPER_CALL.name=Bad practice - clone method does not call super.clone()
-rule.findbugs.VA_FORMAT_STRING_BAD_ARGUMENT.name=Correctness - Format string placeholder incompatible with passed argument
-rule.findbugs.EQ_DOESNT_OVERRIDE_EQUALS.name=Dodgy - Class doesn't override equals in superclass
-rule.findbugs.BC_IMPOSSIBLE_DOWNCAST_OF_TOARRAY.name=Correctness - Impossible downcast of toArray() result
-rule.findbugs.SE_NO_SUITABLE_CONSTRUCTOR_FOR_EXTERNALIZATION.name=Bad practice - Class is Externalizable but doesn't define a void constructor
-rule.findbugs.TQ_EXPLICIT_UNKNOWN_SOURCE_VALUE_REACHES_ALWAYS_SINK.name=Correctness - Value required to have type qualifier, but marked as unknown
-rule.findbugs.SIC_INNER_SHOULD_BE_STATIC_NEEDS_THIS.name=Performance - Could be refactored into a static inner class
-rule.findbugs.EQ_CHECK_FOR_OPERAND_NOT_COMPATIBLE_WITH_THIS.name=Bad practice - Equals checks for noncompatible operand
-rule.findbugs.RV_RETURN_VALUE_OF_PUTIFABSENT_IGNORED.name=Correctness - Return value of putIfAbsent ignored, value passed to putIfAbsent reused
-rule.findbugs.STCAL_INVOKE_ON_STATIC_CALENDAR_INSTANCE.name=Multithreaded correctness - Call to static Calendar
-rule.findbugs.MS_CANNOT_BE_FINAL.name=Malicious code vulnerability - Field isn't final and can't be protected from malicious code
-rule.findbugs.IS_INCONSISTENT_SYNC.name=Multithreaded correctness - Inconsistent synchronization
-rule.findbugs.SE_NO_SERIALVERSIONID.name=Bad practice - Class is Serializable, but doesn't define serialVersionUID
-rule.findbugs.EI_EXPOSE_REP2.name=Malicious code vulnerability - May expose internal representation by incorporating reference to mutable object
-rule.findbugs.NM_METHOD_CONSTRUCTOR_CONFUSION.name=Correctness - Apparent method/constructor confusion
-rule.findbugs.ICAST_INTEGER_MULTIPLY_CAST_TO_LONG.name=Dodgy - Result of integer multiplication cast to long
-rule.findbugs.QF_QUESTIONABLE_FOR_LOOP.name=Dodgy - Complicated, subtle or wrong increment in for-loop
-rule.findbugs.DLS_DEAD_STORE_OF_CLASS_LITERAL.name=Correctness - Dead store of class literal
-rule.findbugs.NM_FUTURE_KEYWORD_USED_AS_MEMBER_IDENTIFIER.name=Bad practice - Use of identifier that is a keyword in later versions of Java
-rule.findbugs.BC_VACUOUS_INSTANCEOF.name=Dodgy - instanceof will always return true
-rule.findbugs.INT_VACUOUS_BIT_OPERATION.name=Dodgy - Vacuous bit mask operation on integer value
-rule.findbugs.NP_NULL_INSTANCEOF.name=Correctness - A known null value is checked to see if it is an instance of a type
-rule.findbugs.SIC_THREADLOCAL_DEADLY_EMBRACE.name=Correctness - Deadly embrace of non-static inner class and thread local
-rule.findbugs.EQ_UNUSUAL.name=Dodgy - Unusual equals method
-rule.findbugs.IJU_NO_TESTS.name=Correctness - TestCase has no tests
-rule.findbugs.EQ_OVERRIDING_EQUALS_NOT_SYMMETRIC.name=Correctness - equals method overrides equals in superclass and may not be symmetric
-rule.findbugs.XFB_XML_FACTORY_BYPASS.name=Dodgy - Method directly allocates a specific implementation of xml interfaces
-rule.findbugs.SWL_SLEEP_WITH_LOCK_HELD.name=Multithreaded correctness - Method calls Thread.sleep() with a lock held
-rule.findbugs.CN_IDIOM.name=Bad practice - Class implements Cloneable but does not define or use clone method
-rule.findbugs.WA_AWAIT_NOT_IN_LOOP.name=Multithreaded correctness - Condition.await() not in loop
-rule.findbugs.DM_FP_NUMBER_CTOR.name=Performance - Method invokes inefficient floating-point Number constructor; use static valueOf instead
-rule.findbugs.SF_SWITCH_NO_DEFAULT.name=Switch statement found where default case is missing
-rule.findbugs.NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE.name=Dodgy - Possible null pointer dereference due to return value of called method
-rule.findbugs.NP_CLONE_COULD_RETURN_NULL.name=Bad practice - Clone method may return null
-rule.findbugs.MS_OOI_PKGPROTECT.name=Malicious code vulnerability - Field should be moved out of an interface and made package protected
-rule.findbugs.DM_BOXED_PRIMITIVE_TOSTRING.name=Performance - Method allocates a boxed primitive just to call toString
-rule.findbugs.EQ_ABSTRACT_SELF.name=Bad practice - Abstract class defines covariant equals() method
-rule.findbugs.DM_STRING_TOSTRING.name=Performance - Method invokes toString() method on a String
-rule.findbugs.SE_METHOD_MUST_BE_PRIVATE.name=Correctness - Method must be private in order for serialization to work
-rule.findbugs.DL_SYNCHRONIZATION_ON_BOOLEAN.name=Multithreaded correctness - Synchronization on Boolean could lead to deadlock
-rule.findbugs.UWF_UNWRITTEN_FIELD.name=Correctness - Unwritten field
-rule.findbugs.IS2_INCONSISTENT_SYNC.name=Multithreaded correctness - Inconsistent synchronization
-rule.findbugs.IM_AVERAGE_COMPUTATION_COULD_OVERFLOW.name=Dodgy - Computation of average could overflow
-rule.findbugs.BIT_SIGNED_CHECK_HIGH_BIT.name=Correctness - Check for sign of bitwise operation
-rule.findbugs.FL_MATH_USING_FLOAT_PRECISION.name=Correctness - Method performs math using floating point precision
-rule.findbugs.WS_WRITEOBJECT_SYNC.name=Multithreaded correctness - Class's writeObject() method is synchronized but nothing else is
-rule.findbugs.RV_RETURN_VALUE_IGNORED.name=Correctness - Method ignores return value
-rule.findbugs.SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE.name=Security - Nonconstant string passed to execute method on an SQL statement
-rule.findbugs.JCIP_FIELD_ISNT_FINAL_IN_IMMUTABLE_CLASS.name=Bad practice - Fields of immutable classes should be final
-rule.findbugs.AM_CREATES_EMPTY_ZIP_FILE_ENTRY.name=Bad practice - Creates an empty zip file entry
-rule.findbugs.DM_NEXTINT_VIA_NEXTDOUBLE.name=Performance - Use the nextInt method of Random rather than nextDouble to generate a random integer
-rule.findbugs.UI_INHERITANCE_UNSAFE_GETRESOURCE.name=Bad practice - Usage of GetResource may be unsafe if class is extended
-rule.findbugs.SIO_SUPERFLUOUS_INSTANCEOF.name=Correctness - Unnecessary type check done using instanceof operator
-rule.findbugs.EQ_OTHER_NO_OBJECT.name=Correctness - equals() method defined that doesn't override equals(Object)
-rule.findbugs.USM_USELESS_ABSTRACT_METHOD.name=Experimental - Abstract Method is already defined in implemented interface
-rule.findbugs.MTIA_SUSPECT_SERVLET_INSTANCE_FIELD.name=Dodgy - Class extends Servlet class and uses instance variables
-rule.findbugs.DM_USELESS_THREAD.name=Multithreaded correctness - A thread was created using the default empty run method
-rule.findbugs.ML_SYNC_ON_UPDATED_FIELD.name=Multithreaded correctness - Method synchronizes on an updated field
-rule.findbugs.CO_SELF_NO_OBJECT.name=Bad practice - Covariant compareTo() method defined
-rule.findbugs.BC_UNCONFIRMED_CAST.name=Dodgy - Unchecked/unconfirmed cast
-rule.findbugs.FI_FINALIZER_NULLS_FIELDS.name=Bad practice - Finalizer nulls fields
-rule.findbugs.BIT_AND.name=Correctness - Incompatible bit masks (BIT_AND)
-rule.findbugs.FE_FLOATING_POINT_EQUALITY.name=Dodgy - Test for floating point equality
-rule.findbugs.TQ_EXPLICIT_UNKNOWN_SOURCE_VALUE_REACHES_NEVER_SINK.name=Correctness - Value required to not have type qualifier, but marked as unknown
-rule.findbugs.NP_NULL_PARAM_DEREF.name=Correctness - Method call passes null for nonnull parameter
-rule.findbugs.FB_MISSING_EXPECTED_WARNING.name=Experimental - Missing expected or desired warning from FindBugs
-rule.findbugs.DMI_INVOKING_HASHCODE_ON_ARRAY.name=Correctness - Invocation of hashCode on an array
-rule.findbugs.QBA_QUESTIONABLE_BOOLEAN_ASSIGNMENT.name=Correctness - Method assigns boolean literal in boolean expression
-rule.findbugs.SA_FIELD_SELF_COMPARISON.name=Correctness - Self comparison of field with itself
-rule.findbugs.UR_UNINIT_READ_CALLED_FROM_SUPER_CONSTRUCTOR.name=Correctness - Uninitialized read of field method called from constructor of superclass
-rule.findbugs.ES_COMPARING_PARAMETER_STRING_WITH_EQ.name=Bad practice - Comparison of String parameter using == or !=
-rule.findbugs.INT_BAD_COMPARISON_WITH_NONNEGATIVE_VALUE.name=Correctness - Bad comparison of nonnegative value with negative constant
-rule.findbugs.INT_BAD_COMPARISON_WITH_SIGNED_BYTE.name=Correctness - Bad comparison of signed byte
-rule.findbugs.IO_APPENDING_TO_OBJECT_OUTPUT_STREAM.name=Correctness - Doomed attempt to append to an object output stream
-rule.findbugs.FI_MISSING_SUPER_CALL.name=Bad practice - Finalizer does not call superclass finalizer
-rule.findbugs.VA_FORMAT_STRING_EXTRA_ARGUMENTS_PASSED.name=Correctness - More arguments are passed that are actually used in the format string
-rule.findbugs.HE_EQUALS_USE_HASHCODE.name=Bad practice - Class defines equals() and uses Object.hashCode()
-rule.findbugs.IJU_BAD_SUITE_METHOD.name=Correctness - TestCase declares a bad suite method
-rule.findbugs.DMI_CONSTANT_DB_PASSWORD.name=Security - Hardcoded constant database password
-rule.findbugs.REC_CATCH_EXCEPTION.name=Dodgy - Exception is caught when Exception is not thrown
-rule.findbugs.PS_PUBLIC_SEMAPHORES.name=Dodgy - Class exposes synchronization and semaphores in its public interface
-rule.findbugs.EC_UNRELATED_INTERFACES.name=Correctness - Call to equals() comparing different interface types
-rule.findbugs.UCF_USELESS_CONTROL_FLOW_NEXT_LINE.name=Correctness - Useless control flow to next line
-rule.findbugs.LG_LOST_LOGGER_DUE_TO_WEAK_REFERENCE.name=Experimental - Potential lost logger changes due to weak reference in OpenJDK
-rule.findbugs.NP_UNWRITTEN_FIELD.name=Correctness - Read of unwritten field
-rule.findbugs.DMI_UNSUPPORTED_METHOD.name=Dodgy - Call to unsupported method
-rule.findbugs.RCN_REDUNDANT_COMPARISON_OF_NULL_AND_NONNULL_VALUE.name=Dodgy - Redundant comparison of non-null value to null
-rule.findbugs.EC_BAD_ARRAY_COMPARE.name=Correctness - Invocation of equals() on an array, which is equivalent to ==
-rule.findbugs.EI_EXPOSE_REP.name=Malicious code vulnerability - May expose internal representation by returning reference to mutable object
-rule.findbugs.NP_DEREFERENCE_OF_READLINE_VALUE.name=Dodgy - Dereference of the result of readLine() without nullcheck
-rule.findbugs.UPM_UNCALLED_PRIVATE_METHOD.name=Performance - Private method is never called
-rule.findbugs.NP_NULL_ON_SOME_PATH.name=Correctness - Possible null pointer dereference
-rule.findbugs.NP_EQUALS_SHOULD_HANDLE_NULL_ARGUMENT.name=Bad practice - equals() method does not check for null argument
-rule.findbugs.EC_NULL_ARG.name=Correctness - Call to equals() with null argument
-rule.findbugs.SE_BAD_FIELD_STORE.name=Bad practice - Non-serializable value stored into instance field of a serializable class
-rule.findbugs.VO_VOLATILE_REFERENCE_TO_ARRAY.name=Multithreaded correctness - A volatile reference to an array doesn't treat the array elements as volatile
-rule.findbugs.NP_SYNC_AND_NULL_CHECK_FIELD.name=Multithreaded correctness - Synchronize and null check on the same field.
-rule.findbugs.DM_EXIT.name=Bad practice - Method invokes System.exit(...)
-rule.findbugs.RC_REF_COMPARISON.name=Bad practice - Suspicious reference comparison
-rule.findbugs.SE_NO_SUITABLE_CONSTRUCTOR.name=Bad practice - Class is Serializable but its superclass doesn't define a void constructor
-rule.findbugs.DC_DOUBLECHECK.name=Multithreaded correctness - Possible double check of field
-rule.findbugs.DMI_LONG_BITS_TO_DOUBLE_INVOKED_ON_INT.name=Correctness - Double.longBitsToDouble invoked on an int
-rule.findbugs.RpC_REPEATED_CONDITIONAL_TEST.name=Correctness - Repeated conditional tests
-rule.findbugs.WMI_WRONG_MAP_ITERATOR.name=Performance - Inefficient use of keySet iterator instead of entrySet iterator
-rule.findbugs.DLS_DEAD_LOCAL_STORE.name=Dodgy - Dead store to local variable
-rule.findbugs.INT_BAD_REM_BY_1.name=Correctness - Integer remainder modulo 1
-rule.findbugs.RV_RETURN_VALUE_IGNORED_BAD_PRACTICE.name=Bad practice - Method ignores exceptional return value
-rule.findbugs.SA_LOCAL_SELF_ASSIGNMENT.name=Dodgy - Self assignment of local variable
-rule.findbugs.MS_SHOULD_BE_FINAL.name=Malicious code vulnerability - Field isn't final but should be
-rule.findbugs.SIC_INNER_SHOULD_BE_STATIC.name=Performance - Should be a static inner class
-rule.findbugs.NP_GUARANTEED_DEREF.name=Correctness - Null value is guaranteed to be dereferenced
-rule.findbugs.SE_READ_RESOLVE_MUST_RETURN_OBJECT.name=Bad practice - The readResolve method must be declared with a return type of Object.
-rule.findbugs.NP_LOAD_OF_KNOWN_NULL_VALUE.name=Dodgy - Load of known null value
-rule.findbugs.BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION.name=Performance - Primitive value is boxed then unboxed to perform primitive coercion
-rule.findbugs.CN_IMPLEMENTS_CLONE_BUT_NOT_CLONEABLE.name=Bad practice - Class defines clone() but doesn't implement Cloneable
-rule.findbugs.CO_ABSTRACT_SELF.name=Bad practice - Abstract class defines covariant compareTo() method
-rule.findbugs.BAC_BAD_APPLET_CONSTRUCTOR.name=Experimental - Bad Applet Constructor relies on uninitialized AppletStub
-rule.findbugs.EQ_GETCLASS_AND_CLASS_CONSTANT.name=Bad practice - equals method fails for subtypes
-rule.findbugs.DB_DUPLICATE_SWITCH_CLAUSES.name=Dodgy - Method uses the same code for two switch clauses
-rule.findbugs.DB_DUPLICATE_BRANCHES.name=Dodgy - Method uses the same code for two branches
-rule.findbugs.UOE_USE_OBJECT_EQUALS.name=Experimental - Calls to equals on a final class that doesn't override Object's equals method
-rule.findbugs.FI_USELESS.name=Bad practice - Finalizer does nothing but call superclass finalizer
-rule.findbugs.NP_ALWAYS_NULL.name=Correctness - Null pointer dereference
-rule.findbugs.DMI_VACUOUS_SELF_COLLECTION_CALL.name=Correctness - Vacuous call to collections
-rule.findbugs.DLS_DEAD_LOCAL_STORE_IN_RETURN.name=Correctness - Useless assignment in return statement
-rule.findbugs.IJU_ASSERT_METHOD_INVOKED_FROM_RUN_METHOD.name=Correctness - JUnit assertion in run method will not be noticed by JUnit
-rule.findbugs.DMI_EMPTY_DB_PASSWORD.name=Security - Empty database password
-rule.findbugs.DM_BOOLEAN_CTOR.name=Performance - Method invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead
-rule.findbugs.BC_IMPOSSIBLE_DOWNCAST.name=Correctness - Impossible downcast
-rule.findbugs.BC_EQUALS_METHOD_SHOULD_WORK_FOR_ALL_OBJECTS.name=Bad practice - Equals method should not assume anything about the type of its argument
-rule.findbugs.RV_EXCEPTION_NOT_THROWN.name=Correctness - Exception created and dropped rather than thrown
-rule.findbugs.VA_PRIMITIVE_ARRAY_PASSED_TO_OBJECT_VARARG.name=Correctness - Primitive array passed to function expecting a variable number of object arguments
-rule.findbugs.LI_LAZY_INIT_UPDATE_STATIC.name=Multithreaded correctness - Incorrect lazy initialization and update of static field
-rule.findbugs.SA_FIELD_SELF_ASSIGNMENT.name=Correctness - Self assignment of field
-rule.findbugs.EQ_ALWAYS_FALSE.name=Correctness - equals method always returns false
-rule.findbugs.DMI_RANDOM_USED_ONLY_ONCE.name=Bad practice - Random object created and used only once
-rule.findbugs.NM_CLASS_NOT_EXCEPTION.name=Bad practice - Class is not derived from an Exception, even though it is named as such
-rule.findbugs.SA_LOCAL_DOUBLE_ASSIGNMENT.name=Dodgy - Double assignment of local variable
-rule.findbugs.NP_NULL_PARAM_DEREF_ALL_TARGETS_DANGEROUS.name=Correctness - Method call passes null for nonnull parameter (ALL_TARGETS_DANGEROUS)
-rule.findbugs.NP_TOSTRING_COULD_RETURN_NULL.name=Bad practice - toString method may return null
-rule.findbugs.BC_BAD_CAST_TO_ABSTRACT_COLLECTION.name=Dodgy - Questionable cast to abstract collection
-rule.findbugs.NM_LCASE_HASHCODE.name=Class defines hashcode(); should it be hashCode()?
-rule.findbugs.RU_INVOKE_RUN.name=Multithreaded correctness - Invokes run on a thread (did you mean to start it instead?)
-rule.findbugs.DMI_INVOKING_TOSTRING_ON_ARRAY.name=Correctness - Invocation of toString on an array
-rule.findbugs.NM_METHOD_NAMING_CONVENTION.name=Method names should start with a lower case letter
-rule.findbugs.RCN_REDUNDANT_COMPARISON_TWO_NULL_VALUES.name=Dodgy - Redundant comparison of two null values
-rule.findbugs.SA_LOCAL_SELF_COMPUTATION.name=Correctness - Nonsensical self computation involving a variable (e.g., x & x)
-rule.findbugs.MS_MUTABLE_HASHTABLE.name=Malicious code vulnerability - Field is a mutable Hashtable
-rule.findbugs.RV_DONT_JUST_NULL_CHECK_READLINE.name=Dodgy - Method discards result of readLine after checking if it is nonnull
-rule.findbugs.ES_COMPARING_STRINGS_WITH_EQ.name=Bad practice - Comparison of String objects using == or !=
-rule.findbugs.DL_SYNCHRONIZATION_ON_SHARED_CONSTANT.name=Multithreaded correctness - Synchronization on interned String could lead to deadlock
-rule.findbugs.MF_METHOD_MASKS_FIELD.name=Correctness - Method defines a variable that obscures a field
-rule.findbugs.EQ_SELF_USE_OBJECT.name=Correctness - Covariant equals() method defined, Object.equals(Object) inherited
-rule.findbugs.ICAST_INT_CAST_TO_FLOAT_PASSED_TO_ROUND.name=Correctness - int value cast to float and then passed to Math.round
-rule.findbugs.GC_UNRELATED_TYPES.name=Correctness - No relationship between generic parameter and method argument
-rule.findbugs.BC_IMPOSSIBLE_INSTANCEOF.name=Correctness - instanceof will always return false
-rule.findbugs.SBSC_USE_STRINGBUFFER_CONCATENATION.name=Performance - Method concatenates strings using + in a loop
-rule.findbugs.ICAST_INT_CAST_TO_DOUBLE_PASSED_TO_CEIL.name=Correctness - int value cast to double and then passed to Math.ceil
-rule.findbugs.UG_SYNC_SET_UNSYNC_GET.name=Multithreaded correctness - Unsynchronized get method, synchronized set method
-rule.findbugs.RE_BAD_SYNTAX_FOR_REGULAR_EXPRESSION.name=Correctness - Invalid syntax for regular expression
-rule.findbugs.SA_FIELD_SELF_COMPUTATION.name=Correctness - Nonsensical self computation involving a field (e.g., x & x)
-rule.findbugs.DMI_SCHEDULED_THREAD_POOL_EXECUTOR_WITH_ZERO_CORE_THREADS.name=Correctness - Creation of ScheduledThreadPoolExecutor with zero core threads
-rule.findbugs.DMI_USELESS_SUBSTRING.name=Dodgy - Invocation of substring(0), which returns the original value
-rule.findbugs.IA_AMBIGUOUS_INVOCATION_OF_INHERITED_OR_OUTER_METHOD.name=Dodgy - Ambiguous invocation of either an inherited or outer method
-rule.findbugs.OS_OPEN_STREAM.name=Bad practice - Method may fail to close stream
-rule.findbugs.HE_INHERITS_EQUALS_USE_HASHCODE.name=Bad practice - Class inherits equals() and uses Object.hashCode()
-rule.findbugs.SE_NONFINAL_SERIALVERSIONID.name=Bad practice - serialVersionUID isn't final
-rule.findbugs.EQ_SELF_NO_OBJECT.name=Bad practice - Covariant equals() method defined
-rule.findbugs.SF_DEAD_STORE_DUE_TO_SWITCH_FALLTHROUGH.name=Dead store due to switch statement fall through
-rule.findbugs.SW_SWING_METHODS_INVOKED_IN_SWING_THREAD.name=Bad practice - Certain swing methods needs to be invoked in Swing thread
-rule.findbugs.VA_FORMAT_STRING_ILLEGAL.name=Correctness - Illegal format string
-rule.findbugs.DM_NUMBER_CTOR.name=Performance - Method invokes inefficient Number constructor; use static valueOf instead
-rule.findbugs.RV_REM_OF_RANDOM_INT.name=Dodgy - Remainder of 32-bit signed random integer
-rule.findbugs.EQ_COMPARING_CLASS_NAMES.name=Correctness - equals method compares class names rather than class objects
-rule.findbugs.ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD.name=Dodgy - Write to static field from instance method
-rule.findbugs.TQ_NEVER_VALUE_USED_WHERE_ALWAYS_REQUIRED.name=Correctness - Value annotated as never carrying a type qualifier used where value carrying that qualifier is required
-rule.findbugs.NS_NON_SHORT_CIRCUIT.name=Dodgy - Questionable use of non-short-circuit logic
-rule.findbugs.VA_FORMAT_STRING_NO_PREVIOUS_ARGUMENT.name=Correctness - No previous argument for format string
-rule.findbugs.SE_PRIVATE_READ_RESOLVE_NOT_INHERITED.name=Dodgy - private readResolve method not inherited by subclasses
-rule.findbugs.RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE.name=Dodgy - Redundant nullcheck of value known to be non-null
-rule.findbugs.NM_LCASE_TOSTRING.name=Class defines tostring(); should it be toString()?
-rule.findbugs.HSC_HUGE_SHARED_STRING_CONSTANT.name=Performance - Huge string constants is duplicated across multiple class files
-rule.findbugs.SE_TRANSIENT_FIELD_NOT_RESTORED.name=Bad practice - Transient field that isn't set by deserialization.
-rule.findbugs.JLM_JSR166_LOCK_MONITORENTER.name=Multithreaded correctness - Synchronization performed on java.util.concurrent Lock
-rule.findbugs.EQ_ALWAYS_TRUE.name=Correctness - equals method always returns true
-rule.findbugs.ISC_INSTANTIATE_STATIC_CLASS.name=Bad practice - Needless instantiation of class that only supplies static methods
-rule.findbugs.ICAST_IDIV_CAST_TO_DOUBLE.name=Dodgy - int division result cast to double or float
-rule.findbugs.RC_REF_COMPARISON_BAD_PRACTICE.name=Correctness - Suspicious reference comparison to constant
-rule.findbugs.FI_EXPLICIT_INVOCATION.name=Bad practice - Explicit invocation of finalizer
-rule.findbugs.ESync_EMPTY_SYNC.name=Multithreaded correctness - Empty synchronized block
-rule.findbugs.DMI_USING_REMOVEALL_TO_CLEAR_COLLECTION.name=Correctness - Don't use removeAll to clear a collection
-rule.findbugs.SE_BAD_FIELD.name=Non-transient non-serializable instance field in serializable class
-rule.findbugs.NP_STORE_INTO_NONNULL_FIELD.name=Correctness - Store of null value into field annotated NonNull
-rule.findbugs.IT_NO_SUCH_ELEMENT.name=Bad practice - Iterator next() method can't throw NoSuchElementException
-rule.findbugs.HRS_REQUEST_PARAMETER_TO_HTTP_HEADER.name=Security - HTTP Response splitting vulnerability
-rule.findbugs.DMI_THREAD_PASSED_WHERE_RUNNABLE_EXPECTED.name=Dodgy - Thread passed where Runnable expected
-rule.findbugs.NP_GUARANTEED_DEREF_ON_EXCEPTION_PATH.name=Correctness - Value is null and guaranteed to be dereferenced on exception path
-rule.findbugs.RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE.name=Dodgy - Redundant nullcheck of value known to be null
-rule.findbugs.DMI_CALLING_NEXT_FROM_HASNEXT.name=Correctness - hasNext method invokes next
-rule.findbugs.HE_HASHCODE_USE_OBJECT_EQUALS.name=Bad practice - Class defines hashCode() and uses Object.equals()
-rule.findbugs.VA_FORMAT_STRING_EXPECTED_MESSAGE_FORMAT_SUPPLIED.name=Correctness - MessageFormat supplied where printf style format expected
-rule.findbugs.NP_BOOLEAN_RETURN_NULL.name=Bad practice - Method with Boolean return type returns explicit null
-rule.findbugs.RI_REDUNDANT_INTERFACES.name=Dodgy - Class implements same interface as superclass
-rule.findbugs.DL_SYNCHRONIZATION_ON_UNSHARED_BOXED_PRIMITIVE.name=Multithreaded correctness - Synchronization on boxed primitive values
-rule.findbugs.STCAL_STATIC_CALENDAR_INSTANCE.name=Multithreaded correctness - Static Calendar
-rule.findbugs.RR_NOT_CHECKED.name=Bad practice - Method ignores results of InputStream.read()
-rule.findbugs.IL_INFINITE_RECURSIVE_LOOP.name=Correctness - An apparent infinite recursive loop
-rule.findbugs.DMI_NONSERIALIZABLE_OBJECT_WRITTEN.name=Dodgy - Non serializable object written to ObjectOutput
-rule.findbugs.GC_UNCHECKED_TYPE_IN_GENERIC_CALL.name=Bad practice - Unchecked type in generic call
-rule.findbugs.IMA_INEFFICIENT_MEMBER_ACCESS.name=Experimental - Method accesses a private member variable of owning class
-rule.findbugs.FI_PUBLIC_SHOULD_BE_PROTECTED.name=Malicious code vulnerability - Finalizer should be protected, not public
-rule.findbugs.RV_CHECK_FOR_POSITIVE_INDEXOF.name=Dodgy - Method checks to see if result of String.indexOf is positive
-rule.findbugs.ICAST_QUESTIONABLE_UNSIGNED_RIGHT_SHIFT.name=Dodgy - Unsigned right shift cast to short/byte
-rule.findbugs.DM_STRING_VOID_CTOR.name=Performance - Method invokes inefficient new String() constructor
-rule.findbugs.RE_POSSIBLE_UNINTENDED_PATTERN.name=Correctness - "." used for regular expression
-rule.findbugs.WL_USING_GETCLASS_RATHER_THAN_CLASS_LITERAL.name=Multithreaded correctness - Sychronization on getClass rather than class literal
-rule.findbugs.ICAST_BAD_SHIFT_AMOUNT.name=Correctness - Integer shift by an amount not in the range 0..31
-rule.findbugs.SF_SWITCH_FALLTHROUGH.name=Switch statement found where one case falls through to the next case
-rule.findbugs.DP_DO_INSIDE_DO_PRIVILEGED.name=Bad practice - Method invoked that should be only be invoked inside a doPrivileged block
-rule.findbugs.NO_NOTIFY_NOT_NOTIFYALL.name=Multithreaded correctness - Using notify() rather than notifyAll()
-rule.findbugs.SS_SHOULD_BE_STATIC.name=Performance - Unread field: should this field be static?
-rule.findbugs.DM_RUN_FINALIZERS_ON_EXIT.name=Bad practice - Method invokes dangerous method runFinalizersOnExit
-rule.findbugs.MS_FINAL_PKGPROTECT.name=Malicious code vulnerability - Field should be both final and package protected
-rule.findbugs.BC_BAD_CAST_TO_CONCRETE_COLLECTION.name=Dodgy - Questionable cast to concrete collection
-rule.findbugs.BIT_IOR_OF_SIGNED_BYTE.name=Correctness - Bitwise OR of signed byte value
-rule.findbugs.MSF_MUTABLE_SERVLET_FIELD.name=Multithreaded correctness - Mutable servlet field
-rule.findbugs.SE_BAD_FIELD_INNER_CLASS.name=Bad practice - Non-serializable class has a serializable inner class
-rule.findbugs.BIT_ADD_OF_SIGNED_BYTE.name=Correctness - Bitwise add of signed byte value
-rule.findbugs.FI_FINALIZER_ONLY_NULLS_FIELDS.name=Bad practice - Finalizer only nulls fields
-rule.findbugs.DE_MIGHT_IGNORE.name=Bad practice - Method might ignore exception
-rule.findbugs.XSS_REQUEST_PARAMETER_TO_SERVLET_WRITER.name=Security - Servlet reflected cross site scripting vulnerability
-rule.findbugs.ML_SYNC_ON_FIELD_TO_GUARD_CHANGING_THAT_FIELD.name=Multithreaded correctness - Synchronization on field in futile attempt to guard that field
-rule.findbugs.SQL_BAD_PREPARED_STATEMENT_ACCESS.name=Correctness - Method attempts to access a prepared statement parameter with index 0
-rule.findbugs.DM_CONVERT_CASE.name=Internationalization - Consider using Locale parameterized version of invoked method
-rule.findbugs.SE_TRANSIENT_FIELD_OF_NONSERIALIZABLE_CLASS.name=Dodgy - Transient field of class that isn't Serializable.
-rule.findbugs.NN_NAKED_NOTIFY.name=Multithreaded correctness - Naked notify
-rule.findbugs.VA_FORMAT_STRING_MISSING_ARGUMENT.name=Correctness - Format string references missing argument
-rule.findbugs.IC_SUPERCLASS_USES_SUBCLASS_DURING_INITIALIZATION.name=Bad practice - Superclass uses subclass during initialization
-rule.findbugs.SA_LOCAL_SELF_COMPARISON.name=Correctness - Self comparison of value with itself
-rule.findbugs.IM_BAD_CHECK_FOR_ODD.name=Dodgy - Check for oddness that won't work for negative numbers
-rule.findbugs.NP_CLOSING_NULL.name=Correctness - close() invoked on a value that is always null
-rule.findbugs.XSS_REQUEST_PARAMETER_TO_JSP_WRITER.name=Security - JSP reflected cross site scripting vulnerability
-rule.findbugs.IS_FIELD_NOT_GUARDED.name=Multithreaded correctness - Field not guarded against concurrent access
-rule.findbugs.DM_GC.name=Performance - Explicit garbage collection; extremely dubious except in benchmarking code
-rule.findbugs.IM_MULTIPLYING_RESULT_OF_IREM.name=Correctness - Integer multiply of result of integer remainder
-rule.findbugs.SE_COMPARATOR_SHOULD_BE_SERIALIZABLE.name=Bad practice - Comparator doesn't implement Serializable
-rule.findbugs.HE_HASHCODE_NO_EQUALS.name=Bad practice - Class defines hashCode() but not equals()
-rule.findbugs.MF_CLASS_MASKS_FIELD.name=Correctness - Class defines field that masks a superclass field
-rule.findbugs.NM_VERY_CONFUSING_INTENTIONAL.name=Bad practice - Very confusing method names (but perhaps intentional)
-rule.findbugs.SR_NOT_CHECKED.name=Bad practice - Method ignores results of InputStream.skip()
-rule.findbugs.LI_LAZY_INIT_STATIC.name=Multithreaded correctness - Incorrect lazy initialization of static field
-rule.findbugs.DMI_ANNOTATION_IS_NOT_VISIBLE_TO_REFLECTION.name=Correctness - Can't use reflection to check for presence of annotation without runtime retention
-rule.findbugs.ODR_OPEN_DATABASE_RESOURCE_EXCEPTION_PATH.name=Bad practice - Method may fail to close database resource on exception
-rule.findbugs.BIT_IOR.name=Correctness - Incompatible bit masks (BIT_IOR)
-rule.findbugs.ODR_OPEN_DATABASE_RESOURCE.name=Bad practice - Method may fail to close database resource
-rule.findbugs.IP_PARAMETER_IS_DEAD_BUT_OVERWRITTEN.name=Correctness - A parameter is dead upon entry to a method but overwritten
-rule.findbugs.SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING.name=Security - A prepared statement is generated from a nonconstant String
-rule.findbugs.UUF_UNUSED_FIELD.name=Performance - Unused field
-rule.findbugs.RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE.name=Correctness - Nullcheck of value previously dereferenced
-rule.findbugs.EQ_OTHER_USE_OBJECT.name=Correctness - equals() method defined that doesn't override Object.equals(Object)
-rule.findbugs.SP_SPIN_ON_FIELD.name=Multithreaded correctness - Method spins on field
-rule.findbugs.SI_INSTANCE_BEFORE_FINALS_ASSIGNED.name=Bad practice - Static initializer creates instance before all static final fields assigned
-rule.findbugs.NP_ALWAYS_NULL_EXCEPTION.name=Correctness - Null pointer dereference in method on exception path
-rule.findbugs.MS_EXPOSE_REP.name=Malicious code vulnerability - Public static method may expose internal representation by returning array
-rule.findbugs.VA_FORMAT_STRING_BAD_CONVERSION_TO_BOOLEAN.name=Dodgy - Non-Boolean argument formatted using %b format specifier
-rule.findbugs.MS_PKGPROTECT.name=Malicious code vulnerability - Field should be package protected
-rule.findbugs.NP_NONNULL_RETURN_VIOLATION.name=Correctness - Method may return null, but is declared @NonNull
-rule.findbugs.J2EE_STORE_OF_NON_SERIALIZABLE_OBJECT_INTO_SESSION.name=Bad practice - Store of non serializable object into HttpSession
-rule.findbugs.NM_SAME_SIMPLE_NAME_AS_SUPERCLASS.name=Bad practice - Class names shouldn't shadow simple name of superclass
-rule.findbugs.DMI_BLOCKING_METHODS_ON_URL.name=Performance - The equals and hashCode methods of URL are blocking
-rule.findbugs.HE_SIGNATURE_DECLARES_HASHING_OF_UNHASHABLE_CLASS.name=Correctness - Signature declares use of unhashable class in hashed construct
-rule.findbugs.UR_UNINIT_READ.name=Correctness - Uninitialized read of field in constructor
-rule.findbugs.WA_NOT_IN_LOOP.name=Multithreaded correctness - Wait not in loop
-rule.findbugs.DMI_FUTILE_ATTEMPT_TO_CHANGE_MAXPOOL_SIZE_OF_SCHEDULED_THREAD_POOL_EXECUTOR.name=Correctness - Futile attempt to change max pool size of ScheduledThreadPoolExecutor
-rule.findbugs.RV_RETURN_VALUE_IGNORED2.name=Correctness - Method ignores return value
-rule.findbugs.NM_FIELD_NAMING_CONVENTION.name=Field names should start with a lower case letter
-rule.findbugs.FB_UNEXPECTED_WARNING.name=Experimental - Unexpected/undesired warning from FindBugs
-rule.findbugs.BX_UNBOXED_AND_COERCED_FOR_TERNARY_OPERATOR.name=Correctness - Primitive value is unboxed and coerced for ternary operator
-rule.findbugs.DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED.name=Bad practice - Classloaders should only be created inside doPrivileged block
-rule.findbugs.NM_WRONG_PACKAGE.name=Correctness - Method doesn't override method in superclass due to wrong package for parameter
-rule.findbugs.IL_CONTAINER_ADDED_TO_ITSELF.name=Correctness - A collection is added to itself
-rule.findbugs.CI_CONFUSED_INHERITANCE.name=Dodgy - Class is final but declares protected field
-rule.findbugs.HE_USE_OF_UNHASHABLE_CLASS.name=Correctness - Use of class without a hashCode() method in a hashed data structure
-rule.findbugs.IJU_SUITE_NOT_STATIC.name=Correctness - TestCase implements a non-static suite method
-rule.findbugs.RS_READOBJECT_SYNC.name=Multithreaded correctness - Class's readObject() method is synchronized
-rule.findbugs.AM_CREATES_EMPTY_JAR_FILE_ENTRY.name=Bad practice - Creates an empty jar file entry
-rule.findbugs.VA_FORMAT_STRING_BAD_CONVERSION_FROM_ARRAY.name=Correctness - Array formatted in useless way using format string
-rule.findbugs.SF_DEAD_STORE_DUE_TO_SWITCH_FALLTHROUGH_TO_THROW.name=Dead store due to switch statement fall through to throw
-rule.findbugs.RV_ABSOLUTE_VALUE_OF_HASHCODE.name=Correctness - Bad attempt to compute absolute value of signed 32-bit hashcode
-rule.findbugs.EQ_DONT_DEFINE_EQUALS_FOR_ENUM.name=Correctness - Covariant equals() method defined for enum
-rule.findbugs.SA_FIELD_DOUBLE_ASSIGNMENT.name=Correctness - Double assignment of field
-rule.findbugs.DMI_COLLECTION_OF_URLS.name=Performance - Maps and sets of URLs can be performance hogs
-rule.findbugs.NM_SAME_SIMPLE_NAME_AS_INTERFACE.name=Bad practice - Class names shouldn't shadow simple name of implemented interface
-rule.findbugs.UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR.name=Correctness - Field not initialized in constructor
-rule.findbugs.TQ_MAYBE_SOURCE_VALUE_REACHES_NEVER_SINK.name=Correctness - Value that might carry a type qualifier is always used in a way prohibits it from having that type qualifier
-rule.findbugs.SE_NONLONG_SERIALVERSIONID.name=Bad practice - serialVersionUID isn't long
-rule.findbugs.RV_REM_OF_HASHCODE.name=Dodgy - Remainder of hashCode could be negative
-rule.findbugs.NS_DANGEROUS_NON_SHORT_CIRCUIT.name=Dodgy - Potentially dangerous use of non-short-circuit logic
-rule.findbugs.USM_USELESS_SUBCLASS_METHOD.name=Experimental - Method superfluously delegates to parent class method
-rule.findbugs.ITA_INEFFICIENT_TO_ARRAY.name=Performance - Method uses toArray() with zero-length array argument
-rule.findbugs.DM_MONITOR_WAIT_ON_CONDITION.name=Multithreaded correctness - Monitor wait() called on Condition
-rule.findbugs.BOA_BADLY_OVERRIDDEN_ADAPTER.name=Correctness - Class overrides a method implemented in super class Adapter wrongly
-rule.findbugs.IC_INIT_CIRCULARITY.name=Dodgy - Initialization circularity
-rule.findbugs.NM_FUTURE_KEYWORD_USED_AS_IDENTIFIER.name=Bad practice - Use of identifier that is a keyword in later versions of Java
-rule.findbugs.EC_UNRELATED_CLASS_AND_INTERFACE.name=Correctness - Call to equals() comparing unrelated class and interface
-rule.findbugs.TQ_MAYBE_SOURCE_VALUE_REACHES_ALWAYS_SINK.name=Correctness - Value that might not carry a type qualifier is always used in a way requires that type qualifier
-rule.findbugs.FE_TEST_IF_EQUAL_TO_NOT_A_NUMBER.name=Correctness - Doomed test for equality to NaN
-rule.findbugs.NM_CONFUSING.name=Bad practice - Confusing method names
-rule.findbugs.VA_FORMAT_STRING_ARG_MISMATCH.name=Correctness - Number of format-string arguments does not correspond to number of placeholders
-rule.findbugs.NP_NULL_ON_SOME_PATH_EXCEPTION.name=Correctness - Possible null pointer dereference in method on exception path
-rule.findbugs.DL_SYNCHRONIZATION_ON_BOXED_PRIMITIVE.name=Multithreaded correctness - Synchronization on boxed primitive could lead to deadlock
-rule.findbugs.IJU_TEARDOWN_NO_SUPER.name=Correctness - TestCase defines tearDown that doesn't call super.tearDown()
-rule.findbugs.SE_READ_RESOLVE_IS_STATIC.name=Correctness - The readResolve method must not be declared as a static method.
-rule.findbugs.NP_NULL_ON_SOME_PATH_MIGHT_BE_INFEASIBLE.name=Dodgy - Possible null pointer dereference on path that might be infeasible
-rule.findbugs.UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS.name=Correctness - Uncallable method defined in anonymous class
-rule.findbugs.VA_FORMAT_STRING_BAD_CONVERSION.name=Correctness - The type of a supplied argument doesn't match format specifier
-rule.findbugs.EC_ARRAY_AND_NONARRAY.name=Correctness - equals() used to compare array and nonarray
-rule.findbugs.NM_BAD_EQUAL.name=Class defines equal(Object); should it be equals(Object)?
-rule.findbugs.EC_UNRELATED_TYPES_USING_POINTER_EQUALITY.name=Correctness - Using pointer equality to compare different types
-rule.findbugs.STI_INTERRUPTED_ON_CURRENTTHREAD.name=Correctness - Unneeded use of currentThread() call, to call interrupted()
-rule.findbugs.RE_CANT_USE_FILE_SEPARATOR_AS_REGULAR_EXPRESSION.name=Correctness - File.separator used for regular expression
-rule.findbugs.MWN_MISMATCHED_WAIT.name=Multithreaded correctness - Mismatched wait()
-rule.findbugs.IL_INFINITE_LOOP.name=Correctness - An apparent infinite loop
-rule.findbugs.NP_IMMEDIATE_DEREFERENCE_OF_READLINE.name=Dodgy - Immediate dereference of the result of readLine()
-rule.findbugs.SC_START_IN_CTOR.name=Multithreaded correctness - Constructor invokes Thread.start()
-rule.findbugs.STCAL_STATIC_SIMPLE_DATE_FORMAT_INSTANCE.name=Multithreaded correctness - Static DateFormat
-rule.findbugs.HE_EQUALS_NO_HASHCODE.name=Bad practice - Class defines equals() but not hashCode()
-rule.findbugs.UL_UNRELEASED_LOCK.name=Multithreaded correctness - Method does not release lock on all paths
-rule.findbugs.PZLA_PREFER_ZERO_LENGTH_ARRAYS.name=Dodgy - Consider returning a zero length array rather than null
-rule.findbugs.SKIPPED_CLASS_TOO_BIG.name=Dodgy - Class too big for analysis
-rule.findbugs.NP_ARGUMENT_MIGHT_BE_NULL.name=Correctness - Method does not check for null argument
-rule.findbugs.UM_UNNECESSARY_MATH.name=Performance - Method calls static Math class method on a constant value
-rule.findbugs.NM_WRONG_PACKAGE_INTENTIONAL.name=Bad practice - Method doesn't override method in superclass due to wrong package for parameter
-rule.findbugs.NP_NONNULL_PARAM_VIOLATION.name=Correctness - Method call passes null to a nonnull parameter
-rule.findbugs.BIT_AND_ZZ.name=Correctness - Check to see if ((...) & 0) == 0
-rule.findbugs.HRS_REQUEST_PARAMETER_TO_COOKIE.name=Security - HTTP cookie formed from untrusted input
-rule.findbugs.SQL_BAD_RESULTSET_ACCESS.name=Correctness - Method attempts to access a result set field with index 0
-rule.findbugs.INT_VACUOUS_COMPARISON.name=Dodgy - Vacuous comparison of integer value
-rule.findbugs.EQ_COMPARETO_USE_OBJECT_EQUALS.name=Bad practice - Class defines compareTo(...) and uses Object.equals()
-rule.findbugs.DMI_HARDCODED_ABSOLUTE_FILENAME.name=Dodgy - Code contains a hard coded reference to an absolute pathname
-rule.findbugs.DMI_COLLECTIONS_SHOULD_NOT_CONTAIN_THEMSELVES.name=Correctness - Collections should not contain themselves
-rule.findbugs.URF_UNREAD_FIELD.name=Performance - Unread field
-rule.findbugs.DLS_OVERWRITTEN_INCREMENT.name=Correctness - Overwritten increment
-rule.findbugs.BIT_SIGNED_CHECK.name=Bad practice - Check for sign of bitwise operation
-rule.findbugs.UWF_NULL_FIELD.name=Correctness - Field only ever set to null
-rule.findbugs.DE_MIGHT_DROP.name=Bad practice - Method might drop exception
-rule.findbugs.DMI_BAD_MONTH.name=Correctness - Bad constant value for month
-rule.findbugs.MS_MUTABLE_ARRAY.name=Malicious code vulnerability - Field is a mutable array
-rule.findbugs.SE_INNER_CLASS.name=Bad practice - Serializable inner class
-rule.findbugs.OS_OPEN_STREAM_EXCEPTION_PATH.name=Bad practice - Method may fail to close stream on exception
-rule.findbugs.AT_OPERATION_SEQUENCE_ON_CONCURRENT_ABSTRACTION.name=Sequence of calls to concurrent abstraction may not be atomic
-rule.findbugs.BX_UNBOXING_IMMEDIATELY_REBOXED.name=Boxed value is unboxed and then immediately reboxed
-rule.findbugs.CO_COMPARETO_RESULTS_MIN_VALUE.name=compareTo()/compare() returns Integer.MIN_VALUE
-rule.findbugs.DLS_DEAD_LOCAL_STORE_SHADOWS_FIELD.name=Dead store to local variable that shadows field
-rule.findbugs.DMI_ARGUMENTS_WRONG_ORDER.name=Reversed method arguments
-rule.findbugs.DMI_BIGDECIMAL_CONSTRUCTED_FROM_DOUBLE.name=BigDecimal constructed from double that isn't represented precisely
-rule.findbugs.DMI_DOH.name=D'oh! A nonsensical method invocation
-rule.findbugs.DMI_ENTRY_SETS_MAY_REUSE_ENTRY_OBJECTS.name=Adding elements of an entry set may fail due to reuse of Entry objects
-rule.findbugs.DM_DEFAULT_ENCODING.name=Reliance on default encoding
-rule.findbugs.ICAST_INT_2_LONG_AS_INSTANT.name=int value converted to long and used as absolute time
-rule.findbugs.INT_BAD_COMPARISON_WITH_INT_VALUE.name=Bad comparison of int value with long constant
-rule.findbugs.JML_JSR166_CALLING_WAIT_RATHER_THAN_AWAIT.name=Using monitor style wait methods on util.concurrent abstraction
-rule.findbugs.NP_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD.name=Read of unwritten public or protected field
-rule.findbugs.OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE.name=Method may fail to clean up stream or resource on checked exception
-rule.findbugs.PZ_DONT_REUSE_ENTRY_OBJECTS_IN_ITERATORS.name=Don't reuse entry objects in iterators
-rule.findbugs.RV_CHECK_COMPARETO_FOR_SPECIFIC_RETURN_VALUE.name=Code checks for specific values returned by compareTo
-rule.findbugs.RV_NEGATING_RESULT_OF_COMPARETO.name=Negating the result of compareTo()/compare()
-rule.findbugs.RV_RETURN_VALUE_IGNORED_INFERRED.name=Method ignores return value, is this OK?
-rule.findbugs.SA_LOCAL_SELF_ASSIGNMENT_INSTEAD_OF_FIELD.name=Self assignment of local rather than assignment to field
-rule.findbugs.URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD.name=Unread public/protected field
-rule.findbugs.UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD.name=Unused public or protected field
-rule.findbugs.UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD.name=Unwritten public or protected field
-rule.findbugs.VA_FORMAT_STRING_USES_NEWLINE.name=Format string should use %n rather than \\n
-rule.findbugs.VO_VOLATILE_INCREMENT.name=An increment to a volatile field isn't atomic
-rule.findbugs.PT_ABSOLUTE_PATH_TRAVERSAL.name=Absolute path traversal in servlet
-rule.findbugs.PT_RELATIVE_PATH_TRAVERSAL.name=Relative path traversal in servlet
-rule.findbugs.NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR.name=Nonnull field is not initialized
-rule.findbugs.MS_SHOULD_BE_REFACTORED_TO_BE_FINAL.name=Field isn't final but should be refactored to be so
-rule.findbugs.BC_UNCONFIRMED_CAST_OF_RETURN_VALUE.name=Unchecked/unconfirmed cast of return value from method
-rule.findbugs.TQ_COMPARING_VALUES_WITH_INCOMPATIBLE_TYPE_QUALIFIERS.name=Comparing values with incompatible type qualifiers
+++ /dev/null
-<p>The code calls <code>putNextEntry()</code>, immediately
-followed by a call to <code>closeEntry()</code>. This results
-in an empty JarFile entry. The contents of the entry
-should be written to the JarFile between the calls to
-<code>putNextEntry()</code> and
-<code>closeEntry()</code>.</p>
\ No newline at end of file
+++ /dev/null
-<p>The code calls <code>putNextEntry()</code>, immediately
-followed by a call to <code>closeEntry()</code>. This results
-in an empty ZipFile entry. The contents of the entry
-should be written to the ZipFile between the calls to
-<code>putNextEntry()</code> and
-<code>closeEntry()</code>.</p>
\ No newline at end of file
+++ /dev/null
-<p>This code contains a sequence of calls to a concurrent abstraction (such as a concurrent hash map). These calls will not be executed atomically.</p>
\ No newline at end of file
+++ /dev/null
-<p>
- This constructor calls methods in the parent Applet that rely on the AppletStub. Since the AppletStub
- isn't initialized until the init() method of this applet is called, these methods will not perform
- correctly.
- </p>
\ No newline at end of file
+++ /dev/null
-<p>
-This code casts a Collection to an abstract collection
-(such as <code>List</code>, <code>Set</code>, or <code>Map</code>).
-Ensure that you are guaranteed that the object is of the type
-you are casting to. If all you need is to be able
-to iterate through a collection, you don't need to cast it to a Set or List.
-</p>
\ No newline at end of file
+++ /dev/null
-<p>
-This code casts an abstract collection (such as a Collection, List, or Set)
-to a specific concrete implementation (such as an ArrayList or HashSet).
-This might not be correct, and it may make your code fragile, since
-it makes it harder to switch to other concrete implementations at a future
-point. Unless you have a particular reason to do so, just use the abstract
-collection class.
-</p>
\ No newline at end of file
+++ /dev/null
-<p>
-The <code>equals(Object o)</code> method shouldn't make any assumptions
-about the type of <code>o</code>. It should simply return
-false if <code>o</code> is not the same type as <code>this</code>.
-</p>
\ No newline at end of file
+++ /dev/null
-<p>
-This cast will always throw a ClassCastException.
-</p>
\ No newline at end of file
+++ /dev/null
-This cast will always throw a ClassCastException. The analysis believes it knows the precise type of the value being cast, and the attempt to downcast it to a subtype will always fail by throwing a ClassCastException.
\ No newline at end of file
+++ /dev/null
-<p>This code is casting the result of calling toArray() on a collection to a type more specific than Object[], as in:</p>
-<pre>
- String[] getAsArray(Collection<String> c) {
- return (String[]) c.toArray();
- }
-</pre>
-<p>This will usually fail by throwing a ClassCastException. The <code>toArray()</code> of almost all collections return an <code>Object[]</code>. They can't really do anything else, since the Collection object has no reference to the declared generic type of the collection.</p>
-<p>The correct way to do get an array of a specific type from a collection is to use <code>c.toArray(new String[]);</code> or <code>c.toArray(new String[c.size()]);</code> (the latter is slightly more efficient).</p>
-<p>There is one common/known exception exception to this. The toArray() method of lists returned by Arrays.asList(...) will return a covariantly typed array. For example, <code>Arrays.asArray(new String[] { "a" }).toArray()</code> will return a String []. FindBugs attempts to detect and suppress such cases, but may miss some.</p>
\ No newline at end of file
+++ /dev/null
-<p>
-This instanceof test will always return false. Although this is safe, make sure it isn't
-an indication of some misunderstanding or some other logic error.
-</p>
\ No newline at end of file
+++ /dev/null
-<p>
-This cast is unchecked, and not all instances of the type casted from can be cast to
-the type it is being cast to. Ensure that your program logic ensures that this
-cast will not fail.
-</p>
\ No newline at end of file
+++ /dev/null
-<p>
-This code performs an unchecked cast of the return value of a method.
-The code might be calling the method in such a way that the cast is guaranteed to be
-safe, but FindBugs is unable to verify that the cast is safe. Check that your program logic ensures that this
-cast will not fail.
-</p>
+++ /dev/null
-<p>
-This instanceof test will always return true (unless the value being tested is null).
-Although this is safe, make sure it isn't
-an indication of some misunderstanding or some other logic error.
-If you really want to test the value for being null, perhaps it would be clearer to do
-better to do a null test rather than an instanceof test.
-</p>
\ No newline at end of file
+++ /dev/null
-<p> Adds a byte value and a value which is known to the 8 lower bits clear.
-Values loaded from a byte array are sign extended to 32 bits
-before any any bitwise operations are performed on the value.
-Thus, if <code>b[0]</code> contains the value <code>0xff</code>, and
-<code>x</code> is initially 0, then the code
-<code>((x << 8) + b[0])</code> will sign extend <code>0xff</code>
-to get <code>0xffffffff</code>, and thus give the value
-<code>0xffffffff</code> as the result.
-</p>
-
-<p>In particular, the following code for packing a byte array into an int is badly wrong: </p>
-<pre>
-int result = 0;
-for(int i = 0; i < 4; i++)
- result = ((result << 8) + b[i]);
-</pre>
-
-<p>The following idiom will work instead: </p>
-<pre>
-int result = 0;
-for(int i = 0; i < 4; i++)
- result = ((result << 8) + (b[i] & 0xff));
-</pre>
\ No newline at end of file
+++ /dev/null
-<p> This method compares an expression of the form (e & C) to D,
-which will always compare unequal
-due to the specific values of constants C and D.
-This may indicate a logic error or typo.</p>
\ No newline at end of file
+++ /dev/null
-<p> This method compares an expression of the form (e & 0) to 0,
-which will always compare equal.
-This may indicate a logic error or typo.</p>
\ No newline at end of file
+++ /dev/null
-<p> This method compares an expression of the form (e | C) to D.
-which will always compare unequal
-due to the specific values of constants C and D.
-This may indicate a logic error or typo.</p>
-
-<p> Typically, this bug occurs because the code wants to perform
-a membership test in a bit set, but uses the bitwise OR
-operator ("|") instead of bitwise AND ("&").</p>
\ No newline at end of file
+++ /dev/null
-<p> Loads a value from a byte array and performs a bitwise OR with
-that value. Values loaded from a byte array are sign extended to 32 bits
-before any any bitwise operations are performed on the value.
-Thus, if <code>b[0]</code> contains the value <code>0xff</code>, and
-<code>x</code> is initially 0, then the code
-<code>((x << 8) | b[0])</code> will sign extend <code>0xff</code>
-to get <code>0xffffffff</code>, and thus give the value
-<code>0xffffffff</code> as the result.
-</p>
-
-<p>In particular, the following code for packing a byte array into an int is badly wrong: </p>
-<pre>
-int result = 0;
-for(int i = 0; i < 4; i++)
- result = ((result << 8) | b[i]);
-</pre>
-
-<p>The following idiom will work instead: </p>
-<pre>
-int result = 0;
-for(int i = 0; i < 4; i++)
- result = ((result << 8) | (b[i] & 0xff));
-</pre>
\ No newline at end of file
+++ /dev/null
-<p> This method compares an expression such as
-<pre>((event.detail & SWT.SELECTED) > 0)</pre>.
-Using bit arithmetic and then comparing with the greater than operator can
-lead to unexpected results (of course depending on the value of
-SWT.SELECTED). If SWT.SELECTED is a negative number, this is a candidate
-for a bug. Even when SWT.SELECTED is not negative, it seems good practice
-to use '!= 0' instead of '> 0'.
-</p>
-<p>
-<em>Boris Bokowski</em>
-</p>
\ No newline at end of file
+++ /dev/null
-<p> This method compares an expression such as
-<pre>((event.detail & SWT.SELECTED) > 0)</pre>.
-Using bit arithmetic and then comparing with the greater than operator can
-lead to unexpected results (of course depending on the value of
-SWT.SELECTED). If SWT.SELECTED is a negative number, this is a candidate
-for a bug. Even when SWT.SELECTED is not negative, it seems good practice
-to use '!= 0' instead of '> 0'.
-</p>
-<p>
-<em>Boris Bokowski</em>
-</p>
\ No newline at end of file
+++ /dev/null
-<p> This method overrides a method found in a parent class, where that class is an Adapter that implements
-a listener defined in the java.awt.event or javax.swing.event package. As a result, this method will not
-get called when the event occurs.</p>
\ No newline at end of file
+++ /dev/null
-<p>A primitive is boxed, and then immediately unboxed. This probably is due to a manual
- boxing in a place where an unboxed value is required, thus forcing the compiler
-to immediately undo the work of the boxing.
-</p>
\ No newline at end of file
+++ /dev/null
-<p>A primitive boxed value constructed and then immediately converted into a different primitive type
-(e.g., <code>new Double(d).intValue()</code>). Just perform direct primitive coercion (e.g., <code>(int) d</code>).</p>
\ No newline at end of file
+++ /dev/null
-<p>A wrapped primitive value is unboxed and converted to another primitive type as part of the
-evaluation of a conditional ternary operator (the <code> b ? e1 : e2</code> operator). The
-semantics of Java mandate that if <code>e1</code> and <code>e2</code> are wrapped
-numeric values, the values are unboxed and converted/coerced to their common type (e.g,
-if <code>e1</code> is of type <code>Integer</code>
-and <code>e2</code> is of type <code>Float</code>, then <code>e1</code> is unboxed,
-converted to a floating point value, and boxed. See JLS Section 15.25.
-</p>
\ No newline at end of file
+++ /dev/null
-<p>A boxed value is unboxed and then immediately reboxed.</p>
\ No newline at end of file
+++ /dev/null
-<p>
- This class has a circular dependency with other classes. This makes building these classes
- difficult, as each is dependent on the other to build correctly. Consider using interfaces
- to break the hard dependency.
- </p>
\ No newline at end of file
+++ /dev/null
-<p>
- This class is declared to be final, but declares fields to be protected. Since the class
- is final, it can not be derived from, and the use of protected is confusing. The access
- modifier for the field should be changed to private or public to represent the true
- use for the field.
- </p>
\ No newline at end of file
+++ /dev/null
-<p>
- Class implements Cloneable but does not define or
- use the clone method.</p>
\ No newline at end of file
+++ /dev/null
-<p> This non-final class defines a clone() method that does not call super.clone().
-If this class ("<i>A</i>") is extended by a subclass ("<i>B</i>"),
-and the subclass <i>B</i> calls super.clone(), then it is likely that
-<i>B</i>'s clone() method will return an object of type <i>A</i>,
-which violates the standard contract for clone().</p>
-
-<p> If all clone() methods call super.clone(), then they are guaranteed
-to use Object.clone(), which always returns an object of the correct type.</p>
\ No newline at end of file
+++ /dev/null
-<p> This class defines a clone() method but the class doesn't implement Cloneable.
-There are some situations in which this is OK (e.g., you want to control how subclasses
-can clone themselves), but just make sure that this is what you intended.
-</p>
\ No newline at end of file
+++ /dev/null
-<p> This class defines a covariant version of <code>compareTo()</code>.
- To correctly override the <code>compareTo()</code> method in the
- <code>Comparable</code> interface, the parameter of <code>compareTo()</code>
- must have type <code>java.lang.Object</code>.</p>
\ No newline at end of file
+++ /dev/null
-<p>In some situation, this compareTo or compare method returns the constant Integer.MIN_VALUE,
-which is an exceptionally bad practice. The only thing that matters about the return value of
-compareTo is the sign of the result. But people will sometimes negate the return value of compareTo,
-expecting that this will negate the sign of the result. And it will, except in the case where
-the value returned is Integer.MIN_VALUE. So just return -1 rather than Integer.MIN_VALUE.</p>
\ No newline at end of file
+++ /dev/null
-<p> This class defines a covariant version of <code>compareTo()</code>.
- To correctly override the <code>compareTo()</code> method in the
- <code>Comparable</code> interface, the parameter of <code>compareTo()</code>
- must have type <code>java.lang.Object</code>.</p>
\ No newline at end of file
+++ /dev/null
-<p>
- This method uses the same code to implement two branches of a conditional branch.
- Check to ensure that this isn't a coding mistake.
- </p>
\ No newline at end of file
+++ /dev/null
-<p>
- This method uses the same code to implement two clauses of a switch statement.
- This could be a case of duplicate code, but it might also indicate
- a coding mistake.
- </p>
\ No newline at end of file
+++ /dev/null
-<p> This method may contain an instance of double-checked locking.
- This idiom is not correct according to the semantics of the Java memory
- model. For more information, see the web page
- <a href="http://www.cs.umd.edu/~pugh/java/memoryModel/DoubleCheckedLocking.html"
- >http://www.cs.umd.edu/~pugh/java/memoryModel/DoubleCheckedLocking.html</a>.</p>
\ No newline at end of file
+++ /dev/null
-<p> This method might drop an exception. In general, exceptions
- should be handled or reported in some way, or they should be thrown
- out of the method.</p>
\ No newline at end of file
+++ /dev/null
-<p> This method might ignore an exception. In general, exceptions
- should be handled or reported in some way, or they should be thrown
- out of the method.</p>
\ No newline at end of file
+++ /dev/null
-<p>
-This instruction assigns a value to a local variable,
-but the value is not read or used in any subsequent instruction.
-Often, this indicates an error, because the value computed is never
-used.
-</p>
-<p>
-Note that Sun's javac compiler often generates dead stores for
-final local variables. Because FindBugs is a bytecode-based tool,
-there is no easy way to eliminate these false positives.
-</p>
\ No newline at end of file
+++ /dev/null
-<p>
-This statement assigns to a local variable in a return statement. This assignment
-has effect. Please verify that this statement does the right thing.
-</p>
\ No newline at end of file
+++ /dev/null
-<p>The code stores null into a local variable, and the stored value is not
-read. This store may have been introduced to assist the garbage collector, but
-as of Java SE 6.0, this is no longer needed or useful.
-</p>
\ No newline at end of file
+++ /dev/null
-<p>This instruction assigns a value to a local variable, but the value is not read or used in
-any subsequent instruction. Often, this indicates an error, because the value computed is never
-used. There is a field with the same name as the local variable. Did you mean to assign to that
-variable instead?</p>
\ No newline at end of file
+++ /dev/null
-<p>
-This instruction assigns a class literal to a variable and then never uses it.
-<a href="//java.sun.com/j2se/1.5.0/compatibility.html#literal">The behavior of this differs in Java 1.4 and in Java 5.</a>
-In Java 1.4 and earlier, a reference to <code>Foo.class</code> would force the static initializer
-for <code>Foo</code> to be executed, if it has not been executed already.
-In Java 5 and later, it does not.
-</p>
-<p>See Sun's <a href="//java.sun.com/j2se/1.5.0/compatibility.html#literal">article on Java SE compatibility</a>
-for more details and examples, and suggestions on how to force class initialization in Java 5.
-</p>
\ No newline at end of file
+++ /dev/null
-<p>
-The code performs an increment operation (e.g., <code>i++</code>) and then
-immediately overwrites it. For example, <code>i = i++</code> immediately
-overwrites the incremented value with the original value.
-</p>
\ No newline at end of file
+++ /dev/null
-<p> The code synchronizes on a boxed primitive constant, such as an Boolean.
-<pre>
-private static Boolean inited = Boolean.FALSE;
-...
- synchronized(inited) {
- if (!inited) {
- init();
- inited = Boolean.TRUE;
- }
- }
-...
-</pre>
-</p>
-<p>Since there normally exist only two Boolean objects, this code could be synchronizing on the same object as other, unrelated code, leading to unresponsiveness
-and possible deadlock</p>
\ No newline at end of file
+++ /dev/null
-<p> The code synchronizes on a boxed primitive constant, such as an Integer.
-<pre>
-private static Integer count = 0;
-...
- synchronized(count) {
- count++;
- }
-...
-</pre>
-</p>
-<p>Since Integer objects can be cached and shared,
-this code could be synchronizing on the same object as other, unrelated code, leading to unresponsiveness
-and possible deadlock</p>
\ No newline at end of file
+++ /dev/null
-<p> The code synchronizes on interned String.
-<pre>
-private static String LOCK = "LOCK";
-...
- synchronized(LOCK) { ...}
-...
-</pre>
-</p>
-<p>Constant Strings are interned and shared across all other classes loaded by the JVM. Thus, this could
-is locking on something that other code might also be locking. This could result in very strange and hard to diagnose
-blocking and deadlock behavior. See <a href="http://www.javalobby.org/java/forums/t96352.html">http://www.javalobby.org/java/forums/t96352.html</a> and <a href="http://jira.codehaus.org/browse/JETTY-352">http://jira.codehaus.org/browse/JETTY-352</a>.
-</p>
\ No newline at end of file
+++ /dev/null
-<p> The code synchronizes on an apparently unshared boxed primitive,
-such as an Integer.
-<pre>
-private static final Integer fileLock = new Integer(1);
-...
- synchronized(fileLock) {
- .. do something ..
- }
-...
-</pre>
-</p>
-<p>It would be much better, in this code, to redeclare fileLock as
-<pre>
-private static final Object fileLock = new Object();
-</pre>
-The existing code might be OK, but it is confusing and a
-future refactoring, such as the "Remove Boxing" refactoring in IntelliJ,
-might replace this with the use of an interned Integer object shared
-throughout the JVM, leading to very confusing behavior and potential deadlock.
-</p>
\ No newline at end of file
+++ /dev/null
-<p> Unless an annotation has itself been annotated with @Retention(RetentionPolicy.RUNTIME), the annotation can't be observed using reflection
-(e.g., by using the isAnnotationPresent method).
- .</p>
\ No newline at end of file
+++ /dev/null
-<p>The arguments to this method call seem to be in the wrong order. For example, a call
-<code>Preconditions.checkNotNull("message", message)</code> has reserved arguments: the value
-to be checked is the first argument.</p>
\ No newline at end of file
+++ /dev/null
-<p>
-This code passes a constant month
-value outside the expected range of 0..11 to a method.
-</p>
\ No newline at end of file
+++ /dev/null
-<p>This code creates a BigDecimal from a double value that doesn't translate well to a decimal number. For example,
-one might assume that writing <code>new BigDecimal(0.1)</code> in Java creates a BigDecimal which is exactly equal to 0.1
-(an unscaled value of 1, with a scale of 1), but it is actually equal to 0.1000000000000000055511151231257827021181583404541015625.
-You probably want to use the <code>BigDecimal.valueOf(double d)</code> method, which uses the String representation of the double to
-create the BigDecimal (e.g., <code>BigDecimal.valueOf(0.1)</code> gives 0.1).</p>
\ No newline at end of file
+++ /dev/null
-<p> The equals and hashCode
-method of URL perform domain name resolution, this can result in a big performance hit.
-See <a href="http://michaelscharf.blogspot.com/2006/11/javaneturlequals-and-hashcode-make.html">http://michaelscharf.blogspot.com/2006/11/javaneturlequals-and-hashcode-make.html</a> for more information.
-Consider using <code>java.net.URI</code> instead.
- </p>
\ No newline at end of file
+++ /dev/null
-<p>
-The hasNext() method invokes the next() method. This is almost certainly wrong,
-since the hasNext() method is not supposed to change the state of the iterator,
-and the next method is supposed to change the state of the iterator.
-</p>
\ No newline at end of file
+++ /dev/null
-<p> This call to a generic collection's method would only make sense if a collection contained
-itself (e.g., if <code>s.contains(s)</code> were true). This is unlikely to be true and would cause
-problems if it were true (such as the computation of the hash code resulting in infinite recursion).
-It is likely that the wrong value is being passed as a parameter.
- </p>
\ No newline at end of file
+++ /dev/null
-<p> This method or field is or uses a Map or Set of URLs. Since both the equals and hashCode
-method of URL perform domain name resolution, this can result in a big performance hit.
-See <a href="http://michaelscharf.blogspot.com/2006/11/javaneturlequals-and-hashcode-make.html">http://michaelscharf.blogspot.com/2006/11/javaneturlequals-and-hashcode-make.html</a> for more information.
-Consider using <code>java.net.URI</code> instead.
- </p>
\ No newline at end of file
+++ /dev/null
-<p>This code creates a database connect using a hardcoded, constant password. Anyone with access to either the source code or the compiled code can
- easily learn the password.
-</p>
\ No newline at end of file
+++ /dev/null
-<p>This partical method invocation doesn't make sense, for reasons that should be apparent from inspection.</p>
\ No newline at end of file
+++ /dev/null
-<p>This code creates a database connect using a blank or empty password. This indicates that the database is not protected by a password.
-</p>
\ No newline at end of file
+++ /dev/null
-<p>The entrySet() method is allowed to return a view of the underlying Map in which a single Entry
- object is reused and returned during the iteration. As of Java 1.6, both IdentityHashMap and EnumMap
- did so. When iterating through such a Map, the Entry value is only valid until you advance to the
- next iteration. If, for example, you try to pass such an entrySet to an addAll method, things will
- go badly wrong.</p>
\ No newline at end of file
+++ /dev/null
-<p>(<a href="http://java.sun.com/javase/6/docs/api/java/util/concurrent/ScheduledThreadPoolExecutor.html">Javadoc</a>)
-While ScheduledThreadPoolExecutor inherits from ThreadPoolExecutor, a few of the inherited tuning methods are not useful for it. In particular, because it acts as a fixed-sized pool using corePoolSize threads and an unbounded queue, adjustments to maximumPoolSize have no useful effect.
- </p>
\ No newline at end of file
+++ /dev/null
-<p>This code constructs a File object using a hard coded to an absolute pathname
-(e.g., <code>new File("/home/dannyc/workspace/j2ee/src/share/com/sun/enterprise/deployment");</code>
-</p>
\ No newline at end of file
+++ /dev/null
-<p>
-The code invokes hashCode on an array. Calling hashCode on
-an array returns the same value as System.identityHashCode, and ingores
-the contents and length of the array. If you need a hashCode that
-depends on the contents of an array <code>a</code>,
-use <code>java.util.Arrays.hashCode(a)</code>.
-
-</p>
\ No newline at end of file
+++ /dev/null
-<p>
-The code invokes toString on an (anonymous) array. Calling toString on an array generates a fairly useless result
-such as [C@16f0472. Consider using Arrays.toString to convert the array into a readable
-String that gives the contents of the array. See Programming Puzzlers, chapter 3, puzzle 12.
-</p>
\ No newline at end of file
+++ /dev/null
-<p>
-The code invokes toString on an array, which will generate a fairly useless result
-such as [C@16f0472. Consider using Arrays.toString to convert the array into a readable
-String that gives the contents of the array. See Programming Puzzlers, chapter 3, puzzle 12.
-</p>
\ No newline at end of file
+++ /dev/null
-<p> The Double.longBitsToDouble method is invoked, but a 32 bit int value is passed
- as an argument. This almostly certainly is not intended and is unlikely
- to give the intended result.
-</p>
\ No newline at end of file
+++ /dev/null
-<p>
-This code seems to be passing a non-serializable object to the ObjectOutput.writeObject method.
-If the object is, indeed, non-serializable, an error will result.
-</p>
\ No newline at end of file
+++ /dev/null
-<p> This code creates a java.util.Random object, uses it to generate one random number, and then discards
-the Random object. This produces mediocre quality random numbers and is inefficient.
-If possible, rewrite the code so that the Random object is created once and saved, and each time a new random number
-is required invoke a method on the existing Random object to obtain it.
-</p>
-
-<p>If it is important that the generated Random numbers not be guessable, you <em>must</em> not create a new Random for each random
-number; the values are too easily guessable. You should strongly consider using a java.security.SecureRandom instead
-(and avoid allocating a new SecureRandom for each random number needed).
-</p>
\ No newline at end of file
+++ /dev/null
-<p>(<a href="http://java.sun.com/javase/6/docs/api/java/util/concurrent/ScheduledThreadPoolExecutor.html#ScheduledThreadPoolExecutor(int)">Javadoc</a>)
-A ScheduledThreadPoolExecutor with zero core threads will never execute anything; changes to the max pool size are ignored.
-</p>
\ No newline at end of file
+++ /dev/null
-<p> A Thread object is passed as a parameter to a method where
-a Runnable is expected. This is rather unusual, and may indicate a logic error
-or cause unexpected behavior.
- </p>
\ No newline at end of file
+++ /dev/null
-<p>All targets of this method invocation throw an UnsupportedOperationException.
-</p>
\ No newline at end of file
+++ /dev/null
-<p>
-This code invokes substring(0) on a String, which returns the original value.
-</p>
\ No newline at end of file
+++ /dev/null
-<p> If you want to remove all elements from a collection <code>c</code>, use <code>c.clear</code>,
-not <code>c.removeAll(c)</code>.
- </p>
\ No newline at end of file
+++ /dev/null
-<p> This call doesn't make sense. For any collection <code>c</code>, calling <code>c.containsAll(c)</code> should
-always be true, and <code>c.retainAll(c)</code> should have no effect.
- </p>
\ No newline at end of file
+++ /dev/null
-<p> Creating new instances of <code>java.lang.Boolean</code> wastes
- memory, since <code>Boolean</code> objects are immutable and there are
- only two useful values of this type. Use the <code>Boolean.valueOf()</code>
- method (or Java 1.5 autoboxing) to create <code>Boolean</code> objects instead.</p>
\ No newline at end of file
+++ /dev/null
-<p>A boxed primitive is allocated just to call toString(). It is more effective to just use the static
- form of toString which takes the primitive value. So,</p>
- <table>
- <tr><th>Replace...</th><th>With this...</th></tr>
- <tr><td>new Integer(1).toString()</td><td>Integer.toString(1)</td></tr>
- <tr><td>new Long(1).toString()</td><td>Long.toString(1)</td></tr>
- <tr><td>new Float(1.0).toString()</td><td>Float.toString(1.0)</td></tr>
- <tr><td>new Double(1.0).toString()</td><td>Double.toString(1.0)</td></tr>
- <tr><td>new Byte(1).toString()</td><td>Byte.toString(1)</td></tr>
- <tr><td>new Short(1).toString()</td><td>Short.toString(1)</td></tr>
- <tr><td>new Boolean(true).toString()</td><td>Boolean.toString(true)</td></tr>
- </table>
\ No newline at end of file
+++ /dev/null
-<p> A String is being converted to upper or lowercase, using the platform's default encoding. This may
- result in improper conversions when used with international characters. Use the </p>
- <table><tr><td>String.toUpperCase( Locale l )</td></tr><tr><td>String.toLowerCase( Locale l )</td></tr></table>
- <p>versions instead.</p>
\ No newline at end of file
+++ /dev/null
-<p>Found a call to a method which will perform a byte to String (or String to byte) conversion,
-and will assume that the default platform encoding is suitable. This will cause the application
-behaviour to vary between platforms. Use an alternative API and specify a charset name or
-Charset object explicitly.</p>
\ No newline at end of file
+++ /dev/null
-<p> Invoking System.exit shuts down the entire Java virtual machine. This
- should only been done when it is appropriate. Such calls make it
- hard or impossible for your code to be invoked by other code.
- Consider throwing a RuntimeException instead.</p>
\ No newline at end of file
+++ /dev/null
-<p>
- Using <code>new Double(double)</code> is guaranteed to always result in a new object whereas
- <code>Double.valueOf(double)</code> allows caching of values to be done by the compiler, class library, or JVM.
- Using of cached values avoids object allocation and the code will be faster.
- </p>
- <p>
- Unless the class must be compatible with JVMs predating Java 1.5,
- use either autoboxing or the <code>valueOf()</code> method when creating instances of <code>Double</code> and <code>Float</code>.
- </p>
\ No newline at end of file
+++ /dev/null
-<p> Code explicitly invokes garbage collection.
- Except for specific use in benchmarking, this is very dubious.</p>
- <p>In the past, situations where people have explicitly invoked
- the garbage collector in routines such as close or finalize methods
- has led to huge performance black holes. Garbage collection
- can be expensive. Any situation that forces hundreds or thousands
- of garbage collections will bring the machine to a crawl.</p>
\ No newline at end of file
+++ /dev/null
-<p>
- This method calls <code>wait()</code> on a
- <code>java.util.concurrent.locks.Condition</code> object.
- Waiting for a <code>Condition</code> should be done using one of the <code>await()</code>
- methods defined by the <code>Condition</code> interface.
- </p>
\ No newline at end of file
+++ /dev/null
-<p>This method allocates an object just to call getClass() on it, in order to
- retrieve the Class object for it. It is simpler to just access the .class property of the class.</p>
\ No newline at end of file
+++ /dev/null
-<p>If <code>r</code> is a <code>java.util.Random</code>, you can generate a random number from <code>0</code> to <code>n-1</code>
-using <code>r.nextInt(n)</code>, rather than using <code>(int)(r.nextDouble() * n)</code>.
-</p>
\ No newline at end of file
+++ /dev/null
-<p>
- Using <code>new Integer(int)</code> is guaranteed to always result in a new object whereas
- <code>Integer.valueOf(int)</code> allows caching of values to be done by the compiler, class library, or JVM.
- Using of cached values avoids object allocation and the code will be faster.
- </p>
- <p>
- Values between -128 and 127 are guaranteed to have corresponding cached instances
- and using <code>valueOf</code> is approximately 3.5 times faster than using constructor.
- For values outside the constant range the performance of both styles is the same.
- </p>
- <p>
- Unless the class must be compatible with JVMs predating Java 1.5,
- use either autoboxing or the <code>valueOf()</code> method when creating instances of
- <code>Long</code>, <code>Integer</code>, <code>Short</code>, <code>Character</code>, and <code>Byte</code>.
- </p>
\ No newline at end of file
+++ /dev/null
-<p> <em>Never call System.runFinalizersOnExit
-or Runtime.runFinalizersOnExit for any reason: they are among the most
-dangerous methods in the Java libraries.</em> -- Joshua Bloch</p>
\ No newline at end of file
+++ /dev/null
-<p> Using the <code>java.lang.String(String)</code> constructor wastes memory
- because the object so constructed will be functionally indistinguishable
- from the <code>String</code> passed as a parameter. Just use the
- argument <code>String</code> directly.</p>
\ No newline at end of file
+++ /dev/null
-<p> Calling <code>String.toString()</code> is just a redundant operation.
- Just use the String.</p>
\ No newline at end of file
+++ /dev/null
-<p> Creating a new <code>java.lang.String</code> object using the
- no-argument constructor wastes memory because the object so created will
- be functionally indistinguishable from the empty string constant
- <code>""</code>. Java guarantees that identical string constants
- will be represented by the same <code>String</code> object. Therefore,
- you should just use the empty string constant directly.</p>
\ No newline at end of file
+++ /dev/null
-<p>This method creates a thread without specifying a run method either by deriving from the Thread class, or
- by passing a Runnable object. This thread, then, does nothing but waste time.
-</p>
\ No newline at end of file
+++ /dev/null
-<p> This code creates a classloader, which requires a security manager.
- If this code will be granted security permissions, but might be invoked by code that does not
- have security permissions, then the classloader creation needs to occur inside a doPrivileged block.</p>
\ No newline at end of file
+++ /dev/null
-<p> This code invokes a method that requires a security permission check.
- If this code will be granted security permissions, but might be invoked by code that does not
- have security permissions, then the invocation needs to occur inside a doPrivileged block.</p>
\ No newline at end of file
+++ /dev/null
-<p>
-This method invokes the .equals(Object o) to compare an array and a reference that doesn't seem
-to be an array. If things being compared are of different types, they are guaranteed to be unequal
-and the comparison is almost certainly an error. Even if they are both arrays, the equals method
-on arrays only determines of the two arrays are the same object.
-To compare the
-contents of the arrays, use java.util.Arrays.equals(Object[], Object[]).
-</p>
\ No newline at end of file
+++ /dev/null
-<p>
-This method invokes the .equals(Object o) method on an array. Since arrays do not override the equals
-method of Object, calling equals on an array is the same as comparing their addresses. To compare the
-contents of the arrays, use java.util.Arrays.equals(Object[], Object[]).
-</p>
\ No newline at end of file
+++ /dev/null
-This method invokes the .equals(Object o) to compare two arrays, but the arrays of of incompatible types (e.g., String[] and StringBuffer[], or String[] and int[]). They will never be equal. In addition, when equals(...) is used to compare arrays it only checks to see if they are the same array, and ignores the contents of the arrays.
\ No newline at end of file
+++ /dev/null
-<p> This method calls equals(Object), passing a null value as
-the argument. According to the contract of the equals() method,
-this call should always return <code>false</code>.</p>
\ No newline at end of file
+++ /dev/null
-<p>
-This method calls equals(Object) on two references, one of which is a class
-and the other an interface, where neither the class nor any of its
-non-abstract subclasses implement the interface.
-Therefore, the objects being compared
-are unlikely to be members of the same class at runtime
-(unless some application classes were not analyzed, or dynamic class
-loading can occur at runtime).
-According to the contract of equals(),
-objects of different
-classes should always compare as unequal; therefore, according to the
-contract defined by java.lang.Object.equals(Object),
-the result of this comparison will always be false at runtime.
-</p>
\ No newline at end of file
+++ /dev/null
-<p> This method calls equals(Object) on two references of unrelated
-interface types, where neither is a subtype of the other,
-and there are no known non-abstract classes which implement both interfaces.
-Therefore, the objects being compared
-are unlikely to be members of the same class at runtime
-(unless some application classes were not analyzed, or dynamic class
-loading can occur at runtime).
-According to the contract of equals(),
-objects of different
-classes should always compare as unequal; therefore, according to the
-contract defined by java.lang.Object.equals(Object),
-the result of this comparison will always be false at runtime.
-</p>
\ No newline at end of file
+++ /dev/null
-<p> This method calls equals(Object) on two references of different
-class types with no common subclasses.
-Therefore, the objects being compared
-are unlikely to be members of the same class at runtime
-(unless some application classes were not analyzed, or dynamic class
-loading can occur at runtime).
-According to the contract of equals(),
-objects of different
-classes should always compare as unequal; therefore, according to the
-contract defined by java.lang.Object.equals(Object),
-the result of this comparison will always be false at runtime.
-</p>
\ No newline at end of file
+++ /dev/null
-<p> This method uses using pointer equality to compare two references that seem to be of
-different types. The result of this comparison will always be false at runtime.
-</p>
\ No newline at end of file
+++ /dev/null
-<p> Returning a reference to a mutable object value stored in one of the object's fields
- exposes the internal representation of the object.
- If instances
- are accessed by untrusted code, and unchecked changes to
- the mutable object would compromise security or other
- important properties, you will need to do something different.
- Returning a new copy of the object is better approach in many situations.</p>
\ No newline at end of file
+++ /dev/null
-<p> This code stores a reference to an externally mutable object into the
- internal representation of the object.
- If instances
- are accessed by untrusted code, and unchecked changes to
- the mutable object would compromise security or other
- important properties, you will need to do something different.
- Storing a copy of the object is better approach in many situations.</p>
\ No newline at end of file
+++ /dev/null
-<p> This code stores a reference to an externally mutable object into a static
- field.
- If unchecked changes to
- the mutable object would compromise security or other
- important properties, you will need to do something different.
- Storing a copy of the object is better approach in many situations.</p>
\ No newline at end of file
+++ /dev/null
-<p> This class defines a covariant version of <code>equals()</code>.
- To correctly override the <code>equals()</code> method in
- <code>java.lang.Object</code>, the parameter of <code>equals()</code>
- must have type <code>java.lang.Object</code>.</p>
\ No newline at end of file
+++ /dev/null
-<p> This class defines an equals method that always returns false. This means that an object is not equal to itself, and it is impossible to create useful Maps or Sets of this class. More fundamentally, it means
-that equals is not reflexive, one of the requirements of the equals method.</p>
-<p>The likely intended semantics are object identity: that an object is equal to itself. This is the behavior inherited from class <code>Object</code>. If you need to override an equals inherited from a different
-superclass, you can use use:
-<pre>
-public boolean equals(Object o) { return this == o; }
-</pre>
-</p>
\ No newline at end of file
+++ /dev/null
-<p> This class defines an equals method that always returns true. This is imaginative, but not very smart.
-Plus, it means that the equals method is not symmetric.
-</p>
\ No newline at end of file
+++ /dev/null
-<p> This equals method is checking to see if the argument is some incompatible type
-(i.e., a class that is neither a supertype nor subtype of the class that defines
-the equals method). For example, the Foo class might have an equals method
-that looks like:
-
-<p><code><pre>
-public boolean equals(Object o) {
- if (o instanceof Foo)
- return name.equals(((Foo)o).name);
- else if (o instanceof String)
- return name.equals(o);
- else return false;
-</pre></code></p>
-
-<p>This is considered bad practice, as it makes it very hard to implement an equals method that
-is symmetric and transitive. Without those properties, very unexpected behavoirs are possible.
-</p>
\ No newline at end of file
+++ /dev/null
-<p> This class defines a <code>compareTo(...)</code> method but inherits its
- <code>equals()</code> method from <code>java.lang.Object</code>.
- Generally, the value of compareTo should return zero if and only if
- equals returns true. If this is violated, weird and unpredictable
- failures will occur in classes such as PriorityQueue.
- In Java 5 the PriorityQueue.remove method uses the compareTo method,
- while in Java 6 it uses the equals method.
-
-<p>From the JavaDoc for the compareTo method in the Comparable interface:
-<blockquote>
-It is strongly recommended, but not strictly required that <code>(x.compareTo(y)==0) == (x.equals(y))</code>.
-Generally speaking, any class that implements the Comparable interface and violates this condition
-should clearly indicate this fact. The recommended language
-is "Note: this class has a natural ordering that is inconsistent with equals."
-</blockquote>
\ No newline at end of file
+++ /dev/null
-<p> This method checks to see if two objects are the same class by checking to see if the names
-of their classes are equal. You can have different classes with the same name if they are loaded by
-different class loaders. Just check to see if the class objects are the same.
-</p>
\ No newline at end of file
+++ /dev/null
-<p> This class extends a class that defines an equals method and adds fields, but doesn't
-define an equals method itself. Thus, equality on instances of this class will
-ignore the identity of the subclass and the added fields. Be sure this is what is intended,
-and that you don't need to override the equals method. Even if you don't need to override
-the equals method, consider overriding it anyway to document the fact
-that the equals method for the subclass just return the result of
-invoking super.equals(o).
- </p>
\ No newline at end of file
+++ /dev/null
-<p> This class defines an enumeration, and equality on enumerations are defined
-using object identity. Defining a covariant equals method for an enumeration
-value is exceptionally bad practice, since it would likely result
-in having two different enumeration values that compare as equals using
-the covariant enum method, and as not equal when compared normally.
-Don't do it.
-</p>
\ No newline at end of file
+++ /dev/null
-<p> This class has an equals method that will be broken if it is inherited by subclasses.
-It compares a class literal with the class of the argument (e.g., in class <code>Foo</code>
-it might check if <code>Foo.class == o.getClass()</code>).
-It is better to check if <code>this.getClass() == o.getClass()</code>.
-</p>
\ No newline at end of file
+++ /dev/null
-<p> This class defines an <code>equals()</code>
- method, that doesn't override the normal <code>equals(Object)</code> method
- defined in the base <code>java.lang.Object</code> class. Instead, it
- inherits an <code>equals(Object)</code> method from a superclass.
- The class should probably define a <code>boolean equals(Object)</code> method.
- </p>
\ No newline at end of file
+++ /dev/null
-<p> This class defines an <code>equals()</code>
- method, that doesn't override the normal <code>equals(Object)</code> method
- defined in the base <code>java.lang.Object</code> class.
- The class should probably define a <code>boolean equals(Object)</code> method.
- </p>
\ No newline at end of file
+++ /dev/null
-<p> This class defines an equals method that overrides an equals method in a superclass. Both equals methods
-methods use <code>instanceof</code> in the determination of whether two objects are equal. This is fraught with peril,
-since it is important that the equals method is symmetrical (in other words, <code>a.equals(b) == b.equals(a)</code>).
-If B is a subtype of A, and A's equals method checks that the argument is an instanceof A, and B's equals method
-checks that the argument is an instanceof B, it is quite likely that the equivalence relation defined by these
-methods is not symmetric.
-</p>
\ No newline at end of file
+++ /dev/null
-<p> This class defines a covariant version of <code>equals()</code>.
- To correctly override the <code>equals()</code> method in
- <code>java.lang.Object</code>, the parameter of <code>equals()</code>
- must have type <code>java.lang.Object</code>.</p>
\ No newline at end of file
+++ /dev/null
-<p> This class defines a covariant version of the <code>equals()</code>
- method, but inherits the normal <code>equals(Object)</code> method
- defined in the base <code>java.lang.Object</code> class.
- The class should probably define a <code>boolean equals(Object)</code> method.
- </p>
\ No newline at end of file
+++ /dev/null
-<p> This class doesn't do any of the patterns we recognize for checking that the type of the argument
-is compatible with the type of the <code>this</code> object. There might not be anything wrong with
-this code, but it is worth reviewing.
-</p>
\ No newline at end of file
+++ /dev/null
-<p>This code compares a <code>java.lang.String</code> parameter for reference
-equality using the == or != operators. Requiring callers to
-pass only String constants or interned strings to a method is unnecessarily
-fragile, and rarely leads to measurable performance gains. Consider
-using the <code>equals(Object)</code> method instead.</p>
\ No newline at end of file
+++ /dev/null
-<p>This code compares <code>java.lang.String</code> objects for reference
-equality using the == or != operators.
-Unless both strings are either constants in a source file, or have been
-interned using the <code>String.intern()</code> method, the same string
-value may be represented by two different String objects. Consider
-using the <code>equals(Object)</code> method instead.</p>
\ No newline at end of file
+++ /dev/null
-<p> The code contains an empty synchronized block:</p>
-<pre>
-synchronized() {}
-</pre>
-<p>Empty synchronized blocks are far more subtle and hard to use correctly
-than most people recognize, and empty synchronized blocks
-are almost never a better solution
-than less contrived solutions.
-</p>
\ No newline at end of file
+++ /dev/null
-<p>
- FindBugs didn't generate generated a warning that, according to a @ExpectedWarning annotated,
- is expected or desired
- </p>
\ No newline at end of file
+++ /dev/null
-<p>
- FindBugs generated a warning that, according to a @NoWarning annotated,
- is unexpected or undesired
- </p>
\ No newline at end of file
+++ /dev/null
-<p>
- This operation compares two floating point values for equality.
- Because floating point calculations may involve rounding,
- calculated float and double values may not be accurate.
- For values that must be precise, such as monetary values,
- consider using a fixed-precision type such as BigDecimal.
- For values that need not be precise, consider comparing for equality
- within some range, for example:
- <code>if ( Math.abs(x - y) < .0000001 )</code>.
- See the Java Language Specification, section 4.2.4.
- </p>
\ No newline at end of file
+++ /dev/null
-<p>
- This code checks to see if a floating point value is equal to the special
- Not A Number value (e.g., <code>if (x == Double.NaN)</code>). However,
- because of the special semantics of <code>NaN</code>, no value
- is equal to <code>Nan</code>, including <code>NaN</code>. Thus,
- <code>x == Double.NaN</code> always evaluates to false.
-
- To check to see if a value contained in <code>x</code>
- is the special Not A Number value, use
- <code>Double.isNaN(x)</code> (or <code>Float.isNaN(x)</code> if
- <code>x</code> is floating point precision).
- </p>
\ No newline at end of file
+++ /dev/null
-<p> Empty <code>finalize()</code> methods are useless, so they should
- be deleted.</p>
\ No newline at end of file
+++ /dev/null
-<p> This method contains an explicit invocation of the <code>finalize()</code>
- method on an object. Because finalizer methods are supposed to be
- executed once, and only by the VM, this is a bad idea.</p>
-<p>If a connected set of objects beings finalizable, then the VM will invoke the
-finalize method on all the finalizable object, possibly at the same time in different threads.
-Thus, it is a particularly bad idea, in the finalize method for a class X, invoke finalize
-on objects referenced by X, because they may already be getting finalized in a separate thread.
\ No newline at end of file
+++ /dev/null
-<p> This finalizer nulls out fields. This is usually an error, as it does not aid garbage collection,
- and the object is going to be garbage collected anyway.
\ No newline at end of file
+++ /dev/null
-<p> This finalizer does nothing except null out fields. This is completely pointless, and requires that
-the object be garbage collected, finalized, and then garbage collected again. You should just remove the finalize
-method.
\ No newline at end of file
+++ /dev/null
-<p> This <code>finalize()</code> method does not make a call to its
- superclass's <code>finalize()</code> method. So, any finalizer
- actions defined for the superclass will not be performed.
- Add a call to <code>super.finalize()</code>.</p>
\ No newline at end of file
+++ /dev/null
-<p> This empty <code>finalize()</code> method explicitly negates the
- effect of any finalizer defined by its superclass. Any finalizer
- actions defined for the superclass will not be performed.
- Unless this is intended, delete this method.</p>
\ No newline at end of file
+++ /dev/null
-<p> A class's <code>finalize()</code> method should have protected access,
- not public.</p>
\ No newline at end of file
+++ /dev/null
-<p> The only thing this <code>finalize()</code> method does is call
- the superclass's <code>finalize()</code> method, making it
- redundant. Delete it.</p>
\ No newline at end of file
+++ /dev/null
-<p>
- The method performs math operations using floating point precision.
- Floating point precision is very imprecise. For example,
- 16777216.0f + 1.0f = 16777216.0f. Consider using double math instead.</p>
\ No newline at end of file
+++ /dev/null
-<p> This call to a generic collection method passes an argument
- while compile type Object where a specific type from
- the generic type parameters is expected.
- Thus, neither the standard Java type system nor static analysis
- can provide useful information on whether the
- object being passed as a parameter is of an appropriate type.
- </p>
\ No newline at end of file
+++ /dev/null
-<p> This call to a generic collection method contains an argument
- with an incompatible class from that of the collection's parameter
- (i.e., the type of the argument is neither a supertype nor a subtype
- of the corresponding generic type argument).
- Therefore, it is unlikely that the collection contains any objects
- that are equal to the method argument used here.
- Most likely, the wrong value is being passed to the method.</p>
- <p>In general, instances of two unrelated classes are not equal.
- For example, if the <code>Foo</code> and <code>Bar</code> classes
- are not related by subtyping, then an instance of <code>Foo</code>
- should not be equal to an instance of <code>Bar</code>.
- Among other issues, doing so will likely result in an equals method
- that is not symmetrical. For example, if you define the <code>Foo</code> class
- so that a <code>Foo</code> can be equal to a <code>String</code>,
- your equals method isn't symmetrical since a <code>String</code> can only be equal
- to a <code>String</code>.
- </p>
- <p>In rare cases, people do define nonsymmetrical equals methods and still manage to make
- their code work. Although none of the APIs document or guarantee it, it is typically
- the case that if you check if a <code>Collection<String></code> contains
- a <code>Foo</code>, the equals method of argument (e.g., the equals method of the
- <code>Foo</code> class) used to perform the equality checks.
- </p>
\ No newline at end of file
+++ /dev/null
-<p> This class overrides <code>equals(Object)</code>, but does not
- override <code>hashCode()</code>. Therefore, the class may violate the
- invariant that equal objects must have equal hashcodes.</p>
\ No newline at end of file
+++ /dev/null
-<p> This class overrides <code>equals(Object)</code>, but does not
- override <code>hashCode()</code>, and inherits the implementation of
- <code>hashCode()</code> from <code>java.lang.Object</code> (which returns
- the identity hash code, an arbitrary value assigned to the object
- by the VM). Therefore, the class is very likely to violate the
- invariant that equal objects must have equal hashcodes.</p>
-
-<p>If you don't think instances of this class will ever be inserted into a HashMap/HashTable,
-the recommended <code>hashCode</code> implementation to use is:</p>
-<pre>public int hashCode() {
- assert false : "hashCode not designed";
- return 42; // any arbitrary constant will do
- }</pre>
\ No newline at end of file
+++ /dev/null
-<p> This class defines a <code>hashCode()</code> method but not an
- <code>equals()</code> method. Therefore, the class may
- violate the invariant that equal objects must have equal hashcodes.</p>
\ No newline at end of file
+++ /dev/null
-<p> This class defines a <code>hashCode()</code> method but inherits its
- <code>equals()</code> method from <code>java.lang.Object</code>
- (which defines equality by comparing object references). Although
- this will probably satisfy the contract that equal objects must have
- equal hashcodes, it is probably not what was intended by overriding
- the <code>hashCode()</code> method. (Overriding <code>hashCode()</code>
- implies that the object's identity is based on criteria more complicated
- than simple reference equality.)</p>
-<p>If you don't think instances of this class will ever be inserted into a HashMap/HashTable,
-the recommended <code>hashCode</code> implementation to use is:</p>
-<p><pre>public int hashCode() {
- assert false : "hashCode not designed";
- return 42; // any arbitrary constant will do
- }</pre></p>
\ No newline at end of file
+++ /dev/null
-<p> This class inherits <code>equals(Object)</code> from an abstract
- superclass, and <code>hashCode()</code> from
-<code>java.lang.Object</code> (which returns
- the identity hash code, an arbitrary value assigned to the object
- by the VM). Therefore, the class is very likely to violate the
- invariant that equal objects must have equal hashcodes.</p>
-
- <p>If you don't want to define a hashCode method, and/or don't
- believe the object will ever be put into a HashMap/Hashtable,
- define the <code>hashCode()</code> method
- to throw <code>UnsupportedOperationException</code>.</p>
\ No newline at end of file
+++ /dev/null
-<p> A method, field or class declares a generic signature where a non-hashable class
-is used in context where a hashable class is required.
-A class that declares an equals method but inherits a hashCode() method
-from Object is unhashable, since it doesn't fulfill the requirement that
-equal objects have equal hashCodes.
-</p>
\ No newline at end of file
+++ /dev/null
-<p> A class defines an equals(Object) method but not a hashCode() method,
-and thus doesn't fulfill the requirement that equal objects have equal hashCodes.
-An instance of this class is used in a hash data structure, making the need to
-fix this problem of highest importance.
\ No newline at end of file
+++ /dev/null
-<p>This code constructs an HTTP Cookie using an untrusted HTTP parameter. If this cookie is added to an HTTP response, it will allow a HTTP response splitting
-vulnerability. See <a href="http://en.wikipedia.org/wiki/HTTP_response_splitting">http://en.wikipedia.org/wiki/HTTP_response_splitting</a>
-for more information.</p>
-<p>FindBugs looks only for the most blatant, obvious cases of HTTP response splitting.
-If FindBugs found <em>any</em>, you <em>almost certainly</em> have more
-vulnerabilities that FindBugs doesn't report. If you are concerned about HTTP response splitting, you should seriously
-consider using a commercial static analysis or pen-testing tool.
-</p>
\ No newline at end of file
+++ /dev/null
-<p>This code directly writes an HTTP parameter to an HTTP header, which allows for a HTTP response splitting
-vulnerability. See <a href="http://en.wikipedia.org/wiki/HTTP_response_splitting">http://en.wikipedia.org/wiki/HTTP_response_splitting</a>
-for more information.</p>
-<p>FindBugs looks only for the most blatant, obvious cases of HTTP response splitting.
-If FindBugs found <em>any</em>, you <em>almost certainly</em> have more
-vulnerabilities that FindBugs doesn't report. If you are concerned about HTTP response splitting, you should seriously
-consider using a commercial static analysis or pen-testing tool.
-</p>
\ No newline at end of file
+++ /dev/null
-<p>
- A large String constant is duplicated across multiple class files.
- This is likely because a final field is initialized to a String constant, and the Java language
- mandates that all references to a final field from other classes be inlined into
-that classfile. See <a href="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6447475">JDK bug 6447475</a>
- for a description of an occurrence of this bug in the JDK and how resolving it reduced
- the size of the JDK by 1 megabyte.
-</p>
\ No newline at end of file
+++ /dev/null
-<p> An inner class is invoking a method that could be resolved to either a inherited method or a method defined in an outer class. By the Java semantics,
-it will be resolved to invoke the inherited method, but this may not be want
-you intend. If you really intend to invoke the inherited method,
-invoke it by invoking the method on super (e.g., invoke super.foo(17)), and
-thus it will be clear to other readers of your code and to FindBugs
-that you want to invoke the inherited method, not the method in the outer class.
-</p>
\ No newline at end of file
+++ /dev/null
-<p>
-The code performs an integer shift by a constant amount outside
-the range 0..31.
-The effect of this is to use the lower 5 bits of the integer
-value to decide how much to shift by. This probably isn't want was expected,
-and it at least confusing.
-</p>
\ No newline at end of file
+++ /dev/null
-<p>
-This code casts the result of an integer division operation to double or
-float.
-Doing division on integers truncates the result
-to the integer value closest to zero. The fact that the result
-was cast to double suggests that this precision should have been retained.
-What was probably meant was to cast one or both of the operands to
-double <em>before</em> performing the division. Here is an example:
-</p>
-<blockquote>
-<pre>
-int x = 2;
-int y = 5;
-// Wrong: yields result 0.0
-double value1 = x / y;
-
-// Right: yields result 0.4
-double value2 = x / (double) y;
-</pre>
-</blockquote>
\ No newline at end of file
+++ /dev/null
-<p>
-This code performs integer multiply and then converts the result to a long,
-as in:
-<code>
-<pre>
- long convertDaysToMilliseconds(int days) { return 1000*3600*24*days; }
-</pre></code>
-If the multiplication is done using long arithmetic, you can avoid
-the possibility that the result will overflow. For example, you
-could fix the above code to:
-<code>
-<pre>
- long convertDaysToMilliseconds(int days) { return 1000L*3600*24*days; }
-</pre></code>
-or
-<code>
-<pre>
- static final long MILLISECONDS_PER_DAY = 24L*3600*1000;
- long convertDaysToMilliseconds(int days) { return days * MILLISECONDS_PER_DAY; }
-</pre></code>
-</p>
\ No newline at end of file
+++ /dev/null
-<p>This code converts a 32-bit int value to a 64-bit long value, and then passes that value for a
-method parameter that requires an absolute time value. An absolute time value is the number of
-milliseconds since the standard base time known as "the epoch", namely January 1, 1970, 00:00:00 GMT.
-For example, the following method, intended to convert seconds since the epoc into a Date, is badly broken:
-<pre>
-Date getDate(int seconds) { return new Date(seconds * 1000); }
-</pre>
-</p>
-<p>The multiplication is done using 32-bit arithmetic, and then converted to a 64-bit value. When a 32-bit
-value is converted to 64-bits and used to express an absolute time value, only dates in December 1969 and
-January 1970 can be represented.</p>
-<p>Correct implementations for the above method are:
-<pre>
-// Fails for dates after 2037
-Date getDate(int seconds) { return new Date(seconds * 1000L); }
-
-// better, works for all dates
-Date getDate(long seconds) { return new Date(seconds * 1000); }
-</pre>
-</p>
\ No newline at end of file
+++ /dev/null
-<p>
-This code converts an int value to a double precision
-floating point number and then
-passing the result to the Math.ceil() function, which rounds a double to
-the next higher integer value. This operation should always be a no-op,
-since the converting an integer to a double should give a number with no fractional part.
-It is likely that the operation that generated the value to be passed
-to Math.ceil was intended to be performed using double precision
-floating point arithmetic.
-</p>
\ No newline at end of file
+++ /dev/null
-<p>
-This code converts an int value to a float precision
-floating point number and then
-passing the result to the Math.round() function, which returns the int/long closest
-to the argument. This operation should always be a no-op,
-since the converting an integer to a float should give a number with no fractional part.
-It is likely that the operation that generated the value to be passed
-to Math.round was intended to be performed using
-floating point arithmetic.
-</p>
\ No newline at end of file
+++ /dev/null
-<p>
-The code performs an unsigned right shift, whose result is then
-cast to a short or byte, which discards the upper bits of the result.
-Since the upper bits are discarded, there may be no difference between
-a signed and unsigned right shift (depending upon the size of the shift).
-</p>
\ No newline at end of file
+++ /dev/null
-<p> A circularity was detected in the static initializers of the two
- classes referenced by the bug instance. Many kinds of unexpected
- behavior may arise from such circularity.</p>
\ No newline at end of file
+++ /dev/null
-<p> During the initialization of a class, the class makes an active use of a subclass.
-That subclass will not yet be initialized at the time of this use.
-For example, in the following code, <code>foo</code> will be null.</p>
-
-<pre>
-public class CircularClassInitialization {
- static class InnerClassSingleton extends CircularClassInitialization {
- static InnerClassSingleton singleton = new InnerClassSingleton();
- }
-
- static CircularClassInitialization foo = InnerClassSingleton.singleton;
-}
-</pre>
\ No newline at end of file
+++ /dev/null
-<p> A JUnit assertion is performed in a run method. Failed JUnit assertions
-just result in exceptions being thrown.
-Thus, if this exception occurs in a thread other than the thread that invokes
-the test method, the exception will terminate the thread but not result
-in the test failing.
-</p>
\ No newline at end of file
+++ /dev/null
-<p> Class is a JUnit TestCase and defines a suite() method.
-However, the suite method needs to be declared as either
-<pre>public static junit.framework.Test suite()</pre>
-or
-<pre>public static junit.framework.TestSuite suite()</pre>
-</p>
\ No newline at end of file
+++ /dev/null
-<p> Class is a JUnit TestCase but has not implemented any test methods</p>
\ No newline at end of file
+++ /dev/null
-<p> Class is a JUnit TestCase and implements the setUp method. The setUp method should call
-super.setUp(), but doesn't.</p>
\ No newline at end of file
+++ /dev/null
-<p> Class is a JUnit TestCase and implements the suite() method.
- The suite method should be declared as being static, but isn't.</p>
\ No newline at end of file
+++ /dev/null
-<p> Class is a JUnit TestCase and implements the tearDown method. The tearDown method should call
-super.tearDown(), but doesn't.</p>
\ No newline at end of file
+++ /dev/null
-<p>A collection is added to itself. As a result, computing the hashCode of this
-set will throw a StackOverflowException.
-</p>
\ No newline at end of file
+++ /dev/null
-<p>This loop doesn't seem to have a way to terminate (other than by perhaps
-throwing an exception).</p>
\ No newline at end of file
+++ /dev/null
-<p>This method unconditionally invokes itself. This would seem to indicate
-an infinite recursive loop that will result in a stack overflow.</p>
\ No newline at end of file
+++ /dev/null
-<p>
- This method of an inner class reads from or writes to a private member variable of the owning class,
- or calls a private method of the owning class. The compiler must generate a special method to access this
- private member, causing this to be less efficient. Relaxing the protection of the member variable or method
- will allow the compiler to treat this as a normal access.
- </p>
\ No newline at end of file
+++ /dev/null
-<p>IllegalMonitorStateException is generally only
- thrown in case of a design flaw in your code (calling wait or
- notify on an object you do not hold a lock on).</p>
\ No newline at end of file
+++ /dev/null
-<p>The code computes the average of two integers using either division or signed right shift,
-and then uses the result as the index of an array.
-If the values being averaged are very large, this can overflow (resulting in the computation
-of a negative average). Assuming that the result is intended to be nonnegative, you
-can use an unsigned right shift instead. In other words, rather that using <code>(low+high)/2</code>,
-use <code>(low+high) >>> 1</code>
-</p>
-<p>This bug exists in many earlier implementations of binary search and merge sort.
-Martin Buchholz <a href="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6412541">found and fixed it</a>
-in the JDK libraries, and Joshua Bloch
-<a href="http://googleresearch.blogspot.com/2006/06/extra-extra-read-all-about-it-nearly.html">widely
-publicized the bug pattern</a>.
-</p>
\ No newline at end of file
+++ /dev/null
-<p>
-The code uses x % 2 == 1 to check to see if a value is odd, but this won't work
-for negative numbers (e.g., (-5) % 2 == -1). If this code is intending to check
-for oddness, consider using x & 1 == 1, or x % 2 != 0.
-</p>
\ No newline at end of file
+++ /dev/null
-<p>
-The code multiplies the result of an integer remaining by an integer constant.
-Be sure you don't have your operator precedence confused. For example
-i % 60 * 1000 is (i % 60) * 1000, not i % (60 * 1000).
-</p>
\ No newline at end of file
+++ /dev/null
-<p>This code compares an int value with a long constant that is outside the range of values that can
- be represented as an int value. This comparison is vacuous and possibily to be incorrect.</p>
\ No newline at end of file
+++ /dev/null
-<p> This code compares a value that is guaranteed to be non-negative with a negative constant.
-</p>
\ No newline at end of file
+++ /dev/null
-<p> Signed bytes can only have a value in the range -128 to 127. Comparing
-a signed byte with a value outside that range is vacuous and likely to be incorrect.
-To convert a signed byte <code>b</code> to an unsigned value in the range 0..255,
-use <code>0xff & b</code>
-</p>
\ No newline at end of file
+++ /dev/null
-<p> Any expression (exp % 1) is guaranteed to always return zero.
-Did you mean (exp & 1) or (exp % 2) instead?
-</p>
\ No newline at end of file
+++ /dev/null
-<p> This is an integer bit operation (and, or, or exclusive or) that doesn't do any useful work
-(e.g., <code>v & 0xffffffff</code>).
-
-</p>
\ No newline at end of file
+++ /dev/null
-<p> There is an integer comparison that always returns
-the same value (e.g., x <= Integer.MAX_VALUE).
-</p>
\ No newline at end of file
+++ /dev/null
-<p>
- This code opens a file in append mode and then wraps the result in an object output stream.
- This won't allow you to append to an existing object output stream stored in a file. If you want to be
- able to append to an object output stream, you need to keep the object output stream open.
- </p>
- <p>The only situation in which opening a file in append mode and the writing an object output stream
- could work is if on reading the file you plan to open it in random access mode and seek to the byte offset
- where the append started.
- </p>
-
- <p>
- TODO: example.
- </p>
\ No newline at end of file
+++ /dev/null
-<p>
-The initial value of this parameter is ignored, and the parameter
-is overwritten here. This often indicates a mistaken belief that
-the write to the parameter will be conveyed back to
-the caller.
-</p>
\ No newline at end of file
+++ /dev/null
-<p> The fields of this class appear to be accessed inconsistently with respect
- to synchronization. This bug report indicates that the bug pattern detector
- judged that
- </p>
- <ol>
- <li> The class contains a mix of locked and unlocked accesses,</li>
- <li> At least one locked access was performed by one of the class's own methods, and</li>
- <li> The number of unsynchronized field accesses (reads and writes) was no more than
- one third of all accesses, with writes being weighed twice as high as reads</li>
- </ol>
-
- <p> A typical bug matching this bug pattern is forgetting to synchronize
- one of the methods in a class that is intended to be thread-safe.</p>
-
- <p> You can select the nodes labeled "Unsynchronized access" to show the
- code locations where the detector believed that a field was accessed
- without synchronization.</p>
-
- <p> Note that there are various sources of inaccuracy in this detector;
- for example, the detector cannot statically detect all situations in which
- a lock is held. Also, even when the detector is accurate in
- distinguishing locked vs. unlocked accesses, the code in question may still
- be correct.</p>
\ No newline at end of file
+++ /dev/null
-<p> This class allocates an object that is based on a class that only supplies static methods. This object
-does not need to be created, just access the static methods directly using the class name as a qualifier.</p>
\ No newline at end of file
+++ /dev/null
-<p> This field is annotated with net.jcip.annotations.GuardedBy,
-but can be accessed in a way that seems to violate the annotation.</p>
\ No newline at end of file
+++ /dev/null
-<p> The fields of this class appear to be accessed inconsistently with respect
- to synchronization. This bug report indicates that the bug pattern detector
- judged that
- </p>
- <ol>
- <li> The class contains a mix of locked and unlocked accesses,</li>
- <li> At least one locked access was performed by one of the class's own methods, and</li>
- <li> The number of unsynchronized field accesses (reads and writes) was no more than
- one third of all accesses, with writes being weighed twice as high as reads</li>
- </ol>
-
- <p> A typical bug matching this bug pattern is forgetting to synchronize
- one of the methods in a class that is intended to be thread-safe.</p>
-
- <p> Note that there are various sources of inaccuracy in this detector;
- for example, the detector cannot statically detect all situations in which
- a lock is held. Also, even when the detector is accurate in
- distinguishing locked vs. unlocked accesses, the code in question may still
- be correct.</p>
\ No newline at end of file
+++ /dev/null
-<p> This method uses the toArray() method of a collection derived class, and passes
-in a zero-length prototype array argument. It is more efficient to use
-<code>myCollection.toArray(new Foo[myCollection.size()])</code>
-If the array passed in is big enough to store all of the
-elements of the collection, then it is populated and returned
-directly. This avoids the need to create a second array
-(by reflection) to return as the result.</p>
\ No newline at end of file
+++ /dev/null
-<p> This class implements the <code>java.util.Iterator</code> interface.
- However, its <code>next()</code> method is not capable of throwing
- <code>java.util.NoSuchElementException</code>. The <code>next()</code>
- method should be changed so it throws <code>NoSuchElementException</code>
- if is called when there are no more elements to return.</p>
\ No newline at end of file
+++ /dev/null
-<p>
-This code seems to be storing a non-serializable object into an HttpSession.
-If this session is passivated or migrated, an error will result.
-</p>
\ No newline at end of file
+++ /dev/null
-<p> The class is annotated with net.jcip.annotations.Immutable, and the rules for that annotation require
-that all fields are final.
- .</p>
\ No newline at end of file
+++ /dev/null
-<p> This method performs synchronization on an implementation of
-<code>java.util.concurrent.locks.Lock</code>. You should use
-the <code>lock()</code> and <code>unlock()</code> methods instead.
-</p>
\ No newline at end of file
+++ /dev/null
-<p>This method calls <code>wait()</code>, <code>notify()</code> or <code>notifyAll()</code> on an object that also
-provides an <code>await()</code>, <code>signal()</code>, <code>signalAll()</code> method (such as util.concurrent
-Condition objects). This probably isn't what you want, and even if you do want it, you should consider changing your
-design, as other developers will find it exceptionally confusing.</p>
\ No newline at end of file
+++ /dev/null
-<p>
- OpenJDK introduces a potential incompatibility.
- In particular, the java.util.logging.Logger behavior has
- changed. Instead of using strong references, it now uses weak references
- internally. That's a reasonable change, but unfortunately some code relies on
- the old behavior - when changing logger configuration, it simply drops the
- logger reference. That means that the garbage collector is free to reclaim
- that memory, which means that the logger configuration is lost. For example,
- consider:
- </p>
- <p><pre>public static void initLogging() throws Exception {
- Logger logger = Logger.getLogger("edu.umd.cs");
- logger.addHandler(new FileHandler()); // call to change logger configuration
- logger.setUseParentHandlers(false); // another call to change logger configuration
- }</pre></p>
- <p>The logger reference is lost at the end of the method (it doesn't
- escape the method), so if you have a garbage collection cycle just
- after the call to initLogging, the logger configuration is lost
- (because Logger only keeps weak references).</p>
- <p><pre>public static void main(String[] args) throws Exception {
- initLogging(); // adds a file handler to the logger
- System.gc(); // logger configuration lost
- Logger.getLogger("edu.umd.cs").info("Some message"); // this isn't logged to the file as expected
- }</pre></p>
- <p><em>Ulf Ochsenfahrt and Eric Fellheimer</em>
- </p>
\ No newline at end of file
+++ /dev/null
-<p> This method contains an unsynchronized lazy initialization of a non-volatile static field.
-Because the compiler or processor may reorder instructions,
-threads are not guaranteed to see a completely initialized object,
-<em>if the method can be called by multiple threads</em>.
-You can make the field volatile to correct the problem.
-For more information, see the
-<a href="http://www.cs.umd.edu/~pugh/java/memoryModel/">Java Memory Model web site</a>.
-</p>
\ No newline at end of file
+++ /dev/null
-<p> This method contains an unsynchronized lazy initialization of a static field.
-After the field is set, the object stored into that location is further accessed.
-The setting of the field is visible to other threads as soon as it is set. If the
-futher accesses in the method that set the field serve to initialize the object, then
-you have a <em>very serious</em> multithreading bug, unless something else prevents
-any other thread from accessing the stored object until it is fully initialized.
-</p>
\ No newline at end of file
+++ /dev/null
-<p> This class defines a field with the same name as a visible
-instance field in a superclass. This is confusing, and
-may indicate an error if methods update or access one of
-the fields when they wanted the other.</p>
\ No newline at end of file
+++ /dev/null
-<p> This method defines a local variable with the same name as a field
-in this class or a superclass. This may cause the method to
-read an uninitialized value from the field, leave the field uninitialized,
-or both.</p>
\ No newline at end of file
+++ /dev/null
-<p> This method synchronizes on a field in what appears to be an attempt
-to guard against simultaneous updates to that field. But guarding a field
-gets a lock on the referenced object, not on the field. This may not
-provide the mutual exclusion you need, and other threads might
-be obtaining locks on the referenced objects (for other purposes). An example
-of this pattern would be:
-
-<p><pre>
-private Long myNtfSeqNbrCounter = new Long(0);
-private Long getNotificationSequenceNumber() {
- Long result = null;
- synchronized(myNtfSeqNbrCounter) {
- result = new Long(myNtfSeqNbrCounter.longValue() + 1);
- myNtfSeqNbrCounter = new Long(result.longValue());
- }
- return result;
- }
-</pre>
-
-
-</p>
\ No newline at end of file
+++ /dev/null
-<p> This method synchronizes on an object
- referenced from a mutable field.
- This is unlikely to have useful semantics, since different
-threads may be synchronizing on different objects.</p>
\ No newline at end of file
+++ /dev/null
-<p>A web server generally only creates one instance of servlet or jsp class (i.e., treats
-the class as a Singleton),
-and will
-have multiple threads invoke methods on that instance to service multiple
-simultaneous requests.
-Thus, having a mutable instance field generally creates race conditions.
\ No newline at end of file
+++ /dev/null
-<p>
- A mutable static field could be changed by malicious code or
- by accident from another package.
- Unfortunately, the way the field is used doesn't allow
- any easy fix to this problem.</p>
\ No newline at end of file
+++ /dev/null
-<p> A public static method returns a reference to
- an array that is part of the static state of the class.
- Any code that calls this method can freely modify
- the underlying array.
- One fix is to return a copy of the array.</p>
\ No newline at end of file
+++ /dev/null
-<p>
- A mutable static field could be changed by malicious code or
- by accident from another package.
- The field could be made package protected and/or made final
- to avoid
- this vulnerability.</p>
\ No newline at end of file
+++ /dev/null
-<p> A final static field references an array
- and can be accessed by malicious code or
- by accident from another package.
- This code can freely modify the contents of the array.</p>
\ No newline at end of file
+++ /dev/null
-<p>A final static field references a Hashtable
- and can be accessed by malicious code or
- by accident from another package.
- This code can freely modify the contents of the Hashtable.</p>
\ No newline at end of file
+++ /dev/null
-<p>
- A final static field that is
-defined in an interface references a mutable
- object such as an array or hashtable.
- This mutable object could
- be changed by malicious code or
- by accident from another package.
- To solve this, the field needs to be moved to a class
- and made package protected
- to avoid
- this vulnerability.</p>
\ No newline at end of file
+++ /dev/null
-<p> A mutable static field could be changed by malicious code or
- by accident.
- The field could be made package protected to avoid
- this vulnerability.</p>
\ No newline at end of file
+++ /dev/null
-<p>
- A mutable static field could be changed by malicious code or
- by accident from another package.
- The field could be made final to avoid
- this vulnerability.</p>
\ No newline at end of file
+++ /dev/null
-<p>
-This static field public but not final, and
-could be changed by malicious code or
-by accident from another package.
-The field could be made final to avoid
-this vulnerability. However, the static initializer contains more than one write
-to the field, so doing so will require some refactoring.
-</p>
+++ /dev/null
-<p>
- This class extends from a Servlet class, and uses an instance member variable. Since only
- one instance of a Servlet class is created by the J2EE framework, and used in a
- multithreaded way, this paradigm is highly discouraged and most likely problematic. Consider
- only using method local variables.
- </p>
\ No newline at end of file
+++ /dev/null
-<p>
- This class extends from a Struts Action class, and uses an instance member variable. Since only
- one instance of a struts Action class is created by the Struts framework, and used in a
- multithreaded way, this paradigm is highly discouraged and most likely problematic. Consider
- only using method local variables. Only instance fields that are written outside of a monitor
- are reported.
- </p>
\ No newline at end of file
+++ /dev/null
-<p> This method calls Object.notify() or Object.notifyAll() without obviously holding a lock
-on the object. Calling notify() or notifyAll() without a lock held will result in
-an <code>IllegalMonitorStateException</code> being thrown.</p>
\ No newline at end of file
+++ /dev/null
-<p> This method calls Object.wait() without obviously holding a lock
-on the object. Calling wait() without a lock held will result in
-an <code>IllegalMonitorStateException</code> being thrown.</p>
\ No newline at end of file
+++ /dev/null
-<p>
- This class defines a method <code>equal(Object)</code>.
- This method does not override the <code>equals(Object)</code> method
- in <code>java.lang.Object</code>, which is probably what was intended.
- </p>
\ No newline at end of file
+++ /dev/null
-<p>
- Class names should be nouns, in mixed case with the first letter of each internal word capitalized.
- Try to keep your class names simple and descriptive. Use whole words-avoid acronyms and abbreviations
- (unless the abbreviation is much more widely used than the long form, such as URL or HTML).
- </p>
\ No newline at end of file
+++ /dev/null
-<p> This class is not derived from another exception, but ends with 'Exception'. This will
-be confusing to users of this class.</p>
\ No newline at end of file
+++ /dev/null
-<p> The referenced methods have names that differ only by capitalization.</p>
\ No newline at end of file
+++ /dev/null
-<p>
- Names of fields that are not final should be in mixed case
- with a lowercase first letter and the first letters of subsequent words capitalized.
- </p>
\ No newline at end of file
+++ /dev/null
-<p>The identifier is a word that is reserved as a keyword in later versions of Java, and your code will need to be changed
-in order to compile it in later versions of Java.</p>
\ No newline at end of file
+++ /dev/null
-<p>This identifier is used as a keyword in later versions of Java. This code, and
-any code that references this API,
-will need to be changed in order to compile it in later versions of Java.</p>
\ No newline at end of file
+++ /dev/null
-<p>
- This class defines a method called <code>hashcode()</code>.
- This method does not override the <code>hashCode()</code>
- method in <code>java.lang.Object</code>, which is probably what was intended.
- </p>
\ No newline at end of file
+++ /dev/null
-<p>
- This class defines a method called <code>tostring()</code>.
- This method does not override the <code>toString()</code>
- method in <code>java.lang.Object</code>, which is probably what was intended.
- </p>
\ No newline at end of file
+++ /dev/null
-<p> This regular method has the same name as the class it is defined in. It is likely that this was intended to be a constructor.
- If it was intended to be a constructor, remove the declaration of a void return value.
- If you had accidently defined this method, realized the mistake, defined a proper constructor
- but can't get rid of this method due to backwards compatibility, deprecate the method.
-</p>
\ No newline at end of file
+++ /dev/null
-<p>
- Methods should be verbs, in mixed case with the first letter lowercase,
- with the first letter of each internal word capitalized.
- </p>
\ No newline at end of file
+++ /dev/null
-<p> This class/interface has a simple name that is identical to that of an implemented/extended interface, except
-that the interface is in a different package (e.g., <code>alpha.Foo</code> extends <code>beta.Foo</code>).
-This can be exceptionally confusing, create lots of situations in which you have to look at import statements
-to resolve references and creates many
-opportunities to accidently define methods that do not override methods in their superclasses.
-</p>
\ No newline at end of file
+++ /dev/null
-<p> This class has a simple name that is identical to that of its superclass, except
-that its superclass is in a different package (e.g., <code>alpha.Foo</code> extends <code>beta.Foo</code>).
-This can be exceptionally confusing, create lots of situations in which you have to look at import statements
-to resolve references and creates many
-opportunities to accidently define methods that do not override methods in their superclasses.
-</p>
\ No newline at end of file
+++ /dev/null
-<p> The referenced methods have names that differ only by capitalization.
-This is very confusing because if the capitalization were
-identical then one of the methods would override the other.
-</p>
\ No newline at end of file
+++ /dev/null
-<p> The referenced methods have names that differ only by capitalization.
-This is very confusing because if the capitalization were
-identical then one of the methods would override the other. From the existence of other methods, it
-seems that the existence of both of these methods is intentional, but is sure is confusing.
-You should try hard to eliminate one of them, unless you are forced to have both due to frozen APIs.
-</p>
\ No newline at end of file
+++ /dev/null
-<p> The method in the subclass doesn't override a similar method in a superclass because the type of a parameter doesn't exactly match
-the type of the corresponding parameter in the superclass. For example, if you have:</p>
-
-<blockquote>
-<pre>
-import alpha.Foo;
-public class A {
- public int f(Foo x) { return 17; }
-}
-----
-import beta.Foo;
-public class B extends A {
- public int f(Foo x) { return 42; }
-}
-</pre>
-</blockquote>
-
-<p>The <code>f(Foo)</code> method defined in class <code>B</code> doesn't
-override the
-<code>f(Foo)</code> method defined in class <code>A</code>, because the argument
-types are <code>Foo</code>'s from different packages.
-</p>
\ No newline at end of file
+++ /dev/null
-<p> The method in the subclass doesn't override a similar method in a superclass because the type of a parameter doesn't exactly match
-the type of the corresponding parameter in the superclass. For example, if you have:</p>
-
-<blockquote>
-<pre>
-import alpha.Foo;
-public class A {
- public int f(Foo x) { return 17; }
-}
-----
-import beta.Foo;
-public class B extends A {
- public int f(Foo x) { return 42; }
- public int f(alpha.Foo x) { return 27; }
-}
-</pre>
-</blockquote>
-
-<p>The <code>f(Foo)</code> method defined in class <code>B</code> doesn't
-override the
-<code>f(Foo)</code> method defined in class <code>A</code>, because the argument
-types are <code>Foo</code>'s from different packages.
-</p>
-
-<p>In this case, the subclass does define a method with a signature identical to the method in the superclass,
-so this is presumably understood. However, such methods are exceptionally confusing. You should strongly consider
-removing or deprecating the method with the similar but not identical signature.
-</p>
\ No newline at end of file
+++ /dev/null
-<p> A call to <code>notify()</code> or <code>notifyAll()</code>
- was made without any (apparent) accompanying
- modification to mutable object state. In general, calling a notify
- method on a monitor is done because some condition another thread is
- waiting for has become true. However, for the condition to be meaningful,
- it must involve a heap object that is visible to both threads.</p>
-
- <p> This bug does not necessarily indicate an error, since the change to
- mutable object state may have taken place in a method which then called
- the method containing the notification.</p>
\ No newline at end of file
+++ /dev/null
-<p> This method calls <code>notify()</code> rather than <code>notifyAll()</code>.
- Java monitors are often used for multiple conditions. Calling <code>notify()</code>
- only wakes up one thread, meaning that the thread woken up might not be the
- one waiting for the condition that the caller just satisfied.</p>
\ No newline at end of file
+++ /dev/null
-<p> A null pointer is dereferenced here. This will lead to a
-<code>NullPointerException</code> when the code is executed.</p>
\ No newline at end of file
+++ /dev/null
-<p> A pointer which is null on an exception path is dereferenced here.
-This will lead to a <code>NullPointerException</code> when the code is executed.
-Note that because FindBugs currently does not prune infeasible exception paths,
-this may be a false warning.</p>
-
-<p> Also note that FindBugs considers the default case of a switch statement to
-be an exception path, since the default case is often infeasible.</p>
\ No newline at end of file
+++ /dev/null
-<p>
- A parameter to this method has been identified as a value that should
- always be checked to see whether or not it is null, but it is being dereferenced
- without a preceding null check.
- </p>
\ No newline at end of file
+++ /dev/null
-<p>
- A method that returns either Boolean.TRUE, Boolean.FALSE or null is an accident waiting to happen.
- This method can be invoked as though it returned a value of type boolean, and
- the compiler will insert automatic unboxing of the Boolean value. If a null value is returned,
- this will result in a NullPointerException.
- </p>
\ No newline at end of file
+++ /dev/null
-<p>
- This clone method seems to return null in some circumstances, but clone is never
- allowed to return a null value. If you are convinced this path is unreachable, throw an AssertionError
- instead.
- </p>
\ No newline at end of file
+++ /dev/null
-close() is being invoked on a value that is always null. If this statement is executed, a null pointer exception will occur. But the big risk here you never close something that should be closed.
\ No newline at end of file
+++ /dev/null
-<p> The result of invoking readLine() is dereferenced without checking to see if the result is null. If there are no more lines of text
-to read, readLine() will return null and dereferencing that will generate a null pointer exception.
-</p>
\ No newline at end of file
+++ /dev/null
-<p>
- This implementation of equals(Object) violates the contract defined
- by java.lang.Object.equals() because it does not check for null
- being passed as the argument. All equals() methods should return
- false if passed a null value.
- </p>
\ No newline at end of file
+++ /dev/null
-<p>
- There is a statement or branch that if executed guarantees that
- a value is null at this point, and that
- value that is guaranteed to be dereferenced
- (except on forward paths involving runtime exceptions).
- </p>
\ No newline at end of file
+++ /dev/null
-<p>
- There is a statement or branch on an exception path
- that if executed guarantees that
- a value is null at this point, and that
- value that is guaranteed to be dereferenced
- (except on forward paths involving runtime exceptions).
- </p>
\ No newline at end of file
+++ /dev/null
-<p> The result of invoking readLine() is immediately dereferenced. If there are no more lines of text
-to read, readLine() will return null and dereferencing that will generate a null pointer exception.
-</p>
\ No newline at end of file
+++ /dev/null
-<p> The variable referenced at this point is known to be null due to an earlier
- check against null. Although this is valid, it might be a mistake (perhaps you
-intended to refer to a different variable, or perhaps the earlier check to see if the
-variable is null should have been a check to see if it was nonnull).
-</p>
\ No newline at end of file
+++ /dev/null
-<p>
-The field is marked as nonnull, but isn't written to by the constructor.
-The field might be initialized elsewhere during constructor, or might always
-be initialized before use.
-</p>
+++ /dev/null
-<p>
- This method passes a null value as the parameter of a method which
- must be nonnull. Either this parameter has been explicitly marked
- as @Nonnull, or analysis has determined that this parameter is
- always dereferenced.
- </p>
\ No newline at end of file
+++ /dev/null
-<p>
- This method may return a null value, but the method (or a superclass method
- which it overrides) is declared to return @NonNull.
- </p>
\ No newline at end of file
+++ /dev/null
-<p>
-This instanceof test will always return false, since the value being checked is guaranteed to be null.
-Although this is safe, make sure it isn't
-an indication of some misunderstanding or some other logic error.
-</p>
\ No newline at end of file
+++ /dev/null
-<p> There is a branch of statement that, <em>if executed,</em> guarantees that
-a null value will be dereferenced, which
-would generate a <code>NullPointerException</code> when the code is executed.
-Of course, the problem might be that the branch or statement is infeasible and that
-the null pointer exception can't ever be executed; deciding that is beyond the ability of FindBugs.
-</p>
\ No newline at end of file
+++ /dev/null
-<p> A reference value which is null on some exception control path is
-dereferenced here. This may lead to a <code>NullPointerException</code>
-when the code is executed.
-Note that because FindBugs currently does not prune infeasible exception paths,
-this may be a false warning.</p>
-
-<p> Also note that FindBugs considers the default case of a switch statement to
-be an exception path, since the default case is often infeasible.</p>
\ No newline at end of file
+++ /dev/null
-<p> The return value from a method is dereferenced without a null check,
-and the return value of that method is one that should generally be checked
-for null. This may lead to a <code>NullPointerException</code> when the code is executed.
-</p>
\ No newline at end of file
+++ /dev/null
-<p> There is a branch of statement that, <em>if executed,</em> guarantees that
-a null value will be dereferenced, which
-would generate a <code>NullPointerException</code> when the code is executed.
-Of course, the problem might be that the branch or statement is infeasible and that
-the null pointer exception can't ever be executed; deciding that is beyond the ability of FindBugs.
-Due to the fact that this value had been previously tested for nullness, this is a definite possibility.
-</p>
\ No newline at end of file
+++ /dev/null
-<p>
- This method call passes a null value for a nonnull method parameter.
- Either the parameter is annotated as a parameter that should
- always be nonnull, or analysis has shown that it will always be
- dereferenced.
- </p>
\ No newline at end of file
+++ /dev/null
-<p>
- A possibly-null value is passed at a call site where all known
- target methods require the parameter to be nonnull.
- Either the parameter is annotated as a parameter that should
- always be nonnull, or analysis has shown that it will always be
- dereferenced.
- </p>
\ No newline at end of file
+++ /dev/null
-<p>
- A possibly-null value is passed to a nonnull method parameter.
- Either the parameter is annotated as a parameter that should
- always be nonnull, or analysis has shown that it will always be
- dereferenced.
- </p>
\ No newline at end of file
+++ /dev/null
-<p> This parameter is always used in a way that requires it to be nonnull,
-but the parameter is explicitly annotated as being Nullable. Either the use
-of the parameter or the annotation is wrong.
-</p>
\ No newline at end of file
+++ /dev/null
-<p> A value that could be null is stored into a field that has been annotated as NonNull. </p>
\ No newline at end of file
+++ /dev/null
-<p>Since the field is synchronized on, it seems not likely to be null.
-If it is null and then synchronized on a NullPointerException will be
-thrown and the check would be pointless. Better to synchronize on
-another field.</p>
\ No newline at end of file
+++ /dev/null
-<p>
- This toString method seems to return null in some circumstances. A liberal reading of the
- spec could be interpreted as allowing this, but it is probably a bad idea and could cause
- other code to break. Return the empty string or some other appropriate string rather than null.
- </p>
\ No newline at end of file
+++ /dev/null
-<p>The program is dereferencing a field that does not seem to ever have a non-null value written to it. Dereferencing this value will generate a null pointer exception.</p>
\ No newline at end of file
+++ /dev/null
-<p>The program is dereferencing a public or protected field that does not seem to ever have a non-null
- value written to it. Unless the field is initialized via some mechanism not seen by the analysis,
- dereferencing this value will generate a null pointer exception.</p>
\ No newline at end of file
+++ /dev/null
-<p> This code seems to be using non-short-circuit logic (e.g., &
-or |)
-rather than short-circuit logic (&& or ||). In addition,
-it seem possible that, depending on the value of the left hand side, you might not
-want to evaluate the right hand side (because it would have side effects, could cause an exception
-or could be expensive.</p>
-<p>
-Non-short-circuit logic causes both sides of the expression
-to be evaluated even when the result can be inferred from
-knowing the left-hand side. This can be less efficient and
-can result in errors if the left-hand side guards cases
-when evaluating the right-hand side can generate an error.
-</p>
-
-<p>See <a href="http://java.sun.com/docs/books/jls/third_edition/html/expressions.html#15.22.2">the Java
-Language Specification</a> for details
-
-</p>
\ No newline at end of file
+++ /dev/null
-<p> This code seems to be using non-short-circuit logic (e.g., &
-or |)
-rather than short-circuit logic (&& or ||).
-Non-short-circuit logic causes both sides of the expression
-to be evaluated even when the result can be inferred from
-knowing the left-hand side. This can be less efficient and
-can result in errors if the left-hand side guards cases
-when evaluating the right-hand side can generate an error.
-
-<p>See <a href="http://java.sun.com/docs/books/jls/third_edition/html/expressions.html#15.22.2">the Java
-Language Specification</a> for details
-
-</p>
\ No newline at end of file
+++ /dev/null
-<p>
- This method may fail to clean up (close, dispose of) a stream,
- database object, or other
- resource requiring an explicit cleanup operation.
- </p>
- <p>
- In general, if a method opens a stream or other resource,
- the method should use a try/finally block to ensure that
- the stream or resource is cleaned up before the method
- returns.
- </p>
- <p>
- This bug pattern is essentially the same as the
- OS_OPEN_STREAM and ODR_OPEN_DATABASE_RESOURCE
- bug patterns, but is based on a different
- (and hopefully better) static analysis technique.
- We are interested is getting feedback about the
- usefulness of this bug pattern.
- To send feedback, either:
- </p>
- <ul>
- <li>send email to findbugs@cs.umd.edu</li>
- <li>file a bug report: <a href="http://findbugs.sourceforge.net/reportingBugs.html">http://findbugs.sourceforge.net/reportingBugs.html</a></li>
- </ul>
- <p>
- In particular,
- the false-positive suppression heuristics for this
- bug pattern have not been extensively tuned, so
- reports about false positives are helpful to us.
- </p>
- <p>
- See Weimer and Necula, <i>Finding and Preventing Run-Time Error Handling Mistakes</i>, for
- a description of the analysis technique.
- </p>
\ No newline at end of file
+++ /dev/null
-<p>This method may fail to clean up (close, dispose of) a stream, database object, or other resource requiring an
-explicit cleanup operation.<br/>In general, if a method opens a stream or other resource, the method should use a try/finally block to ensure
-that the stream or resource is cleaned up before the method returns.<p/>
-<p>This bug pattern is essentially the same as the OS_OPEN_STREAM and ODR_OPEN_DATABASE_RESOURCE bug patterns, but is based on a different
-(and hopefully better) static analysis technique. See Weimer and Necula, Finding and Preventing Run-Time Error Handling Mistakes, for a
-description of the analysis technique. .</p>
\ No newline at end of file
+++ /dev/null
-<p> The method creates a database resource (such as a database connection
-or row set), does not assign it to any
-fields, pass it to other methods, or return it, and does not appear to close
-the object on all paths out of the method. Failure to
-close database resources on all paths out of a method may
-result in poor performance, and could cause the application to
-have problems communicating with the database.
-</p>
\ No newline at end of file
+++ /dev/null
-<p> The method creates a database resource (such as a database connection
-or row set), does not assign it to any
-fields, pass it to other methods, or return it, and does not appear to close
-the object on all exception paths out of the method. Failure to
-close database resources on all paths out of a method may
-result in poor performance, and could cause the application to
-have problems communicating with the database.</p>
\ No newline at end of file
+++ /dev/null
-<p> The method creates an IO stream object, does not assign it to any
-fields, pass it to other methods that might close it,
-or return it, and does not appear to close
-the stream on all paths out of the method. This may result in
-a file descriptor leak. It is generally a good
-idea to use a <code>finally</code> block to ensure that streams are
-closed.</p>
\ No newline at end of file
+++ /dev/null
-<p> The method creates an IO stream object, does not assign it to any
-fields, pass it to other methods, or return it, and does not appear to close
-it on all possible exception paths out of the method.
-This may result in a file descriptor leak. It is generally a good
-idea to use a <code>finally</code> block to ensure that streams are
-closed.</p>
\ No newline at end of file
+++ /dev/null
-<p>
- This class uses synchronization along with wait(), notify() or notifyAll() on itself (the this
- reference). Client classes that use this class, may, in addition, use an instance of this class
- as a synchronizing object. Because two classes are using the same object for synchronization,
- Multithread correctness is suspect. You should not synchronize nor call semaphore methods on
- a public reference. Consider using a internal private member variable to control synchronization.
- </p>
\ No newline at end of file
+++ /dev/null
-<p>
-The software uses an HTTP request parameter to construct a pathname that should be within a restricted directory,
-but it does not properly neutralize absolute path sequences such as "/abs/path" that can resolve to a location that is outside of that directory.
-
-See <a href="http://cwe.mitre.org/data/definitions/36.html">http://cwe.mitre.org/data/definitions/36.html</a> for more information.
-</p>
-
-<p>
-FindBugs looks only for the most blatant, obvious cases of absolute path traversal.
-If FindBugs found <em>any</em>, you <em>almost certainly</em> have more
-vulnerabilities that FindBugs doesn't report. If you are concerned about absolute path traversal, you should seriously
-consider using a commercial static analysis or pen-testing tool.
-</p>
+++ /dev/null
-<p>
-The software uses an HTTP request parameter to construct a pathname that should be within a restricted directory,
-but it does not properly neutralize sequences such as ".." that can resolve to a location that is outside of that directory.
-
-See <a href="http://cwe.mitre.org/data/definitions/23.html">http://cwe.mitre.org/data/definitions/23.html</a> for more information.</p>
-
-<p>
-FindBugs looks only for the most blatant, obvious cases of relative path traversal.
-If FindBugs found <em>any</em>, you <em>almost certainly</em> have more
-vulnerabilities that FindBugs doesn't report. If you are concerned about relative path traversal, you should seriously
-consider using a commercial static analysis or pen-testing tool.
-</p>
+++ /dev/null
-<p> It is often a better design to
-return a length zero array rather than a null reference to indicate that there
-are no results (i.e., an empty list of results).
-This way, no explicit check for null is needed by clients of the method.</p>
-
-<p>On the other hand, using null to indicate
-"there is no answer to this question" is probably appropriate.
-For example, <code>File.listFiles()</code> returns an empty list
-if given a directory containing no files, and returns null if the file
-is not a directory.</p>
\ No newline at end of file
+++ /dev/null
-<p>The entrySet() method is allowed to return a view of the underlying Map in which an <code>Iterator</code>
-and <code>Map.Entry</code>. This clever idea was used in several Map implementations, but introduces the possibility of
- nasty coding mistakes. If a map m returns such an iterator for an entrySet, then <code>c.addAll(m.entrySet())</code> will
- go badly wrong. All of the Map implementations in OpenJDK 1.7 have been rewritten to avoid this, you should to.</p>
\ No newline at end of file
+++ /dev/null
-<p>
- This method assigns a literal boolean value (true or false) to a boolean variable inside
- an if or while expression. Most probably this was supposed to be a boolean comparison using
- ==, not an assignment using =.
- </p>
\ No newline at end of file
+++ /dev/null
-<p>Are you sure this for loop is incrementing the correct variable?
- It appears that another variable is being initialized and checked
- by the for loop.
-</p>
\ No newline at end of file
+++ /dev/null
-<p> This method contains a reference known to be non-null with another reference
-known to be null.</p>
\ No newline at end of file
+++ /dev/null
-<p> This method contains a redundant comparison of two references known to
-both be definitely null.</p>
\ No newline at end of file
+++ /dev/null
-<p> This method contains a redundant check of a known non-null value against
-the constant null.</p>
\ No newline at end of file
+++ /dev/null
-<p> This method contains a redundant check of a known null value against
-the constant null.</p>
\ No newline at end of file
+++ /dev/null
-<p> A value is checked here to see whether it is null, but this value can't
-be null because it was previously dereferenced and if it were null a null pointer
-exception would have occurred at the earlier dereference.
-Essentially, this code and the previous dereference
-disagree as to whether this value is allowed to be null. Either the check is redundant
-or the previous dereference is erroneous.</p>
\ No newline at end of file
+++ /dev/null
-<p> This method compares two reference values using the == or != operator,
-where the correct way to compare instances of this type is generally
-with the equals() method. Examples of classes which should generally
-not be compared by reference are java.lang.Integer, java.lang.Float, etc.</p>
\ No newline at end of file
+++ /dev/null
-This method compares a reference value to a constant using the == or != operator, where the correct way to compare instances of this type is generally with the equals() method. It is possible to create distinct instances that are equal but do not compare as == since they are different objects. Examples of classes which should generally not be compared by reference are java.lang.Integer, java.lang.Float, etc.
\ No newline at end of file
+++ /dev/null
-This method compares two Boolean values using the == or != operator. Normally, there are only two Boolean values (Boolean.TRUE and Boolean.FALSE), but it is possible to create other Boolean objects using the new Boolean(b) constructor. It is best to avoid such objects, but if they do exist, then checking Boolean objects for equality using == or != will give results than are different than you would get using .equals(...)
\ No newline at end of file
+++ /dev/null
-<p>
- This method uses a try-catch block that catches Exception objects, but Exception is not
- thrown within the try block, and RuntimeException is not explicitly caught. It is a common bug pattern to
- say try { ... } catch (Exception e) { something } as a shorthand for catching a number of types of exception
- each of whose catch blocks is identical, but this construct also accidentally catches RuntimeException as well,
- masking potential bugs.
- </p>
\ No newline at end of file
+++ /dev/null
-<p>
-The code here uses a regular expression that is invalid according to the syntax
-for regular expressions. This statement will throw a PatternSyntaxException when
-executed.
-</p>
\ No newline at end of file
+++ /dev/null
-<p>
-The code here uses <code>File.separator</code>
-where a regular expression is required. This will fail on Windows
-platforms, where the <code>File.separator</code> is a backslash, which is interpreted in a
-regular expression as an escape character. Amoung other options, you can just use
-<code>File.separatorChar=='\\' & "\\\\" : File.separator</code> instead of
-<code>File.separator</code>
-
-</p>
\ No newline at end of file
+++ /dev/null
-<p>
-A String function is being invoked and "." is being passed
-to a parameter that takes a regular expression as an argument. Is this what you intended?
-For example
-s.replaceAll(".", "/") will return a String in which <em>every</em>
-character has been replaced by a / character.
-</p>
\ No newline at end of file
+++ /dev/null
-<p>
- This class declares that it implements an interface that is also implemented by a superclass.
- This is redundant because once a superclass implements an interface, all subclasses by default also
- implement this interface. It may point out that the inheritance hierarchy has changed since
- this class was created, and consideration should be given to the ownership of
- the interface's implementation.
- </p>
\ No newline at end of file
+++ /dev/null
-<p> This method ignores the return value of one of the variants of
- <code>java.io.InputStream.read()</code> which can return multiple bytes.
- If the return value is not checked, the caller will not be able to correctly
- handle the case where fewer bytes were read than the caller requested.
- This is a particularly insidious kind of bug, because in many programs,
- reads from input streams usually do read the full amount of data requested,
- causing the program to fail only sporadically.</p>
\ No newline at end of file
+++ /dev/null
-<p> This serializable class defines a <code>readObject()</code> which is
- synchronized. By definition, an object created by deserialization
- is only reachable by one thread, and thus there is no need for
- <code>readObject()</code> to be synchronized. If the <code>readObject()</code>
- method itself is causing the object to become visible to another thread,
- that is an example of very dubious coding style.</p>
\ No newline at end of file
+++ /dev/null
-<p> This method explicitly invokes <code>run()</code> on an object.
- In general, classes implement the <code>Runnable</code> interface because
- they are going to have their <code>run()</code> method invoked in a new thread,
- in which case <code>Thread.start()</code> is the right method to call.</p>
\ No newline at end of file
+++ /dev/null
-<p>A random value from 0 to 1 is being coerced to the integer value 0. You probably
-want to multiple the random value by something else before coercing it to an integer, or use the <code>Random.nextInt(n)</code> method.
-</p>
\ No newline at end of file
+++ /dev/null
-<p> This code generates a hashcode and then computes
-the absolute value of that hashcode. If the hashcode
-is <code>Integer.MIN_VALUE</code>, then the result will be negative as well (since
-<code>Math.abs(Integer.MIN_VALUE) == Integer.MIN_VALUE</code>).
-</p>
\ No newline at end of file
+++ /dev/null
-<p> This code generates a random signed integer and then computes
-the absolute value of that random integer. If the number returned by the random number
-generator is <code>Integer.MIN_VALUE</code>, then the result will be negative as well (since
-<code>Math.abs(Integer.MIN_VALUE) == Integer.MIN_VALUE</code>).
-</p>
\ No newline at end of file
+++ /dev/null
-<p>This code invoked a compareTo or compare method, and checks to see if the return value is a specific
-value, such as 1 or -1. When invoking these methods, you should only check the sign of the result, not
-for any specific non-zero value. While many or most compareTo and compare methods only return -1, 0 or 1,
-some of them will return other values.</p>
\ No newline at end of file
+++ /dev/null
-<p> The method invokes String.indexOf and checks to see if the result is positive or non-positive.
- It is much more typical to check to see if the result is negative or non-negative. It is
- positive only if the substring checked for occurs at some place other than at the beginning of
- the String.</p>
\ No newline at end of file
+++ /dev/null
-<p> The value returned by readLine is discarded after checking to see if the return
-value is non-null. In almost all situations, if the result is non-null, you will want
-to use that non-null value. Calling readLine again will give you a different line.</p>
\ No newline at end of file
+++ /dev/null
-<p> This code creates an exception (or error) object, but doesn't do anything with it. For example,
-something like </p>
-<blockquote>
-<pre>
-if (x < 0)
- new IllegalArgumentException("x must be nonnegative");
-</pre>
-</blockquote>
-<p>It was probably the intent of the programmer to throw the created exception:</p>
-<blockquote>
-<pre>
-if (x < 0)
- throw new IllegalArgumentException("x must be nonnegative");
-</pre>
-</blockquote>
\ No newline at end of file
+++ /dev/null
-<p>This code negatives the return value of a compareTo or compare method. This is a questionable or bad
-programming practice, since if the return value is Integer.MIN_VALUE, negating the return value won't
-negate the sign of the result. You can achieve the same intended result by reversing the order of the
-operands rather than by negating the results.</p>
\ No newline at end of file
+++ /dev/null
-<p> This code computes a hashCode, and then computes
-the remainder of that value modulo another value. Since the hashCode
-can be negative, the result of the remainder operation
-can also be negative. </p>
-<p> Assuming you want to ensure that the result of your computation is nonnegative,
-you may need to change your code.
-If you know the divisor is a power of 2,
-you can use a bitwise and operator instead (i.e., instead of
-using <code>x.hashCode()%n</code>, use <code>x.hashCode()&(n-1)</code>.
-This is probably faster than computing the remainder as well.
-If you don't know that the divisor is a power of 2, take the absolute
-value of the result of the remainder operation (i.e., use
-<code>Math.abs(x.hashCode()%n)</code>
-</p>
\ No newline at end of file
+++ /dev/null
-<p> This code generates a random signed integer and then computes
-the remainder of that value modulo another value. Since the random
-number can be negative, the result of the remainder operation
-can also be negative. Be sure this is intended, and strongly
-consider using the Random.nextInt(int) method instead.
-</p>
\ No newline at end of file
+++ /dev/null
-<p> The return value of this method should be checked. One common
-cause of this warning is to invoke a method on an immutable object,
-thinking that it updates the object. For example, in the following code
-fragment,</p>
-<blockquote>
-<pre>
-String dateString = getHeaderField(name);
-dateString.trim();
-</pre>
-</blockquote>
-<p>the programmer seems to be thinking that the trim() method will update
-the String referenced by dateString. But since Strings are immutable, the trim()
-function returns a new String value, which is being ignored here. The code
-should be corrected to: </p>
-<blockquote>
-<pre>
-String dateString = getHeaderField(name);
-dateString = dateString.trim();
-</pre>
-</blockquote>
\ No newline at end of file
+++ /dev/null
-<p> The return value of this method should be checked. One common
-cause of this warning is to invoke a method on an immutable object,
-thinking that it updates the object. For example, in the following code
-fragment,</p>
-<blockquote>
-<pre>
-String dateString = getHeaderField(name);
-dateString.trim();
-</pre>
-</blockquote>
-<p>the programmer seems to be thinking that the trim() method will update
-the String referenced by dateString. But since Strings are immutable, the trim()
-function returns a new String value, which is being ignored here. The code
-should be corrected to: </p>
-<blockquote>
-<pre>
-String dateString = getHeaderField(name);
-dateString = dateString.trim();
-</pre>
-</blockquote>
\ No newline at end of file
+++ /dev/null
-<p> This method returns a value that is not checked. The return value should be checked
-since it can indicate an unusual or unexpected function execution. For
-example, the <code>File.delete()</code> method returns false
-if the file could not be successfully deleted (rather than
-throwing an Exception).
-If you don't check the result, you won't notice if the method invocation
-signals unexpected behavior by returning an atypical return value.
-</p>
\ No newline at end of file
+++ /dev/null
-<p>This code calls a method and ignores the return value. The return value is the same type as the type the
-method is invoked on, and from our analysis it looks like the return value might be important (e.g., like
-ignoring the return value of <code>String.toLowerCase()</code>).
-</p>
-<p>We are guessing that ignoring the return value might be a bad idea just from a simple analysis of the
-body of the method. You can use a <code>@CheckReturnValue</code> annotation to instruct FindBugs as to whether
-ignoring the return value of this method is important or acceptable.<p>
-<p>Please investigate this closely to decide whether it is OK to ignore the return value. </p>
\ No newline at end of file
+++ /dev/null
-The putIfAbsent method is typically used to ensure that a single value is associated with a given key (the first value for which put if absent succeeds). If you ignore the return value and retain a reference to the value passed in, you run the risk of retaining a value that is not the one that is associated with the key in the map. If it matters which one you use and you use the one that isn't stored in the map, your program will behave incorrectly.
\ No newline at end of file
+++ /dev/null
-<p>The code contains a conditional test is performed twice, one right after the other
-(e.g., <code>x == 0 || x == 0</code>). Perhaps the second occurrence is intended to be something else
-(e.g., <code>x == 0 || y == 0</code>).
-</p>
\ No newline at end of file
+++ /dev/null
-<p> This method contains a double assignment of a field; e.g.
-</p>
-<pre>
- int x,y;
- public void foo() {
- x = x = 17;
- }
-</pre>
-<p>Assigning to a field twice is useless, and may indicate a logic error or typo.</p>
\ No newline at end of file
+++ /dev/null
-<p> This method contains a self assignment of a field; e.g.
-</p>
-<pre>
- int x;
- public void foo() {
- x = x;
- }
-</pre>
-<p>Such assignments are useless, and may indicate a logic error or typo.</p>
\ No newline at end of file
+++ /dev/null
-<p> This method compares a field with itself, and may indicate a typo or
-a logic error. Make sure that you are comparing the right things.
-</p>
\ No newline at end of file
+++ /dev/null
-<p> This method performs a nonsensical computation of a field with another
-reference to the same field (e.g., x&x or x-x). Because of the nature
-of the computation, this operation doesn't seem to make sense,
-and may indicate a typo or
-a logic error. Double check the computation.
-</p>
\ No newline at end of file
+++ /dev/null
-<p> This method contains a double assignment of a local variable; e.g.
-</p>
-<pre>
- public void foo() {
- int x,y;
- x = x = 17;
- }
-</pre>
-<p>Assigning the same value to a variable twice is useless, and may indicate a logic error or typo.</p>
\ No newline at end of file
+++ /dev/null
-<p> This method contains a self assignment of a local variable; e.g.</p>
-<pre>
- public void foo() {
- int x = 3;
- x = x;
- }
-</pre>
-<p>
-Such assignments are useless, and may indicate a logic error or typo.
-</p>
\ No newline at end of file
+++ /dev/null
-<p>This method contains a self assignment of a local variable, and there is a field with an identical name.
-Assignment appears to have been ; e.g.
-<pre>
- int foo;
- public void setFoo(int foo) {
- foo = foo;
- }
-</pre>
-The assignment is useless. Did you mean to assign to the field instead?</p>
\ No newline at end of file
+++ /dev/null
-<p> This method compares a local variable with itself, and may indicate a typo or
-a logic error. Make sure that you are comparing the right things.
-</p>
\ No newline at end of file
+++ /dev/null
-<p> This method performs a nonsensical computation of a local variable with another
-reference to the same variable (e.g., x&x or x-x). Because of the nature
-of the computation, this operation doesn't seem to make sense,
-and may indicate a typo or
-a logic error. Double check the computation.
-</p>
\ No newline at end of file
+++ /dev/null
-<p> The method seems to be building a String using concatenation in a loop.
-In each iteration, the String is converted to a StringBuffer/StringBuilder,
- appended to, and converted back to a String.
- This can lead to a cost quadratic in the number of iterations,
- as the growing string is recopied in each iteration. </p>
-
-<p>Better performance can be obtained by using
-a StringBuffer (or StringBuilder in Java 1.5) explicitly.</p>
-
-<p> For example:</p>
-<pre>
- // This is bad
- String s = "";
- for (int i = 0; i < field.length; ++i) {
- s = s + field[i];
- }
-
- // This is better
- StringBuffer buf = new StringBuffer();
- for (int i = 0; i < field.length; ++i) {
- buf.append(field[i]);
- }
- String s = buf.toString();
-</pre>
\ No newline at end of file
+++ /dev/null
-<p> The constructor starts a thread. This is likely to be wrong if
- the class is ever extended/subclassed, since the thread will be started
- before the subclass constructor is started.</p>
\ No newline at end of file
+++ /dev/null
-<p>
- This Serializable class defines a non-primitive instance field which is neither transient,
- Serializable, or <code>java.lang.Object</code>, and does not appear to implement the <code>Externalizable</code>
- interface or the <code>readObject()</code> and <code>writeObject()</code> methods.
- Objects of this class will not be deserialized correctly if a non-Serializable object is stored in this field.
- </p>
\ No newline at end of file
+++ /dev/null
-<p> This Serializable class is an inner class of a non-serializable class.
-Thus, attempts to serialize it will also attempt to associate instance of the outer
-class with which it is associated, leading to a runtime error.
-</p>
-<p>If possible, making the inner class a static inner class should solve the
-problem. Making the outer class serializable might also work, but that would
-mean serializing an instance of the inner class would always also serialize the instance
-of the outer class, which it often not what you really want.
\ No newline at end of file
+++ /dev/null
-<p> A non-serializable value is stored into a non-transient field
-of a serializable class.</p>
\ No newline at end of file
+++ /dev/null
-<p> This class implements the <code>Comparator</code> interface. You
-should consider whether or not it should also implement the <code>Serializable</code>
-interface. If a comparator is used to construct an ordered collection
-such as a <code>TreeMap</code>, then the <code>TreeMap</code>
-will be serializable only if the comparator is also serializable.
-As most comparators have little or no state, making them serializable
-is generally easy and good defensive programming.
-</p>
\ No newline at end of file
+++ /dev/null
-<p> This Serializable class is an inner class. Any attempt to serialize
-it will also serialize the associated outer instance. The outer instance is serializable,
-so this won't fail, but it might serialize a lot more data than intended.
-If possible, making the inner class a static inner class (also known as a nested class) should solve the
-problem.
\ No newline at end of file
+++ /dev/null
-<p> This class implements the <code>Serializable</code> interface, and defines a method
- for custom serialization/deserialization. But since that method isn't declared private,
- it will be silently ignored by the serialization/deserialization API.</p>
\ No newline at end of file
+++ /dev/null
-<p> This class defines a <code>serialVersionUID</code> field that is not final.
- The field should be made final
- if it is intended to specify
- the version UID for purposes of serialization.</p>
\ No newline at end of file
+++ /dev/null
-<p> This class defines a <code>serialVersionUID</code> field that is not long.
- The field should be made long
- if it is intended to specify
- the version UID for purposes of serialization.</p>
\ No newline at end of file
+++ /dev/null
-<p> This class defines a <code>serialVersionUID</code> field that is not static.
- The field should be made static
- if it is intended to specify
- the version UID for purposes of serialization.</p>
\ No newline at end of file
+++ /dev/null
-<p> This class implements the <code>Serializable</code> interface, but does
- not define a <code>serialVersionUID</code> field.
- A change as simple as adding a reference to a .class object
- will add synthetic fields to the class,
- which will unfortunately change the implicit
- serialVersionUID (e.g., adding a reference to <code>String.class</code>
- will generate a static field <code>class$java$lang$String</code>).
- Also, different source code to bytecode compilers may use different
- naming conventions for synthetic variables generated for
- references to class objects or inner classes.
- To ensure interoperability of Serializable across versions,
- consider adding an explicit serialVersionUID.</p>
\ No newline at end of file
+++ /dev/null
-<p> This class implements the <code>Serializable</code> interface
- and its superclass does not. When such an object is deserialized,
- the fields of the superclass need to be initialized by
- invoking the void constructor of the superclass.
- Since the superclass does not have one,
- serialization and deserialization will fail at runtime.</p>
\ No newline at end of file
+++ /dev/null
-<p> This class implements the <code>Externalizable</code> interface, but does
- not define a void constructor. When Externalizable objects are deserialized,
- they first need to be constructed by invoking the void
- constructor. Since this class does not have one,
- serialization and deserialization will fail at runtime.</p>
\ No newline at end of file
+++ /dev/null
-<p> This class defines a private readResolve method. Since it is private, it won't be inherited by subclasses.
-This might be intentional and OK, but should be reviewed to ensure it is what is intended.
-</p>
\ No newline at end of file
+++ /dev/null
-<p> In order for the readResolve method to be recognized by the serialization
-mechanism, it must not be declared as a static method.
-</p>
\ No newline at end of file
+++ /dev/null
-<p> In order for the readResolve method to be recognized by the serialization
-mechanism, it must be declared to have a return type of Object.
-</p>
\ No newline at end of file
+++ /dev/null
-<p> This class contains a field that is updated at multiple places in the class, thus it seems to be part of the state of the class. However, since the field is marked as transient and not set in readObject or readResolve, it will contain the default value in any
-deserialized instance of the class.
-</p>
\ No newline at end of file
+++ /dev/null
-<p> The field is marked as transient, but the class isn't Serializable, so marking it as transient
-has absolutely no effect.
-This may be leftover marking from a previous version of the code in which the class was transient, or
-it may indicate a misunderstanding of how serialization works.
-</p>
\ No newline at end of file
+++ /dev/null
-<p>
- A value stored in the previous switch case is overwritten here due
- to a switch fall through. It is likely that you forgot to put a
- break or return at the end of the previous case.
- </p>
\ No newline at end of file
+++ /dev/null
-<p>
- A value stored in the previous switch case is ignored here due to a switch fall through to a place where an exception is thrown.
- It is likely that you forgot to put a break or return at the end of the previous case.
- </p>
\ No newline at end of file
+++ /dev/null
-<p>
- This method contains a switch statement where one case branch will fall
- through to the next case. Usually you need to end this case with a break or return.
- </p>
\ No newline at end of file
+++ /dev/null
-<p>
- This method contains a switch statement where default case is missing.
- Usually you need to provide a default case.
- </p>
\ No newline at end of file
+++ /dev/null
-<p> This class is an inner class, but does not use its embedded reference
- to the object which created it. This reference makes the instances
- of the class larger, and may keep the reference to the creator object
- alive longer than necessary. If possible, the class should be
- made static.
-</p>
\ No newline at end of file
+++ /dev/null
-<p> This class is an inner class, but does not use its embedded reference
- to the object which created it. This reference makes the instances
- of the class larger, and may keep the reference to the creator object
- alive longer than necessary. If possible, the class should be
- made into a <em>static</em> inner class. Since anonymous inner
-classes cannot be marked as static, doing this will require refactoring
-the inner class so that it is a named inner class.</p>
\ No newline at end of file
+++ /dev/null
-<p> This class is an inner class, but does not use its embedded reference
- to the object which created it except during construction of the
-inner object. This reference makes the instances
- of the class larger, and may keep the reference to the creator object
- alive longer than necessary. If possible, the class should be
- made into a <em>static</em> inner class. Since the reference to the
- outer object is required during construction of the inner instance,
- the inner class will need to be refactored so as to
- pass a reference to the outer instance to the constructor
- for the inner class.</p>
\ No newline at end of file
+++ /dev/null
-This class is an inner class, but should probably be a static inner class. As it is, there is a serious danger of a deadly embrace between the inner class and the thread local in the outer class. Because the inner class isn't static, it retains a reference to the outer class. If the thread local contains a reference to an instance of the inner class, the inner and outer instance will both be reachable and not eligible for garbage collection.
\ No newline at end of file
+++ /dev/null
-<p> Type check performed using the instanceof operator where it can be statically determined whether the object
-is of the type requested. </p>
\ No newline at end of file
+++ /dev/null
-<p> The class's static initializer creates an instance of the class
-before all of the static final fields are assigned.</p>
\ No newline at end of file
+++ /dev/null
-<p>This class is bigger than can be effectively handled, and was not fully analyzed for errors.
-</p>
\ No newline at end of file
+++ /dev/null
-<p> This method spins in a loop which reads a field. The compiler
- may legally hoist the read out of the loop, turning the code into an
- infinite loop. The class should be changed so it uses proper
- synchronization (including wait and notify calls).</p>
\ No newline at end of file
+++ /dev/null
-<p> A call to a setXXX method of a prepared statement was made where the
-parameter index is 0. As parameter indexes start at index 1, this is always a mistake.</p>
\ No newline at end of file
+++ /dev/null
-<p> A call to getXXX or updateXXX methods of a result set was made where the
-field index is 0. As ResultSet fields start at index 1, this is always a mistake.</p>
\ No newline at end of file
+++ /dev/null
-<p>The method invokes the execute method on an SQL statement with a String that seems
-to be dynamically generated. Consider using
-a prepared statement instead. It is more efficient and less vulnerable to
-SQL injection attacks.
-</p>
\ No newline at end of file
+++ /dev/null
-<p>The code creates an SQL prepared statement from a nonconstant String.
-If unchecked, tainted data from a user is used in building this String, SQL injection could
-be used to make the prepared statement do something unexpected and undesirable.
-</p>
\ No newline at end of file
+++ /dev/null
-<p> This method ignores the return value of
- <code>java.io.InputStream.skip()</code> which can skip multiple bytes.
- If the return value is not checked, the caller will not be able to correctly
- handle the case where fewer bytes were skipped than the caller requested.
- This is a particularly insidious kind of bug, because in many programs,
- skips from input streams usually do skip the full amount of data requested,
- causing the program to fail only sporadically. With Buffered streams, however,
- skip() will only skip data in the buffer, and will routinely fail to skip the
- requested number of bytes.</p>
\ No newline at end of file
+++ /dev/null
-<p> This class contains an instance final field that
- is initialized to a compile-time static value.
- Consider making the field static.</p>
\ No newline at end of file
+++ /dev/null
-<p>Even though the JavaDoc does not contain a hint about it, Calendars are inherently unsafe for multihtreaded use.
-The detector has found a call to an instance of Calendar that has been obtained via a static
-field. This looks suspicous.</p>
-<p>For more information on this see <a href="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6231579">Sun Bug #6231579</a>
-and <a href="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6178997">Sun Bug #6178997</a>.</p>
\ No newline at end of file
+++ /dev/null
-<p>As the JavaDoc states, DateFormats are inherently unsafe for multithreaded use.
-The detector has found a call to an instance of DateFormat that has been obtained via a static
-field. This looks suspicous.</p>
-<p>For more information on this see <a href="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6231579">Sun Bug #6231579</a>
-and <a href="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6178997">Sun Bug #6178997</a>.</p>
\ No newline at end of file
+++ /dev/null
-<p>Even though the JavaDoc does not contain a hint about it, Calendars are inherently unsafe for multihtreaded use.
-Sharing a single instance across thread boundaries without proper synchronization will result in erratic behavior of the
-application. Under 1.4 problems seem to surface less often than under Java 5 where you will probably see
-random ArrayIndexOutOfBoundsExceptions or IndexOutOfBoundsExceptions in sun.util.calendar.BaseCalendar.getCalendarDateFromFixedDate().</p>
-<p>You may also experience serialization problems.</p>
-<p>Using an instance field is recommended.</p>
-<p>For more information on this see <a href="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6231579">Sun Bug #6231579</a>
-and <a href="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6178997">Sun Bug #6178997</a>.</p>
\ No newline at end of file
+++ /dev/null
-<p>As the JavaDoc states, DateFormats are inherently unsafe for multithreaded use.
-Sharing a single instance across thread boundaries without proper synchronization will result in erratic behavior of the
-application.</p>
-<p>You may also experience serialization problems.</p>
-<p>Using an instance field is recommended.</p>
-<p>For more information on this see <a href="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6231579">Sun Bug #6231579</a>
-and <a href="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6178997">Sun Bug #6178997</a>.</p>
\ No newline at end of file
+++ /dev/null
-<p>
-This method invokes the Thread.currentThread() call, just to call the interrupted() method. As interrupted() is a
-static method, is more simple and clear to use Thread.interrupted().
-</p>
\ No newline at end of file
+++ /dev/null
-<p>
-This method invokes the Thread.interrupted() method on a Thread object that appears to be a Thread object that is
-not the current thread. As the interrupted() method is static, the interrupted method will be called on a different
-object than the one the author intended.
-</p>
\ No newline at end of file
+++ /dev/null
-<p> This instance method writes to a static field. This is tricky to get
-correct if multiple instances are being manipulated,
-and generally bad practice.
-</p>
\ No newline at end of file
+++ /dev/null
-<p>
- This method calls Thread.sleep() with a lock held. This may result
- in very poor performance and scalability, or a deadlock, since other threads may
- be waiting to acquire the lock. It is a much better idea to call
- wait() on the lock, which releases the lock and allows other threads
- to run.
- </p>
\ No newline at end of file
+++ /dev/null
-<p>(<a href="http://java.sun.com/developer/JDCTechTips/2003/tt1208.html#1">From JDC Tech Tip</a>): The Swing methods
-show(), setVisible(), and pack() will create the associated peer for the frame.
-With the creation of the peer, the system creates the event dispatch thread.
-This makes things problematic because the event dispatch thread could be notifying
-listeners while pack and validate are still processing. This situation could result in
-two threads going through the Swing component-based GUI -- it's a serious flaw that
-could result in deadlocks or other related threading issues. A pack call causes
-components to be realized. As they are being realized (that is, not necessarily
-visible), they could trigger listener notification on the event dispatch thread.</p>
\ No newline at end of file
+++ /dev/null
-<p> Waiting on a monitor while two locks are held may cause
- deadlock.
-
- Performing a wait only releases the lock on the object
- being waited on, not any other locks.
-
-This not necessarily a bug, but is worth examining
- closely.</p>
\ No newline at end of file
+++ /dev/null
-<p>
- A value specified as carrying a type qualifier annotation is
- consumed in a location or locations requiring that the value not
- carry that annotation.
- </p>
-
- <p>
- More precisely, a value annotated with a type qualifier specifying when=ALWAYS
- is guaranteed to reach a use or uses where the same type qualifier specifies when=NEVER.
- </p>
-
- <p>
- For example, say that @NonNegative is a nickname for
- the type qualifier annotation @Negative(when=When.NEVER).
- The following code will generate this warning because
- the return statement requires a @NonNegative value,
- but receives one that is marked as @Negative.
- </p>
- <blockquote>
-<pre>
-public @NonNegative Integer example(@Negative Integer value) {
- return value;
-}
-</pre>
- </blockquote>
\ No newline at end of file
+++ /dev/null
-<p>
-A value specified as carrying a type qualifier annotation is
-compared with a value that doesn't ever carry that qualifier.
-</p>
-
-<p>
-More precisely, a value annotated with a type qualifier specifying when=ALWAYS
-is compared with a value that where the same type qualifier specifies when=NEVER.
-</p>
-
-<p>
-For example, say that @NonNegative is a nickname for
-the type qualifier annotation @Negative(when=When.NEVER).
-The following code will generate this warning because
-the return statement requires a @NonNegative value,
-but receives one that is marked as @Negative.
-</p>
-<pre>
-public boolean example(@Negative Integer value1, @NonNegative Integer value2) {
- return value1.equals(value2);
-}
-</pre>
+++ /dev/null
-<p>
- A value is used in a way that requires it to be always be a value denoted by a type qualifier, but
- there is an explicit annotation stating that it is not known where the value is required to have that type qualifier.
- Either the usage or the annotation is incorrect.
- </p>
\ No newline at end of file
+++ /dev/null
-<p>
- A value is used in a way that requires it to be never be a value denoted by a type qualifier, but
- there is an explicit annotation stating that it is not known where the value is prohibited from having that type qualifier.
- Either the usage or the annotation is incorrect.
- </p>
\ No newline at end of file
+++ /dev/null
-<p>
- A value that is annotated as possibility not being an instance of
- the values denoted by the type qualifier, and the value is guaranteed to be used
- in a way that requires values denoted by that type qualifier.
- </p>
\ No newline at end of file
+++ /dev/null
-<p>
- A value that is annotated as possibility being an instance of
- the values denoted by the type qualifier, and the value is guaranteed to be used
- in a way that prohibits values denoted by that type qualifier.
- </p>
\ No newline at end of file
+++ /dev/null
-<p>
- A value specified as not carrying a type qualifier annotation is guaranteed
- to be consumed in a location or locations requiring that the value does
- carry that annotation.
- </p>
-
- <p>
- More precisely, a value annotated with a type qualifier specifying when=NEVER
- is guaranteed to reach a use or uses where the same type qualifier specifies when=ALWAYS.
- </p>
-
- <p>
- TODO: example
- </p>
\ No newline at end of file
+++ /dev/null
-<p> This method contains a useless control flow statement, where
-control flow continues onto the same place regardless of whether or not
-the branch is taken. For example,
-this is caused by having an empty statement
-block for an <code>if</code> statement:</p>
-<pre>
- if (argv.length == 0) {
- // TODO: handle this case
- }
-</pre>
\ No newline at end of file
+++ /dev/null
-<p> This method contains a useless control flow statement in which control
-flow follows to the same or following line regardless of whether or not
-the branch is taken.
-Often, this is caused by inadvertently using an empty statement as the
-body of an <code>if</code> statement, e.g.:</p>
-<pre>
- if (argv.length == 1);
- System.out.println("Hello, " + argv[0]);
-</pre>
\ No newline at end of file
+++ /dev/null
-<p> This class contains similarly-named get and set
- methods where the set method is synchronized and the get method is not.
- This may result in incorrect behavior at runtime, as callers of the get
- method will not necessarily see a consistent state for the object.
- The get method should be made synchronized.</p>
\ No newline at end of file
+++ /dev/null
-<p>Calling <code>this.getClass().getResource(...)</code> could give
-results other than expected if this class is extended by a class in
-another package.</p>
\ No newline at end of file
+++ /dev/null
-<p> This method acquires a JSR-166 (<code>java.util.concurrent</code>) lock,
-but does not release it on all paths out of the method. In general, the correct idiom
-for using a JSR-166 lock is:
-</p>
-<pre>
- Lock l = ...;
- l.lock();
- try {
- // do something
- } finally {
- l.unlock();
- }
-</pre>
\ No newline at end of file
+++ /dev/null
-<p> This method acquires a JSR-166 (<code>java.util.concurrent</code>) lock,
-but does not release it on all exception paths out of the method. In general, the correct idiom
-for using a JSR-166 lock is:
-</p>
-<pre>
- Lock l = ...;
- l.lock();
- try {
- // do something
- } finally {
- l.unlock();
- }
-</pre>
\ No newline at end of file
+++ /dev/null
-<p> This anonymous class defined a method that is not directly invoked and does not override
-a method in a superclass. Since methods in other classes cannot directly invoke methods
-declared in an anonymous class, it seems that this method is uncallable. The method
-might simply be dead code, but it is also possible that the method is intended to
-override a method declared in a superclass, and due to an typo or other error the method does not,
-in fact, override the method it is intended to.
-</p>
\ No newline at end of file
+++ /dev/null
-<p> This method uses a static method from java.lang.Math on a constant value. This method's
-result in this case, can be determined statically, and is faster and sometimes more accurate to
-just use the constant. Methods detected are:
-</p>
-<table>
-<tr>
- <th>Method</th> <th>Parameter</th>
-</tr>
-<tr>
- <td>abs</td> <td>-any-</td>
-</tr>
-<tr>
- <td>acos</td> <td>0.0 or 1.0</td>
-</tr>
-<tr>
- <td>asin</td> <td>0.0 or 1.0</td>
-</tr>
-<tr>
- <td>atan</td> <td>0.0 or 1.0</td>
-</tr>
-<tr>
- <td>atan2</td> <td>0.0</td>
-</tr>
-<tr>
- <td>cbrt</td> <td>0.0 or 1.0</td>
-</tr>
-<tr>
- <td>ceil</td> <td>-any-</td>
-</tr>
-<tr>
- <td>cos</td> <td>0.0</td>
-</tr>
-<tr>
- <td>cosh</td> <td>0.0</td>
-</tr>
-<tr>
- <td>exp</td> <td>0.0 or 1.0</td>
-</tr>
-<tr>
- <td>expm1</td> <td>0.0</td>
-</tr>
-<tr>
- <td>floor</td> <td>-any-</td>
-</tr>
-<tr>
- <td>log</td> <td>0.0 or 1.0</td>
-</tr>
-<tr>
- <td>log10</td> <td>0.0 or 1.0</td>
-</tr>
-<tr>
- <td>rint</td> <td>-any-</td>
-</tr>
-<tr>
- <td>round</td> <td>-any-</td>
-</tr>
-<tr>
- <td>sin</td> <td>0.0</td>
-</tr>
-<tr>
- <td>sinh</td> <td>0.0</td>
-</tr>
-<tr>
- <td>sqrt</td> <td>0.0 or 1.0</td>
-</tr>
-<tr>
- <td>tan</td> <td>0.0</td>
-</tr>
-<tr>
- <td>tanh</td> <td>0.0</td>
-</tr>
-<tr>
- <td>toDegrees</td> <td>0.0 or 1.0</td>
-</tr>
-<tr>
- <td>toRadians</td> <td>0.0</td>
-</tr>
-</table>
\ No newline at end of file
+++ /dev/null
-<p>
- This method invokes the .equals(Object o) method on a final class that doesn't override the equals method
- in the Object class, effectively making the equals method test for sameness, like ==. It is good to use
- the .equals method, but you should consider adding an .equals method in this class.
- </p>
- <p>[Bill Pugh]: Sorry, but I strongly disagree that this should be a warning, and I think your code
- is just fine. Users of your code shouldn't care how you've implemented equals(), and they should never
- depend on == to compare instances, since that bypasses the libraries ability to control how objects
- are compared.
- </p>
\ No newline at end of file
+++ /dev/null
-<p> This private method is never called. Although it is
-possible that the method will be invoked through reflection,
-it is more likely that the method is never used, and should be
-removed.
-</p>
\ No newline at end of file
+++ /dev/null
-<p> This field is never read. Consider removing it from the class.</p>
\ No newline at end of file
+++ /dev/null
-<p>This field is never read. The field is public or protected, so perhaps it is intended to be
-used with classes not seen as part of the analysis. If not, consider removing it from the class.</p>
\ No newline at end of file
+++ /dev/null
-<p> This constructor reads a field which has not yet been assigned a value.
- This is often caused when the programmer mistakenly uses the field instead
- of one of the constructor's parameters.</p>
\ No newline at end of file
+++ /dev/null
-<p>This method is invoked in the constructor of of the superclass. At this point, the fields of the class have not yet initialized. To make this more concrete, consider the following classes:</p>
-<pre>
- abstract class A {
- int hashCode;
- abstract Object getValue();
- A() {
- hashCode = getValue().hashCode();
- }
- }
- class B extends A {
- Object value;
- B(Object v) {
- this.value = v;
- }
- Object getValue() {
- return value;
- }
- }
-</pre>
-<p>When a B is constructed, the constructor for the A class is invoked before the constructor for B sets value. Thus, when the constructor for A invokes getValue, an uninitialized value is read for value.</p>
\ No newline at end of file
+++ /dev/null
-<p>
- This abstract method is already defined in an interface that is implemented by this abstract
- class. This method can be removed, as it provides no additional value.
- </p>
\ No newline at end of file
+++ /dev/null
-<p>
- This derived method merely calls the same superclass method passing in the exact parameters
- received. This method can be removed, as it provides no additional value.
- </p>
\ No newline at end of file
+++ /dev/null
-<p> This field is never used. Consider removing it from the class.</p>
\ No newline at end of file
+++ /dev/null
-<p>This field is never used. The field is public or protected, so perhaps it is intended to be used
-with classes not seen as part of the analysis. If not, consider removing it from the class.</p>
\ No newline at end of file
+++ /dev/null
-<p>This field is never initialized within any constructor, and is therefore could be null after the object is constructed. This could be a either an error or a questionable design, since it means a null pointer exception will be generated if that field is dereferenced before being initialized.</p>
\ No newline at end of file
+++ /dev/null
-<p> All writes to this field are of the constant value null, and thus
-all reads of the field will return null.
-Check for errors, or remove it if it is useless.</p>
\ No newline at end of file
+++ /dev/null
-<p>This field is never written. All reads of it will return the default value. Check for errors (should it have been initialized?), or remove it if it is useless.</p>
\ No newline at end of file
+++ /dev/null
-<p>No writes were seen to this public/protected field. All reads of it will return the default value.
-Check for errors (should it have been initialized?), or remove it if it is useless.</p>
\ No newline at end of file
+++ /dev/null
-<p> This method contains a call to <code>java.lang.Object.wait()</code> which
- is not guarded by conditional control flow. The code should
- verify that condition it intends to wait for is not already satisfied
- before calling wait; any previous notifications will be ignored.
- </p>
\ No newline at end of file
+++ /dev/null
-<p>
-A format-string method with a variable number of arguments is called,
-but the number of arguments passed does not match with the number of
-% placeholders in the format string. This is probably not what the
-author intended.
-</p>
\ No newline at end of file
+++ /dev/null
-<p>
-The format string placeholder is incompatible with the corresponding
-argument. For example,
-<code>
- System.out.println("%d\n", "hello");
-</code>
-<p>The %d placeholder requires a numeric argument, but a string value is
-passed instead.
-A runtime exception will occur when
-this statement is executed.
-</p>
\ No newline at end of file
+++ /dev/null
-<p>
-One of the arguments is uncompatible with the corresponding format string specifier.
-As a result, this will generate a runtime exception when executed.
-For example, <code>String.format("%d", "1")</code> will generate an exception, since
-the String "1" is incompatible with the format specifier %d.
-</p>
\ No newline at end of file
+++ /dev/null
-<p>
-One of the arguments being formatted with a format string is an array. This will be formatted
-using a fairly useless format, such as [I@304282, which doesn't actually show the contents
-of the array.
-Consider wrapping the array using <code>Arrays.asList(...)</code> before handling it off to a formatted.
-</p>
\ No newline at end of file
+++ /dev/null
-<p>
-An argument not of type Boolean is being formatted with a %b format specifier. This won't throw an
-exception; instead, it will print true for any nonnull value, and false for null.
-This feature of format strings is strange, and may not be what you intended.
-</p>
\ No newline at end of file
+++ /dev/null
-A method is called that expects a Java printf format string and a list of arguments. However, the format string doesn't contain any format specifiers (e.g., %s) but does contain message format elements (e.g., {0}). It is likely that the code is supplying a MessageFormat string when a printf-style format string is required. At runtime, all of the arguments will be ignored and the format string will be returned exactly as provided without any formatting.
\ No newline at end of file
+++ /dev/null
-<p>
-A format-string method with a variable number of arguments is called,
-but more arguments are passed than are actually used by the format string.
-This won't cause a runtime exception, but the code may be silently omitting
-information that was intended to be included in the formatted string.
-</p>
\ No newline at end of file
+++ /dev/null
-<p>
-The format string is syntactically invalid,
-and a runtime exception will occur when
-this statement is executed.
-</p>
\ No newline at end of file
+++ /dev/null
-<p>
-Not enough arguments are passed to satisfy a placeholder in the format string.
-A runtime exception will occur when
-this statement is executed.
-</p>
\ No newline at end of file
+++ /dev/null
-<p>
-The format string specifies a relative index to request that the argument for the previous format specifier
-be reused. However, there is no previous argument.
-For example,
-</p>
-<p><code>formatter.format("%<s %s", "a", "b")</code>
-</p>
-<p>would throw a MissingFormatArgumentException when executed.
-</p>
\ No newline at end of file
+++ /dev/null
-<p>This format string include a newline character (\n). In format strings, it is generally preferable
-better to use %n, which will produce the platform-specific line separator.</p>
\ No newline at end of file
+++ /dev/null
-<p>
-This code passes a primitive array to a function that takes a variable number of object arguments.
-This creates an array of length one to hold the primitive array and passes it to the function.
-</p>
\ No newline at end of file
+++ /dev/null
-<p>This code increments a volatile field. Increments of volatile fields aren't atomic. If more
-than one thread is incrementing the field at the same time, increments could be lost. </p>
\ No newline at end of file
+++ /dev/null
-<p>This declares a volatile reference to an array, which might not be what
-you want. With a volatile reference to an array, reads and writes of
-the reference to the array are treated as volatile, but the array elements
-are non-volatile. To get volatile array elements, you will need to use
-one of the atomic array classes in java.util.concurrent (provided
-in Java 5.0).</p>
\ No newline at end of file
+++ /dev/null
-<p> This method contains a call to <code>java.util.concurrent.await()</code>
- (or variants)
- which is not in a loop. If the object is used for multiple conditions,
- the condition the caller intended to wait for might not be the one
- that actually occurred.</p>
\ No newline at end of file
+++ /dev/null
-<p> This method contains a call to <code>java.lang.Object.wait()</code>
- which is not in a loop. If the monitor is used for multiple conditions,
- the condition the caller intended to wait for might not be the one
- that actually occurred.</p>
\ No newline at end of file
+++ /dev/null
-<p>
- This instance method synchronizes on <code>this.getClass()</code>. If this class is subclassed,
- subclasses will synchronize on the class object for the subclass, which isn't likely what was intended.
- For example, consider this code from java.awt.Label:
- <pre>
- private static final String base = "label";
- private static int nameCounter = 0;
- String constructComponentName() {
- synchronized (getClass()) {
- return base + nameCounter++;
- }
- }
- </pre></p>
- <p>Subclasses of <code>Label</code> won't synchronize on the same subclass, giving rise to a datarace.
- Instead, this code should be synchronizing on <code>Label.class</code>
- <pre>
- private static final String base = "label";
- private static int nameCounter = 0;
- String constructComponentName() {
- synchronized (Label.class) {
- return base + nameCounter++;
- }
- }
- </pre></p>
- <p>Bug pattern contributed by Jason Mehrens</p>
\ No newline at end of file
+++ /dev/null
-<p> This method accesses the value of a Map entry, using a key that was retrieved from
-a keySet iterator. It is more efficient to use an iterator on the entrySet of the map, to avoid the
-Map.get(key) lookup.</p>
\ No newline at end of file
+++ /dev/null
-<p> This class has a <code>writeObject()</code> method which is synchronized;
- however, no other method of the class is synchronized.</p>
\ No newline at end of file
+++ /dev/null
-<p>
- This method allocates a specific implementation of an xml interface. It is preferable to use
- the supplied factory classes to create these objects so that the implementation can be
- changed at runtime. See
- </p>
- <ul>
- <li>javax.xml.parsers.DocumentBuilderFactory</li>
- <li>javax.xml.parsers.SAXParserFactory</li>
- <li>javax.xml.transform.TransformerFactory</li>
- <li>org.w3c.dom.Document.create<i>XXXX</i></li>
- </ul>
- <p>for details.</p>
\ No newline at end of file
+++ /dev/null
-<p>This code directly writes an HTTP parameter to JSP output, which allows for a cross site scripting
-vulnerability. See <a href="http://en.wikipedia.org/wiki/Cross-site_scripting">http://en.wikipedia.org/wiki/Cross-site_scripting</a>
-for more information.</p>
-<p>FindBugs looks only for the most blatant, obvious cases of cross site scripting.
-If FindBugs found <em>any</em>, you <em>almost certainly</em> have more cross site scripting
-vulnerabilities that FindBugs doesn't report. If you are concerned about cross site scripting, you should seriously
-consider using a commercial static analysis or pen-testing tool.
-</p>
\ No newline at end of file
+++ /dev/null
-<p>This code directly writes an HTTP parameter to a Server error page (using HttpServletResponse.sendError). Echoing this untrusted input allows
-for a reflected cross site scripting
-vulnerability. See <a href="http://en.wikipedia.org/wiki/Cross-site_scripting">http://en.wikipedia.org/wiki/Cross-site_scripting</a>
-for more information.</p>
-<p>FindBugs looks only for the most blatant, obvious cases of cross site scripting.
-If FindBugs found <em>any</em>, you <em>almost certainly</em> have more cross site scripting
-vulnerabilities that FindBugs doesn't report. If you are concerned about cross site scripting, you should seriously
-consider using a commercial static analysis or pen-testing tool.
-</p>
\ No newline at end of file
+++ /dev/null
-<p>This code directly writes an HTTP parameter to Servlet output, which allows for a reflected cross site scripting
-vulnerability. See <a href="http://en.wikipedia.org/wiki/Cross-site_scripting">http://en.wikipedia.org/wiki/Cross-site_scripting</a>
-for more information.</p>
-<p>FindBugs looks only for the most blatant, obvious cases of cross site scripting.
-If FindBugs found <em>any</em>, you <em>almost certainly</em> have more cross site scripting
-vulnerabilities that FindBugs doesn't report. If you are concerned about cross site scripting, you should seriously
-consider using a commercial static analysis or pen-testing tool.
-</p>
\ No newline at end of file
+++ /dev/null
-findbugs.version=${findbugs.version}
+++ /dev/null
-<?xml version="1.0" encoding="UTF-8"?>
-<!-- Generated by Sonar -->
-<FindBugsFilter>
- <Match>
- <Bug pattern="SA_LOCAL_SELF_COMPARISON"/>
- </Match>
- <Match>
- <Bug pattern="UG_SYNC_SET_UNSYNC_GET"/>
- </Match>
- <Match>
- <Bug pattern="IC_SUPERCLASS_USES_SUBCLASS_DURING_INITIALIZATION"/>
- </Match>
- <Match>
- <Bug pattern="NM_FIELD_NAMING_CONVENTION"/>
- </Match>
- <Match>
- <Bug pattern="BC_IMPOSSIBLE_DOWNCAST"/>
- </Match>
- <Match>
- <Bug pattern="SA_FIELD_SELF_COMPUTATION"/>
- </Match>
- <Match>
- <Bug pattern="EQ_CHECK_FOR_OPERAND_NOT_COMPATIBLE_WITH_THIS"/>
- </Match>
- <Match>
- <Bug pattern="TQ_MAYBE_SOURCE_VALUE_REACHES_NEVER_SINK"/>
- </Match>
- <Match>
- <Bug pattern="NO_NOTIFY_NOT_NOTIFYALL"/>
- </Match>
- <Match>
- <Bug pattern="VA_FORMAT_STRING_BAD_ARGUMENT"/>
- </Match>
- <Match>
- <Bug pattern="UPM_UNCALLED_PRIVATE_METHOD"/>
- </Match>
- <Match>
- <Bug pattern="SF_DEAD_STORE_DUE_TO_SWITCH_FALLTHROUGH"/>
- </Match>
- <Match>
- <Bug pattern="SF_DEAD_STORE_DUE_TO_SWITCH_FALLTHROUGH_TO_THROW"/>
- </Match>
- <Match>
- <Bug pattern="EQ_COMPARETO_USE_OBJECT_EQUALS"/>
- </Match>
- <Match>
- <Bug pattern="LI_LAZY_INIT_UPDATE_STATIC"/>
- </Match>
- <Match>
- <Bug pattern="SE_NONLONG_SERIALVERSIONID"/>
- </Match>
- <Match>
- <Bug pattern="DMI_THREAD_PASSED_WHERE_RUNNABLE_EXPECTED"/>
- </Match>
- <Match>
- <Bug pattern="ODR_OPEN_DATABASE_RESOURCE"/>
- </Match>
- <Match>
- <Bug pattern="RC_REF_COMPARISON_BAD_PRACTICE"/>
- </Match>
- <Match>
- <Bug pattern="NM_LCASE_HASHCODE"/>
- </Match>
- <Match>
- <Bug pattern="VO_VOLATILE_REFERENCE_TO_ARRAY"/>
- </Match>
- <Match>
- <Bug pattern="XSS_REQUEST_PARAMETER_TO_JSP_WRITER"/>
- </Match>
- <Match>
- <Bug pattern="DM_NUMBER_CTOR"/>
- </Match>
- <Match>
- <Bug pattern="ITA_INEFFICIENT_TO_ARRAY"/>
- </Match>
- <Match>
- <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE"/>
- </Match>
- <Match>
- <Bug pattern="IJU_TEARDOWN_NO_SUPER"/>
- </Match>
- <Match>
- <Bug pattern="SIC_INNER_SHOULD_BE_STATIC"/>
- </Match>
- <Match>
- <Bug pattern="NM_BAD_EQUAL"/>
- </Match>
- <Match>
- <Bug pattern="DM_BOXED_PRIMITIVE_TOSTRING"/>
- </Match>
- <Match>
- <Bug pattern="IJU_SUITE_NOT_STATIC"/>
- </Match>
- <Match>
- <Bug pattern="IM_MULTIPLYING_RESULT_OF_IREM"/>
- </Match>
- <Match>
- <Bug pattern="HE_HASHCODE_USE_OBJECT_EQUALS"/>
- </Match>
- <Match>
- <Bug pattern="IL_CONTAINER_ADDED_TO_ITSELF"/>
- </Match>
- <Match>
- <Bug pattern="ES_COMPARING_PARAMETER_STRING_WITH_EQ"/>
- </Match>
- <Match>
- <Bug pattern="VA_FORMAT_STRING_BAD_CONVERSION"/>
- </Match>
- <Match>
- <Bug pattern="SR_NOT_CHECKED"/>
- </Match>
- <Match>
- <Bug pattern="DB_DUPLICATE_SWITCH_CLAUSES"/>
- </Match>
- <Match>
- <Bug pattern="NP_NULL_PARAM_DEREF_NONVIRTUAL"/>
- </Match>
- <Match>
- <Bug pattern="IP_PARAMETER_IS_DEAD_BUT_OVERWRITTEN"/>
- </Match>
- <Match>
- <Bug pattern="RV_RETURN_VALUE_IGNORED"/>
- </Match>
- <Match>
- <Bug pattern="RV_EXCEPTION_NOT_THROWN"/>
- </Match>
- <Match>
- <Bug pattern="DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED"/>
- </Match>
- <Match>
- <Bug pattern="CO_SELF_NO_OBJECT"/>
- </Match>
- <Match>
- <Bug pattern="MS_MUTABLE_ARRAY"/>
- </Match>
- <Match>
- <Bug pattern="DM_CONVERT_CASE"/>
- </Match>
- <Match>
- <Bug pattern="INT_VACUOUS_COMPARISON"/>
- </Match>
- <Match>
- <Bug pattern="UW_UNCOND_WAIT"/>
- </Match>
- <Match>
- <Bug pattern="MS_FINAL_PKGPROTECT"/>
- </Match>
- <Match>
- <Bug pattern="NP_BOOLEAN_RETURN_NULL"/>
- </Match>
- <Match>
- <Bug pattern="DL_SYNCHRONIZATION_ON_UNSHARED_BOXED_PRIMITIVE"/>
- </Match>
- <Match>
- <Bug pattern="TQ_MAYBE_SOURCE_VALUE_REACHES_ALWAYS_SINK"/>
- </Match>
- <Match>
- <Bug pattern="DM_GC"/>
- </Match>
- <Match>
- <Bug pattern="DMI_RANDOM_USED_ONLY_ONCE"/>
- </Match>
- <Match>
- <Bug pattern="BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION"/>
- </Match>
- <Match>
- <Bug pattern="BIT_SIGNED_CHECK_HIGH_BIT"/>
- </Match>
- <Match>
- <Bug pattern="DL_SYNCHRONIZATION_ON_BOXED_PRIMITIVE"/>
- </Match>
- <Match>
- <Bug pattern="DE_MIGHT_DROP"/>
- </Match>
- <Match>
- <Bug pattern="RV_DONT_JUST_NULL_CHECK_READLINE"/>
- </Match>
- <Match>
- <Bug pattern="RV_CHECK_FOR_POSITIVE_INDEXOF"/>
- </Match>
- <Match>
- <Bug pattern="URF_UNREAD_FIELD"/>
- </Match>
- <Match>
- <Bug pattern="DMI_USELESS_SUBSTRING"/>
- </Match>
- <Match>
- <Bug pattern="DM_MONITOR_WAIT_ON_CONDITION"/>
- </Match>
- <Match>
- <Bug pattern="NP_NULL_INSTANCEOF"/>
- </Match>
- <Match>
- <Bug pattern="MS_PKGPROTECT"/>
- </Match>
- <Match>
- <Bug pattern="TQ_EXPLICIT_UNKNOWN_SOURCE_VALUE_REACHES_NEVER_SINK"/>
- </Match>
- <Match>
- <Bug pattern="NP_LOAD_OF_KNOWN_NULL_VALUE"/>
- </Match>
- <Match>
- <Bug pattern="EQ_OVERRIDING_EQUALS_NOT_SYMMETRIC"/>
- </Match>
- <Match>
- <Bug pattern="EC_UNRELATED_INTERFACES"/>
- </Match>
- <Match>
- <Bug pattern="SWL_SLEEP_WITH_LOCK_HELD"/>
- </Match>
- <Match>
- <Bug pattern="DM_FP_NUMBER_CTOR"/>
- </Match>
- <Match>
- <Bug pattern="FI_PUBLIC_SHOULD_BE_PROTECTED"/>
- </Match>
- <Match>
- <Bug pattern="STI_INTERRUPTED_ON_CURRENTTHREAD"/>
- </Match>
- <Match>
- <Bug pattern="SE_COMPARATOR_SHOULD_BE_SERIALIZABLE"/>
- </Match>
- <Match>
- <Bug pattern="DE_MIGHT_IGNORE"/>
- </Match>
- <Match>
- <Bug pattern="BIT_SIGNED_CHECK"/>
- </Match>
- <Match>
- <Bug pattern="DMI_BAD_MONTH"/>
- </Match>
- <Match>
- <Bug pattern="UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR"/>
- </Match>
- <Match>
- <Bug pattern="FI_MISSING_SUPER_CALL"/>
- </Match>
- <Match>
- <Bug pattern="EQ_OTHER_NO_OBJECT"/>
- </Match>
- <Match>
- <Bug pattern="IJU_SETUP_NO_SUPER"/>
- </Match>
- <Match>
- <Bug pattern="NP_NONNULL_PARAM_VIOLATION"/>
- </Match>
- <Match>
- <Bug pattern="SQL_BAD_PREPARED_STATEMENT_ACCESS"/>
- </Match>
- <Match>
- <Bug pattern="EQ_UNUSUAL"/>
- </Match>
- <Match>
- <Bug pattern="FI_EMPTY"/>
- </Match>
- <Match>
- <Bug pattern="NP_CLOSING_NULL"/>
- </Match>
- <Match>
- <Bug pattern="UWF_NULL_FIELD"/>
- </Match>
- <Match>
- <Bug pattern="SE_TRANSIENT_FIELD_OF_NONSERIALIZABLE_CLASS"/>
- </Match>
- <Match>
- <Bug pattern="NN_NAKED_NOTIFY"/>
- </Match>
- <Match>
- <Bug pattern="OS_OPEN_STREAM"/>
- </Match>
- <Match>
- <Bug pattern="HE_USE_OF_UNHASHABLE_CLASS"/>
- </Match>
- <Match>
- <Bug pattern="NM_SAME_SIMPLE_NAME_AS_SUPERCLASS"/>
- </Match>
- <Match>
- <Bug pattern="EQ_ABSTRACT_SELF"/>
- </Match>
- <Match>
- <Bug pattern="J2EE_STORE_OF_NON_SERIALIZABLE_OBJECT_INTO_SESSION"/>
- </Match>
- <Match>
- <Bug pattern="TQ_EXPLICIT_UNKNOWN_SOURCE_VALUE_REACHES_ALWAYS_SINK"/>
- </Match>
- <Match>
- <Bug pattern="RCN_REDUNDANT_COMPARISON_TWO_NULL_VALUES"/>
- </Match>
- <Match>
- <Bug pattern="SIC_INNER_SHOULD_BE_STATIC_ANON"/>
- </Match>
- <Match>
- <Bug pattern="JCIP_FIELD_ISNT_FINAL_IN_IMMUTABLE_CLASS"/>
- </Match>
- <Match>
- <Bug pattern="EQ_SELF_USE_OBJECT"/>
- </Match>
- <Match>
- <Bug pattern="NM_CLASS_NOT_EXCEPTION"/>
- </Match>
- <Match>
- <Bug pattern="QBA_QUESTIONABLE_BOOLEAN_ASSIGNMENT"/>
- </Match>
- <Match>
- <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE"/>
- </Match>
- <Match>
- <Bug pattern="SE_METHOD_MUST_BE_PRIVATE"/>
- </Match>
- <Match>
- <Bug pattern="BC_IMPOSSIBLE_INSTANCEOF"/>
- </Match>
- <Match>
- <Bug pattern="EC_ARRAY_AND_NONARRAY"/>
- </Match>
- <Match>
- <Bug pattern="FI_EXPLICIT_INVOCATION"/>
- </Match>
- <Match>
- <Bug pattern="SS_SHOULD_BE_STATIC"/>
- </Match>
- <Match>
- <Bug pattern="BIT_IOR"/>
- </Match>
- <Match>
- <Bug pattern="SE_NONFINAL_SERIALVERSIONID"/>
- </Match>
- <Match>
- <Bug pattern="MS_SHOULD_BE_FINAL"/>
- </Match>
- <Match>
- <Bug pattern="EQ_DONT_DEFINE_EQUALS_FOR_ENUM"/>
- </Match>
- <Match>
- <Bug pattern="SE_TRANSIENT_FIELD_NOT_RESTORED"/>
- </Match>
- <Match>
- <Bug pattern="VA_FORMAT_STRING_EXTRA_ARGUMENTS_PASSED"/>
- </Match>
- <Match>
- <Bug pattern="EQ_ALWAYS_FALSE"/>
- </Match>
- <Match>
- <Bug pattern="EI_EXPOSE_REP2"/>
- </Match>
- <Match>
- <Bug pattern="RV_REM_OF_RANDOM_INT"/>
- </Match>
- <Match>
- <Bug pattern="INT_VACUOUS_BIT_OPERATION"/>
- </Match>
- <Match>
- <Bug pattern="SF_SWITCH_NO_DEFAULT"/>
- </Match>
- <Match>
- <Bug pattern="IL_INFINITE_LOOP"/>
- </Match>
- <Match>
- <Bug pattern="NP_NULL_PARAM_DEREF"/>
- </Match>
- <Match>
- <Bug pattern="AM_CREATES_EMPTY_JAR_FILE_ENTRY"/>
- </Match>
- <Match>
- <Bug pattern="EQ_COMPARING_CLASS_NAMES"/>
- </Match>
- <Match>
- <Bug pattern="NP_ALWAYS_NULL_EXCEPTION"/>
- </Match>
- <Match>
- <Bug pattern="DB_DUPLICATE_BRANCHES"/>
- </Match>
- <Match>
- <Bug pattern="IMSE_DONT_CATCH_IMSE"/>
- </Match>
- <Match>
- <Bug pattern="XSS_REQUEST_PARAMETER_TO_SERVLET_WRITER"/>
- </Match>
- <Match>
- <Bug pattern="DM_STRING_CTOR"/>
- </Match>
- <Match>
- <Bug pattern="SE_NO_SERIALVERSIONID"/>
- </Match>
- <Match>
- <Bug pattern="SE_BAD_FIELD_STORE"/>
- </Match>
- <Match>
- <Bug pattern="EC_UNRELATED_TYPES_USING_POINTER_EQUALITY"/>
- </Match>
- <Match>
- <Bug pattern="SE_NO_SUITABLE_CONSTRUCTOR_FOR_EXTERNALIZATION"/>
- </Match>
- <Match>
- <Bug pattern="DMI_HARDCODED_ABSOLUTE_FILENAME"/>
- </Match>
- <Match>
- <Bug pattern="RU_INVOKE_RUN"/>
- </Match>
- <Match>
- <Bug pattern="SQL_BAD_RESULTSET_ACCESS"/>
- </Match>
- <Match>
- <Bug pattern="IJU_ASSERT_METHOD_INVOKED_FROM_RUN_METHOD"/>
- </Match>
- <Match>
- <Bug pattern="BX_BOXING_IMMEDIATELY_UNBOXED"/>
- </Match>
- <Match>
- <Bug pattern="VA_FORMAT_STRING_BAD_CONVERSION_FROM_ARRAY"/>
- </Match>
- <Match>
- <Bug pattern="HE_HASHCODE_NO_EQUALS"/>
- </Match>
- <Match>
- <Bug pattern="SI_INSTANCE_BEFORE_FINALS_ASSIGNED"/>
- </Match>
- <Match>
- <Bug pattern="UI_INHERITANCE_UNSAFE_GETRESOURCE"/>
- </Match>
- <Match>
- <Bug pattern="NP_SYNC_AND_NULL_CHECK_FIELD"/>
- </Match>
- <Match>
- <Bug pattern="RpC_REPEATED_CONDITIONAL_TEST"/>
- </Match>
- <Match>
- <Bug pattern="DLS_DEAD_LOCAL_STORE_IN_RETURN"/>
- </Match>
- <Match>
- <Bug pattern="EC_UNRELATED_CLASS_AND_INTERFACE"/>
- </Match>
- <Match>
- <Bug pattern="RE_CANT_USE_FILE_SEPARATOR_AS_REGULAR_EXPRESSION"/>
- </Match>
- <Match>
- <Bug pattern="HE_INHERITS_EQUALS_USE_HASHCODE"/>
- </Match>
- <Match>
- <Bug pattern="NP_DEREFERENCE_OF_READLINE_VALUE"/>
- </Match>
- <Match>
- <Bug pattern="WA_NOT_IN_LOOP"/>
- </Match>
- <Match>
- <Bug pattern="BC_IMPOSSIBLE_CAST"/>
- </Match>
- <Match>
- <Bug pattern="OS_OPEN_STREAM_EXCEPTION_PATH"/>
- </Match>
- <Match>
- <Bug pattern="ICAST_QUESTIONABLE_UNSIGNED_RIGHT_SHIFT"/>
- </Match>
- <Match>
- <Bug pattern="NP_NULL_ON_SOME_PATH_EXCEPTION"/>
- </Match>
- <Match>
- <Bug pattern="DMI_ANNOTATION_IS_NOT_VISIBLE_TO_REFLECTION"/>
- </Match>
- <Match>
- <Bug pattern="IC_INIT_CIRCULARITY"/>
- </Match>
- <Match>
- <Bug pattern="UM_UNNECESSARY_MATH"/>
- </Match>
- <Match>
- <Bug pattern="NM_CLASS_NAMING_CONVENTION"/>
- </Match>
- <Match>
- <Bug pattern="STCAL_STATIC_CALENDAR_INSTANCE"/>
- </Match>
- <Match>
- <Bug pattern="NP_ALWAYS_NULL"/>
- </Match>
- <Match>
- <Bug pattern="RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE"/>
- </Match>
- <Match>
- <Bug pattern="NP_GUARANTEED_DEREF_ON_EXCEPTION_PATH"/>
- </Match>
- <Match>
- <Bug pattern="UUF_UNUSED_FIELD"/>
- </Match>
- <Match>
- <Bug pattern="EQ_DOESNT_OVERRIDE_EQUALS"/>
- </Match>
- <Match>
- <Bug pattern="INT_BAD_COMPARISON_WITH_SIGNED_BYTE"/>
- </Match>
- <Match>
- <Bug pattern="NP_CLONE_COULD_RETURN_NULL"/>
- </Match>
- <Match>
- <Bug pattern="HE_EQUALS_NO_HASHCODE"/>
- </Match>
- <Match>
- <Bug pattern="IS_FIELD_NOT_GUARDED"/>
- </Match>
- <Match>
- <Bug pattern="NM_LCASE_TOSTRING"/>
- </Match>
- <Match>
- <Bug pattern="NM_WRONG_PACKAGE"/>
- </Match>
- <Match>
- <Bug pattern="UCF_USELESS_CONTROL_FLOW"/>
- </Match>
- <Match>
- <Bug pattern="DM_USELESS_THREAD"/>
- </Match>
- <Match>
- <Bug pattern="DMI_USING_REMOVEALL_TO_CLEAR_COLLECTION"/>
- </Match>
- <Match>
- <Bug pattern="SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING"/>
- </Match>
- <Match>
- <Bug pattern="NP_EQUALS_SHOULD_HANDLE_NULL_ARGUMENT"/>
- </Match>
- <Match>
- <Bug pattern="ICAST_BAD_SHIFT_AMOUNT"/>
- </Match>
- <Match>
- <Bug pattern="ICAST_IDIV_CAST_TO_DOUBLE"/>
- </Match>
- <Match>
- <Bug pattern="FI_NULLIFY_SUPER"/>
- </Match>
- <Match>
- <Bug pattern="MS_MUTABLE_HASHTABLE"/>
- </Match>
- <Match>
- <Bug pattern="SE_READ_RESOLVE_MUST_RETURN_OBJECT"/>
- </Match>
- <Match>
- <Bug pattern="SIO_SUPERFLUOUS_INSTANCEOF"/>
- </Match>
- <Match>
- <Bug pattern="BOA_BADLY_OVERRIDDEN_ADAPTER"/>
- </Match>
- <Match>
- <Bug pattern="IM_AVERAGE_COMPUTATION_COULD_OVERFLOW"/>
- </Match>
- <Match>
- <Bug pattern="DM_NEW_FOR_GETCLASS"/>
- </Match>
- <Match>
- <Bug pattern="NM_CONFUSING"/>
- </Match>
- <Match>
- <Bug pattern="WMI_WRONG_MAP_ITERATOR"/>
- </Match>
- <Match>
- <Bug pattern="NP_UNWRITTEN_FIELD"/>
- </Match>
- <Match>
- <Bug pattern="SE_BAD_FIELD_INNER_CLASS"/>
- </Match>
- <Match>
- <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE"/>
- </Match>
- <Match>
- <Bug pattern="UCF_USELESS_CONTROL_FLOW_NEXT_LINE"/>
- </Match>
- <Match>
- <Bug pattern="NP_GUARANTEED_DEREF"/>
- </Match>
- <Match>
- <Bug pattern="EI_EXPOSE_STATIC_REP2"/>
- </Match>
- <Match>
- <Bug pattern="NM_FUTURE_KEYWORD_USED_AS_MEMBER_IDENTIFIER"/>
- </Match>
- <Match>
- <Bug pattern="WA_AWAIT_NOT_IN_LOOP"/>
- </Match>
- <Match>
- <Bug pattern="RC_REF_COMPARISON"/>
- </Match>
- <Match>
- <Bug pattern="SC_START_IN_CTOR"/>
- </Match>
- <Match>
- <Bug pattern="MF_CLASS_MASKS_FIELD"/>
- </Match>
- <Match>
- <Bug pattern="PZLA_PREFER_ZERO_LENGTH_ARRAYS"/>
- </Match>
- <Match>
- <Bug pattern="PS_PUBLIC_SEMAPHORES"/>
- </Match>
- <Match>
- <Bug pattern="DMI_INVOKING_HASHCODE_ON_ARRAY"/>
- </Match>
- <Match>
- <Bug pattern="SKIPPED_CLASS_TOO_BIG"/>
- </Match>
- <Match>
- <Bug pattern="UR_UNINIT_READ_CALLED_FROM_SUPER_CONSTRUCTOR"/>
- </Match>
- <Match>
- <Bug pattern="HSC_HUGE_SHARED_STRING_CONSTANT"/>
- </Match>
- <Match>
- <Bug pattern="SA_LOCAL_SELF_COMPUTATION"/>
- </Match>
- <Match>
- <Bug pattern="VA_FORMAT_STRING_ILLEGAL"/>
- </Match>
- <Match>
- <Bug pattern="SE_NO_SUITABLE_CONSTRUCTOR"/>
- </Match>
- <Match>
- <Bug pattern="MWN_MISMATCHED_NOTIFY"/>
- </Match>
- <Match>
- <Bug pattern="NP_NULL_PARAM_DEREF_ALL_TARGETS_DANGEROUS"/>
- </Match>
- <Match>
- <Bug pattern="STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE"/>
- </Match>
- <Match>
- <Bug pattern="SE_READ_RESOLVE_IS_STATIC"/>
- </Match>
- <Match>
- <Bug pattern="SA_LOCAL_DOUBLE_ASSIGNMENT"/>
- </Match>
- <Match>
- <Bug pattern="DP_DO_INSIDE_DO_PRIVILEGED"/>
- </Match>
- <Match>
- <Bug pattern="RV_RETURN_VALUE_IGNORED2"/>
- </Match>
- <Match>
- <Bug pattern="RI_REDUNDANT_INTERFACES"/>
- </Match>
- <Match>
- <Bug pattern="MTIA_SUSPECT_SERVLET_INSTANCE_FIELD"/>
- </Match>
- <Match>
- <Bug pattern="FI_FINALIZER_ONLY_NULLS_FIELDS"/>
- </Match>
- <Match>
- <Bug pattern="NM_VERY_CONFUSING"/>
- </Match>
- <Match>
- <Bug pattern="VA_FORMAT_STRING_NO_PREVIOUS_ARGUMENT"/>
- </Match>
- <Match>
- <Bug pattern="IO_APPENDING_TO_OBJECT_OUTPUT_STREAM"/>
- </Match>
- <Match>
- <Bug pattern="DM_RUN_FINALIZERS_ON_EXIT"/>
- </Match>
- <Match>
- <Bug pattern="STCAL_STATIC_SIMPLE_DATE_FORMAT_INSTANCE"/>
- </Match>
- <Match>
- <Bug pattern="FI_FINALIZER_NULLS_FIELDS"/>
- </Match>
- <Match>
- <Bug pattern="FE_TEST_IF_EQUAL_TO_NOT_A_NUMBER"/>
- </Match>
- <Match>
- <Bug pattern="DMI_UNSUPPORTED_METHOD"/>
- </Match>
- <Match>
- <Bug pattern="TLW_TWO_LOCK_WAIT"/>
- </Match>
- <Match>
- <Bug pattern="DMI_CONSTANT_DB_PASSWORD"/>
- </Match>
- <Match>
- <Bug pattern="RV_01_TO_INT"/>
- </Match>
- <Match>
- <Bug pattern="IA_AMBIGUOUS_INVOCATION_OF_INHERITED_OR_OUTER_METHOD"/>
- </Match>
- <Match>
- <Bug pattern="DMI_COLLECTION_OF_URLS"/>
- </Match>
- <Match>
- <Bug pattern="BIT_AND_ZZ"/>
- </Match>
- <Match>
- <Bug pattern="DM_STRING_VOID_CTOR"/>
- </Match>
- <Match>
- <Bug pattern="UL_UNRELEASED_LOCK"/>
- </Match>
- <Match>
- <Bug pattern="NM_METHOD_NAMING_CONVENTION"/>
- </Match>
- <Match>
- <Bug pattern="HRS_REQUEST_PARAMETER_TO_HTTP_HEADER"/>
- </Match>
- <Match>
- <Bug pattern="CN_IMPLEMENTS_CLONE_BUT_NOT_CLONEABLE"/>
- </Match>
- <Match>
- <Bug pattern="SIC_THREADLOCAL_DEADLY_EMBRACE"/>
- </Match>
- <Match>
- <Bug pattern="DL_SYNCHRONIZATION_ON_SHARED_CONSTANT"/>
- </Match>
- <Match>
- <Bug pattern="MF_METHOD_MASKS_FIELD"/>
- </Match>
- <Match>
- <Bug pattern="NM_WRONG_PACKAGE_INTENTIONAL"/>
- </Match>
- <Match>
- <Bug pattern="INT_BAD_REM_BY_1"/>
- </Match>
- <Match>
- <Bug pattern="ES_COMPARING_STRINGS_WITH_EQ"/>
- </Match>
- <Match>
- <Bug pattern="SA_FIELD_SELF_COMPARISON"/>
- </Match>
- <Match>
- <Bug pattern="QF_QUESTIONABLE_FOR_LOOP"/>
- </Match>
- <Match>
- <Bug pattern="VA_FORMAT_STRING_BAD_CONVERSION_TO_BOOLEAN"/>
- </Match>
- <Match>
- <Bug pattern="XFB_XML_FACTORY_BYPASS"/>
- </Match>
- <Match>
- <Bug pattern="SE_INNER_CLASS"/>
- </Match>
- <Match>
- <Bug pattern="CI_CONFUSED_INHERITANCE"/>
- </Match>
- <Match>
- <Bug pattern="UWF_UNWRITTEN_FIELD"/>
- </Match>
- <Match>
- <Bug pattern="WS_WRITEOBJECT_SYNC"/>
- </Match>
- <Match>
- <Bug pattern="CN_IDIOM_NO_SUPER_CALL"/>
- </Match>
- <Match>
- <Bug pattern="DLS_DEAD_STORE_OF_CLASS_LITERAL"/>
- </Match>
- <Match>
- <Bug pattern="BC_EQUALS_METHOD_SHOULD_WORK_FOR_ALL_OBJECTS"/>
- </Match>
- <Match>
- <Bug pattern="FI_USELESS"/>
- </Match>
- <Match>
- <Bug pattern="NM_METHOD_CONSTRUCTOR_CONFUSION"/>
- </Match>
- <Match>
- <Bug pattern="ML_SYNC_ON_FIELD_TO_GUARD_CHANGING_THAT_FIELD"/>
- </Match>
- <Match>
- <Bug pattern="MWN_MISMATCHED_WAIT"/>
- </Match>
- <Match>
- <Bug pattern="ML_SYNC_ON_UPDATED_FIELD"/>
- </Match>
- <Match>
- <Bug pattern="FL_MATH_USING_FLOAT_PRECISION"/>
- </Match>
- <Match>
- <Bug pattern="DM_NEXTINT_VIA_NEXTDOUBLE"/>
- </Match>
- <Match>
- <Bug pattern="VA_FORMAT_STRING_EXPECTED_MESSAGE_FORMAT_SUPPLIED"/>
- </Match>
- <Match>
- <Bug pattern="DMI_NONSERIALIZABLE_OBJECT_WRITTEN"/>
- </Match>
- <Match>
- <Bug pattern="MTIA_SUSPECT_STRUTS_INSTANCE_FIELD"/>
- </Match>
- <Match>
- <Bug pattern="EQ_OTHER_USE_OBJECT"/>
- </Match>
- <Match>
- <Bug pattern="RCN_REDUNDANT_COMPARISON_OF_NULL_AND_NONNULL_VALUE"/>
- </Match>
- <Match>
- <Bug pattern="DLS_DEAD_LOCAL_STORE_OF_NULL"/>
- </Match>
- <Match>
- <Bug pattern="DMI_BLOCKING_METHODS_ON_URL"/>
- </Match>
- <Match>
- <Bug pattern="MS_CANNOT_BE_FINAL"/>
- </Match>
- <Match>
- <Bug pattern="NP_NULL_ON_SOME_PATH_MIGHT_BE_INFEASIBLE"/>
- </Match>
- <Match>
- <Bug pattern="NP_STORE_INTO_NONNULL_FIELD"/>
- </Match>
- <Match>
- <Bug pattern="DMI_INVOKING_TOSTRING_ON_ANONYMOUS_ARRAY"/>
- </Match>
- <Match>
- <Bug pattern="IM_BAD_CHECK_FOR_ODD"/>
- </Match>
- <Match>
- <Bug pattern="NM_VERY_CONFUSING_INTENTIONAL"/>
- </Match>
- <Match>
- <Bug pattern="SP_SPIN_ON_FIELD"/>
- </Match>
- <Match>
- <Bug pattern="IS2_INCONSISTENT_SYNC"/>
- </Match>
- <Match>
- <Bug pattern="ICAST_INT_CAST_TO_DOUBLE_PASSED_TO_CEIL"/>
- </Match>
- <Match>
- <Bug pattern="ODR_OPEN_DATABASE_RESOURCE_EXCEPTION_PATH"/>
- </Match>
- <Match>
- <Bug pattern="CN_IDIOM"/>
- </Match>
- <Match>
- <Bug pattern="DMI_SCHEDULED_THREAD_POOL_EXECUTOR_WITH_ZERO_CORE_THREADS"/>
- </Match>
- <Match>
- <Bug pattern="XSS_REQUEST_PARAMETER_TO_SEND_ERROR"/>
- </Match>
- <Match>
- <Bug pattern="GC_UNCHECKED_TYPE_IN_GENERIC_CALL"/>
- </Match>
- <Match>
- <Bug pattern="SE_PRIVATE_READ_RESOLVE_NOT_INHERITED"/>
- </Match>
- <Match>
- <Bug pattern="DMI_INVOKING_TOSTRING_ON_ARRAY"/>
- </Match>
- <Match>
- <Bug pattern="DL_SYNCHRONIZATION_ON_BOOLEAN"/>
- </Match>
- <Match>
- <Bug pattern="SW_SWING_METHODS_INVOKED_IN_SWING_THREAD"/>
- </Match>
- <Match>
- <Bug pattern="NP_ARGUMENT_MIGHT_BE_NULL"/>
- </Match>
- <Match>
- <Bug pattern="NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE"/>
- </Match>
- <Match>
- <Bug pattern="CO_ABSTRACT_SELF"/>
- </Match>
- <Match>
- <Bug pattern="DM_EXIT"/>
- </Match>
- <Match>
- <Bug pattern="RV_RETURN_VALUE_OF_PUTIFABSENT_IGNORED"/>
- </Match>
- <Match>
- <Bug pattern="DC_DOUBLECHECK"/>
- </Match>
- <Match>
- <Bug pattern="UL_UNRELEASED_LOCK_EXCEPTION_PATH"/>
- </Match>
- <Match>
- <Bug pattern="EC_BAD_ARRAY_COMPARE"/>
- </Match>
- <Match>
- <Bug pattern="SE_BAD_FIELD"/>
- </Match>
- <Match>
- <Bug pattern="SA_LOCAL_SELF_ASSIGNMENT"/>
- </Match>
- <Match>
- <Bug pattern="REC_CATCH_EXCEPTION"/>
- </Match>
- <Match>
- <Bug pattern="TQ_NEVER_VALUE_USED_WHERE_ALWAYS_REQUIRED"/>
- </Match>
- <Match>
- <Bug pattern="UR_UNINIT_READ"/>
- </Match>
- <Match>
- <Bug pattern="DMI_VACUOUS_SELF_COLLECTION_CALL"/>
- </Match>
- <Match>
- <Bug pattern="DMI_FUTILE_ATTEMPT_TO_CHANGE_MAXPOOL_SIZE_OF_SCHEDULED_THREAD_POOL_EXECUTOR"/>
- </Match>
- <Match>
- <Bug pattern="BIT_AND"/>
- </Match>
- <Match>
- <Bug pattern="RR_NOT_CHECKED"/>
- </Match>
- <Match>
- <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>
- </Match>
- <Match>
- <Bug pattern="EQ_SELF_NO_OBJECT"/>
- </Match>
- <Match>
- <Bug pattern="NP_TOSTRING_COULD_RETURN_NULL"/>
- </Match>
- <Match>
- <Bug pattern="DMI_COLLECTIONS_SHOULD_NOT_CONTAIN_THEMSELVES"/>
- </Match>
- <Match>
- <Bug pattern="GC_UNRELATED_TYPES"/>
- </Match>
- <Match>
- <Bug pattern="HE_SIGNATURE_DECLARES_HASHING_OF_UNHASHABLE_CLASS"/>
- </Match>
- <Match>
- <Bug pattern="EC_NULL_ARG"/>
- </Match>
- <Match>
- <Bug pattern="IL_INFINITE_RECURSIVE_LOOP"/>
- </Match>
- <Match>
- <Bug pattern="NP_NONNULL_RETURN_VIOLATION"/>
- </Match>
- <Match>
- <Bug pattern="DM_STRING_TOSTRING"/>
- </Match>
- <Match>
- <Bug pattern="AM_CREATES_EMPTY_ZIP_FILE_ENTRY"/>
- </Match>
- <Match>
- <Bug pattern="VA_PRIMITIVE_ARRAY_PASSED_TO_OBJECT_VARARG"/>
- </Match>
- <Match>
- <Bug pattern="NS_NON_SHORT_CIRCUIT"/>
- </Match>
- <Match>
- <Bug pattern="DM_BOOLEAN_CTOR"/>
- </Match>
- <Match>
- <Bug pattern="DLS_DEAD_LOCAL_STORE"/>
- </Match>
- <Match>
- <Bug pattern="BC_BAD_CAST_TO_CONCRETE_COLLECTION"/>
- </Match>
- <Match>
- <Bug pattern="SIC_INNER_SHOULD_BE_STATIC_NEEDS_THIS"/>
- </Match>
- <Match>
- <Bug pattern="LI_LAZY_INIT_STATIC"/>
- </Match>
- <Match>
- <Bug pattern="HE_EQUALS_USE_HASHCODE"/>
- </Match>
- <Match>
- <Bug pattern="RV_ABSOLUTE_VALUE_OF_RANDOM_INT"/>
- </Match>
- <Match>
- <Bug pattern="FE_FLOATING_POINT_EQUALITY"/>
- </Match>
- <Match>
- <Bug pattern="NM_FUTURE_KEYWORD_USED_AS_IDENTIFIER"/>
- </Match>
- <Match>
- <Bug pattern="ICAST_INTEGER_MULTIPLY_CAST_TO_LONG"/>
- </Match>
- <Match>
- <Bug pattern="NM_SAME_SIMPLE_NAME_AS_INTERFACE"/>
- </Match>
- <Match>
- <Bug pattern="STI_INTERRUPTED_ON_UNKNOWNTHREAD"/>
- </Match>
- <Match>
- <Bug pattern="SA_FIELD_SELF_ASSIGNMENT"/>
- </Match>
- <Match>
- <Bug pattern="DMI_EMPTY_DB_PASSWORD"/>
- </Match>
- <Match>
- <Bug pattern="IJU_BAD_SUITE_METHOD"/>
- </Match>
- <Match>
- <Bug pattern="VA_FORMAT_STRING_MISSING_ARGUMENT"/>
- </Match>
- <Match>
- <Bug pattern="BIT_ADD_OF_SIGNED_BYTE"/>
- </Match>
- <Match>
- <Bug pattern="SBSC_USE_STRINGBUFFER_CONCATENATION"/>
- </Match>
- <Match>
- <Bug pattern="WL_USING_GETCLASS_RATHER_THAN_CLASS_LITERAL"/>
- </Match>
- <Match>
- <Bug pattern="SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE"/>
- </Match>
- <Match>
- <Bug pattern="TQ_ALWAYS_VALUE_USED_WHERE_NEVER_REQUIRED"/>
- </Match>
- <Match>
- <Bug pattern="RE_BAD_SYNTAX_FOR_REGULAR_EXPRESSION"/>
- </Match>
- <Match>
- <Bug pattern="NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE"/>
- </Match>
- <Match>
- <Bug pattern="EQ_ALWAYS_TRUE"/>
- </Match>
- <Match>
- <Bug pattern="STCAL_INVOKE_ON_STATIC_CALENDAR_INSTANCE"/>
- </Match>
- <Match>
- <Bug pattern="ISC_INSTANTIATE_STATIC_CLASS"/>
- </Match>
- <Match>
- <Bug pattern="BC_BAD_CAST_TO_ABSTRACT_COLLECTION"/>
- </Match>
- <Match>
- <Bug pattern="IT_NO_SUCH_ELEMENT"/>
- </Match>
- <Match>
- <Bug pattern="EI_EXPOSE_REP"/>
- </Match>
- <Match>
- <Bug pattern="INT_BAD_COMPARISON_WITH_NONNEGATIVE_VALUE"/>
- </Match>
- <Match>
- <Bug pattern="MSF_MUTABLE_SERVLET_FIELD"/>
- </Match>
- <Match>
- <Bug pattern="BIT_IOR_OF_SIGNED_BYTE"/>
- </Match>
- <Match>
- <Bug pattern="JLM_JSR166_LOCK_MONITORENTER"/>
- </Match>
- <Match>
- <Bug pattern="IS_INCONSISTENT_SYNC"/>
- </Match>
- <Match>
- <Bug pattern="LG_LOST_LOGGER_DUE_TO_WEAK_REFERENCE"/>
- </Match>
- <Match>
- <Bug pattern="RV_REM_OF_HASHCODE"/>
- </Match>
- <Match>
- <Bug pattern="ICAST_INT_CAST_TO_FLOAT_PASSED_TO_ROUND"/>
- </Match>
- <Match>
- <Bug pattern="SE_NONSTATIC_SERIALVERSIONID"/>
- </Match>
- <Match>
- <Bug pattern="BC_VACUOUS_INSTANCEOF"/>
- </Match>
- <Match>
- <Bug pattern="RC_REF_COMPARISON_BAD_PRACTICE_BOOLEAN"/>
- </Match>
- <Match>
- <Bug pattern="RV_ABSOLUTE_VALUE_OF_HASHCODE"/>
- </Match>
- <Match>
- <Bug pattern="DMI_CALLING_NEXT_FROM_HASNEXT"/>
- </Match>
- <Match>
- <Bug pattern="NP_NULL_ON_SOME_PATH"/>
- </Match>
- <Match>
- <Bug pattern="RS_READOBJECT_SYNC"/>
- </Match>
- <Match>
- <Bug pattern="EC_INCOMPATIBLE_ARRAY_COMPARE"/>
- </Match>
- <Match>
- <Bug pattern="NS_DANGEROUS_NON_SHORT_CIRCUIT"/>
- </Match>
- <Match>
- <Bug pattern="BC_IMPOSSIBLE_DOWNCAST_OF_TOARRAY"/>
- </Match>
- <Match>
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
- <Match>
- <Bug pattern="EQ_GETCLASS_AND_CLASS_CONSTANT"/>
- </Match>
- <Match>
- <Bug pattern="SA_FIELD_DOUBLE_ASSIGNMENT"/>
- </Match>
- <Match>
- <Bug pattern="VA_FORMAT_STRING_ARG_MISMATCH"/>
- </Match>
- <Match>
- <Bug pattern="MS_OOI_PKGPROTECT"/>
- </Match>
- <Match>
- <Bug pattern="EC_UNRELATED_TYPES"/>
- </Match>
- <Match>
- <Bug pattern="MS_EXPOSE_REP"/>
- </Match>
- <Match>
- <Bug pattern="BX_UNBOXED_AND_COERCED_FOR_TERNARY_OPERATOR"/>
- </Match>
- <Match>
- <Bug pattern="SF_SWITCH_FALLTHROUGH"/>
- </Match>
- <Match>
- <Bug pattern="NP_IMMEDIATE_DEREFERENCE_OF_READLINE"/>
- </Match>
- <Match>
- <Bug pattern="ESync_EMPTY_SYNC"/>
- </Match>
- <Match>
- <Bug pattern="HRS_REQUEST_PARAMETER_TO_COOKIE"/>
- </Match>
- <Match>
- <Bug pattern="DMI_LONG_BITS_TO_DOUBLE_INVOKED_ON_INT"/>
- </Match>
- <Match>
- <Bug pattern="UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS"/>
- </Match>
- <Match>
- <Bug pattern="IJU_NO_TESTS"/>
- </Match>
- <Match>
- <Bug pattern="RE_POSSIBLE_UNINTENDED_PATTERN"/>
- </Match>
- <Match>
- <Bug pattern="DLS_OVERWRITTEN_INCREMENT"/>
- </Match>
- <Match>
- <Bug pattern="AT_OPERATION_SEQUENCE_ON_CONCURRENT_ABSTRACTION"/>
- </Match>
- <Match>
- <Bug pattern="BX_UNBOXING_IMMEDIATELY_REBOXED"/>
- </Match>
- <Match>
- <Bug pattern="CO_COMPARETO_RESULTS_MIN_VALUE"/>
- </Match>
- <Match>
- <Bug pattern="DLS_DEAD_LOCAL_STORE_SHADOWS_FIELD"/>
- </Match>
- <Match>
- <Bug pattern="DMI_ARGUMENTS_WRONG_ORDER"/>
- </Match>
- <Match>
- <Bug pattern="DMI_BIGDECIMAL_CONSTRUCTED_FROM_DOUBLE"/>
- </Match>
- <Match>
- <Bug pattern="DMI_DOH"/>
- </Match>
- <Match>
- <Bug pattern="DMI_ENTRY_SETS_MAY_REUSE_ENTRY_OBJECTS"/>
- </Match>
- <Match>
- <Bug pattern="DM_DEFAULT_ENCODING"/>
- </Match>
- <Match>
- <Bug pattern="ICAST_INT_2_LONG_AS_INSTANT"/>
- </Match>
- <Match>
- <Bug pattern="INT_BAD_COMPARISON_WITH_INT_VALUE"/>
- </Match>
- <Match>
- <Bug pattern="JML_JSR166_CALLING_WAIT_RATHER_THAN_AWAIT"/>
- </Match>
- <Match>
- <Bug pattern="NP_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD"/>
- </Match>
- <Match>
- <Bug pattern="OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE"/>
- </Match>
- <Match>
- <Bug pattern="PZ_DONT_REUSE_ENTRY_OBJECTS_IN_ITERATORS"/>
- </Match>
- <Match>
- <Bug pattern="RV_CHECK_COMPARETO_FOR_SPECIFIC_RETURN_VALUE"/>
- </Match>
- <Match>
- <Bug pattern="RV_NEGATING_RESULT_OF_COMPARETO"/>
- </Match>
- <Match>
- <Bug pattern="RV_RETURN_VALUE_IGNORED_INFERRED"/>
- </Match>
- <Match>
- <Bug pattern="SA_LOCAL_SELF_ASSIGNMENT_INSTEAD_OF_FIELD"/>
- </Match>
- <Match>
- <Bug pattern="URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD"/>
- </Match>
- <Match>
- <Bug pattern="UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD"/>
- </Match>
- <Match>
- <Bug pattern="UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD"/>
- </Match>
- <Match>
- <Bug pattern="VA_FORMAT_STRING_USES_NEWLINE"/>
- </Match>
- <Match>
- <Bug pattern="VO_VOLATILE_INCREMENT"/>
- </Match>
- <Match>
- <Bug pattern="PT_ABSOLUTE_PATH_TRAVERSAL"/>
- </Match>
- <Match>
- <Bug pattern="PT_RELATIVE_PATH_TRAVERSAL"/>
- </Match>
- <Match>
- <Bug pattern="NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR"/>
- </Match>
- <Match>
- <Bug pattern="MS_SHOULD_BE_REFACTORED_TO_BE_FINAL"/>
- </Match>
- <Match>
- <Bug pattern="BC_UNCONFIRMED_CAST_OF_RETURN_VALUE"/>
- </Match>
- <Match>
- <Bug pattern="TQ_COMPARING_VALUES_WITH_INCOMPATIBLE_TYPE_QUALIFIERS"/>
- </Match>
-</FindBugsFilter>
+++ /dev/null
-<rules>
-
- <rule key="BC_IMPOSSIBLE_DOWNCAST">
- <priority>BLOCKER</priority>
- <name><![CDATA[Correctness - Impossible downcast]]></name>
- <configKey><![CDATA[BC_IMPOSSIBLE_DOWNCAST]]></configKey>
- </rule>
-
- <rule key="BC_IMPOSSIBLE_DOWNCAST_OF_TOARRAY">
- <priority>BLOCKER</priority>
- <name><![CDATA[Correctness - Impossible downcast of toArray() result]]></name>
- <configKey><![CDATA[BC_IMPOSSIBLE_DOWNCAST_OF_TOARRAY]]></configKey>
- </rule>
-
- <rule key="EC_INCOMPATIBLE_ARRAY_COMPARE">
- <priority>BLOCKER</priority>
- <name><![CDATA[Correctness - equals(...) used to compare incompatible arrays]]></name>
- <configKey><![CDATA[EC_INCOMPATIBLE_ARRAY_COMPARE]]></configKey>
- </rule>
-
- <rule key="EC_INCOMPATIBLE_ARRAY_COMPARE">
- <priority>BLOCKER</priority>
- <name><![CDATA[Correctness - equals(...) used to compare incompatible arrays]]></name>
- <configKey><![CDATA[EC_INCOMPATIBLE_ARRAY_COMPARE]]></configKey>
- </rule>
-
- <rule key="LG_LOST_LOGGER_DUE_TO_WEAK_REFERENCE">
- <priority>MAJOR</priority>
- <name><![CDATA[Correctness - Potential lost logger changes due to weak reference in OpenJDK ]]></name>
- <configKey><![CDATA[LG_LOST_LOGGER_DUE_TO_WEAK_REFERENCE]]></configKey>
- </rule>
-
- <rule key="NP_CLOSING_NULL">
- <priority>BLOCKER</priority>
- <name><![CDATA[Correctness - close() invoked on a value that is always null]]></name>
- <configKey><![CDATA[NP_CLOSING_NULL]]></configKey>
- </rule>
-
- <rule key="RC_REF_COMPARISON_BAD_PRACTICE">
- <priority>MAJOR</priority>
- <name><![CDATA[Correctness - Suspicious reference comparison to constant]]></name>
- <configKey><![CDATA[RC_REF_COMPARISON_BAD_PRACTICE]]></configKey>
- </rule>
-
- <rule key="RC_REF_COMPARISON_BAD_PRACTICE_BOOLEAN">
- <priority>MAJOR</priority>
- <name><![CDATA[Correctness - Suspicious reference comparison of Boolean values]]></name>
- <configKey><![CDATA[RC_REF_COMPARISON_BAD_PRACTICE_BOOLEAN]]></configKey>
- </rule>
-
- <rule key="RV_RETURN_VALUE_OF_PUTIFABSENT_IGNORED">
- <priority>MAJOR</priority>
- <name><![CDATA[Correctness - Return value of putIfAbsent ignored, value passed to putIfAbsent reused ]]></name>
- <configKey><![CDATA[RV_RETURN_VALUE_OF_PUTIFABSENT_IGNORED]]></configKey>
- </rule>
-
- <rule key="SIC_THREADLOCAL_DEADLY_EMBRACE">
- <priority>MAJOR</priority>
- <name><![CDATA[Correctness - Deadly embrace of non-static inner class and thread local]]></name>
- <configKey><![CDATA[SIC_THREADLOCAL_DEADLY_EMBRACE]]></configKey>
- </rule>
-
- <rule key="UR_UNINIT_READ_CALLED_FROM_SUPER_CONSTRUCTOR">
- <priority>MAJOR</priority>
- <name><![CDATA[Correctness - Uninitialized read of field method called from constructor of superclass]]></name>
- <configKey><![CDATA[UR_UNINIT_READ_CALLED_FROM_SUPER_CONSTRUCTOR]]></configKey>
- </rule>
-
- <rule key="VA_FORMAT_STRING_EXPECTED_MESSAGE_FORMAT_SUPPLIED">
- <priority>MAJOR</priority>
- <name><![CDATA[Correctness - MessageFormat supplied where printf style format expected ]]></name>
- <configKey><![CDATA[VA_FORMAT_STRING_EXPECTED_MESSAGE_FORMAT_SUPPLIED]]></configKey>
- </rule>
-
- <rule key="UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR">
- <priority>MINOR</priority>
- <name><![CDATA[Correctness - Field not initialized in constructor]]></name>
- <configKey><![CDATA[UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR]]></configKey>
- </rule>
-
- <rule key="NP_UNWRITTEN_FIELD">
- <priority>MAJOR</priority>
- <name><![CDATA[Correctness - Read of unwritten field]]></name>
- <configKey><![CDATA[NP_UNWRITTEN_FIELD]]></configKey>
- </rule>
-
- <rule key="UWF_UNWRITTEN_FIELD">
- <priority>MINOR</priority>
- <name><![CDATA[Correctness - Unwritten field]]></name>
- <configKey><![CDATA[UWF_UNWRITTEN_FIELD]]></configKey>
- </rule>
-
- <rule key="SKIPPED_CLASS_TOO_BIG">
- <priority>MINOR</priority>
- <name><![CDATA[Dodgy - Class too big for analysis]]></name>
- <configKey><![CDATA[SKIPPED_CLASS_TOO_BIG]]></configKey>
- </rule>
-
- <rule key="DMI_SCHEDULED_THREAD_POOL_EXECUTOR_WITH_ZERO_CORE_THREADS">
- <priority>MINOR</priority>
- <name><![CDATA[Correctness - Creation of ScheduledThreadPoolExecutor with zero core threads]]></name>
- <configKey><![CDATA[DMI_SCHEDULED_THREAD_POOL_EXECUTOR_WITH_ZERO_CORE_THREADS]]></configKey>
- </rule>
-
- <rule key="DMI_FUTILE_ATTEMPT_TO_CHANGE_MAXPOOL_SIZE_OF_SCHEDULED_THREAD_POOL_EXECUTOR">
- <priority>MINOR</priority>
- <name><![CDATA[Correctness - Futile attempt to change max pool size of ScheduledThreadPoolExecutor]]></name>
- <configKey><![CDATA[DMI_FUTILE_ATTEMPT_TO_CHANGE_MAXPOOL_SIZE_OF_SCHEDULED_THREAD_POOL_EXECUTOR]]></configKey>
- </rule>
-
- <rule key="DMI_UNSUPPORTED_METHOD">
- <priority>MAJOR</priority>
- <name><![CDATA[Dodgy - Call to unsupported method]]></name>
- <configKey><![CDATA[DMI_UNSUPPORTED_METHOD]]></configKey>
- </rule>
-
- <rule key="DMI_EMPTY_DB_PASSWORD">
- <priority>CRITICAL</priority>
- <name><![CDATA[Security - Empty database password]]></name>
- <configKey><![CDATA[DMI_EMPTY_DB_PASSWORD]]></configKey>
- </rule>
-
- <rule key="DMI_CONSTANT_DB_PASSWORD">
- <priority>BLOCKER</priority>
- <name><![CDATA[Security - Hardcoded constant database password]]></name>
- <configKey><![CDATA[DMI_CONSTANT_DB_PASSWORD]]></configKey>
- </rule>
-
- <rule key="HRS_REQUEST_PARAMETER_TO_COOKIE">
- <priority>MAJOR</priority>
- <name><![CDATA[Security - HTTP cookie formed from untrusted input]]></name>
- <configKey><![CDATA[HRS_REQUEST_PARAMETER_TO_COOKIE]]></configKey>
- </rule>
-
- <rule key="HRS_REQUEST_PARAMETER_TO_HTTP_HEADER">
- <priority>MAJOR</priority>
- <name><![CDATA[Security - HTTP Response splitting vulnerability]]></name>
- <configKey><![CDATA[HRS_REQUEST_PARAMETER_TO_HTTP_HEADER]]></configKey>
- </rule>
-
- <rule key="XSS_REQUEST_PARAMETER_TO_SERVLET_WRITER">
- <priority>CRITICAL</priority>
- <name><![CDATA[Security - Servlet reflected cross site scripting vulnerability]]></name>
- <configKey><![CDATA[XSS_REQUEST_PARAMETER_TO_SERVLET_WRITER]]></configKey>
- </rule>
-
- <rule key="XSS_REQUEST_PARAMETER_TO_SEND_ERROR">
- <priority>CRITICAL</priority>
- <name><![CDATA[Security - Servlet reflected cross site scripting vulnerability]]></name>
- <configKey><![CDATA[XSS_REQUEST_PARAMETER_TO_SEND_ERROR]]></configKey>
- </rule>
-
- <rule key="XSS_REQUEST_PARAMETER_TO_JSP_WRITER">
- <priority>CRITICAL</priority>
- <name><![CDATA[Security - JSP reflected cross site scripting vulnerability]]></name>
- <configKey><![CDATA[XSS_REQUEST_PARAMETER_TO_JSP_WRITER]]></configKey>
- </rule>
-
- <rule key="SW_SWING_METHODS_INVOKED_IN_SWING_THREAD">
- <priority>MAJOR</priority>
- <name><![CDATA[Bad practice - Certain swing methods needs to be invoked in Swing thread]]></name>
- <configKey><![CDATA[SW_SWING_METHODS_INVOKED_IN_SWING_THREAD]]></configKey>
- </rule>
-
- <rule key="IL_INFINITE_LOOP">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - An apparent infinite loop]]></name>
- <configKey><![CDATA[IL_INFINITE_LOOP]]></configKey>
- </rule>
-
- <rule key="IL_INFINITE_RECURSIVE_LOOP">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - An apparent infinite recursive loop]]></name>
- <configKey><![CDATA[IL_INFINITE_RECURSIVE_LOOP]]></configKey>
- </rule>
-
- <rule key="IL_CONTAINER_ADDED_TO_ITSELF">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - A collection is added to itself]]></name>
- <configKey><![CDATA[IL_CONTAINER_ADDED_TO_ITSELF]]></configKey>
- </rule>
-
- <rule key="VO_VOLATILE_REFERENCE_TO_ARRAY">
- <priority>MAJOR</priority>
- <name><![CDATA[Multithreaded correctness - A volatile reference to an array doesn't treat the array elements as volatile]]></name>
- <configKey><![CDATA[VO_VOLATILE_REFERENCE_TO_ARRAY]]></configKey>
- </rule>
-
- <rule key="UI_INHERITANCE_UNSAFE_GETRESOURCE">
- <priority>MAJOR</priority>
- <name><![CDATA[Bad practice - Usage of GetResource may be unsafe if class is extended]]></name>
- <configKey><![CDATA[UI_INHERITANCE_UNSAFE_GETRESOURCE]]></configKey>
- </rule>
-
- <rule key="NP_BOOLEAN_RETURN_NULL">
- <priority>MAJOR</priority>
- <name><![CDATA[Bad practice - Method with Boolean return type returns explicit null]]></name>
- <configKey><![CDATA[NP_BOOLEAN_RETURN_NULL]]></configKey>
- </rule>
-
- <rule key="NP_SYNC_AND_NULL_CHECK_FIELD">
- <priority>MAJOR</priority>
- <name><![CDATA[Multithreaded correctness - Synchronize and null check on the same field.]]></name>
- <configKey><![CDATA[NP_SYNC_AND_NULL_CHECK_FIELD]]></configKey>
- </rule>
-
- <rule key="RpC_REPEATED_CONDITIONAL_TEST">
- <priority>MAJOR</priority>
- <name><![CDATA[Correctness - Repeated conditional tests]]></name>
- <configKey><![CDATA[RpC_REPEATED_CONDITIONAL_TEST]]></configKey>
- </rule>
-
- <rule key="AM_CREATES_EMPTY_ZIP_FILE_ENTRY">
- <priority>MAJOR</priority>
- <name><![CDATA[Bad practice - Creates an empty zip file entry]]></name>
- <configKey><![CDATA[AM_CREATES_EMPTY_ZIP_FILE_ENTRY]]></configKey>
- </rule>
-
- <rule key="AM_CREATES_EMPTY_JAR_FILE_ENTRY">
- <priority>MAJOR</priority>
- <name><![CDATA[Bad practice - Creates an empty jar file entry]]></name>
- <configKey><![CDATA[AM_CREATES_EMPTY_JAR_FILE_ENTRY]]></configKey>
- </rule>
-
- <rule key="IMSE_DONT_CATCH_IMSE">
- <priority>MAJOR</priority>
- <name><![CDATA[Bad practice - Dubious catching of IllegalMonitorStateException]]></name>
- <configKey><![CDATA[IMSE_DONT_CATCH_IMSE]]></configKey>
- </rule>
-
- <rule key="FL_MATH_USING_FLOAT_PRECISION">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Method performs math using floating point precision]]></name>
- <configKey><![CDATA[FL_MATH_USING_FLOAT_PRECISION]]></configKey>
- </rule>
-
- <rule key="CN_IDIOM">
- <priority>MAJOR</priority>
- <name><![CDATA[Bad practice - Class implements Cloneable but does not define or use clone method]]></name>
- <configKey><![CDATA[CN_IDIOM]]></configKey>
- </rule>
-
- <rule key="CN_IMPLEMENTS_CLONE_BUT_NOT_CLONEABLE">
- <priority>MAJOR</priority>
- <name><![CDATA[Bad practice - Class defines clone() but doesn't implement Cloneable]]></name>
- <configKey><![CDATA[CN_IMPLEMENTS_CLONE_BUT_NOT_CLONEABLE]]></configKey>
- </rule>
-
- <rule key="CN_IDIOM_NO_SUPER_CALL">
- <priority>MAJOR</priority>
- <name><![CDATA[Bad practice - clone method does not call super.clone()]]></name>
- <configKey><![CDATA[CN_IDIOM_NO_SUPER_CALL]]></configKey>
- </rule>
-
- <rule key="NM_FUTURE_KEYWORD_USED_AS_IDENTIFIER">
- <priority>MAJOR</priority>
- <name><![CDATA[Bad practice - Use of identifier that is a keyword in later versions of Java]]></name>
- <configKey><![CDATA[NM_FUTURE_KEYWORD_USED_AS_IDENTIFIER]]></configKey>
- </rule>
-
- <rule key="NM_FUTURE_KEYWORD_USED_AS_MEMBER_IDENTIFIER">
- <priority>MAJOR</priority>
- <name><![CDATA[Bad practice - Use of identifier that is a keyword in later versions of Java]]></name>
- <configKey><![CDATA[NM_FUTURE_KEYWORD_USED_AS_MEMBER_IDENTIFIER]]></configKey>
- </rule>
-
- <rule key="DE_MIGHT_DROP">
- <priority>MAJOR</priority>
- <name><![CDATA[Bad practice - Method might drop exception]]></name>
- <configKey><![CDATA[DE_MIGHT_DROP]]></configKey>
- </rule>
-
- <rule key="DE_MIGHT_IGNORE">
- <priority>MAJOR</priority>
- <name><![CDATA[Bad practice - Method might ignore exception]]></name>
- <configKey><![CDATA[DE_MIGHT_IGNORE]]></configKey>
- </rule>
-
- <rule key="DP_DO_INSIDE_DO_PRIVILEGED">
- <priority>MAJOR</priority>
- <name><![CDATA[Bad practice - Method invoked that should be only be invoked inside a doPrivileged block]]></name>
- <configKey><![CDATA[DP_DO_INSIDE_DO_PRIVILEGED]]></configKey>
- </rule>
-
- <rule key="DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED">
- <priority>MAJOR</priority>
- <name><![CDATA[Bad practice - Classloaders should only be created inside doPrivileged block]]></name>
- <configKey><![CDATA[DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED]]></configKey>
- </rule>
-
- <rule key="JCIP_FIELD_ISNT_FINAL_IN_IMMUTABLE_CLASS">
- <priority>MINOR</priority>
- <name><![CDATA[Bad practice - Fields of immutable classes should be final]]></name>
- <configKey><![CDATA[JCIP_FIELD_ISNT_FINAL_IN_IMMUTABLE_CLASS]]></configKey>
- </rule>
-
- <rule key="DMI_THREAD_PASSED_WHERE_RUNNABLE_EXPECTED">
- <priority>MAJOR</priority>
- <name><![CDATA[Dodgy - Thread passed where Runnable expected]]></name>
- <configKey><![CDATA[DMI_THREAD_PASSED_WHERE_RUNNABLE_EXPECTED]]></configKey>
- </rule>
-
- <rule key="DMI_COLLECTION_OF_URLS">
- <priority>BLOCKER</priority>
- <name><![CDATA[Performance - Maps and sets of URLs can be performance hogs]]></name>
- <configKey><![CDATA[DMI_COLLECTION_OF_URLS]]></configKey>
- </rule>
-
- <rule key="DMI_BLOCKING_METHODS_ON_URL">
- <priority>BLOCKER</priority>
- <name><![CDATA[Performance - The equals and hashCode methods of URL are blocking]]></name>
- <configKey><![CDATA[DMI_BLOCKING_METHODS_ON_URL]]></configKey>
- </rule>
-
- <rule key="DMI_ANNOTATION_IS_NOT_VISIBLE_TO_REFLECTION">
- <priority>MAJOR</priority>
- <name><![CDATA[Correctness - Can't use reflection to check for presence of annotation without runtime retention]]></name>
- <configKey><![CDATA[DMI_ANNOTATION_IS_NOT_VISIBLE_TO_REFLECTION]]></configKey>
- </rule>
-
- <rule key="DM_EXIT">
- <priority>MAJOR</priority>
- <name><![CDATA[Bad practice - Method invokes System.exit(...)]]></name>
- <configKey><![CDATA[DM_EXIT]]></configKey>
- </rule>
-
- <rule key="DM_RUN_FINALIZERS_ON_EXIT">
- <priority>MAJOR</priority>
- <name><![CDATA[Bad practice - Method invokes dangerous method runFinalizersOnExit]]></name>
- <configKey><![CDATA[DM_RUN_FINALIZERS_ON_EXIT]]></configKey>
- </rule>
-
- <rule key="DM_STRING_CTOR">
- <priority>MAJOR</priority>
- <name><![CDATA[Performance - Method invokes inefficient new String(String) constructor]]></name>
- <configKey><![CDATA[DM_STRING_CTOR]]></configKey>
- </rule>
-
- <rule key="DM_STRING_VOID_CTOR">
- <priority>MAJOR</priority>
- <name><![CDATA[Performance - Method invokes inefficient new String() constructor]]></name>
- <configKey><![CDATA[DM_STRING_VOID_CTOR]]></configKey>
- </rule>
-
- <rule key="DM_STRING_TOSTRING">
- <priority>INFO</priority>
- <name><![CDATA[Performance - Method invokes toString() method on a String]]></name>
- <configKey><![CDATA[DM_STRING_TOSTRING]]></configKey>
- </rule>
-
- <rule key="DM_GC">
- <priority>MAJOR</priority>
- <name><![CDATA[Performance - Explicit garbage collection; extremely dubious except in benchmarking code]]></name>
- <configKey><![CDATA[DM_GC]]></configKey>
- </rule>
-
- <rule key="DM_BOOLEAN_CTOR">
- <priority>MAJOR</priority>
- <name><![CDATA[Performance - Method invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead]]></name>
- <configKey><![CDATA[DM_BOOLEAN_CTOR]]></configKey>
- </rule>
-
- <rule key="DM_NUMBER_CTOR">
- <priority>CRITICAL</priority>
- <name><![CDATA[Performance - Method invokes inefficient Number constructor; use static valueOf instead]]></name>
- <configKey><![CDATA[DM_NUMBER_CTOR]]></configKey>
- </rule>
-
- <rule key="DM_FP_NUMBER_CTOR">
- <priority>MAJOR</priority>
- <name><![CDATA[Performance - Method invokes inefficient floating-point Number constructor; use static valueOf instead]]></name>
- <configKey><![CDATA[DM_FP_NUMBER_CTOR]]></configKey>
- </rule>
-
- <rule key="DM_CONVERT_CASE">
- <priority>INFO</priority>
- <name><![CDATA[Internationalization - Consider using Locale parameterized version of invoked method]]></name>
- <configKey><![CDATA[DM_CONVERT_CASE]]></configKey>
- </rule>
-
- <rule key="BX_UNBOXED_AND_COERCED_FOR_TERNARY_OPERATOR">
- <priority>MAJOR</priority>
- <name><![CDATA[Correctness - Primitive value is unboxed and coerced for ternary operator]]></name>
- <configKey><![CDATA[BX_UNBOXED_AND_COERCED_FOR_TERNARY_OPERATOR]]></configKey>
- </rule>
-
- <rule key="BX_BOXING_IMMEDIATELY_UNBOXED">
- <priority>MAJOR</priority>
- <name><![CDATA[Performance - Primitive value is boxed and then immediately unboxed]]></name>
- <configKey><![CDATA[BX_BOXING_IMMEDIATELY_UNBOXED]]></configKey>
- </rule>
-
- <rule key="BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION">
- <priority>MAJOR</priority>
- <name><![CDATA[Performance - Primitive value is boxed then unboxed to perform primitive coercion]]></name>
- <configKey><![CDATA[BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION]]></configKey>
- </rule>
-
- <rule key="DM_BOXED_PRIMITIVE_TOSTRING">
- <priority>MAJOR</priority>
- <name><![CDATA[Performance - Method allocates a boxed primitive just to call toString]]></name>
- <configKey><![CDATA[DM_BOXED_PRIMITIVE_TOSTRING]]></configKey>
- </rule>
-
- <rule key="DM_NEW_FOR_GETCLASS">
- <priority>MAJOR</priority>
- <name><![CDATA[Performance - Method allocates an object, only to get the class object]]></name>
- <configKey><![CDATA[DM_NEW_FOR_GETCLASS]]></configKey>
- </rule>
-
- <rule key="DM_MONITOR_WAIT_ON_CONDITION">
- <priority>MAJOR</priority>
- <name><![CDATA[Multithreaded correctness - Monitor wait() called on Condition]]></name>
- <configKey><![CDATA[DM_MONITOR_WAIT_ON_CONDITION]]></configKey>
- </rule>
-
- <rule key="RV_01_TO_INT">
- <priority>MAJOR</priority>
- <name><![CDATA[Correctness - Random value from 0 to 1 is coerced to the integer 0]]></name>
- <configKey><![CDATA[RV_01_TO_INT]]></configKey>
- </rule>
-
- <rule key="DM_NEXTINT_VIA_NEXTDOUBLE">
- <priority>MAJOR</priority>
- <name><![CDATA[Performance - Use the nextInt method of Random rather than nextDouble to generate a random integer]]></name>
- <configKey><![CDATA[DM_NEXTINT_VIA_NEXTDOUBLE]]></configKey>
- </rule>
-
- <rule key="SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE">
- <priority>CRITICAL</priority>
- <name><![CDATA[Security - Nonconstant string passed to execute method on an SQL statement]]></name>
- <configKey><![CDATA[SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE]]></configKey>
- </rule>
-
- <rule key="SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING">
- <priority>CRITICAL</priority>
- <name><![CDATA[Security - A prepared statement is generated from a nonconstant String]]></name>
- <configKey><![CDATA[SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING]]></configKey>
- </rule>
-
- <rule key="DM_USELESS_THREAD">
- <priority>MAJOR</priority>
- <name><![CDATA[Multithreaded correctness - A thread was created using the default empty run method]]></name>
- <configKey><![CDATA[DM_USELESS_THREAD]]></configKey>
- </rule>
-
- <rule key="DC_DOUBLECHECK">
- <priority>MAJOR</priority>
- <name><![CDATA[Multithreaded correctness - Possible double check of field]]></name>
- <configKey><![CDATA[DC_DOUBLECHECK]]></configKey>
- </rule>
-
- <rule key="FI_FINALIZER_NULLS_FIELDS">
- <priority>MAJOR</priority>
- <name><![CDATA[Bad practice - Finalizer nulls fields]]></name>
- <configKey><![CDATA[FI_FINALIZER_NULLS_FIELDS]]></configKey>
- </rule>
-
- <rule key="FI_FINALIZER_ONLY_NULLS_FIELDS">
- <priority>MAJOR</priority>
- <name><![CDATA[Bad practice - Finalizer only nulls fields]]></name>
- <configKey><![CDATA[FI_FINALIZER_ONLY_NULLS_FIELDS]]></configKey>
- </rule>
-
- <rule key="FI_PUBLIC_SHOULD_BE_PROTECTED">
- <priority>MAJOR</priority>
- <name><![CDATA[Malicious code vulnerability - Finalizer should be protected, not public]]></name>
- <configKey><![CDATA[FI_PUBLIC_SHOULD_BE_PROTECTED]]></configKey>
- </rule>
-
- <rule key="FI_EMPTY">
- <priority>MAJOR</priority>
- <name><![CDATA[Bad practice - Empty finalizer should be deleted]]></name>
- <configKey><![CDATA[FI_EMPTY]]></configKey>
- </rule>
-
- <rule key="FI_NULLIFY_SUPER">
- <priority>CRITICAL</priority>
- <name><![CDATA[Bad practice - Finalizer nullifies superclass finalizer]]></name>
- <configKey><![CDATA[FI_NULLIFY_SUPER]]></configKey>
- </rule>
-
- <rule key="FI_USELESS">
- <priority>MINOR</priority>
- <name><![CDATA[Bad practice - Finalizer does nothing but call superclass finalizer]]></name>
- <configKey><![CDATA[FI_USELESS]]></configKey>
- </rule>
-
- <rule key="FI_MISSING_SUPER_CALL">
- <priority>MAJOR</priority>
- <name><![CDATA[Bad practice - Finalizer does not call superclass finalizer]]></name>
- <configKey><![CDATA[FI_MISSING_SUPER_CALL]]></configKey>
- </rule>
-
- <rule key="FI_EXPLICIT_INVOCATION">
- <priority>MAJOR</priority>
- <name><![CDATA[Bad practice - Explicit invocation of finalizer]]></name>
- <configKey><![CDATA[FI_EXPLICIT_INVOCATION]]></configKey>
- </rule>
-
- <rule key="EQ_CHECK_FOR_OPERAND_NOT_COMPATIBLE_WITH_THIS">
- <priority>MAJOR</priority>
- <name><![CDATA[Bad practice - Equals checks for noncompatible operand]]></name>
- <configKey><![CDATA[EQ_CHECK_FOR_OPERAND_NOT_COMPATIBLE_WITH_THIS]]></configKey>
- </rule>
-
- <rule key="EQ_DONT_DEFINE_EQUALS_FOR_ENUM">
- <priority>MAJOR</priority>
- <name><![CDATA[Correctness - Covariant equals() method defined for enum]]></name>
- <configKey><![CDATA[EQ_DONT_DEFINE_EQUALS_FOR_ENUM]]></configKey>
- </rule>
-
- <rule key="EQ_SELF_USE_OBJECT">
- <priority>MAJOR</priority>
- <name><![CDATA[Correctness - Covariant equals() method defined, Object.equals(Object) inherited]]></name>
- <configKey><![CDATA[EQ_SELF_USE_OBJECT]]></configKey>
- </rule>
-
- <rule key="EQ_OTHER_USE_OBJECT">
- <priority>MAJOR</priority>
- <name><![CDATA[Correctness - equals() method defined that doesn't override Object.equals(Object)]]></name>
- <configKey><![CDATA[EQ_OTHER_USE_OBJECT]]></configKey>
- </rule>
-
- <rule key="EQ_OTHER_NO_OBJECT">
- <priority>MAJOR</priority>
- <name><![CDATA[Correctness - equals() method defined that doesn't override equals(Object)]]></name>
- <configKey><![CDATA[EQ_OTHER_NO_OBJECT]]></configKey>
- </rule>
-
- <!-- warning : http://sourceforge.net/tracker/?func=detail&aid=2786054&group_id=96405&atid=614693 -->
- <rule key="EQ_DOESNT_OVERRIDE_EQUALS">
- <name><![CDATA[Dodgy - Class doesn't override equals in superclass]]></name>
- <configKey><![CDATA[EQ_DOESNT_OVERRIDE_EQUALS]]></configKey>
- </rule>
-
- <rule key="EQ_SELF_NO_OBJECT">
- <priority>MAJOR</priority>
- <name><![CDATA[Bad practice - Covariant equals() method defined]]></name>
- <configKey><![CDATA[EQ_SELF_NO_OBJECT]]></configKey>
- </rule>
-
- <rule key="EQ_OVERRIDING_EQUALS_NOT_SYMMETRIC">
- <priority>MAJOR</priority>
- <name><![CDATA[Correctness - equals method overrides equals in superclass and may not be symmetric]]></name>
- <configKey><![CDATA[EQ_OVERRIDING_EQUALS_NOT_SYMMETRIC]]></configKey>
- </rule>
-
- <rule key="EQ_GETCLASS_AND_CLASS_CONSTANT">
- <priority>CRITICAL</priority>
- <name><![CDATA[Bad practice - equals method fails for subtypes]]></name>
- <configKey><![CDATA[EQ_GETCLASS_AND_CLASS_CONSTANT]]></configKey>
- </rule>
-
- <rule key="EQ_UNUSUAL">
- <priority>MINOR</priority>
- <name><![CDATA[Dodgy - Unusual equals method ]]></name>
- <configKey><![CDATA[EQ_UNUSUAL]]></configKey>
- </rule>
-
- <rule key="EQ_COMPARING_CLASS_NAMES">
- <priority>MAJOR</priority>
- <name><![CDATA[Correctness - equals method compares class names rather than class objects]]></name>
- <configKey><![CDATA[EQ_COMPARING_CLASS_NAMES]]></configKey>
- </rule>
-
- <rule key="EQ_ALWAYS_TRUE">
- <priority>BLOCKER</priority>
- <name><![CDATA[Correctness - equals method always returns true]]></name>
- <configKey><![CDATA[EQ_ALWAYS_TRUE]]></configKey>
- </rule>
-
- <rule key="EQ_ALWAYS_FALSE">
- <priority>BLOCKER</priority>
- <name><![CDATA[Correctness - equals method always returns false]]></name>
- <configKey><![CDATA[EQ_ALWAYS_FALSE]]></configKey>
- </rule>
-
- <rule key="HSC_HUGE_SHARED_STRING_CONSTANT">
- <priority>CRITICAL</priority>
- <name><![CDATA[Performance - Huge string constants is duplicated across multiple class files]]></name>
- <configKey><![CDATA[HSC_HUGE_SHARED_STRING_CONSTANT]]></configKey>
- </rule>
-
- <rule key="NP_ARGUMENT_MIGHT_BE_NULL">
- <priority>MAJOR</priority>
- <name><![CDATA[Correctness - Method does not check for null argument]]></name>
- <configKey><![CDATA[NP_ARGUMENT_MIGHT_BE_NULL]]></configKey>
- </rule>
-
- <rule key="NP_EQUALS_SHOULD_HANDLE_NULL_ARGUMENT">
- <priority>CRITICAL</priority>
- <name><![CDATA[Bad practice - equals() method does not check for null argument]]></name>
- <configKey><![CDATA[NP_EQUALS_SHOULD_HANDLE_NULL_ARGUMENT]]></configKey>
- </rule>
-
- <rule key="CO_SELF_NO_OBJECT">
- <priority>MAJOR</priority>
- <name><![CDATA[Bad practice - Covariant compareTo() method defined]]></name>
- <configKey><![CDATA[CO_SELF_NO_OBJECT]]></configKey>
- </rule>
-
- <rule key="HE_SIGNATURE_DECLARES_HASHING_OF_UNHASHABLE_CLASS">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Signature declares use of unhashable class in hashed construct]]></name>
- <configKey><![CDATA[HE_SIGNATURE_DECLARES_HASHING_OF_UNHASHABLE_CLASS]]></configKey>
- </rule>
-
- <rule key="HE_USE_OF_UNHASHABLE_CLASS">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Use of class without a hashCode() method in a hashed data structure]]></name>
- <configKey><![CDATA[HE_USE_OF_UNHASHABLE_CLASS]]></configKey>
- </rule>
-
- <rule key="HE_HASHCODE_USE_OBJECT_EQUALS">
- <priority>CRITICAL</priority>
- <name><![CDATA[Bad practice - Class defines hashCode() and uses Object.equals()]]></name>
- <configKey><![CDATA[HE_HASHCODE_USE_OBJECT_EQUALS]]></configKey>
- </rule>
-
- <rule key="EQ_COMPARETO_USE_OBJECT_EQUALS">
- <priority>CRITICAL</priority>
- <name><![CDATA[Bad practice - Class defines compareTo(...) and uses Object.equals()]]></name>
- <configKey><![CDATA[EQ_COMPARETO_USE_OBJECT_EQUALS]]></configKey>
- </rule>
-
- <rule key="HE_HASHCODE_NO_EQUALS">
- <priority>CRITICAL</priority>
- <name><![CDATA[Bad practice - Class defines hashCode() but not equals()]]></name>
- <configKey><![CDATA[HE_HASHCODE_NO_EQUALS]]></configKey>
- </rule>
-
- <rule key="HE_EQUALS_USE_HASHCODE">
- <priority>CRITICAL</priority>
- <name><![CDATA[Bad practice - Class defines equals() and uses Object.hashCode()]]></name>
- <configKey><![CDATA[HE_EQUALS_USE_HASHCODE]]></configKey>
- </rule>
-
- <rule key="HE_INHERITS_EQUALS_USE_HASHCODE">
- <priority>CRITICAL</priority>
- <name><![CDATA[Bad practice - Class inherits equals() and uses Object.hashCode()]]></name>
- <configKey><![CDATA[HE_INHERITS_EQUALS_USE_HASHCODE]]></configKey>
- </rule>
-
- <rule key="HE_EQUALS_NO_HASHCODE">
- <priority>MAJOR</priority>
- <name><![CDATA[Bad practice - Class defines equals() but not hashCode()]]></name>
- <configKey><![CDATA[HE_EQUALS_NO_HASHCODE]]></configKey>
- </rule>
-
- <rule key="EQ_ABSTRACT_SELF">
- <priority>MAJOR</priority>
- <name><![CDATA[Bad practice - Abstract class defines covariant equals() method]]></name>
- <configKey><![CDATA[EQ_ABSTRACT_SELF]]></configKey>
- </rule>
-
- <rule key="ES_COMPARING_STRINGS_WITH_EQ">
- <priority>MAJOR</priority>
- <name><![CDATA[Bad practice - Comparison of String objects using == or !=]]></name>
- <configKey><![CDATA[ES_COMPARING_STRINGS_WITH_EQ]]></configKey>
- </rule>
-
- <rule key="ES_COMPARING_PARAMETER_STRING_WITH_EQ">
- <priority>MAJOR</priority>
- <name><![CDATA[Bad practice - Comparison of String parameter using == or !=]]></name>
- <configKey><![CDATA[ES_COMPARING_PARAMETER_STRING_WITH_EQ]]></configKey>
- </rule>
-
- <rule key="CO_ABSTRACT_SELF">
- <priority>MAJOR</priority>
- <name><![CDATA[Bad practice - Abstract class defines covariant compareTo() method]]></name>
- <configKey><![CDATA[CO_ABSTRACT_SELF]]></configKey>
- </rule>
-
- <rule key="IS_FIELD_NOT_GUARDED">
- <priority>CRITICAL</priority>
- <name><![CDATA[Multithreaded correctness - Field not guarded against concurrent access]]></name>
- <configKey><![CDATA[IS_FIELD_NOT_GUARDED]]></configKey>
- </rule>
-
- <rule key="MSF_MUTABLE_SERVLET_FIELD">
- <priority>MAJOR</priority>
- <name><![CDATA[Multithreaded correctness - Mutable servlet field]]></name>
- <configKey><![CDATA[MSF_MUTABLE_SERVLET_FIELD]]></configKey>
- </rule>
-
- <rule key="IS2_INCONSISTENT_SYNC">
- <priority>CRITICAL</priority>
- <name><![CDATA[Multithreaded correctness - Inconsistent synchronization]]></name>
- <configKey><![CDATA[IS2_INCONSISTENT_SYNC]]></configKey>
- </rule>
-
- <rule key="NN_NAKED_NOTIFY">
- <priority>CRITICAL</priority>
- <name><![CDATA[Multithreaded correctness - Naked notify]]></name>
- <configKey><![CDATA[NN_NAKED_NOTIFY]]></configKey>
- </rule>
-
- <rule key="MS_EXPOSE_REP">
- <priority>CRITICAL</priority>
- <name><![CDATA[Malicious code vulnerability - Public static method may expose internal representation by returning array]]></name>
- <configKey><![CDATA[MS_EXPOSE_REP]]></configKey>
- </rule>
-
- <rule key="EI_EXPOSE_REP">
- <priority>MAJOR</priority>
- <name><![CDATA[Malicious code vulnerability - May expose internal representation by returning reference to mutable object]]></name>
- <configKey><![CDATA[EI_EXPOSE_REP]]></configKey>
- </rule>
-
- <rule key="EI_EXPOSE_REP2">
- <priority>MAJOR</priority>
- <name><![CDATA[Malicious code vulnerability - May expose internal representation by incorporating reference to mutable object]]></name>
- <configKey><![CDATA[EI_EXPOSE_REP2]]></configKey>
- </rule>
-
- <rule key="EI_EXPOSE_STATIC_REP2">
- <priority>MAJOR</priority>
- <name><![CDATA[Malicious code vulnerability - May expose internal static state by storing a mutable object into a static field]]></name>
- <configKey><![CDATA[EI_EXPOSE_STATIC_REP2]]></configKey>
- </rule>
-
- <rule key="RU_INVOKE_RUN">
- <priority>MAJOR</priority>
- <name><![CDATA[Multithreaded correctness - Invokes run on a thread (did you mean to start it instead?)]]></name>
- <configKey><![CDATA[RU_INVOKE_RUN]]></configKey>
- </rule>
-
- <rule key="SP_SPIN_ON_FIELD">
- <priority>MAJOR</priority>
- <name><![CDATA[Multithreaded correctness - Method spins on field]]></name>
- <configKey><![CDATA[SP_SPIN_ON_FIELD]]></configKey>
- </rule>
-
- <rule key="NS_DANGEROUS_NON_SHORT_CIRCUIT">
- <priority>CRITICAL</priority>
- <name><![CDATA[Dodgy - Potentially dangerous use of non-short-circuit logic]]></name>
- <configKey><![CDATA[NS_DANGEROUS_NON_SHORT_CIRCUIT]]></configKey>
- </rule>
-
- <rule key="NS_NON_SHORT_CIRCUIT">
- <priority>MAJOR</priority>
- <name><![CDATA[Dodgy - Questionable use of non-short-circuit logic]]></name>
- <configKey><![CDATA[NS_NON_SHORT_CIRCUIT]]></configKey>
- </rule>
-
- <rule key="TLW_TWO_LOCK_WAIT">
- <priority>MAJOR</priority>
- <name><![CDATA[Multithreaded correctness - Wait with two locks held]]></name>
- <configKey><![CDATA[TLW_TWO_LOCK_WAIT]]></configKey>
- </rule>
-
- <rule key="UW_UNCOND_WAIT">
- <priority>MAJOR</priority>
- <name><![CDATA[Multithreaded correctness - Unconditional wait]]></name>
- <configKey><![CDATA[UW_UNCOND_WAIT]]></configKey>
- </rule>
-
- <rule key="UR_UNINIT_READ">
- <priority>MAJOR</priority>
- <name><![CDATA[Correctness - Uninitialized read of field in constructor]]></name>
- <configKey><![CDATA[UR_UNINIT_READ]]></configKey>
- </rule>
-
- <rule key="UG_SYNC_SET_UNSYNC_GET">
- <priority>MAJOR</priority>
- <name><![CDATA[Multithreaded correctness - Unsynchronized get method, synchronized set method]]></name>
- <configKey><![CDATA[UG_SYNC_SET_UNSYNC_GET]]></configKey>
- </rule>
-
- <rule key="IC_INIT_CIRCULARITY">
- <priority>CRITICAL</priority>
- <name><![CDATA[Dodgy - Initialization circularity]]></name>
- <configKey><![CDATA[IC_INIT_CIRCULARITY]]></configKey>
- </rule>
-
- <rule key="IC_SUPERCLASS_USES_SUBCLASS_DURING_INITIALIZATION">
- <priority>MAJOR</priority>
- <name><![CDATA[Bad practice - Superclass uses subclass during initialization]]></name>
- <configKey><![CDATA[IC_SUPERCLASS_USES_SUBCLASS_DURING_INITIALIZATION]]></configKey>
- </rule>
-
- <rule key="IT_NO_SUCH_ELEMENT">
- <priority>MINOR</priority>
- <name><![CDATA[Bad practice - Iterator next() method can't throw NoSuchElementException]]></name>
- <configKey><![CDATA[IT_NO_SUCH_ELEMENT]]></configKey>
- </rule>
-
- <rule key="DL_SYNCHRONIZATION_ON_SHARED_CONSTANT">
- <priority>CRITICAL</priority>
- <name><![CDATA[Multithreaded correctness - Synchronization on interned String could lead to deadlock]]></name>
- <configKey><![CDATA[DL_SYNCHRONIZATION_ON_SHARED_CONSTANT]]></configKey>
- </rule>
-
- <rule key="DL_SYNCHRONIZATION_ON_BOOLEAN">
- <priority>CRITICAL</priority>
- <name><![CDATA[Multithreaded correctness - Synchronization on Boolean could lead to deadlock]]></name>
- <configKey><![CDATA[DL_SYNCHRONIZATION_ON_BOOLEAN]]></configKey>
- </rule>
-
- <rule key="DL_SYNCHRONIZATION_ON_UNSHARED_BOXED_PRIMITIVE">
- <priority>CRITICAL</priority>
- <name><![CDATA[Multithreaded correctness - Synchronization on boxed primitive values]]></name>
- <configKey><![CDATA[DL_SYNCHRONIZATION_ON_UNSHARED_BOXED_PRIMITIVE]]></configKey>
- </rule>
-
- <rule key="DL_SYNCHRONIZATION_ON_BOXED_PRIMITIVE">
- <priority>CRITICAL</priority>
- <name><![CDATA[Multithreaded correctness - Synchronization on boxed primitive could lead to deadlock]]></name>
- <configKey><![CDATA[DL_SYNCHRONIZATION_ON_BOXED_PRIMITIVE]]></configKey>
- </rule>
-
- <rule key="ESync_EMPTY_SYNC">
- <priority>MAJOR</priority>
- <name><![CDATA[Multithreaded correctness - Empty synchronized block]]></name>
- <configKey><![CDATA[ESync_EMPTY_SYNC]]></configKey>
- </rule>
-
- <rule key="IS_INCONSISTENT_SYNC">
- <priority>MAJOR</priority>
- <name><![CDATA[Multithreaded correctness - Inconsistent synchronization]]></name>
- <configKey><![CDATA[IS_INCONSISTENT_SYNC]]></configKey>
- </rule>
-
- <rule key="ML_SYNC_ON_FIELD_TO_GUARD_CHANGING_THAT_FIELD">
- <priority>MAJOR</priority>
- <name><![CDATA[Multithreaded correctness - Synchronization on field in futile attempt to guard that field]]></name>
- <configKey><![CDATA[ML_SYNC_ON_FIELD_TO_GUARD_CHANGING_THAT_FIELD]]></configKey>
- </rule>
-
- <rule key="ML_SYNC_ON_UPDATED_FIELD">
- <priority>MAJOR</priority>
- <name><![CDATA[Multithreaded correctness - Method synchronizes on an updated field]]></name>
- <configKey><![CDATA[ML_SYNC_ON_UPDATED_FIELD]]></configKey>
- </rule>
-
- <rule key="MS_OOI_PKGPROTECT">
- <priority>MAJOR</priority>
- <name><![CDATA[Malicious code vulnerability - Field should be moved out of an interface and made package protected]]></name>
- <configKey><![CDATA[MS_OOI_PKGPROTECT]]></configKey>
- </rule>
-
- <rule key="MS_FINAL_PKGPROTECT">
- <priority>MAJOR</priority>
- <name><![CDATA[Malicious code vulnerability - Field should be both final and package protected]]></name>
- <configKey><![CDATA[MS_FINAL_PKGPROTECT]]></configKey>
- </rule>
-
- <rule key="MS_SHOULD_BE_FINAL">
- <priority>MAJOR</priority>
- <name><![CDATA[Malicious code vulnerability - Field isn't final but should be]]></name>
- <configKey><![CDATA[MS_SHOULD_BE_FINAL]]></configKey>
- </rule>
-
- <rule key="MS_PKGPROTECT">
- <priority>MAJOR</priority>
- <name><![CDATA[Malicious code vulnerability - Field should be package protected]]></name>
- <configKey><![CDATA[MS_PKGPROTECT]]></configKey>
- </rule>
-
- <rule key="MS_MUTABLE_HASHTABLE">
- <priority>MAJOR</priority>
- <name><![CDATA[Malicious code vulnerability - Field is a mutable Hashtable]]></name>
- <configKey><![CDATA[MS_MUTABLE_HASHTABLE]]></configKey>
- </rule>
-
- <rule key="MS_MUTABLE_ARRAY">
- <priority>MAJOR</priority>
- <name><![CDATA[Malicious code vulnerability - Field is a mutable array]]></name>
- <configKey><![CDATA[MS_MUTABLE_ARRAY]]></configKey>
- </rule>
-
- <rule key="MS_CANNOT_BE_FINAL">
- <priority>MAJOR</priority>
- <name><![CDATA[Malicious code vulnerability - Field isn't final and can't be protected from malicious code]]></name>
- <configKey><![CDATA[MS_CANNOT_BE_FINAL]]></configKey>
- </rule>
-
- <rule key="IA_AMBIGUOUS_INVOCATION_OF_INHERITED_OR_OUTER_METHOD">
- <priority>MAJOR</priority>
- <name><![CDATA[Dodgy - Ambiguous invocation of either an inherited or outer method]]></name>
- <configKey><![CDATA[IA_AMBIGUOUS_INVOCATION_OF_INHERITED_OR_OUTER_METHOD]]></configKey>
- </rule>
-
- <rule key="NM_SAME_SIMPLE_NAME_AS_SUPERCLASS">
- <priority>MAJOR</priority>
- <name><![CDATA[Bad practice - Class names shouldn't shadow simple name of superclass]]></name>
- <configKey><![CDATA[NM_SAME_SIMPLE_NAME_AS_SUPERCLASS]]></configKey>
- </rule>
-
- <rule key="NM_SAME_SIMPLE_NAME_AS_INTERFACE">
- <priority>MAJOR</priority>
- <name><![CDATA[Bad practice - Class names shouldn't shadow simple name of implemented interface]]></name>
- <configKey><![CDATA[NM_SAME_SIMPLE_NAME_AS_INTERFACE]]></configKey>
- </rule>
-
- <rule key="NM_VERY_CONFUSING">
- <priority>MAJOR</priority>
- <name><![CDATA[Correctness - Very confusing method names]]></name>
- <configKey><![CDATA[NM_VERY_CONFUSING]]></configKey>
- </rule>
-
- <rule key="NM_VERY_CONFUSING_INTENTIONAL">
- <priority>MAJOR</priority>
- <name><![CDATA[Bad practice - Very confusing method names (but perhaps intentional)]]></name>
- <configKey><![CDATA[NM_VERY_CONFUSING_INTENTIONAL]]></configKey>
- </rule>
-
- <rule key="NM_WRONG_PACKAGE">
- <priority>MAJOR</priority>
- <name><![CDATA[Correctness - Method doesn't override method in superclass due to wrong package for parameter]]></name>
- <configKey><![CDATA[NM_WRONG_PACKAGE]]></configKey>
- </rule>
-
- <rule key="NM_WRONG_PACKAGE_INTENTIONAL">
- <priority>MAJOR</priority>
- <name><![CDATA[Bad practice - Method doesn't override method in superclass due to wrong package for parameter]]></name>
- <configKey><![CDATA[NM_WRONG_PACKAGE_INTENTIONAL]]></configKey>
- </rule>
-
- <rule key="NM_CONFUSING">
- <priority>MAJOR</priority>
- <name><![CDATA[Bad practice - Confusing method names]]></name>
- <configKey><![CDATA[NM_CONFUSING]]></configKey>
- </rule>
-
- <rule key="NM_METHOD_CONSTRUCTOR_CONFUSION">
- <priority>MAJOR</priority>
- <name><![CDATA[Correctness - Apparent method/constructor confusion]]></name>
- <configKey><![CDATA[NM_METHOD_CONSTRUCTOR_CONFUSION]]></configKey>
- </rule>
-
- <rule key="NM_CLASS_NOT_EXCEPTION">
- <priority>MAJOR</priority>
- <name><![CDATA[Bad practice - Class is not derived from an Exception, even though it is named as such]]></name>
- <configKey><![CDATA[NM_CLASS_NOT_EXCEPTION]]></configKey>
- </rule>
-
- <rule key="RR_NOT_CHECKED">
- <priority>MAJOR</priority>
- <name><![CDATA[Bad practice - Method ignores results of InputStream.read()]]></name>
- <configKey><![CDATA[RR_NOT_CHECKED]]></configKey>
- </rule>
-
- <rule key="SR_NOT_CHECKED">
- <priority>MAJOR</priority>
- <name><![CDATA[Bad practice - Method ignores results of InputStream.skip()]]></name>
- <configKey><![CDATA[SR_NOT_CHECKED]]></configKey>
- </rule>
-
- <rule key="SE_READ_RESOLVE_IS_STATIC">
- <priority>MAJOR</priority>
- <name><![CDATA[Correctness - The readResolve method must not be declared as a static method. ]]></name>
- <configKey><![CDATA[SE_READ_RESOLVE_IS_STATIC]]></configKey>
- </rule>
-
- <rule key="SE_PRIVATE_READ_RESOLVE_NOT_INHERITED">
- <priority>MAJOR</priority>
- <name><![CDATA[Dodgy - private readResolve method not inherited by subclasses]]></name>
- <configKey><![CDATA[SE_PRIVATE_READ_RESOLVE_NOT_INHERITED]]></configKey>
- </rule>
-
- <rule key="SE_READ_RESOLVE_MUST_RETURN_OBJECT">
- <priority>MAJOR</priority>
- <name><![CDATA[Bad practice - The readResolve method must be declared with a return type of Object. ]]></name>
- <configKey><![CDATA[SE_READ_RESOLVE_MUST_RETURN_OBJECT]]></configKey>
- </rule>
-
- <rule key="SE_TRANSIENT_FIELD_OF_NONSERIALIZABLE_CLASS">
- <priority>MAJOR</priority>
- <name><![CDATA[Dodgy - Transient field of class that isn't Serializable. ]]></name>
- <configKey><![CDATA[SE_TRANSIENT_FIELD_OF_NONSERIALIZABLE_CLASS]]></configKey>
- </rule>
-
- <rule key="SE_TRANSIENT_FIELD_NOT_RESTORED">
- <priority>MAJOR</priority>
- <name><![CDATA[Bad practice - Transient field that isn't set by deserialization. ]]></name>
- <configKey><![CDATA[SE_TRANSIENT_FIELD_NOT_RESTORED]]></configKey>
- </rule>
-
- <rule key="SE_METHOD_MUST_BE_PRIVATE">
- <priority>MAJOR</priority>
- <name><![CDATA[Correctness - Method must be private in order for serialization to work]]></name>
- <configKey><![CDATA[SE_METHOD_MUST_BE_PRIVATE]]></configKey>
- </rule>
-
- <rule key="SE_NO_SUITABLE_CONSTRUCTOR_FOR_EXTERNALIZATION">
- <priority>MAJOR</priority>
- <name><![CDATA[Bad practice - Class is Externalizable but doesn't define a void constructor]]></name>
- <configKey><![CDATA[SE_NO_SUITABLE_CONSTRUCTOR_FOR_EXTERNALIZATION]]></configKey>
- </rule>
-
- <rule key="SE_NO_SUITABLE_CONSTRUCTOR">
- <priority>MAJOR</priority>
- <name><![CDATA[Bad practice - Class is Serializable but its superclass doesn't define a void constructor]]></name>
- <configKey><![CDATA[SE_NO_SUITABLE_CONSTRUCTOR]]></configKey>
- </rule>
-
- <rule key="SE_NO_SERIALVERSIONID">
- <priority>MAJOR</priority>
- <name><![CDATA[Bad practice - Class is Serializable, but doesn't define serialVersionUID]]></name>
- <configKey><![CDATA[SE_NO_SERIALVERSIONID]]></configKey>
- </rule>
-
- <rule key="SE_COMPARATOR_SHOULD_BE_SERIALIZABLE">
- <priority>MAJOR</priority>
- <name><![CDATA[Bad practice - Comparator doesn't implement Serializable]]></name>
- <configKey><![CDATA[SE_COMPARATOR_SHOULD_BE_SERIALIZABLE]]></configKey>
- </rule>
-
- <rule key="WS_WRITEOBJECT_SYNC">
- <priority>CRITICAL</priority>
- <name><![CDATA[Multithreaded correctness - Class's writeObject() method is synchronized but nothing else is]]></name>
- <configKey><![CDATA[WS_WRITEOBJECT_SYNC]]></configKey>
- </rule>
-
- <rule key="RS_READOBJECT_SYNC">
- <priority>CRITICAL</priority>
- <name><![CDATA[Multithreaded correctness - Class's readObject() method is synchronized]]></name>
- <configKey><![CDATA[RS_READOBJECT_SYNC]]></configKey>
- </rule>
-
- <rule key="SE_NONSTATIC_SERIALVERSIONID">
- <priority>MAJOR</priority>
- <name><![CDATA[Bad practice - serialVersionUID isn't static]]></name>
- <configKey><![CDATA[SE_NONSTATIC_SERIALVERSIONID]]></configKey>
- </rule>
-
- <rule key="SE_NONFINAL_SERIALVERSIONID">
- <priority>CRITICAL</priority>
- <name><![CDATA[Bad practice - serialVersionUID isn't final]]></name>
- <configKey><![CDATA[SE_NONFINAL_SERIALVERSIONID]]></configKey>
- </rule>
-
- <rule key="SE_NONLONG_SERIALVERSIONID">
- <priority>MAJOR</priority>
- <name><![CDATA[Bad practice - serialVersionUID isn't long]]></name>
- <configKey><![CDATA[SE_NONLONG_SERIALVERSIONID]]></configKey>
- </rule>
-
- <rule key="SE_BAD_FIELD_INNER_CLASS">
- <priority>MINOR</priority>
- <name><![CDATA[Bad practice - Non-serializable class has a serializable inner class]]></name>
- <configKey><![CDATA[SE_BAD_FIELD_INNER_CLASS]]></configKey>
- </rule>
-
- <rule key="SE_INNER_CLASS">
- <priority>MAJOR</priority>
- <name><![CDATA[Bad practice - Serializable inner class]]></name>
- <configKey><![CDATA[SE_INNER_CLASS]]></configKey>
- </rule>
-
- <rule key="SE_BAD_FIELD_STORE">
- <priority>CRITICAL</priority>
- <name><![CDATA[Bad practice - Non-serializable value stored into instance field of a serializable class]]></name>
- <configKey><![CDATA[SE_BAD_FIELD_STORE]]></configKey>
- </rule>
-
- <rule key="SC_START_IN_CTOR">
- <priority>CRITICAL</priority>
- <name><![CDATA[Multithreaded correctness - Constructor invokes Thread.start()]]></name>
- <configKey><![CDATA[SC_START_IN_CTOR]]></configKey>
- </rule>
-
- <rule key="SS_SHOULD_BE_STATIC">
- <priority>MAJOR</priority>
- <name><![CDATA[Performance - Unread field: should this field be static?]]></name>
- <configKey><![CDATA[SS_SHOULD_BE_STATIC]]></configKey>
- </rule>
-
- <rule key="UUF_UNUSED_FIELD">
- <priority>MAJOR</priority>
- <name><![CDATA[Performance - Unused field]]></name>
- <configKey><![CDATA[UUF_UNUSED_FIELD]]></configKey>
- </rule>
-
- <rule key="URF_UNREAD_FIELD">
- <priority>MAJOR</priority>
- <name><![CDATA[Performance - Unread field]]></name>
- <configKey><![CDATA[URF_UNREAD_FIELD]]></configKey>
- </rule>
-
- <rule key="QF_QUESTIONABLE_FOR_LOOP">
- <priority>CRITICAL</priority>
- <name><![CDATA[Dodgy - Complicated, subtle or wrong increment in for-loop ]]></name>
- <configKey><![CDATA[QF_QUESTIONABLE_FOR_LOOP]]></configKey>
- </rule>
-
- <rule key="UWF_NULL_FIELD">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Field only ever set to null]]></name>
- <configKey><![CDATA[UWF_NULL_FIELD]]></configKey>
- </rule>
-
- <rule key="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD">
- <priority>CRITICAL</priority>
- <name><![CDATA[Dodgy - Write to static field from instance method]]></name>
- <configKey><![CDATA[ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD]]></configKey>
- </rule>
-
- <rule key="NP_LOAD_OF_KNOWN_NULL_VALUE">
- <priority>CRITICAL</priority>
- <name><![CDATA[Dodgy - Load of known null value]]></name>
- <configKey><![CDATA[NP_LOAD_OF_KNOWN_NULL_VALUE]]></configKey>
- </rule>
-
- <rule key="NP_DEREFERENCE_OF_READLINE_VALUE">
- <priority>CRITICAL</priority>
- <name><![CDATA[Dodgy - Dereference of the result of readLine() without nullcheck]]></name>
- <configKey><![CDATA[NP_DEREFERENCE_OF_READLINE_VALUE]]></configKey>
- </rule>
-
- <rule key="NP_IMMEDIATE_DEREFERENCE_OF_READLINE">
- <priority>CRITICAL</priority>
- <name><![CDATA[Dodgy - Immediate dereference of the result of readLine()]]></name>
- <configKey><![CDATA[NP_IMMEDIATE_DEREFERENCE_OF_READLINE]]></configKey>
- </rule>
-
- <rule key="SIC_INNER_SHOULD_BE_STATIC">
- <priority>MAJOR</priority>
- <name><![CDATA[Performance - Should be a static inner class]]></name>
- <configKey><![CDATA[SIC_INNER_SHOULD_BE_STATIC]]></configKey>
- </rule>
-
- <rule key="SIC_INNER_SHOULD_BE_STATIC_ANON">
- <priority>MAJOR</priority>
- <name><![CDATA[Performance - Could be refactored into a named static inner class]]></name>
- <configKey><![CDATA[SIC_INNER_SHOULD_BE_STATIC_ANON]]></configKey>
- </rule>
-
- <rule key="SIC_INNER_SHOULD_BE_STATIC_NEEDS_THIS">
- <priority>MAJOR</priority>
- <name><![CDATA[Performance - Could be refactored into a static inner class]]></name>
- <configKey><![CDATA[SIC_INNER_SHOULD_BE_STATIC_NEEDS_THIS]]></configKey>
- </rule>
-
- <rule key="WA_NOT_IN_LOOP">
- <priority>CRITICAL</priority>
- <name><![CDATA[Multithreaded correctness - Wait not in loop ]]></name>
- <configKey><![CDATA[WA_NOT_IN_LOOP]]></configKey>
- </rule>
-
- <rule key="WA_AWAIT_NOT_IN_LOOP">
- <priority>CRITICAL</priority>
- <name><![CDATA[Multithreaded correctness - Condition.await() not in loop ]]></name>
- <configKey><![CDATA[WA_AWAIT_NOT_IN_LOOP]]></configKey>
- </rule>
-
- <rule key="NO_NOTIFY_NOT_NOTIFYALL">
- <priority>CRITICAL</priority>
- <name><![CDATA[Multithreaded correctness - Using notify() rather than notifyAll()]]></name>
- <configKey><![CDATA[NO_NOTIFY_NOT_NOTIFYALL]]></configKey>
- </rule>
-
- <rule key="RV_CHECK_FOR_POSITIVE_INDEXOF">
- <priority>MINOR</priority>
- <name><![CDATA[Dodgy - Method checks to see if result of String.indexOf is positive]]></name>
- <configKey><![CDATA[RV_CHECK_FOR_POSITIVE_INDEXOF]]></configKey>
- </rule>
-
- <rule key="RV_DONT_JUST_NULL_CHECK_READLINE">
- <priority>MAJOR</priority>
- <name><![CDATA[Dodgy - Method discards result of readLine after checking if it is nonnull]]></name>
- <configKey><![CDATA[RV_DONT_JUST_NULL_CHECK_READLINE]]></configKey>
- </rule>
-
- <rule key="RV_RETURN_VALUE_IGNORED">
- <priority>MINOR</priority>
- <name><![CDATA[Correctness - Method ignores return value]]></name>
- <configKey><![CDATA[RV_RETURN_VALUE_IGNORED]]></configKey>
- </rule>
-
- <rule key="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE">
- <priority>MAJOR</priority>
- <name><![CDATA[Bad practice - Method ignores exceptional return value]]></name>
- <configKey><![CDATA[RV_RETURN_VALUE_IGNORED_BAD_PRACTICE]]></configKey>
- </rule>
-
- <rule key="RV_EXCEPTION_NOT_THROWN">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Exception created and dropped rather than thrown]]></name>
- <configKey><![CDATA[RV_EXCEPTION_NOT_THROWN]]></configKey>
- </rule>
-
- <rule key="RV_RETURN_VALUE_IGNORED2">
- <priority>MAJOR</priority>
- <name><![CDATA[Correctness - Method ignores return value]]></name>
- <configKey><![CDATA[RV_RETURN_VALUE_IGNORED2]]></configKey>
- </rule>
-
- <rule key="NP_ALWAYS_NULL">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Null pointer dereference]]></name>
- <configKey><![CDATA[NP_ALWAYS_NULL]]></configKey>
- </rule>
-
- <rule key="NP_STORE_INTO_NONNULL_FIELD">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Store of null value into field annotated NonNull]]></name>
- <configKey><![CDATA[NP_STORE_INTO_NONNULL_FIELD]]></configKey>
- </rule>
-
- <rule key="NP_ALWAYS_NULL_EXCEPTION">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Null pointer dereference in method on exception path]]></name>
- <configKey><![CDATA[NP_ALWAYS_NULL_EXCEPTION]]></configKey>
- </rule>
-
- <rule key="NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE">
- <priority>CRITICAL</priority>
- <name><![CDATA[Dodgy - Parameter must be nonnull but is marked as nullable]]></name>
- <configKey><![CDATA[NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE]]></configKey>
- </rule>
-
- <rule key="NP_NULL_ON_SOME_PATH">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Possible null pointer dereference]]></name>
- <configKey><![CDATA[NP_NULL_ON_SOME_PATH]]></configKey>
- </rule>
-
- <rule key="NP_NULL_ON_SOME_PATH_MIGHT_BE_INFEASIBLE">
- <priority>CRITICAL</priority>
- <name><![CDATA[Dodgy - Possible null pointer dereference on path that might be infeasible]]></name>
- <configKey><![CDATA[NP_NULL_ON_SOME_PATH_MIGHT_BE_INFEASIBLE]]></configKey>
- </rule>
-
- <rule key="NP_NULL_ON_SOME_PATH_EXCEPTION">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Possible null pointer dereference in method on exception path]]></name>
- <configKey><![CDATA[NP_NULL_ON_SOME_PATH_EXCEPTION]]></configKey>
- </rule>
-
- <rule key="NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE">
- <priority>CRITICAL</priority>
- <name><![CDATA[Dodgy - Possible null pointer dereference due to return value of called method]]></name>
- <configKey><![CDATA[NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE]]></configKey>
- </rule>
-
- <rule key="NP_NULL_PARAM_DEREF_NONVIRTUAL">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Non-virtual method call passes null for nonnull parameter]]></name>
- <configKey><![CDATA[NP_NULL_PARAM_DEREF_NONVIRTUAL]]></configKey>
- </rule>
-
- <rule key="NP_NULL_PARAM_DEREF_ALL_TARGETS_DANGEROUS">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Method call passes null for nonnull parameter (ALL_TARGETS_DANGEROUS)]]></name>
- <configKey><![CDATA[NP_NULL_PARAM_DEREF_ALL_TARGETS_DANGEROUS]]></configKey>
- </rule>
-
- <rule key="NP_NULL_PARAM_DEREF">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Method call passes null for nonnull parameter]]></name>
- <configKey><![CDATA[NP_NULL_PARAM_DEREF]]></configKey>
- </rule>
-
- <rule key="NP_NONNULL_PARAM_VIOLATION">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Method call passes null to a nonnull parameter ]]></name>
- <configKey><![CDATA[NP_NONNULL_PARAM_VIOLATION]]></configKey>
- </rule>
-
- <rule key="NP_NONNULL_RETURN_VIOLATION">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Method may return null, but is declared @NonNull]]></name>
- <configKey><![CDATA[NP_NONNULL_RETURN_VIOLATION]]></configKey>
- </rule>
-
- <rule key="NP_CLONE_COULD_RETURN_NULL">
- <priority>CRITICAL</priority>
- <name><![CDATA[Bad practice - Clone method may return null]]></name>
- <configKey><![CDATA[NP_CLONE_COULD_RETURN_NULL]]></configKey>
- </rule>
-
- <rule key="NP_TOSTRING_COULD_RETURN_NULL">
- <priority>CRITICAL</priority>
- <name><![CDATA[Bad practice - toString method may return null]]></name>
- <configKey><![CDATA[NP_TOSTRING_COULD_RETURN_NULL]]></configKey>
- </rule>
-
- <rule key="NP_GUARANTEED_DEREF">
- <priority>BLOCKER</priority>
- <name><![CDATA[Correctness - Null value is guaranteed to be dereferenced]]></name>
- <configKey><![CDATA[NP_GUARANTEED_DEREF]]></configKey>
- </rule>
-
- <rule key="NP_GUARANTEED_DEREF_ON_EXCEPTION_PATH">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Value is null and guaranteed to be dereferenced on exception path]]></name>
- <configKey><![CDATA[NP_GUARANTEED_DEREF_ON_EXCEPTION_PATH]]></configKey>
- </rule>
-
- <rule key="SI_INSTANCE_BEFORE_FINALS_ASSIGNED">
- <priority>CRITICAL</priority>
- <name><![CDATA[Bad practice - Static initializer creates instance before all static final fields assigned]]></name>
- <configKey><![CDATA[SI_INSTANCE_BEFORE_FINALS_ASSIGNED]]></configKey>
- </rule>
-
- <rule key="OS_OPEN_STREAM">
- <priority>CRITICAL</priority>
- <name><![CDATA[Bad practice - Method may fail to close stream]]></name>
- <configKey><![CDATA[OS_OPEN_STREAM]]></configKey>
- </rule>
-
- <rule key="OS_OPEN_STREAM_EXCEPTION_PATH">
- <priority>CRITICAL</priority>
- <name><![CDATA[Bad practice - Method may fail to close stream on exception]]></name>
- <configKey><![CDATA[OS_OPEN_STREAM_EXCEPTION_PATH]]></configKey>
- </rule>
-
- <rule key="PZLA_PREFER_ZERO_LENGTH_ARRAYS">
- <priority>MAJOR</priority>
- <name><![CDATA[Dodgy - Consider returning a zero length array rather than null]]></name>
- <configKey><![CDATA[PZLA_PREFER_ZERO_LENGTH_ARRAYS]]></configKey>
- </rule>
-
- <rule key="UCF_USELESS_CONTROL_FLOW">
- <priority>CRITICAL</priority>
- <name><![CDATA[Dodgy - Useless control flow]]></name>
- <configKey><![CDATA[UCF_USELESS_CONTROL_FLOW]]></configKey>
- </rule>
-
- <rule key="UCF_USELESS_CONTROL_FLOW_NEXT_LINE">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Useless control flow to next line]]></name>
- <configKey><![CDATA[UCF_USELESS_CONTROL_FLOW_NEXT_LINE]]></configKey>
- </rule>
-
- <rule key="RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Nullcheck of value previously dereferenced]]></name>
- <configKey><![CDATA[RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE]]></configKey>
- </rule>
-
- <rule key="RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE">
- <priority>CRITICAL</priority>
- <name><![CDATA[Dodgy - Redundant nullcheck of value known to be null]]></name>
- <configKey><![CDATA[RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE]]></configKey>
- </rule>
-
- <rule key="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE">
- <priority>CRITICAL</priority>
- <name><![CDATA[Dodgy - Redundant nullcheck of value known to be non-null]]></name>
- <configKey><![CDATA[RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE]]></configKey>
- </rule>
-
- <rule key="RCN_REDUNDANT_COMPARISON_TWO_NULL_VALUES">
- <priority>CRITICAL</priority>
- <name><![CDATA[Dodgy - Redundant comparison of two null values]]></name>
- <configKey><![CDATA[RCN_REDUNDANT_COMPARISON_TWO_NULL_VALUES]]></configKey>
- </rule>
-
- <rule key="RCN_REDUNDANT_COMPARISON_OF_NULL_AND_NONNULL_VALUE">
- <priority>CRITICAL</priority>
- <name><![CDATA[Dodgy - Redundant comparison of non-null value to null]]></name>
- <configKey><![CDATA[RCN_REDUNDANT_COMPARISON_OF_NULL_AND_NONNULL_VALUE]]></configKey>
- </rule>
-
- <rule key="UL_UNRELEASED_LOCK">
- <priority>CRITICAL</priority>
- <name><![CDATA[Multithreaded correctness - Method does not release lock on all paths]]></name>
- <configKey><![CDATA[UL_UNRELEASED_LOCK]]></configKey>
- </rule>
-
- <rule key="UL_UNRELEASED_LOCK_EXCEPTION_PATH">
- <priority>CRITICAL</priority>
- <name><![CDATA[Multithreaded correctness - Method does not release lock on all exception paths]]></name>
- <configKey><![CDATA[UL_UNRELEASED_LOCK_EXCEPTION_PATH]]></configKey>
- </rule>
-
- <rule key="RC_REF_COMPARISON">
- <priority>CRITICAL</priority>
- <name><![CDATA[Bad practice - Suspicious reference comparison]]></name>
- <configKey><![CDATA[RC_REF_COMPARISON]]></configKey>
- </rule>
-
- <rule key="EC_UNRELATED_TYPES_USING_POINTER_EQUALITY">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Using pointer equality to compare different types]]></name>
- <configKey><![CDATA[EC_UNRELATED_TYPES_USING_POINTER_EQUALITY]]></configKey>
- </rule>
-
- <rule key="EC_UNRELATED_TYPES">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Call to equals() comparing different types]]></name>
- <configKey><![CDATA[EC_UNRELATED_TYPES]]></configKey>
- </rule>
-
- <rule key="EC_UNRELATED_INTERFACES">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Call to equals() comparing different interface types]]></name>
- <configKey><![CDATA[EC_UNRELATED_INTERFACES]]></configKey>
- </rule>
-
- <rule key="EC_UNRELATED_CLASS_AND_INTERFACE">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Call to equals() comparing unrelated class and interface]]></name>
- <configKey><![CDATA[EC_UNRELATED_CLASS_AND_INTERFACE]]></configKey>
- </rule>
-
- <rule key="EC_NULL_ARG">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Call to equals() with null argument]]></name>
- <configKey><![CDATA[EC_NULL_ARG]]></configKey>
- </rule>
-
- <rule key="MWN_MISMATCHED_WAIT">
- <priority>CRITICAL</priority>
- <name><![CDATA[Multithreaded correctness - Mismatched wait()]]></name>
- <configKey><![CDATA[MWN_MISMATCHED_WAIT]]></configKey>
- </rule>
-
- <rule key="MWN_MISMATCHED_NOTIFY">
- <priority>CRITICAL</priority>
- <name><![CDATA[Multithreaded correctness - Mismatched notify()]]></name>
- <configKey><![CDATA[MWN_MISMATCHED_NOTIFY]]></configKey>
- </rule>
-
- <rule key="SA_LOCAL_SELF_ASSIGNMENT">
- <priority>CRITICAL</priority>
- <name><![CDATA[Dodgy - Self assignment of local variable]]></name>
- <configKey><![CDATA[SA_LOCAL_SELF_ASSIGNMENT]]></configKey>
- </rule>
-
- <rule key="SA_FIELD_SELF_ASSIGNMENT">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Self assignment of field]]></name>
- <configKey><![CDATA[SA_FIELD_SELF_ASSIGNMENT]]></configKey>
- </rule>
-
- <rule key="SA_FIELD_DOUBLE_ASSIGNMENT">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Double assignment of field]]></name>
- <configKey><![CDATA[SA_FIELD_DOUBLE_ASSIGNMENT]]></configKey>
- </rule>
-
- <rule key="SA_LOCAL_DOUBLE_ASSIGNMENT">
- <priority>CRITICAL</priority>
- <name><![CDATA[Dodgy - Double assignment of local variable ]]></name>
- <configKey><![CDATA[SA_LOCAL_DOUBLE_ASSIGNMENT]]></configKey>
- </rule>
-
- <rule key="SA_FIELD_SELF_COMPUTATION">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Nonsensical self computation involving a field (e.g., x & x)]]></name>
- <configKey><![CDATA[SA_FIELD_SELF_COMPUTATION]]></configKey>
- </rule>
-
- <rule key="SA_LOCAL_SELF_COMPUTATION">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Nonsensical self computation involving a variable (e.g., x & x)]]></name>
- <configKey><![CDATA[SA_LOCAL_SELF_COMPUTATION]]></configKey>
- </rule>
-
- <rule key="SA_FIELD_SELF_COMPARISON">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Self comparison of field with itself]]></name>
- <configKey><![CDATA[SA_FIELD_SELF_COMPARISON]]></configKey>
- </rule>
-
- <rule key="SA_LOCAL_SELF_COMPARISON">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Self comparison of value with itself]]></name>
- <configKey><![CDATA[SA_LOCAL_SELF_COMPARISON]]></configKey>
- </rule>
-
- <rule key="DMI_LONG_BITS_TO_DOUBLE_INVOKED_ON_INT">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Double.longBitsToDouble invoked on an int]]></name>
- <configKey><![CDATA[DMI_LONG_BITS_TO_DOUBLE_INVOKED_ON_INT]]></configKey>
- </rule>
-
- <rule key="DMI_RANDOM_USED_ONLY_ONCE">
- <priority>CRITICAL</priority>
- <name><![CDATA[Bad practice - Random object created and used only once]]></name>
- <configKey><![CDATA[DMI_RANDOM_USED_ONLY_ONCE]]></configKey>
- </rule>
-
- <rule key="RV_ABSOLUTE_VALUE_OF_RANDOM_INT">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Bad attempt to compute absolute value of signed 32-bit random integer]]></name>
- <configKey><![CDATA[RV_ABSOLUTE_VALUE_OF_RANDOM_INT]]></configKey>
- </rule>
-
- <rule key="RV_ABSOLUTE_VALUE_OF_HASHCODE">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Bad attempt to compute absolute value of signed 32-bit hashcode ]]></name>
- <configKey><![CDATA[RV_ABSOLUTE_VALUE_OF_HASHCODE]]></configKey>
- </rule>
-
- <rule key="RV_REM_OF_RANDOM_INT">
- <priority>CRITICAL</priority>
- <name><![CDATA[Dodgy - Remainder of 32-bit signed random integer]]></name>
- <configKey><![CDATA[RV_REM_OF_RANDOM_INT]]></configKey>
- </rule>
-
- <rule key="RV_REM_OF_HASHCODE">
- <priority>CRITICAL</priority>
- <name><![CDATA[Dodgy - Remainder of hashCode could be negative]]></name>
- <configKey><![CDATA[RV_REM_OF_HASHCODE]]></configKey>
- </rule>
-
- <rule key="INT_BAD_COMPARISON_WITH_NONNEGATIVE_VALUE">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Bad comparison of nonnegative value with negative constant]]></name>
- <configKey><![CDATA[INT_BAD_COMPARISON_WITH_NONNEGATIVE_VALUE]]></configKey>
- </rule>
-
- <rule key="INT_BAD_COMPARISON_WITH_SIGNED_BYTE">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Bad comparison of signed byte]]></name>
- <configKey><![CDATA[INT_BAD_COMPARISON_WITH_SIGNED_BYTE]]></configKey>
- </rule>
-
- <rule key="INT_VACUOUS_BIT_OPERATION">
- <priority>CRITICAL</priority>
- <name><![CDATA[Dodgy - Vacuous bit mask operation on integer value]]></name>
- <configKey><![CDATA[INT_VACUOUS_BIT_OPERATION]]></configKey>
- </rule>
-
- <rule key="INT_VACUOUS_COMPARISON">
- <priority>CRITICAL</priority>
- <name><![CDATA[Dodgy - Vacuous comparison of integer value]]></name>
- <configKey><![CDATA[INT_VACUOUS_COMPARISON]]></configKey>
- </rule>
-
- <rule key="INT_BAD_REM_BY_1">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Integer remainder modulo 1]]></name>
- <configKey><![CDATA[INT_BAD_REM_BY_1]]></configKey>
- </rule>
-
- <rule key="BIT_IOR_OF_SIGNED_BYTE">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Bitwise OR of signed byte value]]></name>
- <configKey><![CDATA[BIT_IOR_OF_SIGNED_BYTE]]></configKey>
- </rule>
-
- <rule key="BIT_ADD_OF_SIGNED_BYTE">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Bitwise add of signed byte value]]></name>
- <configKey><![CDATA[BIT_ADD_OF_SIGNED_BYTE]]></configKey>
- </rule>
-
- <rule key="BIT_AND">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Incompatible bit masks (BIT_AND)]]></name>
- <configKey><![CDATA[BIT_AND]]></configKey>
- </rule>
-
- <rule key="BIT_SIGNED_CHECK">
- <priority>CRITICAL</priority>
- <name><![CDATA[Bad practice - Check for sign of bitwise operation]]></name>
- <configKey><![CDATA[BIT_SIGNED_CHECK]]></configKey>
- </rule>
-
- <rule key="BIT_SIGNED_CHECK_HIGH_BIT">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Check for sign of bitwise operation]]></name>
- <configKey><![CDATA[BIT_SIGNED_CHECK_HIGH_BIT]]></configKey>
- </rule>
-
- <rule key="BIT_AND_ZZ">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Check to see if ((...) & 0) == 0]]></name>
- <configKey><![CDATA[BIT_AND_ZZ]]></configKey>
- </rule>
-
- <rule key="BIT_IOR">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Incompatible bit masks (BIT_IOR)]]></name>
- <configKey><![CDATA[BIT_IOR]]></configKey>
- </rule>
-
- <rule key="LI_LAZY_INIT_STATIC">
- <priority>CRITICAL</priority>
- <name><![CDATA[Multithreaded correctness - Incorrect lazy initialization of static field]]></name>
- <configKey><![CDATA[LI_LAZY_INIT_STATIC]]></configKey>
- </rule>
-
- <rule key="LI_LAZY_INIT_UPDATE_STATIC">
- <priority>CRITICAL</priority>
- <name><![CDATA[Multithreaded correctness - Incorrect lazy initialization and update of static field]]></name>
- <configKey><![CDATA[LI_LAZY_INIT_UPDATE_STATIC]]></configKey>
- </rule>
-
- <rule key="JLM_JSR166_LOCK_MONITORENTER">
- <priority>CRITICAL</priority>
- <name><![CDATA[Multithreaded correctness - Synchronization performed on java.util.concurrent Lock]]></name>
- <configKey><![CDATA[JLM_JSR166_LOCK_MONITORENTER]]></configKey>
- </rule>
-
- <rule key="UPM_UNCALLED_PRIVATE_METHOD">
- <priority>CRITICAL</priority>
- <name><![CDATA[Performance - Private method is never called]]></name>
- <configKey><![CDATA[UPM_UNCALLED_PRIVATE_METHOD]]></configKey>
- </rule>
-
- <rule key="UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Uncallable method defined in anonymous class]]></name>
- <configKey><![CDATA[UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS]]></configKey>
- </rule>
-
- <rule key="ODR_OPEN_DATABASE_RESOURCE">
- <priority>CRITICAL</priority>
- <name><![CDATA[Bad practice - Method may fail to close database resource]]></name>
- <configKey><![CDATA[ODR_OPEN_DATABASE_RESOURCE]]></configKey>
- </rule>
-
- <rule key="ODR_OPEN_DATABASE_RESOURCE_EXCEPTION_PATH">
- <priority>CRITICAL</priority>
- <name><![CDATA[Bad practice - Method may fail to close database resource on exception]]></name>
- <configKey><![CDATA[ODR_OPEN_DATABASE_RESOURCE_EXCEPTION_PATH]]></configKey>
- </rule>
-
- <rule key="SBSC_USE_STRINGBUFFER_CONCATENATION">
- <priority>CRITICAL</priority>
- <name><![CDATA[Performance - Method concatenates strings using + in a loop]]></name>
- <configKey><![CDATA[SBSC_USE_STRINGBUFFER_CONCATENATION]]></configKey>
- </rule>
-
- <rule key="ITA_INEFFICIENT_TO_ARRAY">
- <priority>CRITICAL</priority>
- <name><![CDATA[Performance - Method uses toArray() with zero-length array argument]]></name>
- <configKey><![CDATA[ITA_INEFFICIENT_TO_ARRAY]]></configKey>
- </rule>
-
- <rule key="IJU_ASSERT_METHOD_INVOKED_FROM_RUN_METHOD">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - JUnit assertion in run method will not be noticed by JUnit]]></name>
- <configKey><![CDATA[IJU_ASSERT_METHOD_INVOKED_FROM_RUN_METHOD]]></configKey>
- </rule>
-
- <rule key="IJU_SETUP_NO_SUPER">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - TestCase defines setUp that doesn't call super.setUp()]]></name>
- <configKey><![CDATA[IJU_SETUP_NO_SUPER]]></configKey>
- </rule>
-
- <rule key="IJU_TEARDOWN_NO_SUPER">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - TestCase defines tearDown that doesn't call super.tearDown()]]></name>
- <configKey><![CDATA[IJU_TEARDOWN_NO_SUPER]]></configKey>
- </rule>
-
- <rule key="IJU_SUITE_NOT_STATIC">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - TestCase implements a non-static suite method ]]></name>
- <configKey><![CDATA[IJU_SUITE_NOT_STATIC]]></configKey>
- </rule>
-
- <rule key="IJU_BAD_SUITE_METHOD">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - TestCase declares a bad suite method ]]></name>
- <configKey><![CDATA[IJU_BAD_SUITE_METHOD]]></configKey>
- </rule>
-
- <rule key="IJU_NO_TESTS">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - TestCase has no tests]]></name>
- <configKey><![CDATA[IJU_NO_TESTS]]></configKey>
- </rule>
-
- <rule key="BOA_BADLY_OVERRIDDEN_ADAPTER">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Class overrides a method implemented in super class Adapter wrongly]]></name>
- <configKey><![CDATA[BOA_BADLY_OVERRIDDEN_ADAPTER]]></configKey>
- </rule>
-
- <rule key="SQL_BAD_RESULTSET_ACCESS">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Method attempts to access a result set field with index 0]]></name>
- <configKey><![CDATA[SQL_BAD_RESULTSET_ACCESS]]></configKey>
- </rule>
-
- <rule key="SQL_BAD_PREPARED_STATEMENT_ACCESS">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Method attempts to access a prepared statement parameter with index 0]]></name>
- <configKey><![CDATA[SQL_BAD_PREPARED_STATEMENT_ACCESS]]></configKey>
- </rule>
-
- <rule key="SIO_SUPERFLUOUS_INSTANCEOF">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Unnecessary type check done using instanceof operator]]></name>
- <configKey><![CDATA[SIO_SUPERFLUOUS_INSTANCEOF]]></configKey>
- </rule>
-
- <rule key="EC_ARRAY_AND_NONARRAY">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - equals() used to compare array and nonarray]]></name>
- <configKey><![CDATA[EC_ARRAY_AND_NONARRAY]]></configKey>
- </rule>
-
- <rule key="EC_BAD_ARRAY_COMPARE">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Invocation of equals() on an array, which is equivalent to ==]]></name>
- <configKey><![CDATA[EC_BAD_ARRAY_COMPARE]]></configKey>
- </rule>
-
- <rule key="STI_INTERRUPTED_ON_CURRENTTHREAD">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Unneeded use of currentThread() call, to call interrupted() ]]></name>
- <configKey><![CDATA[STI_INTERRUPTED_ON_CURRENTTHREAD]]></configKey>
- </rule>
-
- <rule key="STI_INTERRUPTED_ON_UNKNOWNTHREAD">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Static Thread.interrupted() method invoked on thread instance]]></name>
- <configKey><![CDATA[STI_INTERRUPTED_ON_UNKNOWNTHREAD]]></configKey>
- </rule>
-
- <rule key="IP_PARAMETER_IS_DEAD_BUT_OVERWRITTEN">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - A parameter is dead upon entry to a method but overwritten]]></name>
- <configKey><![CDATA[IP_PARAMETER_IS_DEAD_BUT_OVERWRITTEN]]></configKey>
- </rule>
-
- <rule key="DLS_DEAD_LOCAL_STORE">
- <priority>CRITICAL</priority>
- <name><![CDATA[Dodgy - Dead store to local variable]]></name>
- <configKey><![CDATA[DLS_DEAD_LOCAL_STORE]]></configKey>
- </rule>
-
- <rule key="DLS_DEAD_LOCAL_STORE_IN_RETURN">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Useless assignment in return statement]]></name>
- <configKey><![CDATA[DLS_DEAD_LOCAL_STORE_IN_RETURN]]></configKey>
- </rule>
-
- <rule key="DLS_DEAD_STORE_OF_CLASS_LITERAL">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Dead store of class literal]]></name>
- <configKey><![CDATA[DLS_DEAD_STORE_OF_CLASS_LITERAL]]></configKey>
- </rule>
-
- <rule key="DLS_DEAD_LOCAL_STORE_OF_NULL">
- <priority>CRITICAL</priority>
- <name><![CDATA[Dodgy - Dead store of null to local variable]]></name>
- <configKey><![CDATA[DLS_DEAD_LOCAL_STORE_OF_NULL]]></configKey>
- </rule>
-
- <rule key="MF_METHOD_MASKS_FIELD">
- <priority>MAJOR</priority>
- <name><![CDATA[Correctness - Method defines a variable that obscures a field]]></name>
- <configKey><![CDATA[MF_METHOD_MASKS_FIELD]]></configKey>
- </rule>
-
- <rule key="MF_CLASS_MASKS_FIELD">
- <priority>MAJOR</priority>
- <name><![CDATA[Correctness - Class defines field that masks a superclass field]]></name>
- <configKey><![CDATA[MF_CLASS_MASKS_FIELD]]></configKey>
- </rule>
-
- <rule key="WMI_WRONG_MAP_ITERATOR">
- <priority>CRITICAL</priority>
- <name><![CDATA[Performance - Inefficient use of keySet iterator instead of entrySet iterator]]></name>
- <configKey><![CDATA[WMI_WRONG_MAP_ITERATOR]]></configKey>
- </rule>
-
- <rule key="ISC_INSTANTIATE_STATIC_CLASS">
- <priority>MAJOR</priority>
- <name><![CDATA[Bad practice - Needless instantiation of class that only supplies static methods]]></name>
- <configKey><![CDATA[ISC_INSTANTIATE_STATIC_CLASS]]></configKey>
- </rule>
-
- <rule key="REC_CATCH_EXCEPTION">
- <priority>MAJOR</priority>
- <name><![CDATA[Dodgy - Exception is caught when Exception is not thrown]]></name>
- <configKey><![CDATA[REC_CATCH_EXCEPTION]]></configKey>
- </rule>
-
- <rule key="FE_TEST_IF_EQUAL_TO_NOT_A_NUMBER">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Doomed test for equality to NaN]]></name>
- <configKey><![CDATA[FE_TEST_IF_EQUAL_TO_NOT_A_NUMBER]]></configKey>
- </rule>
-
- <rule key="FE_FLOATING_POINT_EQUALITY">
- <priority>CRITICAL</priority>
- <name><![CDATA[Dodgy - Test for floating point equality]]></name>
- <configKey><![CDATA[FE_FLOATING_POINT_EQUALITY]]></configKey>
- </rule>
-
- <rule key="UM_UNNECESSARY_MATH">
- <priority>CRITICAL</priority>
- <name><![CDATA[Performance - Method calls static Math class method on a constant value]]></name>
- <configKey><![CDATA[UM_UNNECESSARY_MATH]]></configKey>
- </rule>
-
- <rule key="RI_REDUNDANT_INTERFACES">
- <priority>MAJOR</priority>
- <name><![CDATA[Dodgy - Class implements same interface as superclass]]></name>
- <configKey><![CDATA[RI_REDUNDANT_INTERFACES]]></configKey>
- </rule>
-
- <rule key="MTIA_SUSPECT_STRUTS_INSTANCE_FIELD">
- <priority>CRITICAL</priority>
- <name><![CDATA[Dodgy - Class extends Struts Action class and uses instance variables]]></name>
- <configKey><![CDATA[MTIA_SUSPECT_STRUTS_INSTANCE_FIELD]]></configKey>
- </rule>
-
- <rule key="MTIA_SUSPECT_SERVLET_INSTANCE_FIELD">
- <priority>CRITICAL</priority>
- <name><![CDATA[Dodgy - Class extends Servlet class and uses instance variables]]></name>
- <configKey><![CDATA[MTIA_SUSPECT_SERVLET_INSTANCE_FIELD]]></configKey>
- </rule>
-
- <rule key="PS_PUBLIC_SEMAPHORES">
- <priority>CRITICAL</priority>
- <name><![CDATA[Dodgy - Class exposes synchronization and semaphores in its public interface]]></name>
- <configKey><![CDATA[PS_PUBLIC_SEMAPHORES]]></configKey>
- </rule>
-
- <rule key="ICAST_INTEGER_MULTIPLY_CAST_TO_LONG">
- <priority>CRITICAL</priority>
- <name><![CDATA[Dodgy - Result of integer multiplication cast to long]]></name>
- <configKey><![CDATA[ICAST_INTEGER_MULTIPLY_CAST_TO_LONG]]></configKey>
- </rule>
-
- <rule key="ICAST_INT_CAST_TO_FLOAT_PASSED_TO_ROUND">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - int value cast to float and then passed to Math.round]]></name>
- <configKey><![CDATA[ICAST_INT_CAST_TO_FLOAT_PASSED_TO_ROUND]]></configKey>
- </rule>
-
- <rule key="ICAST_INT_CAST_TO_DOUBLE_PASSED_TO_CEIL">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - int value cast to double and then passed to Math.ceil]]></name>
- <configKey><![CDATA[ICAST_INT_CAST_TO_DOUBLE_PASSED_TO_CEIL]]></configKey>
- </rule>
-
- <rule key="ICAST_IDIV_CAST_TO_DOUBLE">
- <priority>CRITICAL</priority>
- <name><![CDATA[Dodgy - int division result cast to double or float]]></name>
- <configKey><![CDATA[ICAST_IDIV_CAST_TO_DOUBLE]]></configKey>
- </rule>
-
- <rule key="J2EE_STORE_OF_NON_SERIALIZABLE_OBJECT_INTO_SESSION">
- <priority>CRITICAL</priority>
- <name><![CDATA[Bad practice - Store of non serializable object into HttpSession]]></name>
- <configKey><![CDATA[J2EE_STORE_OF_NON_SERIALIZABLE_OBJECT_INTO_SESSION]]></configKey>
- </rule>
-
- <rule key="DMI_NONSERIALIZABLE_OBJECT_WRITTEN">
- <priority>CRITICAL</priority>
- <name><![CDATA[Dodgy - Non serializable object written to ObjectOutput]]></name>
- <configKey><![CDATA[DMI_NONSERIALIZABLE_OBJECT_WRITTEN]]></configKey>
- </rule>
-
- <rule key="VA_FORMAT_STRING_NO_PREVIOUS_ARGUMENT">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - No previous argument for format string]]></name>
- <configKey><![CDATA[VA_FORMAT_STRING_NO_PREVIOUS_ARGUMENT]]></configKey>
- </rule>
-
- <rule key="VA_FORMAT_STRING_BAD_CONVERSION">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - The type of a supplied argument doesn't match format specifier]]></name>
- <configKey><![CDATA[VA_FORMAT_STRING_BAD_CONVERSION]]></configKey>
- </rule>
-
- <rule key="VA_FORMAT_STRING_BAD_CONVERSION_TO_BOOLEAN">
- <priority>MAJOR</priority>
- <name><![CDATA[Dodgy - Non-Boolean argument formatted using %b format specifier]]></name>
- <configKey><![CDATA[VA_FORMAT_STRING_BAD_CONVERSION_TO_BOOLEAN]]></configKey>
- </rule>
-
- <rule key="VA_FORMAT_STRING_BAD_CONVERSION_FROM_ARRAY">
- <priority>MAJOR</priority>
- <name><![CDATA[Correctness - Array formatted in useless way using format string]]></name>
- <configKey><![CDATA[VA_FORMAT_STRING_BAD_CONVERSION_FROM_ARRAY]]></configKey>
- </rule>
-
- <rule key="VA_FORMAT_STRING_ARG_MISMATCH">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Number of format-string arguments does not correspond to number of placeholders]]></name>
- <configKey><![CDATA[VA_FORMAT_STRING_ARG_MISMATCH]]></configKey>
- </rule>
-
- <rule key="VA_FORMAT_STRING_EXTRA_ARGUMENTS_PASSED">
- <priority>MAJOR</priority>
- <name><![CDATA[Correctness - More arguments are passed that are actually used in the format string]]></name>
- <configKey><![CDATA[VA_FORMAT_STRING_EXTRA_ARGUMENTS_PASSED]]></configKey>
- </rule>
-
- <rule key="VA_FORMAT_STRING_ILLEGAL">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Illegal format string]]></name>
- <configKey><![CDATA[VA_FORMAT_STRING_ILLEGAL]]></configKey>
- </rule>
-
- <rule key="VA_FORMAT_STRING_MISSING_ARGUMENT">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Format string references missing argument]]></name>
- <configKey><![CDATA[VA_FORMAT_STRING_MISSING_ARGUMENT]]></configKey>
- </rule>
-
- <rule key="VA_FORMAT_STRING_BAD_ARGUMENT">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Format string placeholder incompatible with passed argument]]></name>
- <configKey><![CDATA[VA_FORMAT_STRING_BAD_ARGUMENT]]></configKey>
- </rule>
-
- <rule key="VA_PRIMITIVE_ARRAY_PASSED_TO_OBJECT_VARARG">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Primitive array passed to function expecting a variable number of object arguments]]></name>
- <configKey><![CDATA[VA_PRIMITIVE_ARRAY_PASSED_TO_OBJECT_VARARG]]></configKey>
- </rule>
-
- <rule key="BC_EQUALS_METHOD_SHOULD_WORK_FOR_ALL_OBJECTS">
- <priority>CRITICAL</priority>
- <name><![CDATA[Bad practice - Equals method should not assume anything about the type of its argument]]></name>
- <configKey><![CDATA[BC_EQUALS_METHOD_SHOULD_WORK_FOR_ALL_OBJECTS]]></configKey>
- </rule>
-
- <rule key="BC_BAD_CAST_TO_ABSTRACT_COLLECTION">
- <priority>MAJOR</priority>
- <name><![CDATA[Dodgy - Questionable cast to abstract collection ]]></name>
- <configKey><![CDATA[BC_BAD_CAST_TO_ABSTRACT_COLLECTION]]></configKey>
- </rule>
-
- <rule key="BC_IMPOSSIBLE_CAST">
- <priority>BLOCKER</priority>
- <name><![CDATA[Correctness - Impossible cast]]></name>
- <configKey><![CDATA[BC_IMPOSSIBLE_CAST]]></configKey>
- </rule>
-
- <rule key="NP_NULL_INSTANCEOF">
- <priority>BLOCKER</priority>
- <name><![CDATA[Correctness - A known null value is checked to see if it is an instance of a type]]></name>
- <configKey><![CDATA[NP_NULL_INSTANCEOF]]></configKey>
- </rule>
-
- <rule key="BC_IMPOSSIBLE_INSTANCEOF">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - instanceof will always return false]]></name>
- <configKey><![CDATA[BC_IMPOSSIBLE_INSTANCEOF]]></configKey>
- </rule>
-
- <rule key="BC_VACUOUS_INSTANCEOF">
- <priority>CRITICAL</priority>
- <name><![CDATA[Dodgy - instanceof will always return true]]></name>
- <configKey><![CDATA[BC_VACUOUS_INSTANCEOF]]></configKey>
- </rule>
-
- <rule key="BC_UNCONFIRMED_CAST">
- <priority>CRITICAL</priority>
- <name><![CDATA[Dodgy - Unchecked/unconfirmed cast]]></name>
- <configKey><![CDATA[BC_UNCONFIRMED_CAST]]></configKey>
- </rule>
-
- <rule key="BC_BAD_CAST_TO_CONCRETE_COLLECTION">
- <priority>CRITICAL</priority>
- <name><![CDATA[Dodgy - Questionable cast to concrete collection]]></name>
- <configKey><![CDATA[BC_BAD_CAST_TO_CONCRETE_COLLECTION]]></configKey>
- </rule>
-
- <rule key="RE_POSSIBLE_UNINTENDED_PATTERN">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - "." used for regular expression]]></name>
- <configKey><![CDATA[RE_POSSIBLE_UNINTENDED_PATTERN]]></configKey>
- </rule>
-
- <rule key="RE_BAD_SYNTAX_FOR_REGULAR_EXPRESSION">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Invalid syntax for regular expression]]></name>
- <configKey><![CDATA[RE_BAD_SYNTAX_FOR_REGULAR_EXPRESSION]]></configKey>
- </rule>
-
- <rule key="RE_CANT_USE_FILE_SEPARATOR_AS_REGULAR_EXPRESSION">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - File.separator used for regular expression]]></name>
- <configKey><![CDATA[RE_CANT_USE_FILE_SEPARATOR_AS_REGULAR_EXPRESSION]]></configKey>
- </rule>
-
- <rule key="DLS_OVERWRITTEN_INCREMENT">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Overwritten increment]]></name>
- <configKey><![CDATA[DLS_OVERWRITTEN_INCREMENT]]></configKey>
- </rule>
-
- <rule key="ICAST_QUESTIONABLE_UNSIGNED_RIGHT_SHIFT">
- <priority>CRITICAL</priority>
- <name><![CDATA[Dodgy - Unsigned right shift cast to short/byte]]></name>
- <configKey><![CDATA[ICAST_QUESTIONABLE_UNSIGNED_RIGHT_SHIFT]]></configKey>
- </rule>
-
- <rule key="ICAST_BAD_SHIFT_AMOUNT">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Integer shift by an amount not in the range 0..31]]></name>
- <configKey><![CDATA[ICAST_BAD_SHIFT_AMOUNT]]></configKey>
- </rule>
-
- <rule key="IM_MULTIPLYING_RESULT_OF_IREM">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Integer multiply of result of integer remainder]]></name>
- <configKey><![CDATA[IM_MULTIPLYING_RESULT_OF_IREM]]></configKey>
- </rule>
-
- <rule key="DMI_INVOKING_HASHCODE_ON_ARRAY">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Invocation of hashCode on an array]]></name>
- <configKey><![CDATA[DMI_INVOKING_HASHCODE_ON_ARRAY]]></configKey>
- </rule>
-
- <rule key="DMI_INVOKING_TOSTRING_ON_ARRAY">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Invocation of toString on an array]]></name>
- <configKey><![CDATA[DMI_INVOKING_TOSTRING_ON_ARRAY]]></configKey>
- </rule>
-
- <rule key="DMI_INVOKING_TOSTRING_ON_ANONYMOUS_ARRAY">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Invocation of toString on an anonymous array]]></name>
- <configKey><![CDATA[DMI_INVOKING_TOSTRING_ON_ANONYMOUS_ARRAY]]></configKey>
- </rule>
-
- <rule key="IM_AVERAGE_COMPUTATION_COULD_OVERFLOW">
- <priority>CRITICAL</priority>
- <name><![CDATA[Dodgy - Computation of average could overflow]]></name>
- <configKey><![CDATA[IM_AVERAGE_COMPUTATION_COULD_OVERFLOW]]></configKey>
- </rule>
-
- <rule key="IM_BAD_CHECK_FOR_ODD">
- <priority>CRITICAL</priority>
- <name><![CDATA[Dodgy - Check for oddness that won't work for negative numbers ]]></name>
- <configKey><![CDATA[IM_BAD_CHECK_FOR_ODD]]></configKey>
- </rule>
-
- <rule key="DMI_HARDCODED_ABSOLUTE_FILENAME">
- <priority>CRITICAL</priority>
- <name><![CDATA[Dodgy - Code contains a hard coded reference to an absolute pathname]]></name>
- <configKey><![CDATA[DMI_HARDCODED_ABSOLUTE_FILENAME]]></configKey>
- </rule>
-
- <rule key="DMI_BAD_MONTH">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Bad constant value for month]]></name>
- <configKey><![CDATA[DMI_BAD_MONTH]]></configKey>
- </rule>
-
- <rule key="DMI_USELESS_SUBSTRING">
- <priority>CRITICAL</priority>
- <name><![CDATA[Dodgy - Invocation of substring(0), which returns the original value]]></name>
- <configKey><![CDATA[DMI_USELESS_SUBSTRING]]></configKey>
- </rule>
-
- <rule key="DMI_CALLING_NEXT_FROM_HASNEXT">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - hasNext method invokes next]]></name>
- <configKey><![CDATA[DMI_CALLING_NEXT_FROM_HASNEXT]]></configKey>
- </rule>
-
- <rule key="SWL_SLEEP_WITH_LOCK_HELD">
- <priority>CRITICAL</priority>
- <name><![CDATA[Multithreaded correctness - Method calls Thread.sleep() with a lock held]]></name>
- <configKey><![CDATA[SWL_SLEEP_WITH_LOCK_HELD]]></configKey>
- </rule>
-
- <rule key="DB_DUPLICATE_BRANCHES">
- <priority>CRITICAL</priority>
- <name><![CDATA[Dodgy - Method uses the same code for two branches]]></name>
- <configKey><![CDATA[DB_DUPLICATE_BRANCHES]]></configKey>
- </rule>
-
- <rule key="DB_DUPLICATE_SWITCH_CLAUSES">
- <priority>CRITICAL</priority>
- <name><![CDATA[Dodgy - Method uses the same code for two switch clauses]]></name>
- <configKey><![CDATA[DB_DUPLICATE_SWITCH_CLAUSES]]></configKey>
- </rule>
-
- <rule key="XFB_XML_FACTORY_BYPASS">
- <priority>CRITICAL</priority>
- <name><![CDATA[Dodgy - Method directly allocates a specific implementation of xml interfaces]]></name>
- <configKey><![CDATA[XFB_XML_FACTORY_BYPASS]]></configKey>
- </rule>
-
- <rule key="CI_CONFUSED_INHERITANCE">
- <priority>MINOR</priority>
- <name><![CDATA[Dodgy - Class is final but declares protected field]]></name>
- <configKey><![CDATA[CI_CONFUSED_INHERITANCE]]></configKey>
- </rule>
-
- <rule key="QBA_QUESTIONABLE_BOOLEAN_ASSIGNMENT">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Method assigns boolean literal in boolean expression]]></name>
- <configKey><![CDATA[QBA_QUESTIONABLE_BOOLEAN_ASSIGNMENT]]></configKey>
- </rule>
-
- <rule key="GC_UNCHECKED_TYPE_IN_GENERIC_CALL">
- <priority>CRITICAL</priority>
- <name><![CDATA[Bad practice - Unchecked type in generic call]]></name>
- <configKey><![CDATA[GC_UNCHECKED_TYPE_IN_GENERIC_CALL]]></configKey>
- </rule>
-
- <rule key="GC_UNRELATED_TYPES">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - No relationship between generic parameter and method argument]]></name>
- <configKey><![CDATA[GC_UNRELATED_TYPES]]></configKey>
- </rule>
-
- <rule key="DMI_COLLECTIONS_SHOULD_NOT_CONTAIN_THEMSELVES">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Collections should not contain themselves]]></name>
- <configKey><![CDATA[DMI_COLLECTIONS_SHOULD_NOT_CONTAIN_THEMSELVES]]></configKey>
- </rule>
-
- <rule key="DMI_VACUOUS_SELF_COLLECTION_CALL">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Vacuous call to collections]]></name>
- <configKey><![CDATA[DMI_VACUOUS_SELF_COLLECTION_CALL]]></configKey>
- </rule>
-
- <rule key="DMI_USING_REMOVEALL_TO_CLEAR_COLLECTION">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Don't use removeAll to clear a collection]]></name>
- <configKey><![CDATA[DMI_USING_REMOVEALL_TO_CLEAR_COLLECTION]]></configKey>
- </rule>
-
- <rule key="STCAL_STATIC_CALENDAR_INSTANCE">
- <priority>CRITICAL</priority>
- <name><![CDATA[Multithreaded correctness - Static Calendar]]></name>
- <configKey><![CDATA[STCAL_STATIC_CALENDAR_INSTANCE]]></configKey>
- </rule>
-
- <rule key="STCAL_INVOKE_ON_STATIC_CALENDAR_INSTANCE">
- <priority>CRITICAL</priority>
- <name><![CDATA[Multithreaded correctness - Call to static Calendar]]></name>
- <configKey><![CDATA[STCAL_INVOKE_ON_STATIC_CALENDAR_INSTANCE]]></configKey>
- </rule>
-
- <rule key="STCAL_STATIC_SIMPLE_DATE_FORMAT_INSTANCE">
- <priority>CRITICAL</priority>
- <name><![CDATA[Multithreaded correctness - Static DateFormat]]></name>
- <configKey><![CDATA[STCAL_STATIC_SIMPLE_DATE_FORMAT_INSTANCE]]></configKey>
- </rule>
-
- <rule key="STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE">
- <priority>CRITICAL</priority>
- <name><![CDATA[Multithreaded correctness - Call to static DateFormat]]></name>
- <configKey><![CDATA[STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE]]></configKey>
- </rule>
-
- <rule key="TQ_ALWAYS_VALUE_USED_WHERE_NEVER_REQUIRED">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Value annotated as carrying a type qualifier used where a value that must not carry that qualifier is required]]></name>
- <configKey><![CDATA[TQ_ALWAYS_VALUE_USED_WHERE_NEVER_REQUIRED]]></configKey>
- </rule>
-
- <rule key="TQ_NEVER_VALUE_USED_WHERE_ALWAYS_REQUIRED">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Value annotated as never carrying a type qualifier used where value carrying that qualifier is required]]></name>
- <configKey><![CDATA[TQ_NEVER_VALUE_USED_WHERE_ALWAYS_REQUIRED]]></configKey>
- </rule>
-
- <rule key="TQ_MAYBE_SOURCE_VALUE_REACHES_ALWAYS_SINK">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Value that might not carry a type qualifier is always used in a way requires that type qualifier]]></name>
- <configKey><![CDATA[TQ_MAYBE_SOURCE_VALUE_REACHES_ALWAYS_SINK]]></configKey>
- </rule>
-
- <rule key="TQ_MAYBE_SOURCE_VALUE_REACHES_NEVER_SINK">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Value that might carry a type qualifier is always used in a way prohibits it from having that type qualifier]]></name>
- <configKey><![CDATA[TQ_MAYBE_SOURCE_VALUE_REACHES_NEVER_SINK]]></configKey>
- </rule>
-
- <rule key="TQ_EXPLICIT_UNKNOWN_SOURCE_VALUE_REACHES_NEVER_SINK">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Value required to not have type qualifier, but marked as unknown]]></name>
- <configKey><![CDATA[TQ_EXPLICIT_UNKNOWN_SOURCE_VALUE_REACHES_NEVER_SINK]]></configKey>
- </rule>
-
- <rule key="TQ_EXPLICIT_UNKNOWN_SOURCE_VALUE_REACHES_ALWAYS_SINK">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Value required to have type qualifier, but marked as unknown]]></name>
- <configKey><![CDATA[TQ_EXPLICIT_UNKNOWN_SOURCE_VALUE_REACHES_ALWAYS_SINK]]></configKey>
- </rule>
-
- <rule key="IO_APPENDING_TO_OBJECT_OUTPUT_STREAM">
- <priority>CRITICAL</priority>
- <name><![CDATA[Correctness - Doomed attempt to append to an object output stream]]></name>
- <configKey><![CDATA[IO_APPENDING_TO_OBJECT_OUTPUT_STREAM]]></configKey>
- </rule>
-
- <rule key="WL_USING_GETCLASS_RATHER_THAN_CLASS_LITERAL">
- <priority>CRITICAL</priority>
- <name><![CDATA[Multithreaded correctness - Sychronization on getClass rather than class literal]]></name>
- <configKey><![CDATA[WL_USING_GETCLASS_RATHER_THAN_CLASS_LITERAL]]></configKey>
- </rule>
-
- <rule key="SF_SWITCH_FALLTHROUGH">
- <priority>CRITICAL</priority>
- <name><![CDATA[Switch statement found where one case falls through to the next case]]></name>
- <configKey><![CDATA[SF_SWITCH_FALLTHROUGH]]></configKey>
- </rule>
-
- <rule key="SF_SWITCH_NO_DEFAULT">
- <priority>MAJOR</priority>
- <name><![CDATA[Switch statement found where default case is missing]]></name>
- <configKey><![CDATA[SF_SWITCH_NO_DEFAULT]]></configKey>
- </rule>
-
- <rule key="SF_DEAD_STORE_DUE_TO_SWITCH_FALLTHROUGH">
- <priority>CRITICAL</priority>
- <name><![CDATA[Dead store due to switch statement fall through]]></name>
- <configKey><![CDATA[SF_DEAD_STORE_DUE_TO_SWITCH_FALLTHROUGH]]></configKey>
- </rule>
-
- <rule key="SF_DEAD_STORE_DUE_TO_SWITCH_FALLTHROUGH_TO_THROW">
- <priority>CRITICAL</priority>
- <name><![CDATA[Dead store due to switch statement fall through to throw]]></name>
- <configKey><![CDATA[SF_DEAD_STORE_DUE_TO_SWITCH_FALLTHROUGH_TO_THROW]]></configKey>
- </rule>
-
- <rule key="NM_CLASS_NAMING_CONVENTION">
- <priority>MAJOR</priority>
- <name><![CDATA[Class names should start with an upper case letter]]></name>
- <configKey><![CDATA[NM_CLASS_NAMING_CONVENTION]]></configKey>
- </rule>
-
- <rule key="NM_FIELD_NAMING_CONVENTION">
- <priority>MAJOR</priority>
- <name><![CDATA[Field names should start with a lower case letter]]></name>
- <configKey><![CDATA[NM_FIELD_NAMING_CONVENTION]]></configKey>
- </rule>
-
- <rule key="NM_METHOD_NAMING_CONVENTION">
- <priority>MAJOR</priority>
- <name><![CDATA[Method names should start with a lower case letter]]></name>
- <configKey><![CDATA[NM_METHOD_NAMING_CONVENTION]]></configKey>
- </rule>
-
- <rule key="SE_BAD_FIELD">
- <priority>MAJOR</priority>
- <name><![CDATA[Non-transient non-serializable instance field in serializable class]]></name>
- <configKey><![CDATA[SE_BAD_FIELD]]></configKey>
- </rule>
-
- <rule key="NM_BAD_EQUAL">
- <priority>CRITICAL</priority>
- <name><![CDATA[Class defines equal(Object); should it be equals(Object)?]]></name>
- <configKey><![CDATA[NM_BAD_EQUAL]]></configKey>
- </rule>
-
- <rule key="NM_LCASE_HASHCODE">
- <priority>CRITICAL</priority>
- <name><![CDATA[Class defines hashcode(); should it be hashCode()?]]></name>
- <configKey><![CDATA[NM_LCASE_HASHCODE]]></configKey>
- </rule>
-
- <rule key="NM_LCASE_TOSTRING">
- <priority>MAJOR</priority>
- <name><![CDATA[Class defines tostring(); should it be toString()?]]></name>
- <configKey><![CDATA[NM_LCASE_TOSTRING]]></configKey>
- </rule>
-
- <rule key="NM_LCASE_TOSTRING">
- <priority>MAJOR</priority>
- <name><![CDATA[Class defines tostring(); should it be toString()?]]></name>
- <configKey><![CDATA[NM_LCASE_TOSTRING]]></configKey>
- </rule>
-
- <rule key="BAC_BAD_APPLET_CONSTRUCTOR">
- <priority>INFO</priority>
- <name><![CDATA[Experimental - Bad Applet Constructor relies on uninitialized AppletStub]]></name>
- <configKey><![CDATA[BAC_BAD_APPLET_CONSTRUCTOR]]></configKey>
- </rule>
-
- <rule key="UOE_USE_OBJECT_EQUALS">
- <priority>INFO</priority>
- <name><![CDATA[Experimental - Calls to equals on a final class that doesn't override Object's equals method]]></name>
- <configKey><![CDATA[UOE_USE_OBJECT_EQUALS]]></configKey>
- </rule>
-
- <rule key="CD_CIRCULAR_DEPENDENCY">
- <priority>INFO</priority>
- <name><![CDATA[Experimental - Test for circular dependencies among classes]]></name>
- <configKey><![CDATA[CD_CIRCULAR_DEPENDENCY]]></configKey>
- </rule>
-
- <rule key="IMA_INEFFICIENT_MEMBER_ACCESS">
- <priority>INFO</priority>
- <name><![CDATA[Experimental - Method accesses a private member variable of owning class]]></name>
- <configKey><![CDATA[IMA_INEFFICIENT_MEMBER_ACCESS]]></configKey>
- </rule>
-
- <rule key="USM_USELESS_SUBCLASS_METHOD">
- <priority>INFO</priority>
- <name><![CDATA[Experimental - Method superfluously delegates to parent class method]]></name>
- <configKey><![CDATA[USM_USELESS_SUBCLASS_METHOD]]></configKey>
- </rule>
-
- <rule key="USM_USELESS_ABSTRACT_METHOD">
- <priority>INFO</priority>
- <name><![CDATA[Experimental - Abstract Method is already defined in implemented interface]]></name>
- <configKey><![CDATA[USM_USELESS_ABSTRACT_METHOD]]></configKey>
- </rule>
-
- <rule key="OBL_UNSATISFIED_OBLIGATION">
- <priority>INFO</priority>
- <name><![CDATA[Experimental - Method may fail to clean up stream or resource]]></name>
- <configKey><![CDATA[OBL_UNSATISFIED_OBLIGATION]]></configKey>
- </rule>
-
- <rule key="FB_UNEXPECTED_WARNING">
- <priority>INFO</priority>
- <name><![CDATA[Experimental - Unexpected/undesired warning from FindBugs]]></name>
- <configKey><![CDATA[FB_UNEXPECTED_WARNING]]></configKey>
- </rule>
-
- <rule key="FB_MISSING_EXPECTED_WARNING">
- <priority>INFO</priority>
- <name><![CDATA[Experimental - Missing expected or desired warning from FindBugs]]></name>
- <configKey><![CDATA[FB_MISSING_EXPECTED_WARNING]]></configKey>
- </rule>
-
- <rule key="LG_LOST_LOGGER_DUE_TO_WEAK_REFERENCE">
- <priority>INFO</priority>
- <name><![CDATA[Experimental - Potential lost logger changes due to weak reference in OpenJDK]]></name>
- <configKey><![CDATA[LG_LOST_LOGGER_DUE_TO_WEAK_REFERENCE]]></configKey>
- </rule>
-
- <rule key="AT_OPERATION_SEQUENCE_ON_CONCURRENT_ABSTRACTION">
- <priority>MAJOR</priority>
- <name><![CDATA[Sequence of calls to concurrent abstraction may not be atomic]]></name>
- <configKey><![CDATA[AT_OPERATION_SEQUENCE_ON_CONCURRENT_ABSTRACTION]]></configKey>
- </rule>
-
- <rule key="BX_UNBOXING_IMMEDIATELY_REBOXED">
- <priority>MAJOR</priority>
- <name><![CDATA[Boxed value is unboxed and then immediately reboxed]]></name>
- <configKey><![CDATA[BX_UNBOXING_IMMEDIATELY_REBOXED]]></configKey>
- </rule>
-
- <rule key="CO_COMPARETO_RESULTS_MIN_VALUE">
- <priority>MAJOR</priority>
- <name><![CDATA[compareTo()/compare() returns Integer.MIN_VALUE]]></name>
- <configKey><![CDATA[CO_COMPARETO_RESULTS_MIN_VALUE]]></configKey>
- </rule>
-
- <rule key="DLS_DEAD_LOCAL_STORE_SHADOWS_FIELD">
- <priority>MAJOR</priority>
- <name><![CDATA[Dead store to local variable that shadows field]]></name>
- <configKey><![CDATA[DLS_DEAD_LOCAL_STORE_SHADOWS_FIELD]]></configKey>
- </rule>
-
- <rule key="DMI_ARGUMENTS_WRONG_ORDER">
- <priority>MINOR</priority>
- <name><![CDATA[Reversed method arguments]]></name>
- <configKey><![CDATA[DMI_ARGUMENTS_WRONG_ORDER]]></configKey>
- </rule>
-
- <rule key="DMI_BIGDECIMAL_CONSTRUCTED_FROM_DOUBLE">
- <priority>MAJOR</priority>
- <name><![CDATA[BigDecimal constructed from double that isn't represented precisely]]></name>
- <configKey><![CDATA[DMI_BIGDECIMAL_CONSTRUCTED_FROM_DOUBLE]]></configKey>
- </rule>
-
- <rule key="DMI_DOH">
- <priority>MAJOR</priority>
- <name><![CDATA[D'oh! A nonsensical method invocation]]></name>
- <configKey><![CDATA[DMI_DOH]]></configKey>
- </rule>
-
- <rule key="DMI_ENTRY_SETS_MAY_REUSE_ENTRY_OBJECTS">
- <priority>MAJOR</priority>
- <name><![CDATA[Adding elements of an entry set may fail due to reuse of Entry objects]]></name>
- <configKey><![CDATA[DMI_ENTRY_SETS_MAY_REUSE_ENTRY_OBJECTS]]></configKey>
- </rule>
-
- <rule key="DM_DEFAULT_ENCODING">
- <priority>MAJOR</priority>
- <name><![CDATA[Reliance on default encoding]]></name>
- <configKey><![CDATA[DM_DEFAULT_ENCODING]]></configKey>
- </rule>
-
- <rule key="ICAST_INT_2_LONG_AS_INSTANT">
- <priority>MAJOR</priority>
- <name><![CDATA[int value converted to long and used as absolute time]]></name>
- <configKey><![CDATA[ICAST_INT_2_LONG_AS_INSTANT]]></configKey>
- </rule>
-
- <rule key="INT_BAD_COMPARISON_WITH_INT_VALUE">
- <priority>MAJOR</priority>
- <name><![CDATA[Bad comparison of int value with long constant]]></name>
- <configKey><![CDATA[INT_BAD_COMPARISON_WITH_INT_VALUE]]></configKey>
- </rule>
-
- <rule key="JML_JSR166_CALLING_WAIT_RATHER_THAN_AWAIT">
- <priority>MAJOR</priority>
- <name><![CDATA[Using monitor style wait methods on util.concurrent abstraction]]></name>
- <configKey><![CDATA[JML_JSR166_CALLING_WAIT_RATHER_THAN_AWAIT]]></configKey>
- </rule>
-
- <rule key="NP_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD">
- <priority>MAJOR</priority>
- <name><![CDATA[Read of unwritten public or protected field]]></name>
- <configKey><![CDATA[NP_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD]]></configKey>
- </rule>
-
- <rule key="OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE">
- <priority>CRITICAL</priority>
- <name><![CDATA[Method may fail to clean up stream or resource on checked exception]]></name>
- <configKey><![CDATA[OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE]]></configKey>
- </rule>
-
- <rule key="PZ_DONT_REUSE_ENTRY_OBJECTS_IN_ITERATORS">
- <priority>MAJOR</priority>
- <name><![CDATA[Don't reuse entry objects in iterators]]></name>
- <configKey><![CDATA[PZ_DONT_REUSE_ENTRY_OBJECTS_IN_ITERATORS]]></configKey>
- </rule>
-
- <rule key="RV_CHECK_COMPARETO_FOR_SPECIFIC_RETURN_VALUE">
- <priority>MAJOR</priority>
- <name><![CDATA[Code checks for specific values returned by compareTo]]></name>
- <configKey><![CDATA[RV_CHECK_COMPARETO_FOR_SPECIFIC_RETURN_VALUE]]></configKey>
- </rule>
-
- <rule key="RV_NEGATING_RESULT_OF_COMPARETO">
- <priority>MINOR</priority>
- <name><![CDATA[Negating the result of compareTo()/compare()]]></name>
- <configKey><![CDATA[RV_NEGATING_RESULT_OF_COMPARETO]]></configKey>
- </rule>
-
- <rule key="RV_RETURN_VALUE_IGNORED_INFERRED">
- <priority>MINOR</priority>
- <name><![CDATA[Method ignores return value, is this OK?]]></name>
- <configKey><![CDATA[RV_RETURN_VALUE_IGNORED_INFERRED]]></configKey>
- </rule>
-
- <rule key="SA_LOCAL_SELF_ASSIGNMENT_INSTEAD_OF_FIELD">
- <priority>MAJOR</priority>
- <name><![CDATA[Self assignment of local rather than assignment to field]]></name>
- <configKey><![CDATA[SA_LOCAL_SELF_ASSIGNMENT_INSTEAD_OF_FIELD]]></configKey>
- </rule>
-
- <rule key="URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD">
- <priority>INFO</priority>
- <name><![CDATA[Unread public/protected field]]></name>
- <configKey><![CDATA[URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD]]></configKey>
- </rule>
-
- <rule key="UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD">
- <priority>INFO</priority>
- <name><![CDATA[Unused public or protected field]]></name>
- <configKey><![CDATA[UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD]]></configKey>
- </rule>
-
- <rule key="UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD">
- <priority>MINOR</priority>
- <name><![CDATA[Unwritten public or protected field]]></name>
- <configKey><![CDATA[UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD]]></configKey>
- </rule>
-
- <rule key="VA_FORMAT_STRING_USES_NEWLINE">
- <priority>MAJOR</priority>
- <name><![CDATA[Format string should use %n rather than \n]]></name>
- <configKey><![CDATA[VA_FORMAT_STRING_USES_NEWLINE]]></configKey>
- </rule>
-
- <rule key="VO_VOLATILE_INCREMENT">
- <priority>CRITICAL</priority>
- <name><![CDATA[An increment to a volatile field isn't atomic]]></name>
- <configKey><![CDATA[VO_VOLATILE_INCREMENT]]></configKey>
- </rule>
-
- <rule key="PT_ABSOLUTE_PATH_TRAVERSAL">
- <priority>MAJOR</priority>
- <name><![CDATA[Absolute path traversal in servlet]]></name>
- <configKey><![CDATA[PT_ABSOLUTE_PATH_TRAVERSAL]]></configKey>
- </rule>
-
- <rule key="PT_RELATIVE_PATH_TRAVERSAL">
- <priority>MAJOR</priority>
- <name><![CDATA[Relative path traversal in servlet]]></name>
- <configKey><![CDATA[PT_RELATIVE_PATH_TRAVERSAL]]></configKey>
- </rule>
-
- <rule key="NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR">
- <priority>CRITICAL</priority>
- <name><![CDATA[Nonnull field is not initialized]]></name>
- <configKey><![CDATA[NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR]]></configKey>
- </rule>
-
- <rule key="MS_SHOULD_BE_REFACTORED_TO_BE_FINAL">
- <priority>MAJOR</priority>
- <name><![CDATA[Field isn't final but should be refactored to be so]]></name>
- <configKey><![CDATA[MS_SHOULD_BE_REFACTORED_TO_BE_FINAL]]></configKey>
- </rule>
-
- <rule key="BC_UNCONFIRMED_CAST_OF_RETURN_VALUE">
- <priority>CRITICAL</priority>
- <name><![CDATA[Unchecked/unconfirmed cast of return value from method]]></name>
- <configKey><![CDATA[BC_UNCONFIRMED_CAST_OF_RETURN_VALUE]]></configKey>
- </rule>
-
- <rule key="TQ_COMPARING_VALUES_WITH_INCOMPATIBLE_TYPE_QUALIFIERS">
- <priority>MAJOR</priority>
- <name><![CDATA[Comparing values with incompatible type qualifiers]]></name>
- <configKey><![CDATA[TQ_COMPARING_VALUES_WITH_INCOMPATIBLE_TYPE_QUALIFIERS]]></configKey>
- </rule>
-
-</rules>
+++ /dev/null
-/*
- * Sonar, open source software quality management tool.
- * Copyright (C) 2008-2012 SonarSource
- * mailto:contact AT sonarsource DOT com
- *
- * Sonar is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * Sonar is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with Sonar; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02
- */
-package org.sonar.plugins.findbugs;
-
-import static org.mockito.Mockito.mock;
-
-import java.util.Collection;
-import java.util.List;
-
-import org.sonar.api.platform.ServerFileSystem;
-import org.sonar.api.rules.Rule;
-import org.sonar.api.rules.RuleFinder;
-import org.sonar.api.rules.RuleQuery;
-import org.sonar.api.rules.XMLRuleParser;
-
-public class FakeRuleFinder implements RuleFinder {
-
- private final List<Rule> findbugsRules;
-
- public FakeRuleFinder() {
- ServerFileSystem sfs = mock(ServerFileSystem.class);
- FindbugsRuleRepository repo = new FindbugsRuleRepository(sfs, new XMLRuleParser());
- findbugsRules = repo.createRules();
- for (Rule rule : findbugsRules) {
- rule.setRepositoryKey(FindbugsConstants.REPOSITORY_KEY);
- }
- }
-
- public Rule findById(int ruleId) {
- throw new UnsupportedOperationException();
- }
-
- public Rule findByKey(String repositoryKey, String key) {
- for (Rule rule : findbugsRules) {
- if (rule.getKey().equals(key)) {
- return rule;
- }
- }
- return null;
- }
-
- public Rule find(RuleQuery query) {
- throw new UnsupportedOperationException();
- }
-
- public Collection<Rule> findAll(RuleQuery query) {
- return findbugsRules;
- }
-}
\ No newline at end of file
+++ /dev/null
-/*
- * Sonar, open source software quality management tool.
- * Copyright (C) 2008-2012 SonarSource
- * mailto:contact AT sonarsource DOT com
- *
- * Sonar is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * Sonar is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with Sonar; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02
- */
-package org.sonar.plugins.findbugs;
-
-import org.junit.Test;
-
-import java.util.regex.Matcher;
-import java.util.regex.Pattern;
-
-import static org.fest.assertions.Assertions.assertThat;
-
-public class FindbugsAntConverterTest {
-
- @Test
- public void convertToJavaRegexFormat() {
- assertAntPatternEqualsToFindBugsRegExp("foo", "~foo", "foo");
- assertAntPatternEqualsToFindBugsRegExp("**/*Test.java", "~(.*\\.)?[^\\\\^\\s]*Test", "Test");
- assertAntPatternEqualsToFindBugsRegExp("**/*Test.java", "~(.*\\.)?[^\\\\^\\s]*Test", "foo.bar.Test");
- }
-
- @Test
- public void shouldConvertAntToJavaRegexp() {
- // see SONAR-853
- assertAntPatternEqualsToFindBugsRegExp("?", "~.", "g");
- assertAntPatternEqualsToFindBugsRegExp("*/myClass.JaVa", "~([^\\\\^\\s]*\\.)?myClass", "foo.bar.test.myClass");
- assertAntPatternEqualsToFindBugsRegExp("*/myClass.java", "~([^\\\\^\\s]*\\.)?myClass", "foo.bar.test.myClass");
- assertAntPatternEqualsToFindBugsRegExp("*/myClass2.jav", "~([^\\\\^\\s]*\\.)?myClass2", "foo.bar.test.myClass2");
- assertAntPatternEqualsToFindBugsRegExp("*/myOtherClass", "~([^\\\\^\\s]*\\.)?myOtherClass", "foo.bar.test.myOtherClass");
- assertAntPatternEqualsToFindBugsRegExp("*", "~[^\\\\^\\s]*", "ga.%#123_(*");
- assertAntPatternEqualsToFindBugsRegExp("**", "~.*", "gd.3reqg.3151];9#@!");
- assertAntPatternEqualsToFindBugsRegExp("**/generated/**", "~(.*\\.)?generated\\..*", "!@$Rq/32T$).generated.##TR.e#@!$");
- assertAntPatternEqualsToFindBugsRegExp("**/cl*nt/*", "~(.*\\.)?cl[^\\\\^\\s]*nt\\.[^\\\\^\\s]*", "!#$_.clr31r#!$(nt.!#$QRW)(.");
- assertAntPatternEqualsToFindBugsRegExp("**/org/apache/commons/**", "~(.*\\.)?org\\.apache\\.commons\\..*", "org.apache.commons.httpclient.contrib.ssl");
- assertAntPatternEqualsToFindBugsRegExp("*/org/apache/commons/**", "~([^\\\\^\\s]*\\.)?org\\.apache\\.commons\\..*", "org.apache.commons.httpclient.contrib.ssl");
- assertAntPatternEqualsToFindBugsRegExp("org/apache/commons/**", "~org\\.apache\\.commons\\..*", "org.apache.commons.httpclient.contrib.ssl");
- }
-
- @Test
- public void shouldntMatchThoseClassPattern() {
- // see SONAR-853
- assertJavaRegexpResult("[^\\\\^\\s]", "fad f.ate 12#)", false);
- }
-
- private void assertAntPatternEqualsToFindBugsRegExp(String antPattern, String regExp, String example) {
- assertThat(FindbugsAntConverter.antToJavaRegexpConvertor(antPattern)).isEqualTo(regExp);
- String javaRegexp = regExp.substring(1, regExp.length());
- assertJavaRegexpResult(javaRegexp, example, true);
- }
-
- private void assertJavaRegexpResult(String javaRegexp, String example, boolean expectedResult) {
- Pattern pattern = Pattern.compile(javaRegexp);
- Matcher matcher = pattern.matcher(example);
- assertThat(matcher.matches()).as(example + " tested with pattern " + javaRegexp).isEqualTo(expectedResult);
- }
-
-}
+++ /dev/null
-/*
- * Sonar, open source software quality management tool.
- * Copyright (C) 2008-2012 SonarSource
- * mailto:contact AT sonarsource DOT com
- *
- * Sonar is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * Sonar is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with Sonar; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02
- */
-package org.sonar.plugins.findbugs;
-
-import org.apache.commons.io.FileUtils;
-import org.junit.Before;
-import org.junit.Rule;
-import org.junit.Test;
-import org.junit.rules.TemporaryFolder;
-import org.sonar.api.CoreProperties;
-import org.sonar.api.config.PropertyDefinitions;
-import org.sonar.api.config.Settings;
-import org.sonar.api.profiles.RulesProfile;
-import org.sonar.api.resources.Project;
-import org.sonar.api.test.SimpleProjectFileSystem;
-
-import java.io.File;
-import java.util.Locale;
-
-import static org.fest.assertions.Assertions.assertThat;
-import static org.mockito.Mockito.mock;
-import static org.mockito.Mockito.when;
-
-public class FindbugsConfigurationTest {
-
- @Rule
- public TemporaryFolder tempFolder = new TemporaryFolder();
-
- private Project project;
- private Settings settings;
- private File findbugsTempDir;
- private FindbugsConfiguration conf;
-
- @Before
- public void setUp() {
- project = mock(Project.class);
- settings = new Settings(new PropertyDefinitions().addComponent(FindbugsPlugin.class));
- findbugsTempDir = tempFolder.newFolder("findbugs");
- when(project.getFileSystem()).thenReturn(new SimpleProjectFileSystem(findbugsTempDir));
- conf = new FindbugsConfiguration(project, settings, RulesProfile.create(), new FindbugsProfileExporter(), null);
- }
-
- @Test
- public void should_return_report_file() throws Exception {
- assertThat(conf.getTargetXMLReport()).isEqualTo(new File(findbugsTempDir, "target/sonar/findbugs-result.xml"));
- }
-
- @Test
- public void should_save_include_config() throws Exception {
- conf.saveIncludeConfigXml();
- File findbugsIncludeFile = new File(findbugsTempDir + "/target/sonar/findbugs-include.xml");
- assertThat(findbugsIncludeFile.exists()).isTrue();
- }
-
- @Test
- public void should_save_exclude_config() throws Exception {
- when(project.getExclusionPatterns()).thenReturn(new String[] {"dir/**/*.java"});
- conf.saveExcludeConfigXml();
- File findbugsExcludeFile = new File(findbugsTempDir + "/target/sonar/findbugs-exclude.xml");
- assertThat(findbugsExcludeFile.exists()).isTrue();
- String findbugsExclude = FileUtils.readFileToString(findbugsExcludeFile);
- assertThat(findbugsExclude).contains("Match");
- }
-
- @Test
- public void should_save_empty_exclude_config() throws Exception {
- conf.saveExcludeConfigXml();
- File findbugsExcludeFile = new File(findbugsTempDir + "/target/sonar/findbugs-exclude.xml");
- assertThat(findbugsExcludeFile.exists()).isTrue();
- String findbugsExclude = FileUtils.readFileToString(findbugsExcludeFile);
- assertThat(findbugsExclude).doesNotContain("Match");
- }
-
- @Test
- public void should_return_effort() {
- assertThat(conf.getEffort()).as("default effort").isEqualTo("default");
- settings.setProperty(CoreProperties.FINDBUGS_EFFORT_PROPERTY, "Max");
- assertThat(conf.getEffort()).isEqualTo("max");
- }
-
- @Test
- public void should_return_timeout() {
- assertThat(conf.getTimeout()).as("default timeout").isEqualTo(600000);
- settings.setProperty(CoreProperties.FINDBUGS_TIMEOUT_PROPERTY, 1);
- assertThat(conf.getTimeout()).isEqualTo(1);
- }
-
- @Test
- public void should_return_locale() {
- settings.setProperty(CoreProperties.CORE_VIOLATION_LOCALE_PROPERTY, "fr");
- assertThat(conf.getLocale()).isEqualTo(Locale.FRENCH);
- }
-
- @Test
- public void should_return_excludes_filters() {
- assertThat(conf.getExcludesFilters()).isEmpty();
- settings.setProperty(FindbugsConstants.EXCLUDES_FILTERS_PROPERTY, " foo.xml , bar.xml,");
- assertThat(conf.getExcludesFilters()).hasSize(2);
- }
-
- @Test
- public void should_return_confidence_level() {
- assertThat(conf.getConfidenceLevel()).as("default confidence level").isEqualTo("medium");
- settings.setProperty(CoreProperties.FINDBUGS_EFFORT_PROPERTY, "HIGH");
- assertThat(conf.getEffort()).isEqualTo("high");
- }
-
-}
+++ /dev/null
-/*
- * Sonar, open source software quality management tool.
- * Copyright (C) 2008-2012 SonarSource
- * mailto:contact AT sonarsource DOT com
- *
- * Sonar is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * Sonar is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with Sonar; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02
- */
-package org.sonar.plugins.findbugs;
-
-import com.google.common.collect.Lists;
-import org.apache.commons.io.FileUtils;
-import org.junit.Test;
-import org.sonar.api.CoreProperties;
-import org.sonar.api.config.Settings;
-import org.sonar.api.resources.Project;
-import org.sonar.api.resources.ProjectFileSystem;
-import org.sonar.api.utils.SonarException;
-
-import java.io.File;
-import java.util.Locale;
-
-import static org.fest.assertions.Assertions.assertThat;
-import static org.mockito.Mockito.mock;
-import static org.mockito.Mockito.when;
-
-public class FindbugsExecutorTest {
-
- @Test
- public void canGenerateXMLReport() throws Exception {
- FindbugsConfiguration conf = mockConf();
- File reportFile = new File("target/test-tmp/findbugs-report.xml");
- when(conf.getTargetXMLReport()).thenReturn(reportFile);
-
- new FindbugsExecutor(conf).execute();
-
- assertThat(reportFile.exists()).isTrue();
- String report = FileUtils.readFileToString(reportFile);
- assertThat(report).as("Report should contain bug instance").contains("<BugInstance");
- assertThat(report).as("Report should be generated with messages").contains("<Message>");
- assertThat(report).contains("priority=\"1\"");
- assertThat(report).doesNotContain("priority=\"3\"");
- }
-
- @Test
- public void canGenerateXMLReportWithCustomConfidence() throws Exception {
- FindbugsConfiguration conf = mockConf();
- File reportFile = new File("target/test-tmp/customized-findbugs-report.xml");
- when(conf.getTargetXMLReport()).thenReturn(reportFile);
- when(conf.getConfidenceLevel()).thenReturn("low");
-
- new FindbugsExecutor(conf).execute();
-
- assertThat(reportFile.exists()).isTrue();
- String report = FileUtils.readFileToString(reportFile);
- assertThat(report).as("Report should contain bug instance").contains("<BugInstance");
- assertThat(report).as("Report should be generated with messages").contains("<Message>");
- assertThat(report).contains("priority=\"1\"");
- assertThat(report).contains("priority=\"3\"");
- assertThat(report).contains("synthetic=\"true\"");
- }
-
- @Test(expected = SonarException.class)
- public void shouldTerminateAfterTimeout() throws Exception {
- FindbugsConfiguration conf = mockConf();
- when(conf.getTimeout()).thenReturn(1L);
-
- new FindbugsExecutor(conf).execute();
- }
-
- @Test(expected = SonarException.class)
- public void shoulFailIfNoCompiledClasses() throws Exception {
- Project project = mock(Project.class);
- ProjectFileSystem fs = mock(ProjectFileSystem.class);
- when(project.getFileSystem()).thenReturn(fs);
- Settings settings = new Settings();
- settings.setProperty(CoreProperties.CORE_VIOLATION_LOCALE_PROPERTY, CoreProperties.CORE_VIOLATION_LOCALE_DEFAULT_VALUE);
- FindbugsConfiguration conf = new FindbugsConfiguration(project, settings, null, null, null);
-
- new FindbugsExecutor(conf).execute();
- }
-
- private FindbugsConfiguration mockConf() throws Exception {
- FindbugsConfiguration conf = mock(FindbugsConfiguration.class);
- edu.umd.cs.findbugs.Project project = new edu.umd.cs.findbugs.Project();
- project.addFile(new File("test-resources/classes").getCanonicalPath());
- project.addSourceDir(new File("test-resources/src").getCanonicalPath());
- project.setCurrentWorkingDirectory(new File("test-resources"));
- when(conf.getFindbugsProject()).thenReturn(project);
- when(conf.saveExcludeConfigXml()).thenReturn(new File("test-resources/findbugs-exclude.xml"));
- when(conf.saveIncludeConfigXml()).thenReturn(new File("test-resources/findbugs-include.xml"));
- when(conf.getExcludesFilters()).thenReturn(Lists.newArrayList(new File("test-resources/findbugs-exclude.xml"), new File("test-resources/fake-file.xml")));
- when(conf.getEffort()).thenReturn("default");
- when(conf.getTimeout()).thenReturn(CoreProperties.FINDBUGS_TIMEOUT_DEFAULT_VALUE);
- when(conf.getLocale()).thenReturn(Locale.ENGLISH);
- return conf;
- }
-
-}
+++ /dev/null
-/*
- * Sonar, open source software quality management tool.
- * Copyright (C) 2008-2012 SonarSource
- * mailto:contact AT sonarsource DOT com
- *
- * Sonar is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * Sonar is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with Sonar; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02
- */
-package org.sonar.plugins.findbugs;
-
-import com.google.common.collect.Lists;
-import org.apache.commons.configuration.Configuration;
-import org.junit.Before;
-import org.junit.Test;
-import org.sonar.api.resources.InputFile;
-import org.sonar.api.resources.InputFileUtils;
-import org.sonar.api.resources.Project;
-import org.sonar.api.resources.ProjectFileSystem;
-import org.sonar.api.test.MavenTestUtils;
-
-import java.util.ArrayList;
-
-import static org.fest.assertions.Assertions.assertThat;
-import static org.mockito.Matchers.anyString;
-import static org.mockito.Matchers.eq;
-import static org.mockito.Mockito.mock;
-import static org.mockito.Mockito.never;
-import static org.mockito.Mockito.verify;
-import static org.mockito.Mockito.when;
-
-public class FindbugsMavenInitializerTest {
-
- private Project project;
- private FindbugsMavenInitializer initializer;
-
- @Before
- public void setUp() {
- project = mock(Project.class);
- initializer = new FindbugsMavenInitializer();
- }
-
- @Test
- public void shouldNotAnalyseIfNoJavaProject() {
- Project project = mock(Project.class);
- when(project.getLanguageKey()).thenReturn("php");
- assertThat(initializer.shouldExecuteOnProject(project)).isFalse();
- }
-
- @Test
- public void shouldNotAnalyseIfJavaProjectButNoSource() {
- Project project = mock(Project.class);
- ProjectFileSystem fs = mock(ProjectFileSystem.class);
- when(fs.mainFiles("java")).thenReturn(new ArrayList<InputFile>());
- when(project.getFileSystem()).thenReturn(fs);
- when(project.getLanguageKey()).thenReturn("java");
- assertThat(initializer.shouldExecuteOnProject(project)).isFalse();
- }
-
- @Test
- public void shouldAnalyse() {
- Project project = mock(Project.class);
- ProjectFileSystem fs = mock(ProjectFileSystem.class);
- when(fs.mainFiles("java")).thenReturn(Lists.newArrayList(InputFileUtils.create(null, "")));
- when(project.getFileSystem()).thenReturn(fs);
- when(project.getLanguageKey()).thenReturn("java");
- when(project.getAnalysisType()).thenReturn(Project.AnalysisType.DYNAMIC);
- assertThat(initializer.shouldExecuteOnProject(project)).isTrue();
- }
-
- @Test
- public void doNotSetExcludesFiltersIfAlreadyConfigured() {
- Configuration configuration = mock(Configuration.class);
- when(configuration.containsKey(FindbugsConstants.EXCLUDES_FILTERS_PROPERTY)).thenReturn(true);
- when(project.getConfiguration()).thenReturn(configuration);
- initializer.execute(project);
- verify(configuration, never()).setProperty(eq(FindbugsConstants.EXCLUDES_FILTERS_PROPERTY), anyString());
- }
-
- @Test
- public void shouldGetExcludesFiltersFromPom() {
- Project project = MavenTestUtils.loadProjectFromPom(getClass(), "pom.xml");
- initializer.execute(project);
- assertThat(project.getConfiguration().getString(FindbugsConstants.EXCLUDES_FILTERS_PROPERTY)).isEqualTo("foo.xml");
- }
-
-}
+++ /dev/null
-/*
- * Sonar, open source software quality management tool.
- * Copyright (C) 2008-2012 SonarSource
- * mailto:contact AT sonarsource DOT com
- *
- * Sonar is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * Sonar is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with Sonar; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02
- */
-package org.sonar.plugins.findbugs;
-
-import org.junit.Test;
-
-import static org.fest.assertions.Assertions.assertThat;
-
-public class FindbugsPluginTest {
-
- @Test
- public void testGetExtensions() {
- assertThat(new FindbugsPlugin().getExtensions().size()).isGreaterThan(1);
- }
-
-}
+++ /dev/null
-/*
- * Sonar, open source software quality management tool.
- * Copyright (C) 2008-2012 SonarSource
- * mailto:contact AT sonarsource DOT com
- *
- * Sonar is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * Sonar is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with Sonar; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02
- */
-package org.sonar.plugins.findbugs;
-
-import org.junit.Test;
-import org.sonar.api.profiles.RulesProfile;
-import org.sonar.api.rules.ActiveRule;
-import org.sonar.api.rules.Rule;
-import org.sonar.api.rules.RulePriority;
-import org.sonar.plugins.findbugs.xml.Bug;
-import org.sonar.plugins.findbugs.xml.FindBugsFilter;
-import org.sonar.plugins.findbugs.xml.Match;
-import org.xml.sax.SAXException;
-
-import java.io.IOException;
-import java.io.StringWriter;
-import java.util.Arrays;
-import java.util.Collections;
-import java.util.List;
-
-import static org.fest.assertions.Assertions.assertThat;
-
-public class FindbugsProfileExporterTest extends FindbugsTests {
-
- private FindbugsProfileExporter exporter = new FindbugsProfileExporter();
-
- @Test
- public void shouldAddHeaderToExportedXml() throws IOException, SAXException {
- RulesProfile profile = RulesProfile.create();
-
- StringWriter xml = new StringWriter();
- exporter.exportProfile(profile, xml);
- assertXmlAreSimilar(xml.toString(), "test_header.xml");
- }
-
- @Test
- public void shouldExportConfiguration() throws IOException, SAXException {
- List<Rule> rules = buildRulesFixture();
- List<ActiveRule> activeRulesExpected = buildActiveRulesFixture(rules);
- RulesProfile profile = RulesProfile.create();
- profile.setActiveRules(activeRulesExpected);
-
- StringWriter xml = new StringWriter();
- exporter.exportProfile(profile, xml);
- assertXmlAreSimilar(xml.toString(), "test_xml_complete.xml");
- }
-
- @Test
- public void shouldBuildOnlyOneModuleWhenNoActiveRules() {
- FindBugsFilter filter = FindbugsProfileExporter.buildFindbugsFilter(Collections.<ActiveRule> emptyList());
- assertThat(filter.getMatchs()).hasSize(0);
- }
-
- @Test
- public void shouldBuildTwoModulesEvenIfSameTwoRulesActivated() {
- ActiveRule activeRule1 = anActiveRule(DLS_DEAD_LOCAL_STORE);
- ActiveRule activeRule2 = anActiveRule(SS_SHOULD_BE_STATIC);
- FindBugsFilter filter = FindbugsProfileExporter.buildFindbugsFilter(Arrays.asList(activeRule1, activeRule2));
-
- List<Match> matches = filter.getMatchs();
- assertThat(matches).hasSize(2);
-
- assertThat(matches.get(0).getBug().getPattern()).isEqualTo("DLS_DEAD_LOCAL_STORE");
- assertThat(matches.get(1).getBug().getPattern()).isEqualTo("SS_SHOULD_BE_STATIC");
- }
-
- @Test
- public void shouldBuildOnlyOneModuleWhenNoFindbugsActiveRules() {
- ActiveRule activeRule1 = anActiveRuleFromAnotherPlugin();
- ActiveRule activeRule2 = anActiveRuleFromAnotherPlugin();
-
- FindBugsFilter filter = FindbugsProfileExporter.buildFindbugsFilter(Arrays.asList(activeRule1, activeRule2));
- assertThat(filter.getMatchs()).hasSize(0);
- }
-
- @Test
- public void shouldBuildModuleWithProperties() {
- ActiveRule activeRule = anActiveRule(DLS_DEAD_LOCAL_STORE);
- FindBugsFilter filter = FindbugsProfileExporter.buildFindbugsFilter(Arrays.asList(activeRule));
-
- assertThat(filter.getMatchs()).hasSize(1);
- assertThat(filter.getMatchs().get(0).getBug().getPattern()).isEqualTo("DLS_DEAD_LOCAL_STORE");
- }
-
- @Test
- public void shouldBuilXmlFromModuleTree() throws IOException, SAXException {
- FindBugsFilter findBugsFilter = new FindBugsFilter();
- findBugsFilter.addMatch(new Match(new Bug("DLS_DEAD_LOCAL_STORE")));
- findBugsFilter.addMatch(new Match(new Bug("URF_UNREAD_FIELD")));
-
- String xml = findBugsFilter.toXml();
-
- assertXmlAreSimilar(xml, "test_module_tree.xml");
- }
-
- private static final String DLS_DEAD_LOCAL_STORE = "DLS_DEAD_LOCAL_STORE";
- private static final String SS_SHOULD_BE_STATIC = "SS_SHOULD_BE_STATIC";
-
- private static ActiveRule anActiveRule(String configKey) {
- Rule rule = Rule.create();
- rule.setConfigKey(configKey);
- rule.setRepositoryKey(FindbugsConstants.REPOSITORY_KEY);
- ActiveRule activeRule = RulesProfile.create().activateRule(rule, RulePriority.CRITICAL);
- return activeRule;
- }
-
- private static ActiveRule anActiveRuleFromAnotherPlugin() {
- Rule rule = Rule.create();
- rule.setPluginName("not-a-findbugs-plugin");
- ActiveRule activeRule = RulesProfile.create().activateRule(rule, RulePriority.CRITICAL);
- return activeRule;
- }
-}
+++ /dev/null
-/*
- * Sonar, open source software quality management tool.
- * Copyright (C) 2008-2012 SonarSource
- * mailto:contact AT sonarsource DOT com
- *
- * Sonar is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * Sonar is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with Sonar; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02
- */
-package org.sonar.plugins.findbugs;
-
-import com.thoughtworks.xstream.XStream;
-import org.apache.commons.io.IOUtils;
-import org.junit.Test;
-import org.sonar.api.profiles.RulesProfile;
-import org.sonar.api.rules.ActiveRule;
-import org.sonar.api.utils.ValidationMessages;
-import org.sonar.plugins.findbugs.xml.FindBugsFilter;
-import org.sonar.plugins.findbugs.xml.Match;
-import org.sonar.test.TestUtils;
-
-import java.io.IOException;
-import java.io.InputStream;
-import java.io.InputStreamReader;
-import java.io.StringReader;
-import java.util.List;
-
-import static org.fest.assertions.Assertions.assertThat;
-
-public class FindbugsProfileImporterTest {
-
- private final FindbugsProfileImporter importer = new FindbugsProfileImporter(new FakeRuleFinder());
-
- @Test
- public void shouldImportPatterns() {
- String findbugsConf = TestUtils.getResourceContent("/org/sonar/plugins/findbugs/shouldImportPatterns.xml");
- RulesProfile profile = importer.importProfile(new StringReader(findbugsConf), ValidationMessages.create());
-
- assertThat(profile.getActiveRules()).hasSize(2);
- assertThat(profile.getActiveRule(FindbugsConstants.REPOSITORY_KEY, "NP_CLOSING_NULL")).isNotNull();
- assertThat(profile.getActiveRule(FindbugsConstants.REPOSITORY_KEY, "RC_REF_COMPARISON_BAD_PRACTICE")).isNotNull();
- }
-
- @Test
- public void shouldImportCodes() {
- InputStream input = getClass().getResourceAsStream("/org/sonar/plugins/findbugs/shouldImportCodes.xml");
- RulesProfile profile = importer.importProfile(new InputStreamReader(input), ValidationMessages.create());
- List<ActiveRule> results = profile.getActiveRules();
-
- assertThat(results).hasSize(19);
- assertThat(profile.getActiveRule(FindbugsConstants.REPOSITORY_KEY, "EC_INCOMPATIBLE_ARRAY_COMPARE")).isNotNull();
- assertThat(profile.getActiveRule(FindbugsConstants.REPOSITORY_KEY, "BC_IMPOSSIBLE_DOWNCAST_OF_TOARRAY")).isNotNull();
- }
-
- @Test
- public void shouldImportCategories() {
- InputStream input = getClass().getResourceAsStream("/org/sonar/plugins/findbugs/shouldImportCategories.xml");
- RulesProfile profile = importer.importProfile(new InputStreamReader(input), ValidationMessages.create());
- List<ActiveRule> results = profile.getActiveRules();
-
- assertThat(results).hasSize(182);
- assertThat(profile.getActiveRule(FindbugsConstants.REPOSITORY_KEY, "LG_LOST_LOGGER_DUE_TO_WEAK_REFERENCE")).isNotNull();
- }
-
- @Test
- public void shouldImportConfigurationBugInclude() {
- InputStream input = getClass().getResourceAsStream("/org/sonar/plugins/findbugs/findbugs-include.xml");
- RulesProfile profile = importer.importProfile(new InputStreamReader(input), ValidationMessages.create());
- List<ActiveRule> results = profile.getActiveRules();
-
- assertThat(results).hasSize(11);
- assertThat(profile.getActiveRule(FindbugsConstants.REPOSITORY_KEY, "RC_REF_COMPARISON_BAD_PRACTICE")).isNotNull();
- }
-
- @Test
- public void shouldBuilModuleTreeFromXml() throws IOException {
- InputStream input = getClass().getResourceAsStream("/org/sonar/plugins/findbugs/test_module_tree.xml");
-
- XStream xStream = FindBugsFilter.createXStream();
- FindBugsFilter filter = (FindBugsFilter) xStream.fromXML(IOUtils.toString(input));
-
- List<Match> matches = filter.getMatchs();
- assertThat(matches).hasSize(2);
- assertThat(matches.get(0).getBug().getPattern()).isEqualTo("DLS_DEAD_LOCAL_STORE");
- assertThat(matches.get(1).getBug().getPattern()).isEqualTo("URF_UNREAD_FIELD");
- }
-
- @Test
- public void testImportingUncorrectXmlFile() {
- String uncorrectFindbugsXml = TestUtils.getResourceContent("/org/sonar/plugins/findbugs/uncorrectFindbugsXml.xml");
- ValidationMessages messages = ValidationMessages.create();
- RulesProfile profile = importer.importProfile(new StringReader(uncorrectFindbugsXml), messages);
- List<ActiveRule> results = profile.getActiveRules();
-
- assertThat(results).hasSize(0);
- assertThat(messages.getErrors()).hasSize(1);
- }
-
- @Test
- public void testImportingXmlFileWithUnknownRule() {
- String uncorrectFindbugsXml = TestUtils.getResourceContent("/org/sonar/plugins/findbugs/findbugsXmlWithUnknownRule.xml");
- ValidationMessages messages = ValidationMessages.create();
- RulesProfile profile = importer.importProfile(new StringReader(uncorrectFindbugsXml), messages);
- List<ActiveRule> results = profile.getActiveRules();
-
- assertThat(results).hasSize(1);
- assertThat(messages.getWarnings()).hasSize(1);
- }
-
- @Test
- public void testImportingXmlFileWithUnknownCategory() {
- String uncorrectFindbugsXml = TestUtils.getResourceContent("/org/sonar/plugins/findbugs/findbugsXmlWithUnknownCategory.xml");
- ValidationMessages messages = ValidationMessages.create();
- RulesProfile profile = importer.importProfile(new StringReader(uncorrectFindbugsXml), messages);
- List<ActiveRule> results = profile.getActiveRules();
-
- assertThat(results).hasSize(141);
- assertThat(messages.getWarnings()).hasSize(1);
- }
-
- @Test
- public void testImportingXmlFileWithUnknownCode() {
- String uncorrectFindbugsXml = TestUtils.getResourceContent("/org/sonar/plugins/findbugs/findbugsXmlWithUnknownCode.xml");
- ValidationMessages messages = ValidationMessages.create();
- RulesProfile profile = importer.importProfile(new StringReader(uncorrectFindbugsXml), messages);
- List<ActiveRule> results = profile.getActiveRules();
-
- assertThat(results).hasSize(10);
- assertThat(messages.getWarnings()).hasSize(1);
- }
-}
+++ /dev/null
-/*
- * Sonar, open source software quality management tool.
- * Copyright (C) 2008-2012 SonarSource
- * mailto:contact AT sonarsource DOT com
- *
- * Sonar is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * Sonar is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with Sonar; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02
- */
-package org.sonar.plugins.findbugs;
-
-import org.junit.Before;
-import org.junit.Test;
-import org.sonar.api.platform.ServerFileSystem;
-import org.sonar.api.rules.Rule;
-import org.sonar.api.rules.XMLRuleParser;
-import org.sonar.test.i18n.RuleRepositoryTestHelper;
-
-import java.util.List;
-
-import static org.fest.assertions.Assertions.assertThat;
-import static org.mockito.Mockito.mock;
-
-public class FindbugsRuleRepositoryTest {
- FindbugsRuleRepository repository;
-
- @Before
- public void setUpRuleRepository() {
- repository = new FindbugsRuleRepository(mock(ServerFileSystem.class), new XMLRuleParser());
- }
-
- @Test
- public void testLoadRepositoryFromXml() {
- List<Rule> rules = repository.createRules();
-
- assertThat(rules.size()).isGreaterThan(300);
- for (Rule rule : rules) {
- assertThat(rule.getKey()).isNotNull();
- assertThat(rule.getConfigKey()).isNotNull();
- assertThat(rule.getName()).isNotNull();
- }
- }
-
- @Test
- public void should_provide_a_name_and_description_for_each_rule() {
- List<Rule> rules = RuleRepositoryTestHelper.createRulesWithNameAndDescription("findbugs", repository);
-
- assertThat(rules).onProperty("name").excludes(null, "");
- assertThat(rules).onProperty("description").excludes(null, "");
- }
-}
+++ /dev/null
-/*
- * Sonar, open source software quality management tool.
- * Copyright (C) 2008-2012 SonarSource
- * mailto:contact AT sonarsource DOT com
- *
- * Sonar is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * Sonar is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with Sonar; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02
- */
-package org.sonar.plugins.findbugs;
-
-import com.google.common.collect.Lists;
-import edu.umd.cs.findbugs.BugCollection;
-import edu.umd.cs.findbugs.BugInstance;
-import edu.umd.cs.findbugs.ClassAnnotation;
-import edu.umd.cs.findbugs.MethodAnnotation;
-import edu.umd.cs.findbugs.SortedBugCollection;
-import edu.umd.cs.findbugs.SourceLineAnnotation;
-import org.junit.AfterClass;
-import org.junit.BeforeClass;
-import org.junit.Test;
-import org.sonar.api.batch.SensorContext;
-import org.sonar.api.profiles.RulesProfile;
-import org.sonar.api.resources.InputFile;
-import org.sonar.api.resources.InputFileUtils;
-import org.sonar.api.resources.JavaFile;
-import org.sonar.api.resources.Project;
-import org.sonar.api.resources.ProjectFileSystem;
-import org.sonar.api.resources.Resource;
-import org.sonar.api.rules.Rule;
-import org.sonar.api.rules.Violation;
-import org.sonar.api.test.IsViolation;
-
-import java.util.ArrayList;
-import java.util.Locale;
-
-import static org.fest.assertions.Assertions.assertThat;
-import static org.mockito.Matchers.any;
-import static org.mockito.Matchers.argThat;
-import static org.mockito.Mockito.mock;
-import static org.mockito.Mockito.never;
-import static org.mockito.Mockito.times;
-import static org.mockito.Mockito.verify;
-import static org.mockito.Mockito.when;
-
-public class FindbugsSensorTest extends FindbugsTests {
-
- private static final Locale DEFAULT_LOCALE = Locale.getDefault();
-
- @BeforeClass
- public static void beforeAll() {
- Locale.setDefault(Locale.ENGLISH);
- }
-
- @AfterClass
- public static void afterAll() {
- Locale.setDefault(DEFAULT_LOCALE);
- }
-
- @Test
- public void shouldNotAnalyseIfNoJavaProject() {
- Project project = mock(Project.class);
- when(project.getLanguageKey()).thenReturn("php");
-
- FindbugsSensor sensor = new FindbugsSensor(null, null, null);
- assertThat(sensor.shouldExecuteOnProject(project)).isFalse();
- }
-
- @Test
- public void shouldNotAnalyseIfJavaProjectButNoSource() {
- Project project = mock(Project.class);
- ProjectFileSystem fs = mock(ProjectFileSystem.class);
- when(fs.mainFiles("java")).thenReturn(new ArrayList<InputFile>());
- when(project.getFileSystem()).thenReturn(fs);
- when(project.getLanguageKey()).thenReturn("java");
-
- FindbugsSensor sensor = new FindbugsSensor(null, null, null);
- assertThat(sensor.shouldExecuteOnProject(project)).isFalse();
- }
-
- @Test
- public void shouldNotAnalyseIfJavaProjectButNoRules() {
- Project project = mock(Project.class);
- ProjectFileSystem fs = mock(ProjectFileSystem.class);
- when(fs.mainFiles("java")).thenReturn(Lists.newArrayList(InputFileUtils.create(null, "")));
- when(project.getFileSystem()).thenReturn(fs);
- when(project.getLanguageKey()).thenReturn("java");
-
- FindbugsSensor sensor = new FindbugsSensor(RulesProfile.create(), null, null);
- assertThat(sensor.shouldExecuteOnProject(project)).isFalse();
- }
-
- @Test
- public void shouldAnalyse() {
- Project project = mock(Project.class);
- ProjectFileSystem fs = mock(ProjectFileSystem.class);
- when(fs.mainFiles("java")).thenReturn(Lists.newArrayList(InputFileUtils.create(null, "")));
- when(project.getFileSystem()).thenReturn(fs);
- when(project.getLanguageKey()).thenReturn("java");
-
- FindbugsSensor sensor = new FindbugsSensor(createRulesProfileWithActiveRules(), null, null);
- assertThat(sensor.shouldExecuteOnProject(project)).isTrue();
- }
-
- @Test
- public void shouldExecuteFindbugsWhenNoReportProvided() throws Exception {
- Project project = createProject();
- FindbugsExecutor executor = mock(FindbugsExecutor.class);
- SensorContext context = mock(SensorContext.class);
-
- BugCollection collection = new SortedBugCollection();
- BugInstance bugInstance = new BugInstance("AM_CREATES_EMPTY_ZIP_FILE_ENTRY", 2);
- String className = "org.sonar.commons.ZipUtils";
- String sourceFile = "org/sonar/commons/ZipUtils.java";
- int startLine = 107;
- ClassAnnotation classAnnotation = new ClassAnnotation(className, sourceFile);
- bugInstance.add(classAnnotation);
- MethodAnnotation methodAnnotation = new MethodAnnotation(className, "_zip", "(Ljava/lang/String;Ljava/io/File;Ljava/util/zip/ZipOutputStream;)V", true);
- methodAnnotation.setSourceLines(new SourceLineAnnotation(className, sourceFile, startLine, 0, 0, 0));
- bugInstance.add(methodAnnotation);
- collection.add(bugInstance);
- when(executor.execute()).thenReturn(collection);
-
- when(context.getResource(any(Resource.class))).thenReturn(new JavaFile("org.sonar.MyClass"));
-
- FindbugsSensor analyser = new FindbugsSensor(createRulesProfileWithActiveRules(), new FakeRuleFinder(), executor);
- analyser.analyse(project, context);
-
- verify(executor).execute();
- verify(context, times(1)).saveViolation(any(Violation.class));
-
- Violation wanted = Violation.create((Rule) null, new JavaFile("org.sonar.commons.ZipUtils")).setMessage(
- "Empty zip file entry created in org.sonar.commons.ZipUtils._zip(String, File, ZipOutputStream)").setLineId(107);
- verify(context).saveViolation(argThat(new IsViolation(wanted)));
- }
-
- @Test
- public void shouldIgnoreNotActiveViolations() throws Exception {
- Project project = createProject();
- FindbugsExecutor executor = mock(FindbugsExecutor.class);
- SensorContext context = mock(SensorContext.class);
- when(context.getResource(any(Resource.class))).thenReturn(new JavaFile("org.sonar.MyClass"));
-
- BugCollection collection = new SortedBugCollection();
- BugInstance bugInstance = new BugInstance("UNKNOWN", 2);
- String className = "org.sonar.commons.ZipUtils";
- String sourceFile = "org/sonar/commons/ZipUtils.java";
- ClassAnnotation classAnnotation = new ClassAnnotation(className, sourceFile);
- bugInstance.add(classAnnotation);
- collection.add(bugInstance);
- when(executor.execute()).thenReturn(collection);
-
- FindbugsSensor analyser = new FindbugsSensor(createRulesProfileWithActiveRules(), new FakeRuleFinder(), executor);
- analyser.analyse(project, context);
-
- verify(context, never()).saveViolation(any(Violation.class));
- }
-
- private Project createProject() {
- ProjectFileSystem fileSystem = mock(ProjectFileSystem.class);
- when(fileSystem.hasJavaSourceFiles()).thenReturn(Boolean.TRUE);
-
- Project project = mock(Project.class);
- when(project.getFileSystem()).thenReturn(fileSystem);
- return project;
- }
-
-}
+++ /dev/null
-/*
- * Sonar, open source software quality management tool.
- * Copyright (C) 2008-2012 SonarSource
- * mailto:contact AT sonarsource DOT com
- *
- * Sonar is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * Sonar is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with Sonar; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02
- */
-package org.sonar.plugins.findbugs;
-
-import static org.mockito.Mockito.mock;
-
-import java.io.IOException;
-import java.util.ArrayList;
-import java.util.List;
-
-import org.sonar.api.platform.ServerFileSystem;
-import org.sonar.api.profiles.RulesProfile;
-import org.sonar.api.resources.Java;
-import org.sonar.api.rules.ActiveRule;
-import org.sonar.api.rules.Rule;
-import org.sonar.api.rules.RulePriority;
-import org.sonar.api.rules.XMLRuleParser;
-import org.sonar.test.TestUtils;
-import org.xml.sax.SAXException;
-
-public abstract class FindbugsTests {
-
- protected void assertXmlAreSimilar(String actualContent, String expectedFileName) throws IOException, SAXException {
- String expectedContent = TestUtils.getResourceContent("/org/sonar/plugins/findbugs/" + expectedFileName);
- TestUtils.assertSimilarXml(expectedContent, actualContent);
- }
-
- protected List<Rule> buildRulesFixture() {
- List<Rule> rules = new ArrayList<Rule>();
-
- Rule rule1 = Rule.create(FindbugsConstants.REPOSITORY_KEY, "DLS_DEAD_LOCAL_STORE", "DLS: Dead store to local variable");
- Rule rule2 = Rule.create(FindbugsConstants.REPOSITORY_KEY, "URF_UNREAD_FIELD", "UrF: Unread field");
-
- rules.add(rule1);
- rules.add(rule2);
-
- return rules;
- }
-
- protected List<ActiveRule> buildActiveRulesFixture(List<Rule> rules) {
- List<ActiveRule> activeRules = new ArrayList<ActiveRule>();
- ActiveRule activeRule1 = new ActiveRule(null, rules.get(0), RulePriority.CRITICAL);
- activeRules.add(activeRule1);
- ActiveRule activeRule2 = new ActiveRule(null, rules.get(1), RulePriority.MAJOR);
- activeRules.add(activeRule2);
- return activeRules;
- }
-
- protected RulesProfile createRulesProfileWithActiveRules() {
- RulesProfile profile = RulesProfile.create();
- profile.setName(RulesProfile.SONAR_WAY_FINDBUGS_NAME);
- profile.setLanguage(Java.KEY);
- ServerFileSystem sfs = mock(ServerFileSystem.class);
- for (Rule rule : new FindbugsRuleRepository(sfs, new XMLRuleParser()).createRules()) {
- rule.setRepositoryKey(FindbugsConstants.REPOSITORY_KEY);
- profile.activateRule(rule, null);
- }
- return profile;
- }
-}
+++ /dev/null
-/*
- * Sonar, open source software quality management tool.
- * Copyright (C) 2008-2012 SonarSource
- * mailto:contact AT sonarsource DOT com
- *
- * Sonar is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * Sonar is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with Sonar; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02
- */
-package org.sonar.plugins.findbugs;
-
-import org.junit.Test;
-
-import static org.fest.assertions.Assertions.assertThat;
-
-public class FindbugsVersionTest {
-
- @Test
- public void getFindbugsVersion() {
- assertThat(FindbugsVersion.getVersion().length()).isGreaterThan(1);
- }
-
-}
+++ /dev/null
-/*
- * Sonar, open source software quality management tool.
- * Copyright (C) 2008-2012 SonarSource
- * mailto:contact AT sonarsource DOT com
- *
- * Sonar is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * Sonar is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with Sonar; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02
- */
-package org.sonar.plugins.findbugs;
-
-import org.junit.Before;
-import org.junit.Rule;
-import org.junit.Test;
-import org.junit.rules.ExpectedException;
-import org.sonar.api.utils.SonarException;
-
-import java.io.File;
-import java.net.URISyntaxException;
-import java.util.List;
-
-import static org.fest.assertions.Assertions.assertThat;
-
-public class FindbugsXmlReportParserTest {
-
- @Rule
- public ExpectedException thrown = ExpectedException.none();
-
- private List<FindbugsXmlReportParser.XmlBugInstance> violations;
-
- @Before
- public void init() {
- File findbugsXmlReport = getFile("/org/sonar/plugins/findbugs/findbugsReport.xml");
- FindbugsXmlReportParser xmlParser = new FindbugsXmlReportParser(findbugsXmlReport);
- violations = xmlParser.getBugInstances();
- }
-
- @Test
- public void createFindbugsXmlReportParserWithUnexistedReportFile() {
- File xmlReport = new File("doesntExist.xml");
- thrown.expect(SonarException.class);
- thrown.expectMessage("The findbugs XML report can't be found at '" + xmlReport.getAbsolutePath() + "'");
- new FindbugsXmlReportParser(xmlReport);
- }
-
- @Test
- public void testGetViolations() {
- assertThat(violations.size()).isEqualTo(2);
-
- FindbugsXmlReportParser.XmlBugInstance fbViolation = violations.get(0);
- assertThat(fbViolation.getType()).isEqualTo("AM_CREATES_EMPTY_ZIP_FILE_ENTRY");
- assertThat(fbViolation.getLongMessage()).isEqualTo("Empty zip file entry created in org.sonar.commons.ZipUtils._zip(String, File, ZipOutputStream)");
-
- FindbugsXmlReportParser.XmlSourceLineAnnotation sourceLine = fbViolation.getPrimarySourceLine();
- assertThat(sourceLine.getStart()).isEqualTo(107);
- assertThat(sourceLine.getEnd()).isEqualTo(107);
- assertThat(sourceLine.getClassName()).isEqualTo("org.sonar.commons.ZipUtils");
- }
-
- @Test
- public void testGetSonarJavaFileKey() {
- FindbugsXmlReportParser.XmlSourceLineAnnotation sourceLine = new FindbugsXmlReportParser.XmlSourceLineAnnotation();
- sourceLine.className = "org.sonar.batch.Sensor";
- assertThat(sourceLine.getSonarJavaFileKey()).isEqualTo("org.sonar.batch.Sensor");
- sourceLine.className = "Sensor";
- assertThat(sourceLine.getSonarJavaFileKey()).isEqualTo("Sensor");
- sourceLine.className = "org.sonar.batch.Sensor$1";
- assertThat(sourceLine.getSonarJavaFileKey()).isEqualTo("org.sonar.batch.Sensor");
- }
-
- private final File getFile(String filename) {
- try {
- return new File(getClass().getResource(filename).toURI());
- } catch (URISyntaxException e) {
- throw new SonarException("Unable to open file " + filename, e);
- }
- }
-}
+++ /dev/null
-/*
- * Sonar, open source software quality management tool.
- * Copyright (C) 2008-2012 SonarSource
- * mailto:contact AT sonarsource DOT com
- *
- * Sonar is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * Sonar is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with Sonar; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02
- */
-package org.sonar.plugins.findbugs;
-
-import org.junit.Test;
-import org.sonar.api.profiles.RulesProfile;
-import org.sonar.api.utils.ValidationMessages;
-
-import static org.fest.assertions.Assertions.assertThat;
-
-public class SonarWayWithFindbugsProfileTest {
-
- @Test
- public void shouldCreateProfile() {
- FindbugsProfileImporter importer = new FindbugsProfileImporter(new FakeRuleFinder());
- SonarWayWithFindbugsProfile sonarWayWithFindbugs = new SonarWayWithFindbugsProfile(importer);
- ValidationMessages validation = ValidationMessages.create();
- RulesProfile profile = sonarWayWithFindbugs.createProfile(validation);
- assertThat(profile.getActiveRulesByRepository(FindbugsConstants.REPOSITORY_KEY)).hasSize(405);
- assertThat(validation.hasErrors()).isFalse();
- }
-
-}
+++ /dev/null
-<?xml version="1.0" encoding="UTF-8"?>
-<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
- <modelVersion>4.0.0</modelVersion>
-
- <groupId>fake.group</groupId>
- <artifactId>fake.artifactId</artifactId>
- <packaging>jar</packaging>
- <version>1.0-SNAPSHOT</version>
-
- <build>
- <plugins>
- <plugin>
- <groupId>org.codehaus.mojo</groupId>
- <artifactId>findbugs-maven-plugin</artifactId>
- <configuration>
- <excludeFilterFile>foo.xml</excludeFilterFile>
- </configuration>
- </plugin>
- </plugins>
- </build>
-
-</project>
+++ /dev/null
-<?xml version="1.0" encoding="UTF-8"?>
-<BugCollection version="1.2.1" threshold="Normal" effort="Max" >
-<file classname="ClassOnDefaultPackage" >
-<BugInstance type="DLS_DEAD_LOCAL_STORE" priority="High" category="STYLE" message="DLS: Dead store to i in ClassOnDefaultPackage.ClassOnDefaultPackage(int)" lineNumber="4" />
-<BugInstance type="DLS_DEAD_LOCAL_STORE" priority="Normal" category="STYLE" message="DLS: Dead store to j in ClassOnDefaultPackage.ClassOnDefaultPackage(int)" lineNumber="4" />
-</file>
-</BugCollection>
+++ /dev/null
-<FindBugsFilter>
- <Match>
- <Class name="com.foobar.ClassNotToBeAnalyzed" />
- </Match>
-
- <Match>
- <Class name="com.foobar.ClassWithSomeBugsMatched" />
- <Bug code="NP_CLOSING_NULL" />
- <Priority value="2" />
- </Match>
-
- <Match>
- <Class name="com.foobar.MyClass" />
- <Method name="someMethod" />
- <Local name="maxArgs" />
- <Bug pattern="RC_REF_COMPARISON_BAD_PRACTICE" />
- <Priority value="1" />
- </Match>
-
- <Match>
- <Bug pattern="FB1_IMPORT_TEST_3" />
- <Priority value="3" />
- <Field name="~ajc\$.*" />
- </Match>
-
- <Match>
- <Package name="~com\.foobar\.fooproject\.ui.*" />
- <Or>
- <Method name="nonOverloadedMethod" />
- <Method name="frob" params="int,java.lang.String" returns="void" />
- <Method name="blat" params="" returns="boolean" />
- </Or>
- <Bug category="SECURITY" />
- <Priority value="3" />
- </Match>
- </FindBugsFilter>
\ No newline at end of file
+++ /dev/null
-<BugCollection timestamp='1282919233000' analysisTimestamp='1282919402891' sequence='0' release='' version='1.3.9'>
- <Project projectName=''>
- <Jar>/Users/freddy/Documents/sonar_projects/sonar/sonar-commons/target/classes</Jar>
- <AuxClasspathEntry>/Users/freddy/.m2/repository/org/apache/maven/reporting/maven-reporting-impl/2.0/maven-reporting-impl-2.0.jar</AuxClasspathEntry>
- <SrcDir>/Users/freddy/Documents/sonar_projects/sonar/sonar-commons/src/main/java</SrcDir>
- <WrkDir>/Users/freddy/Documents/sonar_projects/sonar/sonar-commons/target</WrkDir>
- </Project>
- <BugInstance category='BAD_PRACTICE' instanceHash='65c6770c9055a84db4899b95826e4edd' instanceOccurrenceNum='0' priority='2' abbrev='AM' type='AM_CREATES_EMPTY_ZIP_FILE_ENTRY' instanceOccurrenceMax='0'>
- <ShortMessage>Creates an empty zip file entry</ShortMessage>
- <LongMessage>Empty zip file entry created in org.sonar.commons.ZipUtils._zip(String, File, ZipOutputStream)</LongMessage>
- <Class classname='org.sonar.commons.ZipUtils' primary='true'>
- <SourceLine start='33' classname='org.sonar.commons.ZipUtils' sourcepath='org/sonar/commons/ZipUtils.java' sourcefile='ZipUtils.java' end='139'>
- <Message>At ZipUtils.java:[lines 33-139]</Message>
- </SourceLine>
- <Message>In class org.sonar.commons.ZipUtils</Message>
- </Class>
- <Method isStatic='true' classname='org.sonar.commons.ZipUtils' name='_zip' primary='true' signature='(Ljava/lang/String;Ljava/io/File;Ljava/util/zip/ZipOutputStream;)V'>
- <SourceLine endBytecode='353' startBytecode='0' start='103' classname='org.sonar.commons.ZipUtils' sourcepath='org/sonar/commons/ZipUtils.java' sourcefile='ZipUtils.java' end='124'></SourceLine>
- <Message>In method org.sonar.commons.ZipUtils._zip(String, File, ZipOutputStream)</Message>
- </Method>
- <SourceLine endBytecode='42' startBytecode='42' start='107' classname='org.sonar.commons.ZipUtils' primary='true' sourcepath='org/sonar/commons/ZipUtils.java' sourcefile='ZipUtils.java' end='107'>
- <Message>At ZipUtils.java:[line 107]</Message>
- </SourceLine>
- <SourceLine endBytecode='65' startBytecode='65' start='112' classname='org.sonar.commons.ZipUtils' primary='true' sourcepath='org/sonar/commons/ZipUtils.java' sourcefile='ZipUtils.java' end='124'>
- <Message>At ZipUtils.java:[line 107]</Message>
- </SourceLine>
- </BugInstance>
- <BugInstance category='PERFORMANCE' instanceHash='6ba81067bf4e178b360e52be449b1b60' instanceOccurrenceNum='0' priority='3' abbrev='SIC' type='SIC_INNER_SHOULD_BE_STATIC_ANON' instanceOccurrenceMax='0'>
- <ShortMessage>Could be refactored into a named static inner class</ShortMessage>
- <LongMessage>The class org.sonar.commons.resources.MeasuresDao$1 could be refactored into a named _static_ inner class</LongMessage>
- <Class classname='org.sonar.commons.resources.MeasuresDao$1' primary='true'>
- <SourceLine start='56' classname='org.sonar.commons.resources.MeasuresDao$1' sourcepath='org/sonar/commons/resources/MeasuresDao.java' sourcefile='MeasuresDao.java' end='57'>
- <Message>At MeasuresDao.java:[lines 56-57]</Message>
- </SourceLine>
- <Message>In class org.sonar.commons.resources.MeasuresDao$1</Message>
- </Class>
- <SourceLine start='56' classname='org.sonar.commons.resources.MeasuresDao$1' sourcepath='org/sonar/commons/resources/MeasuresDao.java' synthetic='true' sourcefile='MeasuresDao.java' end='57'>
- <Message>At MeasuresDao.java:[lines 56-57]</Message>
- </SourceLine>
- </BugInstance>
- <FindBugsSummary>
- <FindBugsProfile>
- <ClassProfile avgMicrosecondsPerInvocation='398' maxMicrosecondsPerInvocation='107179' name='edu.umd.cs.findbugs.OpcodeStack$JumpInfoFactory' invocations='4722' totalMilliseconds='1881' standardDeviationMircosecondsPerInvocation='3050'></ClassProfile>
- </FindBugsProfile>
- </FindBugsSummary>
- <ClassFeatures></ClassFeatures>
- <History></History>
-</BugCollection>
+++ /dev/null
-<BugCollection version="1.3.9" sequence="0" timestamp="1289571354000" analysisTimestamp="1289571687788" release="">
- <Project projectName="">
- </Project>
- <!-- Before SONAR-1280 type was OBL_UNSATISFIED_OBLIGATION -->
- <BugInstance type="UNKNOWN" priority="2" abbrev="OBL" category="EXPERIMENTAL" instanceHash="4d5bb62bd620a4713ef04e9450237c02" instanceOccurrenceNum="0" instanceOccurrenceMax="0">
- <ShortMessage>Method may fail to clean up stream or resource</ShortMessage>
- <LongMessage>Method com.exedio.csvtools.DBTool.executeUpdate(String) may fail to clean up java.sql.Statement</LongMessage>
- <Class classname="com.exedio.csvtools.DBTool" primary="true">
- <SourceLine classname="com.exedio.csvtools.DBTool" start="55" end="338" sourcefile="DBTool.java" sourcepath="com/exedio/csvtools/DBTool.java">
- <Message>At DBTool.java:[lines 55-338]</Message>
- </SourceLine>
- <Message>In class com.exedio.csvtools.DBTool</Message>
- </Class>
- <Method classname="com.exedio.csvtools.DBTool" name="executeUpdate" signature="(Ljava/lang/String;)V" isStatic="false" primary="true">
- <SourceLine classname="com.exedio.csvtools.DBTool" start="301" end="313" startBytecode="0" endBytecode="234" sourcefile="DBTool.java" sourcepath="com/exedio/csvtools/DBTool.java"/>
- <Message>In method com.exedio.csvtools.DBTool.executeUpdate(String)</Message>
- </Method>
- <Class classname="java.sql.Statement" role="CLASS_REFTYPE">
- <SourceLine classname="java.sql.Statement" sourcefile="Statement.java" sourcepath="java/sql/Statement.java">
- <Message>In Statement.java</Message>
- </SourceLine>
- <Message>Reference type java.sql.Statement</Message>
- </Class>
- <Int value="1" role="INT_OBLIGATIONS_REMAINING">
- <Message>1 instances of obligation remaining</Message>
- </Int>
- <SourceLine classname="com.exedio.csvtools.DBTool" primary="true" start="302" end="302" startBytecode="8" endBytecode="8" sourcefile="DBTool.java" sourcepath="com/exedio/csvtools/DBTool.java" role="SOURCE_LINE_OBLIGATION_CREATED">
- <Message>Obligation to clean up resource created at DBTool.java:[line 302] is not discharged</Message>
- </SourceLine>
- <SourceLine classname="com.exedio.csvtools.DBTool" start="303" end="303" startBytecode="14" endBytecode="14" sourcefile="DBTool.java" sourcepath="com/exedio/csvtools/DBTool.java" role="SOURCE_LINE_PATH_CONTINUES">
- <Message>Path continues at DBTool.java:[line 303]</Message>
- </SourceLine>
- <SourceLine classname="com.exedio.csvtools.DBTool" start="313" end="313" startBytecode="91" endBytecode="91" sourcefile="DBTool.java" sourcepath="com/exedio/csvtools/DBTool.java" role="SOURCE_LINE_PATH_CONTINUES">
- <Message>Path continues at DBTool.java:[line 313]</Message>
- </SourceLine>
- <String value="{Statement x 1}" role="STRING_REMAINING_OBLIGATIONS">
- <Message>Remaining obligations: {Statement x 1}</Message>
- </String>
- </BugInstance>
-</BugCollection>
+++ /dev/null
-<FindBugsFilter>
- <Match>
- <Bug category="CORRECTNESS,MT_CORRECTN9876976" />
- <Priority value="3"/>
- </Match>
-</FindBugsFilter>
\ No newline at end of file
+++ /dev/null
-<FindBugsFilter>
- <Match>
- <Bug code="BC,EC87LK"/>
- <Priority value="2"/>
- </Match>
-</FindBugsFilter>
\ No newline at end of file
+++ /dev/null
-<?xml version="1.0" encoding="UTF-8"?>
-<FindBugsFilter>
- <Match>
- <Bug pattern="DLS_DEAD_LOCAL_STORE" />
- </Match>
- <Match>
- <Bug pattern="UNKNOWN" />
- </Match>
-</FindBugsFilter>
+++ /dev/null
-<FindBugsFilter>
- <Match>
- <Bug category="CORRECTNESS,MT_CORRECTNESS" />
- <Priority value="3"/>
- </Match>
-</FindBugsFilter>
\ No newline at end of file
+++ /dev/null
-<FindBugsFilter>
- <Match>
- <Bug code="BC,EC"/>
- <Priority value="2"/>
- </Match>
-</FindBugsFilter>
\ No newline at end of file
+++ /dev/null
-<FindBugsFilter>
- <Match>
- <Bug pattern="NP_CLOSING_NULL" />
- </Match>
- <Match>
- <Bug pattern="RC_REF_COMPARISON_BAD_PRACTICE" />
- </Match>
- <Match>
- <Bug pattern="RC_REF_COMPARISON_BAD_PRACTICE" />
- </Match>
-</FindBugsFilter>
\ No newline at end of file
+++ /dev/null
-<?xml version="1.0" encoding="UTF-8"?>
-<!-- Sonar Findbugs rules generated configuration -->
-<FindBugsFilter/>
\ No newline at end of file
+++ /dev/null
-<?xml version="1.0" encoding="UTF-8"?>
-<FindBugsFilter>
- <Match>
- <Bug pattern="DLS_DEAD_LOCAL_STORE" />
- </Match>
- <Match>
- <Bug pattern="URF_UNREAD_FIELD" />
- </Match>
-</FindBugsFilter>
+++ /dev/null
-<?xml version="1.0" encoding="UTF-8"?>
-<!-- Sonar Findbugs rules generated configuration -->
-<!-- Do NEVER specify a rule priority in the export file !! -->
-<FindBugsFilter>
- <Match>
- <Bug pattern="DLS_DEAD_LOCAL_STORE" />
- </Match>
- <Match>
- <Bug pattern="URF_UNREAD_FIELD" />
- </Match>
-</FindBugsFilter>
+++ /dev/null
-<BugCollection timestamp='1282919233000' analysisTimestamp='1282919402891' sequence='0' release='' version='1.3.9'>
- <Project projectName=''>
- <Jar>/Users/freddy/Documents/sonar_projects/sonar/sonar-commons/target/classes</Jar>
- <AuxClasspathEntry>/Users/freddy/.m2/repository/org/apache/maven/reporting/maven-reporting-impl/2.0/maven-reporting-impl-2.0.jar</AuxClasspathEntry>
-
\ No newline at end of file
+++ /dev/null
-<FindBugsFilter/>
\ No newline at end of file
+++ /dev/null
-<?xml version="1.0" encoding="UTF-8"?>
-<!-- Generated by Sonar -->
-<FindBugsFilter>
- <Match>
- <Bug pattern="SA_LOCAL_SELF_COMPARISON"/>
- </Match>
- <Match>
- <Bug pattern="UG_SYNC_SET_UNSYNC_GET"/>
- </Match>
- <Match>
- <Bug pattern="IC_SUPERCLASS_USES_SUBCLASS_DURING_INITIALIZATION"/>
- </Match>
- <Match>
- <Bug pattern="NM_FIELD_NAMING_CONVENTION"/>
- </Match>
- <Match>
- <Bug pattern="BC_IMPOSSIBLE_DOWNCAST"/>
- </Match>
- <Match>
- <Bug pattern="SA_FIELD_SELF_COMPUTATION"/>
- </Match>
- <Match>
- <Bug pattern="EQ_CHECK_FOR_OPERAND_NOT_COMPATIBLE_WITH_THIS"/>
- </Match>
- <Match>
- <Bug pattern="TQ_MAYBE_SOURCE_VALUE_REACHES_NEVER_SINK"/>
- </Match>
- <Match>
- <Bug pattern="NO_NOTIFY_NOT_NOTIFYALL"/>
- </Match>
- <Match>
- <Bug pattern="VA_FORMAT_STRING_BAD_ARGUMENT"/>
- </Match>
- <Match>
- <Bug pattern="UPM_UNCALLED_PRIVATE_METHOD"/>
- </Match>
- <Match>
- <Bug pattern="SF_DEAD_STORE_DUE_TO_SWITCH_FALLTHROUGH"/>
- </Match>
- <Match>
- <Bug pattern="SF_DEAD_STORE_DUE_TO_SWITCH_FALLTHROUGH_TO_THROW"/>
- </Match>
- <Match>
- <Bug pattern="EQ_COMPARETO_USE_OBJECT_EQUALS"/>
- </Match>
- <Match>
- <Bug pattern="LI_LAZY_INIT_UPDATE_STATIC"/>
- </Match>
- <Match>
- <Bug pattern="DMI_THREAD_PASSED_WHERE_RUNNABLE_EXPECTED"/>
- </Match>
- <Match>
- <Bug pattern="SE_NONLONG_SERIALVERSIONID"/>
- </Match>
- <Match>
- <Bug pattern="ODR_OPEN_DATABASE_RESOURCE"/>
- </Match>
- <Match>
- <Bug pattern="RC_REF_COMPARISON_BAD_PRACTICE"/>
- </Match>
- <Match>
- <Bug pattern="NM_LCASE_HASHCODE"/>
- </Match>
- <Match>
- <Bug pattern="VO_VOLATILE_REFERENCE_TO_ARRAY"/>
- </Match>
- <Match>
- <Bug pattern="ITA_INEFFICIENT_TO_ARRAY"/>
- </Match>
- <Match>
- <Bug pattern="DM_NUMBER_CTOR"/>
- </Match>
- <Match>
- <Bug pattern="XSS_REQUEST_PARAMETER_TO_JSP_WRITER"/>
- </Match>
- <Match>
- <Bug pattern="IJU_TEARDOWN_NO_SUPER"/>
- </Match>
- <Match>
- <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE"/>
- </Match>
- <Match>
- <Bug pattern="SIC_INNER_SHOULD_BE_STATIC"/>
- </Match>
- <Match>
- <Bug pattern="NM_BAD_EQUAL"/>
- </Match>
- <Match>
- <Bug pattern="DM_BOXED_PRIMITIVE_TOSTRING"/>
- </Match>
- <Match>
- <Bug pattern="IJU_SUITE_NOT_STATIC"/>
- </Match>
- <Match>
- <Bug pattern="IM_MULTIPLYING_RESULT_OF_IREM"/>
- </Match>
- <Match>
- <Bug pattern="HE_HASHCODE_USE_OBJECT_EQUALS"/>
- </Match>
- <Match>
- <Bug pattern="IL_CONTAINER_ADDED_TO_ITSELF"/>
- </Match>
- <Match>
- <Bug pattern="ES_COMPARING_PARAMETER_STRING_WITH_EQ"/>
- </Match>
- <Match>
- <Bug pattern="VA_FORMAT_STRING_BAD_CONVERSION"/>
- </Match>
- <Match>
- <Bug pattern="SR_NOT_CHECKED"/>
- </Match>
- <Match>
- <Bug pattern="DB_DUPLICATE_SWITCH_CLAUSES"/>
- </Match>
- <Match>
- <Bug pattern="NP_NULL_PARAM_DEREF_NONVIRTUAL"/>
- </Match>
- <Match>
- <Bug pattern="IP_PARAMETER_IS_DEAD_BUT_OVERWRITTEN"/>
- </Match>
- <Match>
- <Bug pattern="RV_RETURN_VALUE_IGNORED"/>
- </Match>
- <Match>
- <Bug pattern="RV_EXCEPTION_NOT_THROWN"/>
- </Match>
- <Match>
- <Bug pattern="DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED"/>
- </Match>
- <Match>
- <Bug pattern="CO_SELF_NO_OBJECT"/>
- </Match>
- <Match>
- <Bug pattern="MS_MUTABLE_ARRAY"/>
- </Match>
- <Match>
- <Bug pattern="DM_CONVERT_CASE"/>
- </Match>
- <Match>
- <Bug pattern="INT_VACUOUS_COMPARISON"/>
- </Match>
- <Match>
- <Bug pattern="UW_UNCOND_WAIT"/>
- </Match>
- <Match>
- <Bug pattern="MS_FINAL_PKGPROTECT"/>
- </Match>
- <Match>
- <Bug pattern="NP_BOOLEAN_RETURN_NULL"/>
- </Match>
- <Match>
- <Bug pattern="DL_SYNCHRONIZATION_ON_UNSHARED_BOXED_PRIMITIVE"/>
- </Match>
- <Match>
- <Bug pattern="TQ_MAYBE_SOURCE_VALUE_REACHES_ALWAYS_SINK"/>
- </Match>
- <Match>
- <Bug pattern="DMI_RANDOM_USED_ONLY_ONCE"/>
- </Match>
- <Match>
- <Bug pattern="DM_GC"/>
- </Match>
- <Match>
- <Bug pattern="BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION"/>
- </Match>
- <Match>
- <Bug pattern="BIT_SIGNED_CHECK_HIGH_BIT"/>
- </Match>
- <Match>
- <Bug pattern="DE_MIGHT_DROP"/>
- </Match>
- <Match>
- <Bug pattern="DL_SYNCHRONIZATION_ON_BOXED_PRIMITIVE"/>
- </Match>
- <Match>
- <Bug pattern="RV_DONT_JUST_NULL_CHECK_READLINE"/>
- </Match>
- <Match>
- <Bug pattern="RV_CHECK_FOR_POSITIVE_INDEXOF"/>
- </Match>
- <Match>
- <Bug pattern="DMI_USELESS_SUBSTRING"/>
- </Match>
- <Match>
- <Bug pattern="URF_UNREAD_FIELD"/>
- </Match>
- <Match>
- <Bug pattern="NP_NULL_INSTANCEOF"/>
- </Match>
- <Match>
- <Bug pattern="DM_MONITOR_WAIT_ON_CONDITION"/>
- </Match>
- <Match>
- <Bug pattern="TQ_EXPLICIT_UNKNOWN_SOURCE_VALUE_REACHES_NEVER_SINK"/>
- </Match>
- <Match>
- <Bug pattern="MS_PKGPROTECT"/>
- </Match>
- <Match>
- <Bug pattern="NP_LOAD_OF_KNOWN_NULL_VALUE"/>
- </Match>
- <Match>
- <Bug pattern="EQ_OVERRIDING_EQUALS_NOT_SYMMETRIC"/>
- </Match>
- <Match>
- <Bug pattern="SWL_SLEEP_WITH_LOCK_HELD"/>
- </Match>
- <Match>
- <Bug pattern="EC_UNRELATED_INTERFACES"/>
- </Match>
- <Match>
- <Bug pattern="DM_FP_NUMBER_CTOR"/>
- </Match>
- <Match>
- <Bug pattern="FI_PUBLIC_SHOULD_BE_PROTECTED"/>
- </Match>
- <Match>
- <Bug pattern="STI_INTERRUPTED_ON_CURRENTTHREAD"/>
- </Match>
- <Match>
- <Bug pattern="SE_COMPARATOR_SHOULD_BE_SERIALIZABLE"/>
- </Match>
- <Match>
- <Bug pattern="DMI_BAD_MONTH"/>
- </Match>
- <Match>
- <Bug pattern="BIT_SIGNED_CHECK"/>
- </Match>
- <Match>
- <Bug pattern="DE_MIGHT_IGNORE"/>
- </Match>
- <Match>
- <Bug pattern="UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR"/>
- </Match>
- <Match>
- <Bug pattern="IJU_SETUP_NO_SUPER"/>
- </Match>
- <Match>
- <Bug pattern="EQ_OTHER_NO_OBJECT"/>
- </Match>
- <Match>
- <Bug pattern="FI_MISSING_SUPER_CALL"/>
- </Match>
- <Match>
- <Bug pattern="SQL_BAD_PREPARED_STATEMENT_ACCESS"/>
- </Match>
- <Match>
- <Bug pattern="NP_NONNULL_PARAM_VIOLATION"/>
- </Match>
- <Match>
- <Bug pattern="EQ_UNUSUAL"/>
- </Match>
- <Match>
- <Bug pattern="FI_EMPTY"/>
- </Match>
- <Match>
- <Bug pattern="NP_CLOSING_NULL"/>
- </Match>
- <Match>
- <Bug pattern="NN_NAKED_NOTIFY"/>
- </Match>
- <Match>
- <Bug pattern="SE_TRANSIENT_FIELD_OF_NONSERIALIZABLE_CLASS"/>
- </Match>
- <Match>
- <Bug pattern="UWF_NULL_FIELD"/>
- </Match>
- <Match>
- <Bug pattern="OS_OPEN_STREAM"/>
- </Match>
- <Match>
- <Bug pattern="HE_USE_OF_UNHASHABLE_CLASS"/>
- </Match>
- <Match>
- <Bug pattern="EQ_ABSTRACT_SELF"/>
- </Match>
- <Match>
- <Bug pattern="NM_SAME_SIMPLE_NAME_AS_SUPERCLASS"/>
- </Match>
- <Match>
- <Bug pattern="J2EE_STORE_OF_NON_SERIALIZABLE_OBJECT_INTO_SESSION"/>
- </Match>
- <Match>
- <Bug pattern="TQ_EXPLICIT_UNKNOWN_SOURCE_VALUE_REACHES_ALWAYS_SINK"/>
- </Match>
- <Match>
- <Bug pattern="RCN_REDUNDANT_COMPARISON_TWO_NULL_VALUES"/>
- </Match>
- <Match>
- <Bug pattern="SIC_INNER_SHOULD_BE_STATIC_ANON"/>
- </Match>
- <Match>
- <Bug pattern="EQ_SELF_USE_OBJECT"/>
- </Match>
- <Match>
- <Bug pattern="JCIP_FIELD_ISNT_FINAL_IN_IMMUTABLE_CLASS"/>
- </Match>
- <Match>
- <Bug pattern="NM_CLASS_NOT_EXCEPTION"/>
- </Match>
- <Match>
- <Bug pattern="QBA_QUESTIONABLE_BOOLEAN_ASSIGNMENT"/>
- </Match>
- <Match>
- <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE"/>
- </Match>
- <Match>
- <Bug pattern="SE_METHOD_MUST_BE_PRIVATE"/>
- </Match>
- <Match>
- <Bug pattern="BC_IMPOSSIBLE_INSTANCEOF"/>
- </Match>
- <Match>
- <Bug pattern="EC_ARRAY_AND_NONARRAY"/>
- </Match>
- <Match>
- <Bug pattern="FI_EXPLICIT_INVOCATION"/>
- </Match>
- <Match>
- <Bug pattern="SS_SHOULD_BE_STATIC"/>
- </Match>
- <Match>
- <Bug pattern="BIT_IOR"/>
- </Match>
- <Match>
- <Bug pattern="SE_NONFINAL_SERIALVERSIONID"/>
- </Match>
- <Match>
- <Bug pattern="MS_SHOULD_BE_FINAL"/>
- </Match>
- <Match>
- <Bug pattern="EQ_DONT_DEFINE_EQUALS_FOR_ENUM"/>
- </Match>
- <Match>
- <Bug pattern="SE_TRANSIENT_FIELD_NOT_RESTORED"/>
- </Match>
- <Match>
- <Bug pattern="VA_FORMAT_STRING_EXTRA_ARGUMENTS_PASSED"/>
- </Match>
- <Match>
- <Bug pattern="EQ_ALWAYS_FALSE"/>
- </Match>
- <Match>
- <Bug pattern="EI_EXPOSE_REP2"/>
- </Match>
- <Match>
- <Bug pattern="RV_REM_OF_RANDOM_INT"/>
- </Match>
- <Match>
- <Bug pattern="INT_VACUOUS_BIT_OPERATION"/>
- </Match>
- <Match>
- <Bug pattern="SF_SWITCH_NO_DEFAULT"/>
- </Match>
- <Match>
- <Bug pattern="IL_INFINITE_LOOP"/>
- </Match>
- <Match>
- <Bug pattern="NP_NULL_PARAM_DEREF"/>
- </Match>
- <Match>
- <Bug pattern="AM_CREATES_EMPTY_JAR_FILE_ENTRY"/>
- </Match>
- <Match>
- <Bug pattern="EQ_COMPARING_CLASS_NAMES"/>
- </Match>
- <Match>
- <Bug pattern="NP_ALWAYS_NULL_EXCEPTION"/>
- </Match>
- <Match>
- <Bug pattern="DB_DUPLICATE_BRANCHES"/>
- </Match>
- <Match>
- <Bug pattern="IMSE_DONT_CATCH_IMSE"/>
- </Match>
- <Match>
- <Bug pattern="XSS_REQUEST_PARAMETER_TO_SERVLET_WRITER"/>
- </Match>
- <Match>
- <Bug pattern="DM_STRING_CTOR"/>
- </Match>
- <Match>
- <Bug pattern="SE_NO_SERIALVERSIONID"/>
- </Match>
- <Match>
- <Bug pattern="SE_BAD_FIELD_STORE"/>
- </Match>
- <Match>
- <Bug pattern="EC_UNRELATED_TYPES_USING_POINTER_EQUALITY"/>
- </Match>
- <Match>
- <Bug pattern="SE_NO_SUITABLE_CONSTRUCTOR_FOR_EXTERNALIZATION"/>
- </Match>
- <Match>
- <Bug pattern="DMI_HARDCODED_ABSOLUTE_FILENAME"/>
- </Match>
- <Match>
- <Bug pattern="RU_INVOKE_RUN"/>
- </Match>
- <Match>
- <Bug pattern="SQL_BAD_RESULTSET_ACCESS"/>
- </Match>
- <Match>
- <Bug pattern="IJU_ASSERT_METHOD_INVOKED_FROM_RUN_METHOD"/>
- </Match>
- <Match>
- <Bug pattern="BX_BOXING_IMMEDIATELY_UNBOXED"/>
- </Match>
- <Match>
- <Bug pattern="VA_FORMAT_STRING_BAD_CONVERSION_FROM_ARRAY"/>
- </Match>
- <Match>
- <Bug pattern="HE_HASHCODE_NO_EQUALS"/>
- </Match>
- <Match>
- <Bug pattern="SI_INSTANCE_BEFORE_FINALS_ASSIGNED"/>
- </Match>
- <Match>
- <Bug pattern="UI_INHERITANCE_UNSAFE_GETRESOURCE"/>
- </Match>
- <Match>
- <Bug pattern="NP_SYNC_AND_NULL_CHECK_FIELD"/>
- </Match>
- <Match>
- <Bug pattern="RpC_REPEATED_CONDITIONAL_TEST"/>
- </Match>
- <Match>
- <Bug pattern="DLS_DEAD_LOCAL_STORE_IN_RETURN"/>
- </Match>
- <Match>
- <Bug pattern="EC_UNRELATED_CLASS_AND_INTERFACE"/>
- </Match>
- <Match>
- <Bug pattern="RE_CANT_USE_FILE_SEPARATOR_AS_REGULAR_EXPRESSION"/>
- </Match>
- <Match>
- <Bug pattern="HE_INHERITS_EQUALS_USE_HASHCODE"/>
- </Match>
- <Match>
- <Bug pattern="NP_DEREFERENCE_OF_READLINE_VALUE"/>
- </Match>
- <Match>
- <Bug pattern="WA_NOT_IN_LOOP"/>
- </Match>
- <Match>
- <Bug pattern="BC_IMPOSSIBLE_CAST"/>
- </Match>
- <Match>
- <Bug pattern="OS_OPEN_STREAM_EXCEPTION_PATH"/>
- </Match>
- <Match>
- <Bug pattern="ICAST_QUESTIONABLE_UNSIGNED_RIGHT_SHIFT"/>
- </Match>
- <Match>
- <Bug pattern="NP_NULL_ON_SOME_PATH_EXCEPTION"/>
- </Match>
- <Match>
- <Bug pattern="DMI_ANNOTATION_IS_NOT_VISIBLE_TO_REFLECTION"/>
- </Match>
- <Match>
- <Bug pattern="IC_INIT_CIRCULARITY"/>
- </Match>
- <Match>
- <Bug pattern="UM_UNNECESSARY_MATH"/>
- </Match>
- <Match>
- <Bug pattern="NM_CLASS_NAMING_CONVENTION"/>
- </Match>
- <Match>
- <Bug pattern="STCAL_STATIC_CALENDAR_INSTANCE"/>
- </Match>
- <Match>
- <Bug pattern="NP_ALWAYS_NULL"/>
- </Match>
- <Match>
- <Bug pattern="RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE"/>
- </Match>
- <Match>
- <Bug pattern="NP_GUARANTEED_DEREF_ON_EXCEPTION_PATH"/>
- </Match>
- <Match>
- <Bug pattern="UUF_UNUSED_FIELD"/>
- </Match>
- <Match>
- <Bug pattern="EQ_DOESNT_OVERRIDE_EQUALS"/>
- </Match>
- <Match>
- <Bug pattern="INT_BAD_COMPARISON_WITH_SIGNED_BYTE"/>
- </Match>
- <Match>
- <Bug pattern="NP_CLONE_COULD_RETURN_NULL"/>
- </Match>
- <Match>
- <Bug pattern="HE_EQUALS_NO_HASHCODE"/>
- </Match>
- <Match>
- <Bug pattern="IS_FIELD_NOT_GUARDED"/>
- </Match>
- <Match>
- <Bug pattern="NM_LCASE_TOSTRING"/>
- </Match>
- <Match>
- <Bug pattern="NM_WRONG_PACKAGE"/>
- </Match>
- <Match>
- <Bug pattern="UCF_USELESS_CONTROL_FLOW"/>
- </Match>
- <Match>
- <Bug pattern="DM_USELESS_THREAD"/>
- </Match>
- <Match>
- <Bug pattern="DMI_USING_REMOVEALL_TO_CLEAR_COLLECTION"/>
- </Match>
- <Match>
- <Bug pattern="SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING"/>
- </Match>
- <Match>
- <Bug pattern="NP_EQUALS_SHOULD_HANDLE_NULL_ARGUMENT"/>
- </Match>
- <Match>
- <Bug pattern="ICAST_BAD_SHIFT_AMOUNT"/>
- </Match>
- <Match>
- <Bug pattern="ICAST_IDIV_CAST_TO_DOUBLE"/>
- </Match>
- <Match>
- <Bug pattern="FI_NULLIFY_SUPER"/>
- </Match>
- <Match>
- <Bug pattern="MS_MUTABLE_HASHTABLE"/>
- </Match>
- <Match>
- <Bug pattern="SE_READ_RESOLVE_MUST_RETURN_OBJECT"/>
- </Match>
- <Match>
- <Bug pattern="SIO_SUPERFLUOUS_INSTANCEOF"/>
- </Match>
- <Match>
- <Bug pattern="BOA_BADLY_OVERRIDDEN_ADAPTER"/>
- </Match>
- <Match>
- <Bug pattern="IM_AVERAGE_COMPUTATION_COULD_OVERFLOW"/>
- </Match>
- <Match>
- <Bug pattern="DM_NEW_FOR_GETCLASS"/>
- </Match>
- <Match>
- <Bug pattern="NM_CONFUSING"/>
- </Match>
- <Match>
- <Bug pattern="WMI_WRONG_MAP_ITERATOR"/>
- </Match>
- <Match>
- <Bug pattern="NP_UNWRITTEN_FIELD"/>
- </Match>
- <Match>
- <Bug pattern="SE_BAD_FIELD_INNER_CLASS"/>
- </Match>
- <Match>
- <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE"/>
- </Match>
- <Match>
- <Bug pattern="UCF_USELESS_CONTROL_FLOW_NEXT_LINE"/>
- </Match>
- <Match>
- <Bug pattern="NP_GUARANTEED_DEREF"/>
- </Match>
- <Match>
- <Bug pattern="EI_EXPOSE_STATIC_REP2"/>
- </Match>
- <Match>
- <Bug pattern="NM_FUTURE_KEYWORD_USED_AS_MEMBER_IDENTIFIER"/>
- </Match>
- <Match>
- <Bug pattern="WA_AWAIT_NOT_IN_LOOP"/>
- </Match>
- <Match>
- <Bug pattern="RC_REF_COMPARISON"/>
- </Match>
- <Match>
- <Bug pattern="SC_START_IN_CTOR"/>
- </Match>
- <Match>
- <Bug pattern="MF_CLASS_MASKS_FIELD"/>
- </Match>
- <Match>
- <Bug pattern="DMI_INVOKING_HASHCODE_ON_ARRAY"/>
- </Match>
- <Match>
- <Bug pattern="PS_PUBLIC_SEMAPHORES"/>
- </Match>
- <Match>
- <Bug pattern="PZLA_PREFER_ZERO_LENGTH_ARRAYS"/>
- </Match>
- <Match>
- <Bug pattern="SKIPPED_CLASS_TOO_BIG"/>
- </Match>
- <Match>
- <Bug pattern="HSC_HUGE_SHARED_STRING_CONSTANT"/>
- </Match>
- <Match>
- <Bug pattern="UR_UNINIT_READ_CALLED_FROM_SUPER_CONSTRUCTOR"/>
- </Match>
- <Match>
- <Bug pattern="VA_FORMAT_STRING_ILLEGAL"/>
- </Match>
- <Match>
- <Bug pattern="SA_LOCAL_SELF_COMPUTATION"/>
- </Match>
- <Match>
- <Bug pattern="SE_NO_SUITABLE_CONSTRUCTOR"/>
- </Match>
- <Match>
- <Bug pattern="MWN_MISMATCHED_NOTIFY"/>
- </Match>
- <Match>
- <Bug pattern="NP_NULL_PARAM_DEREF_ALL_TARGETS_DANGEROUS"/>
- </Match>
- <Match>
- <Bug pattern="STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE"/>
- </Match>
- <Match>
- <Bug pattern="SE_READ_RESOLVE_IS_STATIC"/>
- </Match>
- <Match>
- <Bug pattern="SA_LOCAL_DOUBLE_ASSIGNMENT"/>
- </Match>
- <Match>
- <Bug pattern="DP_DO_INSIDE_DO_PRIVILEGED"/>
- </Match>
- <Match>
- <Bug pattern="RV_RETURN_VALUE_IGNORED2"/>
- </Match>
- <Match>
- <Bug pattern="RI_REDUNDANT_INTERFACES"/>
- </Match>
- <Match>
- <Bug pattern="MTIA_SUSPECT_SERVLET_INSTANCE_FIELD"/>
- </Match>
- <Match>
- <Bug pattern="FI_FINALIZER_ONLY_NULLS_FIELDS"/>
- </Match>
- <Match>
- <Bug pattern="IO_APPENDING_TO_OBJECT_OUTPUT_STREAM"/>
- </Match>
- <Match>
- <Bug pattern="VA_FORMAT_STRING_NO_PREVIOUS_ARGUMENT"/>
- </Match>
- <Match>
- <Bug pattern="NM_VERY_CONFUSING"/>
- </Match>
- <Match>
- <Bug pattern="DM_RUN_FINALIZERS_ON_EXIT"/>
- </Match>
- <Match>
- <Bug pattern="STCAL_STATIC_SIMPLE_DATE_FORMAT_INSTANCE"/>
- </Match>
- <Match>
- <Bug pattern="FE_TEST_IF_EQUAL_TO_NOT_A_NUMBER"/>
- </Match>
- <Match>
- <Bug pattern="FI_FINALIZER_NULLS_FIELDS"/>
- </Match>
- <Match>
- <Bug pattern="DMI_UNSUPPORTED_METHOD"/>
- </Match>
- <Match>
- <Bug pattern="DMI_CONSTANT_DB_PASSWORD"/>
- </Match>
- <Match>
- <Bug pattern="TLW_TWO_LOCK_WAIT"/>
- </Match>
- <Match>
- <Bug pattern="RV_01_TO_INT"/>
- </Match>
- <Match>
- <Bug pattern="IA_AMBIGUOUS_INVOCATION_OF_INHERITED_OR_OUTER_METHOD"/>
- </Match>
- <Match>
- <Bug pattern="DMI_COLLECTION_OF_URLS"/>
- </Match>
- <Match>
- <Bug pattern="BIT_AND_ZZ"/>
- </Match>
- <Match>
- <Bug pattern="DM_STRING_VOID_CTOR"/>
- </Match>
- <Match>
- <Bug pattern="NM_METHOD_NAMING_CONVENTION"/>
- </Match>
- <Match>
- <Bug pattern="UL_UNRELEASED_LOCK"/>
- </Match>
- <Match>
- <Bug pattern="HRS_REQUEST_PARAMETER_TO_HTTP_HEADER"/>
- </Match>
- <Match>
- <Bug pattern="CN_IMPLEMENTS_CLONE_BUT_NOT_CLONEABLE"/>
- </Match>
- <Match>
- <Bug pattern="SIC_THREADLOCAL_DEADLY_EMBRACE"/>
- </Match>
- <Match>
- <Bug pattern="MF_METHOD_MASKS_FIELD"/>
- </Match>
- <Match>
- <Bug pattern="DL_SYNCHRONIZATION_ON_SHARED_CONSTANT"/>
- </Match>
- <Match>
- <Bug pattern="INT_BAD_REM_BY_1"/>
- </Match>
- <Match>
- <Bug pattern="NM_WRONG_PACKAGE_INTENTIONAL"/>
- </Match>
- <Match>
- <Bug pattern="ES_COMPARING_STRINGS_WITH_EQ"/>
- </Match>
- <Match>
- <Bug pattern="SA_FIELD_SELF_COMPARISON"/>
- </Match>
- <Match>
- <Bug pattern="VA_FORMAT_STRING_BAD_CONVERSION_TO_BOOLEAN"/>
- </Match>
- <Match>
- <Bug pattern="QF_QUESTIONABLE_FOR_LOOP"/>
- </Match>
- <Match>
- <Bug pattern="XFB_XML_FACTORY_BYPASS"/>
- </Match>
- <Match>
- <Bug pattern="CI_CONFUSED_INHERITANCE"/>
- </Match>
- <Match>
- <Bug pattern="SE_INNER_CLASS"/>
- </Match>
- <Match>
- <Bug pattern="UWF_UNWRITTEN_FIELD"/>
- </Match>
- <Match>
- <Bug pattern="BC_EQUALS_METHOD_SHOULD_WORK_FOR_ALL_OBJECTS"/>
- </Match>
- <Match>
- <Bug pattern="DLS_DEAD_STORE_OF_CLASS_LITERAL"/>
- </Match>
- <Match>
- <Bug pattern="CN_IDIOM_NO_SUPER_CALL"/>
- </Match>
- <Match>
- <Bug pattern="WS_WRITEOBJECT_SYNC"/>
- </Match>
- <Match>
- <Bug pattern="FI_USELESS"/>
- </Match>
- <Match>
- <Bug pattern="ML_SYNC_ON_FIELD_TO_GUARD_CHANGING_THAT_FIELD"/>
- </Match>
- <Match>
- <Bug pattern="NM_METHOD_CONSTRUCTOR_CONFUSION"/>
- </Match>
- <Match>
- <Bug pattern="MWN_MISMATCHED_WAIT"/>
- </Match>
- <Match>
- <Bug pattern="DM_NEXTINT_VIA_NEXTDOUBLE"/>
- </Match>
- <Match>
- <Bug pattern="FL_MATH_USING_FLOAT_PRECISION"/>
- </Match>
- <Match>
- <Bug pattern="ML_SYNC_ON_UPDATED_FIELD"/>
- </Match>
- <Match>
- <Bug pattern="VA_FORMAT_STRING_EXPECTED_MESSAGE_FORMAT_SUPPLIED"/>
- </Match>
- <Match>
- <Bug pattern="DMI_NONSERIALIZABLE_OBJECT_WRITTEN"/>
- </Match>
- <Match>
- <Bug pattern="MTIA_SUSPECT_STRUTS_INSTANCE_FIELD"/>
- </Match>
- <Match>
- <Bug pattern="EQ_OTHER_USE_OBJECT"/>
- </Match>
- <Match>
- <Bug pattern="RCN_REDUNDANT_COMPARISON_OF_NULL_AND_NONNULL_VALUE"/>
- </Match>
- <Match>
- <Bug pattern="DLS_DEAD_LOCAL_STORE_OF_NULL"/>
- </Match>
- <Match>
- <Bug pattern="DMI_BLOCKING_METHODS_ON_URL"/>
- </Match>
- <Match>
- <Bug pattern="NP_NULL_ON_SOME_PATH_MIGHT_BE_INFEASIBLE"/>
- </Match>
- <Match>
- <Bug pattern="MS_CANNOT_BE_FINAL"/>
- </Match>
- <Match>
- <Bug pattern="IM_BAD_CHECK_FOR_ODD"/>
- </Match>
- <Match>
- <Bug pattern="DMI_INVOKING_TOSTRING_ON_ANONYMOUS_ARRAY"/>
- </Match>
- <Match>
- <Bug pattern="NP_STORE_INTO_NONNULL_FIELD"/>
- </Match>
- <Match>
- <Bug pattern="SP_SPIN_ON_FIELD"/>
- </Match>
- <Match>
- <Bug pattern="NM_VERY_CONFUSING_INTENTIONAL"/>
- </Match>
- <Match>
- <Bug pattern="ICAST_INT_CAST_TO_DOUBLE_PASSED_TO_CEIL"/>
- </Match>
- <Match>
- <Bug pattern="IS2_INCONSISTENT_SYNC"/>
- </Match>
- <Match>
- <Bug pattern="ODR_OPEN_DATABASE_RESOURCE_EXCEPTION_PATH"/>
- </Match>
- <Match>
- <Bug pattern="XSS_REQUEST_PARAMETER_TO_SEND_ERROR"/>
- </Match>
- <Match>
- <Bug pattern="DMI_SCHEDULED_THREAD_POOL_EXECUTOR_WITH_ZERO_CORE_THREADS"/>
- </Match>
- <Match>
- <Bug pattern="CN_IDIOM"/>
- </Match>
- <Match>
- <Bug pattern="GC_UNCHECKED_TYPE_IN_GENERIC_CALL"/>
- </Match>
- <Match>
- <Bug pattern="SE_PRIVATE_READ_RESOLVE_NOT_INHERITED"/>
- </Match>
- <Match>
- <Bug pattern="DMI_INVOKING_TOSTRING_ON_ARRAY"/>
- </Match>
- <Match>
- <Bug pattern="SW_SWING_METHODS_INVOKED_IN_SWING_THREAD"/>
- </Match>
- <Match>
- <Bug pattern="DL_SYNCHRONIZATION_ON_BOOLEAN"/>
- </Match>
- <Match>
- <Bug pattern="NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE"/>
- </Match>
- <Match>
- <Bug pattern="NP_ARGUMENT_MIGHT_BE_NULL"/>
- </Match>
- <Match>
- <Bug pattern="DM_EXIT"/>
- </Match>
- <Match>
- <Bug pattern="CO_ABSTRACT_SELF"/>
- </Match>
- <Match>
- <Bug pattern="RV_RETURN_VALUE_OF_PUTIFABSENT_IGNORED"/>
- </Match>
- <Match>
- <Bug pattern="DC_DOUBLECHECK"/>
- </Match>
- <Match>
- <Bug pattern="UL_UNRELEASED_LOCK_EXCEPTION_PATH"/>
- </Match>
- <Match>
- <Bug pattern="EC_BAD_ARRAY_COMPARE"/>
- </Match>
- <Match>
- <Bug pattern="SE_BAD_FIELD"/>
- </Match>
- <Match>
- <Bug pattern="SA_LOCAL_SELF_ASSIGNMENT"/>
- </Match>
- <Match>
- <Bug pattern="REC_CATCH_EXCEPTION"/>
- </Match>
- <Match>
- <Bug pattern="TQ_NEVER_VALUE_USED_WHERE_ALWAYS_REQUIRED"/>
- </Match>
- <Match>
- <Bug pattern="DMI_VACUOUS_SELF_COLLECTION_CALL"/>
- </Match>
- <Match>
- <Bug pattern="UR_UNINIT_READ"/>
- </Match>
- <Match>
- <Bug pattern="DMI_FUTILE_ATTEMPT_TO_CHANGE_MAXPOOL_SIZE_OF_SCHEDULED_THREAD_POOL_EXECUTOR"/>
- </Match>
- <Match>
- <Bug pattern="BIT_AND"/>
- </Match>
- <Match>
- <Bug pattern="RR_NOT_CHECKED"/>
- </Match>
- <Match>
- <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>
- </Match>
- <Match>
- <Bug pattern="DMI_COLLECTIONS_SHOULD_NOT_CONTAIN_THEMSELVES"/>
- </Match>
- <Match>
- <Bug pattern="NP_TOSTRING_COULD_RETURN_NULL"/>
- </Match>
- <Match>
- <Bug pattern="EQ_SELF_NO_OBJECT"/>
- </Match>
- <Match>
- <Bug pattern="GC_UNRELATED_TYPES"/>
- </Match>
- <Match>
- <Bug pattern="EC_NULL_ARG"/>
- </Match>
- <Match>
- <Bug pattern="HE_SIGNATURE_DECLARES_HASHING_OF_UNHASHABLE_CLASS"/>
- </Match>
- <Match>
- <Bug pattern="NP_NONNULL_RETURN_VIOLATION"/>
- </Match>
- <Match>
- <Bug pattern="IL_INFINITE_RECURSIVE_LOOP"/>
- </Match>
- <Match>
- <Bug pattern="DM_STRING_TOSTRING"/>
- </Match>
- <Match>
- <Bug pattern="VA_PRIMITIVE_ARRAY_PASSED_TO_OBJECT_VARARG"/>
- </Match>
- <Match>
- <Bug pattern="AM_CREATES_EMPTY_ZIP_FILE_ENTRY"/>
- </Match>
- <Match>
- <Bug pattern="NS_NON_SHORT_CIRCUIT"/>
- </Match>
- <Match>
- <Bug pattern="DLS_DEAD_LOCAL_STORE"/>
- </Match>
- <Match>
- <Bug pattern="DM_BOOLEAN_CTOR"/>
- </Match>
- <Match>
- <Bug pattern="BC_BAD_CAST_TO_CONCRETE_COLLECTION"/>
- </Match>
- <Match>
- <Bug pattern="SIC_INNER_SHOULD_BE_STATIC_NEEDS_THIS"/>
- </Match>
- <Match>
- <Bug pattern="LI_LAZY_INIT_STATIC"/>
- </Match>
- <Match>
- <Bug pattern="HE_EQUALS_USE_HASHCODE"/>
- </Match>
- <Match>
- <Bug pattern="RV_ABSOLUTE_VALUE_OF_RANDOM_INT"/>
- </Match>
- <Match>
- <Bug pattern="DMI_VACUOUS_CALL_TO_EASYMOCK_METHOD"/>
- </Match>
- <Match>
- <Bug pattern="FE_FLOATING_POINT_EQUALITY"/>
- </Match>
- <Match>
- <Bug pattern="NM_FUTURE_KEYWORD_USED_AS_IDENTIFIER"/>
- </Match>
- <Match>
- <Bug pattern="ICAST_INTEGER_MULTIPLY_CAST_TO_LONG"/>
- </Match>
- <Match>
- <Bug pattern="STI_INTERRUPTED_ON_UNKNOWNTHREAD"/>
- </Match>
- <Match>
- <Bug pattern="NM_SAME_SIMPLE_NAME_AS_INTERFACE"/>
- </Match>
- <Match>
- <Bug pattern="SA_FIELD_SELF_ASSIGNMENT"/>
- </Match>
- <Match>
- <Bug pattern="DMI_EMPTY_DB_PASSWORD"/>
- </Match>
- <Match>
- <Bug pattern="IJU_BAD_SUITE_METHOD"/>
- </Match>
- <Match>
- <Bug pattern="VA_FORMAT_STRING_MISSING_ARGUMENT"/>
- </Match>
- <Match>
- <Bug pattern="WL_USING_GETCLASS_RATHER_THAN_CLASS_LITERAL"/>
- </Match>
- <Match>
- <Bug pattern="SBSC_USE_STRINGBUFFER_CONCATENATION"/>
- </Match>
- <Match>
- <Bug pattern="BIT_ADD_OF_SIGNED_BYTE"/>
- </Match>
- <Match>
- <Bug pattern="TQ_ALWAYS_VALUE_USED_WHERE_NEVER_REQUIRED"/>
- </Match>
- <Match>
- <Bug pattern="SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE"/>
- </Match>
- <Match>
- <Bug pattern="RE_BAD_SYNTAX_FOR_REGULAR_EXPRESSION"/>
- </Match>
- <Match>
- <Bug pattern="NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE"/>
- </Match>
- <Match>
- <Bug pattern="EQ_ALWAYS_TRUE"/>
- </Match>
- <Match>
- <Bug pattern="STCAL_INVOKE_ON_STATIC_CALENDAR_INSTANCE"/>
- </Match>
- <Match>
- <Bug pattern="BC_BAD_CAST_TO_ABSTRACT_COLLECTION"/>
- </Match>
- <Match>
- <Bug pattern="ISC_INSTANTIATE_STATIC_CLASS"/>
- </Match>
- <Match>
- <Bug pattern="IT_NO_SUCH_ELEMENT"/>
- </Match>
- <Match>
- <Bug pattern="INT_BAD_COMPARISON_WITH_NONNEGATIVE_VALUE"/>
- </Match>
- <Match>
- <Bug pattern="EI_EXPOSE_REP"/>
- </Match>
- <Match>
- <Bug pattern="JLM_JSR166_LOCK_MONITORENTER"/>
- </Match>
- <Match>
- <Bug pattern="BIT_IOR_OF_SIGNED_BYTE"/>
- </Match>
- <Match>
- <Bug pattern="MSF_MUTABLE_SERVLET_FIELD"/>
- </Match>
- <Match>
- <Bug pattern="IS_INCONSISTENT_SYNC"/>
- </Match>
- <Match>
- <Bug pattern="RV_REM_OF_HASHCODE"/>
- </Match>
- <Match>
- <Bug pattern="LG_LOST_LOGGER_DUE_TO_WEAK_REFERENCE"/>
- </Match>
- <Match>
- <Bug pattern="ICAST_INT_CAST_TO_FLOAT_PASSED_TO_ROUND"/>
- </Match>
- <Match>
- <Bug pattern="SE_NONSTATIC_SERIALVERSIONID"/>
- </Match>
- <Match>
- <Bug pattern="BC_VACUOUS_INSTANCEOF"/>
- </Match>
- <Match>
- <Bug pattern="RV_ABSOLUTE_VALUE_OF_HASHCODE"/>
- </Match>
- <Match>
- <Bug pattern="RC_REF_COMPARISON_BAD_PRACTICE_BOOLEAN"/>
- </Match>
- <Match>
- <Bug pattern="DMI_CALLING_NEXT_FROM_HASNEXT"/>
- </Match>
- <Match>
- <Bug pattern="NP_NULL_ON_SOME_PATH"/>
- </Match>
- <Match>
- <Bug pattern="RS_READOBJECT_SYNC"/>
- </Match>
- <Match>
- <Bug pattern="EC_INCOMPATIBLE_ARRAY_COMPARE"/>
- </Match>
- <Match>
- <Bug pattern="BC_IMPOSSIBLE_DOWNCAST_OF_TOARRAY"/>
- </Match>
- <Match>
- <Bug pattern="NS_DANGEROUS_NON_SHORT_CIRCUIT"/>
- </Match>
- <Match>
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
- <Match>
- <Bug pattern="SA_FIELD_DOUBLE_ASSIGNMENT"/>
- </Match>
- <Match>
- <Bug pattern="EQ_GETCLASS_AND_CLASS_CONSTANT"/>
- </Match>
- <Match>
- <Bug pattern="VA_FORMAT_STRING_ARG_MISMATCH"/>
- </Match>
- <Match>
- <Bug pattern="MS_OOI_PKGPROTECT"/>
- </Match>
- <Match>
- <Bug pattern="EC_UNRELATED_TYPES"/>
- </Match>
- <Match>
- <Bug pattern="MS_EXPOSE_REP"/>
- </Match>
- <Match>
- <Bug pattern="BX_UNBOXED_AND_COERCED_FOR_TERNARY_OPERATOR"/>
- </Match>
- <Match>
- <Bug pattern="SF_SWITCH_FALLTHROUGH"/>
- </Match>
- <Match>
- <Bug pattern="DMI_LONG_BITS_TO_DOUBLE_INVOKED_ON_INT"/>
- </Match>
- <Match>
- <Bug pattern="HRS_REQUEST_PARAMETER_TO_COOKIE"/>
- </Match>
- <Match>
- <Bug pattern="ESync_EMPTY_SYNC"/>
- </Match>
- <Match>
- <Bug pattern="NP_IMMEDIATE_DEREFERENCE_OF_READLINE"/>
- </Match>
- <Match>
- <Bug pattern="IJU_NO_TESTS"/>
- </Match>
- <Match>
- <Bug pattern="UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS"/>
- </Match>
- <Match>
- <Bug pattern="RE_POSSIBLE_UNINTENDED_PATTERN"/>
- </Match>
- <Match>
- <Bug pattern="DLS_OVERWRITTEN_INCREMENT"/>
- </Match>
-</FindBugsFilter>
\ No newline at end of file
+++ /dev/null
-import java.util.Arrays;
-import java.util.Collections;
-import java.util.Comparator;
-
-class Hello {
-
- static String name;
-
- public void methodWithViolations(String n) {
- name = n;
- Collections.sort(Arrays.asList(new Integer[]{1, 2, 3}), new Comparator<Integer>() {
- public int compare(Integer o1, Integer o2) {
- return o1 - o2;
- }
- });
- }
-
- @Override
- public boolean equals(Object obj) {
- return false;
- }
-}
\ No newline at end of file
<module>sonar-ws-client</module>
<module>plugins/sonar-core-plugin</module>
<module>plugins/sonar-dbcleaner-plugin</module>
- <module>plugins/sonar-findbugs-plugin</module>
<module>plugins/sonar-cpd-plugin</module>
<module>plugins/sonar-design-plugin</module>
<module>plugins/sonar-l10n-en-plugin</module>
<artifactId>sonar-checkstyle-plugin</artifactId>
<version>${sonarJava.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.codehaus.sonar-plugins.java</groupId>
+ <artifactId>sonar-findbugs-plugin</artifactId>
+ <version>${sonarJava.version}</version>
+ </dependency>
<dependency>
<groupId>org.codehaus.sonar-plugins.java</groupId>
<artifactId>sonar-surefire-plugin</artifactId>
<scope>runtime</scope>
</dependency>
<dependency>
- <groupId>org.codehaus.sonar.plugins</groupId>
+ <groupId>org.codehaus.sonar-plugins.java</groupId>
<artifactId>sonar-findbugs-plugin</artifactId>
- <version>${project.version}</version>
<scope>runtime</scope>
</dependency>
<dependency>
<scope>provided</scope>
</dependency>
<dependency>
- <groupId>org.codehaus.sonar.plugins</groupId>
+ <groupId>org.codehaus.sonar-plugins.java</groupId>
<artifactId>sonar-findbugs-plugin</artifactId>
- <version>${project.version}</version>
+ <version>${sonarJava.version}</version>
<type>sonar-plugin</type>
<scope>provided</scope>
</dependency>
projects / sonarqube.git / commitdiff