replaced hard coded style with a css rule

svn changeset:15308/svn branch:6.4

diff --git a/WebContent/VAADIN/themes/base/button/button.css b/WebContent/VAADIN/themes/base/button/button.css
index 29dfab0de79f9792bd26f07af5e8a4e961597e99..5051360bb3d5cd56385c251ba1ca4ec452f01c9b 100644 (file)
--- a/WebContent/VAADIN/themes/base/button/button.css
+++ b/WebContent/VAADIN/themes/base/button/button.css
@@ -130,6 +130,10 @@
 /*\r
  * Checkbox styles\r
  * -------------------------------------- */\r
+ \r
+ .v-checkbox {\r
+       display: block;\r
+ }\r
 \r
 .v-checkbox,\r
 .v-checkbox label,\r

diff --git a/src/com/vaadin/terminal/gwt/client/ui/VCheckBox.java b/src/com/vaadin/terminal/gwt/client/ui/VCheckBox.java
index 08111452f73069574ab5f5344db93ad1d81198c9..469fbf20ae2570fbadc9ae2528b3f1144bc3583b 100644 (file)
--- a/src/com/vaadin/terminal/gwt/client/ui/VCheckBox.java
+++ b/src/com/vaadin/terminal/gwt/client/ui/VCheckBox.java
@@ -42,8 +42,6 @@ public class VCheckBox extends com.google.gwt.user.client.ui.CheckBox implements
 
     private Icon icon;
 
-    private boolean isBlockMode = false;
-
     private HandlerRegistration focusHandlerRegistration;
     private HandlerRegistration blurHandlerRegistration;
 
@@ -170,26 +168,14 @@ public class VCheckBox extends com.google.gwt.user.client.ui.CheckBox implements
 
     @Override
     public void setWidth(String width) {
-        setBlockMode();
         super.setWidth(width);
     }
 
     @Override
     public void setHeight(String height) {
-        setBlockMode();
         super.setHeight(height);
     }
 
-    /**
-     * makes container element (span) to be block element to enable sizing.
-     */
-    private void setBlockMode() {
-        if (!isBlockMode) {
-            DOM.setStyleAttribute(getElement(), "display", "block");
-            isBlockMode = true;
-        }
-    }
-
     public void onFocus(FocusEvent arg0) {
         client.updateVariable(id, EventId.FOCUS, "", true);
     }