#4360 HierarchicalContainer.setParent() left container in inconsistent state

svn changeset:11925/svn branch:6.3

diff --git a/src/com/vaadin/data/util/HierarchicalContainer.java b/src/com/vaadin/data/util/HierarchicalContainer.java
index 152d9b4e584283d435f60ad1737e0ff49b298f68..9d9b375fd6f20bc889a8f29a25dbd6647cc18206 100644 (file)
--- a/src/com/vaadin/data/util/HierarchicalContainer.java
+++ b/src/com/vaadin/data/util/HierarchicalContainer.java
@@ -238,7 +238,7 @@ public class HierarchicalContainer extends IndexedContainer implements
             // roots)
 
             // Removes from old parents children list
-            final LinkedList<Object> l = children.get(itemId);
+            final LinkedList<Object> l = children.get(oldParentId);
             if (l != null) {
                 l.remove(itemId);
                 if (l.isEmpty()) {
@@ -329,7 +329,8 @@ public class HierarchicalContainer extends IndexedContainer implements
     }
 
     /**
-     * TODO javadoc
+     * Moves a node in the container immediately after a sibling node. The two
+     * nodes must have the same parent in the container.
      * 
      * @param itemId
      * @param siblingId