code cleanup: rubocop: fix Style/ZeroLengthPredicate in app/models/issue.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18523 e93f8b46-1217-0410-a6f0-8f06a7374b81

diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index 9afd19ed303c9db0e9ccc772232c93a263f7d3ca..d9971b00c99c4e003435e6f71da22292eca61873 100644 (file)
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -1726,7 +1726,6 @@ Style/WordArray:
 Style/ZeroLengthPredicate:
   Exclude:
     - 'app/models/import.rb'
-    - 'app/models/issue.rb'
     - 'app/models/mail_handler.rb'
     - 'app/models/user.rb'
     - 'lib/redmine/field_format.rb'

diff --git a/app/models/issue.rb b/app/models/issue.rb
index 6bfdaa433702a8d5e40d75f0b984cc7958cd22d8..8f74ec44ea70c43cdb8edccbde944fd9865eb073 100644 (file)
--- a/app/models/issue.rb
+++ b/app/models/issue.rb
@@ -77,7 +77,7 @@ class Issue < ActiveRecord::Base
   }
 
   scope :open, lambda {|*args|
-    is_closed = args.size > 0 ? !args.first : false
+    is_closed = !args.empty? ? !args.first : false
     joins(:status).
     where(:issue_statuses => {:is_closed => is_closed})
   }