SONAR-1814 add a warning when a ExtensionProvider class is registered in Plugin.getEx...

diff --git a/sonar-core/src/main/java/org/sonar/core/plugin/AbstractPluginRepository.java b/sonar-core/src/main/java/org/sonar/core/plugin/AbstractPluginRepository.java
index 24a40d9fd687d2a248ee5551dab45ab406a6ee07..b62bf9830451e43f75cafbed9ab69470f56bbe90 100644 (file)
--- a/sonar-core/src/main/java/org/sonar/core/plugin/AbstractPluginRepository.java
+++ b/sonar-core/src/main/java/org/sonar/core/plugin/AbstractPluginRepository.java
@@ -102,7 +102,15 @@ public abstract class AbstractPluginRepository implements PluginRepository {
   }
 
   protected static boolean isExtensionProvider(Object extension) {
-    return extension instanceof ExtensionProvider;
+    boolean is = false;
+    if (isType(extension, ExtensionProvider.class)) {
+      if (extension instanceof ExtensionProvider) {
+        is = true;
+      } else {
+        LOG.error("The following ExtensionProvider must be registered in Plugin.getExtensions() as an instance but not a class: " + extension);
+      }
+    }
+    return is;
   }
 
   protected static Object getExtensionKey(Object component) {