]> source.dussan.org Git - gitea.git/commitdiff
Add fullTextSearch to dropdowns by default (#14694)
authorzeripath <art27@cantab.net>
Tue, 16 Feb 2021 03:03:32 +0000 (03:03 +0000)
committerGitHub <noreply@github.com>
Tue, 16 Feb 2021 03:03:32 +0000 (11:03 +0800)
This PR adds `fullTextSearch: 'exact'` to most dropdown
invocations meaning that if there is a search box for the
dropdown it will automatically do a fullTextSearch looking
for the provided fragment instead of starting at the beginning

We should consider changing other places that use
`fullTextSearch: true` to `'exact'` because these will be using a
fuzzy-textual search that doesn't necessarily return the
expected results.

Fix #14689

Signed-off-by: Andrew Thornton <art27@cantab.net>
web_src/js/features/gitgraph.js
web_src/js/index.js

index 570d16059f586a7db9ee5896a81e6da7671b8878..cd2668ad354ccd6ca6fbabae8f0a7132bd01bd5a 100644 (file)
@@ -74,6 +74,7 @@ export default async function initGitGraph() {
   $('#flow-select-refs-dropdown').dropdown('set selected', dropdownSelected);
   $('#flow-select-refs-dropdown').dropdown({
     clearable: true,
+    fullTextSeach: 'exact',
     onRemove(toRemove) {
       if (toRemove === '...flow-hide-pr-refs') {
         params.delete('hide-pr-refs');
index 0d60c21ccacc19bd20b3a69b6066e233b5761c9c..c67b3c809bb2f1e23703de510e2d339d0d08a526 100644 (file)
@@ -2408,18 +2408,23 @@ $(document).ready(async () => {
   });
 
   // Semantic UI modules.
-  $('.dropdown:not(.custom)').dropdown();
+  $('.dropdown:not(.custom)').dropdown({
+    fullTextSearch: 'exact'
+  });
   $('.jump.dropdown').dropdown({
     action: 'hide',
     onShow() {
       $('.poping.up').popup('hide');
-    }
+    },
+    fullTextSearch: 'exact'
   });
   $('.slide.up.dropdown').dropdown({
-    transition: 'slide up'
+    transition: 'slide up',
+    fullTextSearch: 'exact'
   });
   $('.upward.dropdown').dropdown({
-    direction: 'upward'
+    direction: 'upward',
+    fullTextSearch: 'exact'
   });
   $('.ui.accordion').accordion();
   $('.ui.checkbox').checkbox();
@@ -3465,6 +3470,7 @@ function initTopicbar() {
   topicDropdown.dropdown({
     allowAdditions: true,
     forceSelection: false,
+    fullTextSearch: 'exact',
     fields: {name: 'description', value: 'data-value'},
     saveRemoteData: false,
     label: {