]> source.dussan.org Git - poi.git/commitdiff
update getCellType to return CellType enum instead of int
authorPJ Fanning <fanningpj@apache.org>
Mon, 18 Sep 2017 13:58:55 +0000 (13:58 +0000)
committerPJ Fanning <fanningpj@apache.org>
Mon, 18 Sep 2017 13:58:55 +0000 (13:58 +0000)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808718 13f79535-47bb-0310-9956-ffa450edef68

46 files changed:
src/examples/src/org/apache/poi/hssf/usermodel/examples/HSSFReadWrite.java
src/java/org/apache/poi/hssf/usermodel/HSSFCell.java
src/java/org/apache/poi/hssf/usermodel/HSSFRow.java
src/java/org/apache/poi/ss/formula/BaseFormulaEvaluator.java
src/java/org/apache/poi/ss/formula/EvaluationCache.java
src/java/org/apache/poi/ss/formula/IStabilityClassifier.java
src/java/org/apache/poi/ss/formula/eval/forked/ForkedEvaluator.java
src/java/org/apache/poi/ss/usermodel/DataFormatter.java
src/java/org/apache/poi/ss/usermodel/FormulaEvaluator.java
src/java/org/apache/poi/ss/util/SheetUtil.java
src/java/org/apache/poi/ss/util/cellwalk/CellWalk.java
src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFFormulaEvaluator.java
src/ooxml/java/org/apache/poi/xssf/streaming/SheetDataWriter.java
src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFRow.java
src/ooxml/testcases/org/apache/poi/ss/formula/TestStructuredReferences.java
src/ooxml/testcases/org/apache/poi/ss/formula/functions/TestProper.java
src/ooxml/testcases/org/apache/poi/xssf/streaming/TestSXSSFFormulaEvaluation.java
src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestFormulaEvaluatorOnXSSF.java
src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFBugs.java
src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFCell.java
src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFFormulaParser.java
src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFRow.java
src/testcases/org/apache/poi/hssf/usermodel/TestBugs.java
src/testcases/org/apache/poi/hssf/usermodel/TestExternalReferenceChange.java
src/testcases/org/apache/poi/hssf/usermodel/TestFormulaEvaluatorBugs.java
src/testcases/org/apache/poi/hssf/usermodel/TestFormulaEvaluatorDocs.java
src/testcases/org/apache/poi/hssf/usermodel/TestHSSFFormulaEvaluator.java
src/testcases/org/apache/poi/ss/formula/BaseTestExternalFunctions.java
src/testcases/org/apache/poi/ss/formula/TestEvaluationCache.java
src/testcases/org/apache/poi/ss/formula/TestMissingWorkbook.java
src/testcases/org/apache/poi/ss/formula/TestWorkbookEvaluator.java
src/testcases/org/apache/poi/ss/formula/atp/TestRandBetween.java
src/testcases/org/apache/poi/ss/formula/eval/TestFormulasFromSpreadsheet.java
src/testcases/org/apache/poi/ss/formula/functions/BaseTestFunctionsFromSpreadsheet.java
src/testcases/org/apache/poi/ss/formula/functions/TestDate.java
src/testcases/org/apache/poi/ss/formula/functions/TestFind.java
src/testcases/org/apache/poi/ss/formula/functions/TestFixed.java
src/testcases/org/apache/poi/ss/formula/functions/TestIndirect.java
src/testcases/org/apache/poi/ss/formula/functions/TestIrr.java
src/testcases/org/apache/poi/ss/formula/functions/TestMirr.java
src/testcases/org/apache/poi/ss/formula/functions/TestNpv.java
src/testcases/org/apache/poi/ss/formula/ptg/TestExternalNameReference.java
src/testcases/org/apache/poi/ss/usermodel/BaseTestBugzillaIssues.java
src/testcases/org/apache/poi/ss/usermodel/BaseTestCell.java
src/testcases/org/apache/poi/ss/usermodel/BaseTestFormulaEvaluator.java
src/testcases/org/apache/poi/ss/usermodel/BaseTestSheetAutosizeColumn.java

index 2393b18122404438d0d408b97370faa79e8d3edb..ab848d3dd6cb0b3ec5deaee2b466c51723ccb9f7 100644 (file)
@@ -188,7 +188,7 @@ public final class HSSFReadWrite {
                                                                String value;
 
                                                                if(cell != null) {
-                                                                       switch (cell.getCellTypeEnum()) {
+                                                                       switch (cell.getCellType()) {
 
                                                                                case FORMULA:
                                                                                        value = "FORMULA value=" + cell.getCellFormula();
@@ -215,7 +215,7 @@ public final class HSSFReadWrite {
                                                                                        break;
 
                                                                                default:
-                                                                                       value = "UNKNOWN value of type " + cell.getCellTypeEnum();
+                                                                                       value = "UNKNOWN value of type " + cell.getCellType();
                                                                        }
                                                                        System.out.println("CELL col=" + cell.getColumnIndex() + " VALUE="
                                                                                        + value);
index 26e80d6a80dc8c39dfbb07284fa888c85831e535..23ed7dc7bc9671f6e94ba4e24741ce9e4aa2428d 100644 (file)
@@ -1012,7 +1012,7 @@ public class HSSFCell implements Cell {
             case STRING:
                 return getStringCellValue();
             default:
-                return "Unknown Cell Type: " + getCellTypeEnum();
+                return "Unknown Cell Type: " + getCellType();
         }
     }
 
index ac0a902b743981e15e8ac41c3395571c7e75080c..4ca64ea8fc24c404de04f2c7a9372b9df7c03932 100644 (file)
@@ -388,7 +388,7 @@ public final class HSSFRow implements Row, Comparable<HSSFRow> {
             case RETURN_NULL_AND_BLANK:
                 return cell;
             case RETURN_BLANK_AS_NULL:
-                boolean isBlank = (cell != null && cell.getCellTypeEnum() == CellType.BLANK);
+                boolean isBlank = (cell != null && cell.getCellType() == CellType.BLANK);
                 return (isBlank) ? null : cell;
             case CREATE_NULL_AS_BLANK:
                 return (cell == null) ? createCell(cellnum, CellType.BLANK) : cell;
index 4bf033e3666ae63c55531f1acea89ecb1dd56839..8648f6a1a864cc06915fc806a9d27b7e7b3546c4 100644 (file)
@@ -93,7 +93,7 @@ public abstract class BaseFormulaEvaluator implements FormulaEvaluator, Workbook
             return null;
         }
 
-        switch (cell.getCellTypeEnum()) {
+        switch (cell.getCellType()) {
             case BOOLEAN:
                 return CellValue.valueOf(cell.getBooleanCellValue());
             case ERROR:
@@ -107,7 +107,7 @@ public abstract class BaseFormulaEvaluator implements FormulaEvaluator, Workbook
             case BLANK:
                 return null;
             default:
-                throw new IllegalStateException("Bad cell type (" + cell.getCellTypeEnum() + ")");
+                throw new IllegalStateException("Bad cell type (" + cell.getCellType() + ")");
         }
     }
     
@@ -124,7 +124,7 @@ public abstract class BaseFormulaEvaluator implements FormulaEvaluator, Workbook
      * </pre>
      * Be aware that your cell value will be changed to hold the
      *  result of the formula. If you simply want the formula
-     *  value computed for you, use {@link #evaluateFormulaCellEnum(Cell)}}
+     *  value computed for you, use {@link #evaluateFormulaCell(Cell)}}
      * @param cell
      * @return the {@code cell} that was passed in, allowing for chained calls
      */
@@ -133,7 +133,7 @@ public abstract class BaseFormulaEvaluator implements FormulaEvaluator, Workbook
         if (cell == null) {
             return null;
         }
-        if (cell.getCellTypeEnum() == CellType.FORMULA) {
+        if (cell.getCellType() == CellType.FORMULA) {
             CellValue cv = evaluateFormulaCellValue(cell);
             setCellValue(cell, cv);
             setCellType(cell, cv); // cell will no longer be a formula cell
@@ -153,7 +153,7 @@ public abstract class BaseFormulaEvaluator implements FormulaEvaluator, Workbook
      *  so you know what kind of value is also stored with
      *  the formula.
      * <pre>
-     * CellType evaluatedCellType = evaluator.evaluateFormulaCellEnum(cell);
+     * CellType evaluatedCellType = evaluator.evaluateFormulaCell(cell);
      * </pre>
      * Be aware that your cell will hold both the formula,
      *  and the result. If you want the cell replaced with
@@ -164,13 +164,13 @@ public abstract class BaseFormulaEvaluator implements FormulaEvaluator, Workbook
      */
     @Override
     public CellType evaluateFormulaCell(Cell cell) {
-        if (cell == null || cell.getCellTypeEnum() != CellType.FORMULA) {
+        if (cell == null || cell.getCellType() != CellType.FORMULA) {
             return CellType._NONE;
         }
         CellValue cv = evaluateFormulaCellValue(cell);
         // cell remains a formula cell, but the cached value is changed
         setCellValue(cell, cv);
-        return cv.getCellTypeEnum();
+        return cv.getCellType();
     }
     
     /**
@@ -183,7 +183,7 @@ public abstract class BaseFormulaEvaluator implements FormulaEvaluator, Workbook
      *  so you know what kind of value is also stored with
      *  the formula.
      * <pre>
-     * CellType evaluatedCellType = evaluator.evaluateFormulaCellEnum(cell);
+     * CellType evaluatedCellType = evaluator.evaluateFormulaCell(cell);
      * </pre>
      * Be aware that your cell will hold both the formula,
      *  and the result. If you want the cell replaced with
@@ -202,7 +202,7 @@ public abstract class BaseFormulaEvaluator implements FormulaEvaluator, Workbook
     }
 
     protected static void setCellType(Cell cell, CellValue cv) {
-        CellType cellType = cv.getCellTypeEnum();
+        CellType cellType = cv.getCellType();
         switch (cellType) {
             case BOOLEAN:
             case ERROR:
@@ -224,7 +224,7 @@ public abstract class BaseFormulaEvaluator implements FormulaEvaluator, Workbook
     protected abstract RichTextString createRichTextString(String str);
     
     protected void setCellValue(Cell cell, CellValue cv) {
-        CellType cellType = cv.getCellTypeEnum();
+        CellType cellType = cv.getCellType();
         switch (cellType) {
             case BOOLEAN:
                 cell.setCellValue(cv.getBooleanValue());
@@ -269,8 +269,8 @@ public abstract class BaseFormulaEvaluator implements FormulaEvaluator, Workbook
 
             for(Row r : sheet) {
                 for (Cell c : r) {
-                    if (c.getCellTypeEnum() == CellType.FORMULA) {
-                        evaluator.evaluateFormulaCellEnum(c);
+                    if (c.getCellType() == CellType.FORMULA) {
+                        evaluator.evaluateFormulaCell(c);
                     }
                 }
             }
index cd68db3977e7643751cfe70e7a8f41e74a42086a..ff655f36bbd27556d2dfcb39c977bff21329af93 100644 (file)
@@ -56,7 +56,7 @@ final class EvaluationCache {
                Loc loc = new Loc(bookIndex, sheetIndex, rowIndex, columnIndex);
                PlainValueCellCacheEntry pcce = _plainCellCache.get(loc);
 
-               if (cell.getCellTypeEnum() == CellType.FORMULA) {
+               if (cell.getCellType() == CellType.FORMULA) {
                        if (fcce == null) {
                                fcce = new FormulaCellCacheEntry();
                                if (pcce == null) {
@@ -197,7 +197,7 @@ final class EvaluationCache {
        }
        public void notifyDeleteCell(int bookIndex, int sheetIndex, EvaluationCell cell) {
 
-               if (cell.getCellTypeEnum() == CellType.FORMULA) {
+               if (cell.getCellType() == CellType.FORMULA) {
                        FormulaCellCacheEntry fcce = _formulaCellCache.remove(cell);
                        if (fcce == null) {
                                // formula cell has not been evaluated yet
index db8beac9b961aa183f0e7c96aa9d2c37be5c1ba8..e4576a7c4d48ff2b0d744b16eadfa0317d4b8285 100644 (file)
@@ -47,7 +47,7 @@ package org.apache.poi.ss.formula;
  * <li>To retain freedom to change any cell definition at any time, an application may classify all
  * cells as 'not final'.  This freedom comes at the expense of greater memory consumption.</li>
  * <li>For the purpose of these classifications, setting the cached formula result of a cell (for 
- * example in {@link org.apache.poi.ss.usermodel.FormulaEvaluator#evaluateFormulaCellEnum(org.apache.poi.ss.usermodel.Cell)})
+ * example in {@link org.apache.poi.ss.usermodel.FormulaEvaluator#evaluateFormulaCell(org.apache.poi.ss.usermodel.Cell)})
  * does not constitute changing the definition of the cell.</li>
  * <li>Updating cells which have been classified as 'final' will cause the evaluator to behave 
  * unpredictably (typically ignoring the update).</li> 
index 7cfcaee002d268d204e57b34f79ff8bf228334d0..9a46ac44a87054e97b2f49986f339afa1652a975 100644 (file)
@@ -112,7 +112,7 @@ public final class ForkedEvaluator {
        public ValueEval evaluate(String sheetName, int rowIndex, int columnIndex) {
                EvaluationCell cell = _sewb.getEvaluationCell(sheetName, rowIndex, columnIndex);
 
-               switch (cell.getCellTypeEnum()) {
+               switch (cell.getCellType()) {
                        case BOOLEAN:
                                return BoolEval.valueOf(cell.getBooleanCellValue());
                        case ERROR:
@@ -126,7 +126,7 @@ public final class ForkedEvaluator {
                        case BLANK:
                                return null;
                        default:
-                               throw new IllegalStateException("Bad cell type (" + cell.getCellTypeEnum() + ")");
+                               throw new IllegalStateException("Bad cell type (" + cell.getCellType() + ")");
                }
        }
        /**
index 7b557fd6587330e8144d959508b8784818f6e4ff..6bcf20009037404bf86d45e17e42ba761c80c48b 100644 (file)
@@ -983,7 +983,7 @@ public class DataFormatter implements Observer {
             if (evaluator == null) {
                 return cell.getCellFormula();
             }
-            cellType = evaluator.evaluateFormulaCellEnum(cell);
+            cellType = evaluator.evaluateFormulaCell(cell);
         }
         switch (cellType) {
             case NUMERIC :
index 4d8a440222126af265fa85ad2d151b40e4f3f91e..b60e55980469c0c9e268971a835e1ac7bdf05311 100644 (file)
@@ -114,7 +114,7 @@ public interface FormulaEvaluator {
      *  so you know what kind of value is also stored with
      *  the formula.
      * <pre>
-     * CellType evaluatedCellType = evaluator.evaluateFormulaCellEnum(cell);
+     * CellType evaluatedCellType = evaluator.evaluateFormulaCell(cell);
      * </pre>
      * Be aware that your cell will hold both the formula,
      *  and the result. If you want the cell replaced with
@@ -143,7 +143,7 @@ public interface FormulaEvaluator {
      * </pre>
      * Be aware that your cell value will be changed to hold the
      *  result of the formula. If you simply want the formula
-     *  value computed for you, use {@link #evaluateFormulaCellEnum(Cell)}
+     *  value computed for you, use {@link #evaluateFormulaCell(Cell)}
      * @param cell
      */
     Cell evaluateInCell(Cell cell);
index e01b8a3b3787082dc1f8980a3ce2291e97cf5272..2087a9dc7e9fbfb1e7dbfa4f9abb82be91a7d525 100644 (file)
@@ -69,7 +69,7 @@ public class SheetUtil {
      *
      *  See Bugzilla #50021
      */
-    private static final FormulaEvaluator dummyEvaluator = new FormulaEvaluator(){
+    private static final FormulaEvaluator dummyEvaluator = new FormulaEvaluator() {
         @Override
         public void clearAllCachedResultValues(){}
         @Override
index c69294676e46253a1792c7366ba2c1734c86ccb9..fe1605ce30eda4f8c3186ec5888cfb5564403346 100644 (file)
@@ -101,7 +101,7 @@ public class CellWalk {
     }
 
     private boolean isEmpty(Cell cell) {
-        return (cell.getCellTypeEnum() == CellType.BLANK);
+        return (cell.getCellType() == CellType.BLANK);
     }
 
     /**
index a995a08b5f27e98d5d9b422f6529c046c3fa8757..85980817e27f8df7957b06b36decca3505231b64 100644 (file)
@@ -106,8 +106,8 @@ public final class SXSSFFormulaEvaluator extends BaseXSSFFormulaEvaluator {
             // Evaluate what we have
             for (Row r : sheet) {
                 for (Cell c : r) {
-                    if (c.getCellTypeEnum() == CellType.FORMULA) {
-                        eval.evaluateFormulaCellEnum(c);
+                    if (c.getCellType() == CellType.FORMULA) {
+                        eval.evaluateFormulaCell(c);
                     }
                 }
             }
index 19f6047d4fcda3a5d1c5e2e6f5593a152ce44d95..cfdade83768be240fe1e4c3cf6d7a040ac6dbc3e 100644 (file)
@@ -252,7 +252,7 @@ public class SheetDataWriter implements Closeable {
             // APIs
             writeAttribute("s", Integer.toString(cellStyle.getIndex() & 0xffff));
         }
-        CellType cellType = cell.getCellTypeEnum();
+        CellType cellType = cell.getCellType();
         switch (cellType) {
             case BLANK: {
                 _out.write('>');
index fed5d383c28117af142bd90397e0d4316693ac54..b33de42577f98d591f9b0f0a45f279451863801e 100644 (file)
@@ -276,7 +276,7 @@ public class XSSFRow implements Row, Comparable<XSSFRow> {
             case RETURN_NULL_AND_BLANK:
                 return cell;
             case RETURN_BLANK_AS_NULL:
-                boolean isBlank = (cell != null && cell.getCellTypeEnum() == CellType.BLANK);
+                boolean isBlank = (cell != null && cell.getCellType() == CellType.BLANK);
                 return (isBlank) ? null : cell;
             case CREATE_NULL_AS_BLANK:
                 return (cell == null) ? createCell(cellnum, CellType.BLANK) : cell;
@@ -496,7 +496,7 @@ public class XSSFRow implements Row, Comparable<XSSFRow> {
         if(xcell.isPartOfArrayFormulaGroup()) {
             xcell.notifyArrayFormulaChanging();
         }
-        if(cell.getCellTypeEnum() == CellType.FORMULA) {
+        if(cell.getCellType() == CellType.FORMULA) {
            _sheet.getWorkbook().onDeleteFormula(xcell);
         }
         // Performance optimization for bug 57840: explicit boxing is slightly faster than auto-unboxing, though may use more memory
@@ -636,7 +636,7 @@ public class XSSFRow implements Row, Comparable<XSSFRow> {
         else {
             for (final Cell c : srcRow){
                 final XSSFCell srcCell = (XSSFCell)c;
-                final XSSFCell destCell = createCell(srcCell.getColumnIndex(), srcCell.getCellTypeEnum());
+                final XSSFCell destCell = createCell(srcCell.getColumnIndex(), srcCell.getCellType());
                 destCell.copyCellFrom(srcCell, policy);
             }
 
index a17c9d08ae741fd0d63155d7503d36b521ea97fc..2599db4e0db37a6aeaa9a1feb4abc2ee61284b30 100644 (file)
@@ -113,7 +113,7 @@ public class TestStructuredReferences {
     private static void confirm(FormulaEvaluator fe, Cell cell, double expectedResult) {
         fe.clearAllCachedResultValues();
         CellValue cv = fe.evaluate(cell);
-        if (cv.getCellTypeEnum() != CellType.NUMERIC) {
+        if (cv.getCellType() != CellType.NUMERIC) {
             fail("expected numeric cell type but got " + cv.formatAsString());
         }
         assertEquals(expectedResult, cv.getNumberValue(), 0.0);
@@ -122,7 +122,7 @@ public class TestStructuredReferences {
     private static void confirm(FormulaEvaluator fe, Cell cell, String expectedResult) {
         fe.clearAllCachedResultValues();
         CellValue cv = fe.evaluate(cell);
-        if (cv.getCellTypeEnum() != CellType.STRING) {
+        if (cv.getCellType() != CellType.STRING) {
             fail("expected String cell type but got " + cv.formatAsString());
         }
         assertEquals(expectedResult, cv.getStringValue());
index 65f7585c4098d9f99497503cb24992487b1dcb02..6c46e3dcc0b66523d2186b02af00bd56ba0b0a91 100644 (file)
@@ -95,7 +95,7 @@ public final class TestProper {
         cell11.setCellFormula(formulaText);
         evaluator.clearAllCachedResultValues();
         CellValue cv = evaluator.evaluate(cell11);
-        if (cv.getCellTypeEnum() != CellType.STRING) {
+        if (cv.getCellType() != CellType.STRING) {
             throw new AssertionFailedError("Wrong result type: " + cv.formatAsString());
         }
         String actualValue = cv.getStringValue();
index 0839fe801a877e45a72c413e06a7654b74efd62d..ff3ee87b3845bc9e23a97d55969a99b2923eb470 100644 (file)
@@ -106,7 +106,7 @@ public final class TestSXSSFFormulaEvaluation {
         
         FormulaEvaluator eval = wb.getCreationHelper().createFormulaEvaluator();
         try {
-            eval.evaluateFormulaCellEnum(c);
+            eval.evaluateFormulaCell(c);
             fail("Evaluate shouldn't work, as reference outside the window");
         } catch(SXSSFFormulaEvaluator.RowFlushedException e) {
             // Expected
@@ -152,7 +152,7 @@ public final class TestSXSSFFormulaEvaluation {
         c.setCellFormula("A1*2");
         
         assertEquals(0, (int)c.getNumericCellValue());
-        eval.evaluateFormulaCellEnum(c);
+        eval.evaluateFormulaCell(c);
         assertEquals(3, (int)c.getNumericCellValue());
         
         wb.close();
@@ -168,12 +168,12 @@ public final class TestSXSSFFormulaEvaluation {
         SXSSFCell c = s.createRow(0).createCell(0);
         c.setCellFormula("1+2");
         assertEquals(0, (int)c.getNumericCellValue());
-        eval.evaluateFormulaCellEnum(c);
+        eval.evaluateFormulaCell(c);
         assertEquals(3, (int)c.getNumericCellValue());
         
         c = s.createRow(1).createCell(0);
         c.setCellFormula("CONCATENATE(\"hello\",\" \",\"world\")");
-        eval.evaluateFormulaCellEnum(c);
+        eval.evaluateFormulaCell(c);
         assertEquals("hello world", c.getStringCellValue());
         
         wb.close();
index c6f3e3cf531a962b8346a626e5571e0fbb1e1a0d..97744249aaf948e36b977be34d82019adcb83e15 100644 (file)
@@ -190,7 +190,7 @@ public final class TestFormulaEvaluatorOnXSSF {
                for (short colnum=SS.COLUMN_INDEX_FIRST_TEST_VALUE; colnum < endcolnum; colnum++) {
                        Cell c = formulasRow.getCell(colnum);
                        assumeNotNull(c);
-                       assumeTrue(c.getCellTypeEnum() == CellType.FORMULA);
+                       assumeTrue(c.getCellType() == CellType.FORMULA);
                        ignoredFormulaTestCase(c.getCellFormula());
 
                        CellValue actValue = evaluator.evaluate(c);
@@ -202,17 +202,17 @@ public final class TestFormulaEvaluatorOnXSSF {
                        assertNotNull(msg + " - Bad setup data expected value is null", expValue);
                        assertNotNull(msg + " - actual value was null", actValue);
                
-               final CellType expectedCellType = expValue.getCellTypeEnum();
+               final CellType expectedCellType = expValue.getCellType();
                switch (expectedCellType) {
                    case BLANK:
-                       assertEquals(msg, CellType.BLANK, actValue.getCellTypeEnum());
+                       assertEquals(msg, CellType.BLANK, actValue.getCellType());
                        break;
                    case BOOLEAN:
-                       assertEquals(msg, CellType.BOOLEAN, actValue.getCellTypeEnum());
+                       assertEquals(msg, CellType.BOOLEAN, actValue.getCellType());
                        assertEquals(msg, expValue.getBooleanCellValue(), actValue.getBooleanValue());
                        break;
                    case ERROR:
-                       assertEquals(msg, CellType.ERROR, actValue.getCellTypeEnum());
+                       assertEquals(msg, CellType.ERROR, actValue.getCellType());
 //                   if(false) { // TODO: fix ~45 functions which are currently returning incorrect error values
 //                       assertEquals(msg, expValue.getErrorCellValue(), actValue.getErrorValue());
 //                   }
@@ -220,14 +220,14 @@ public final class TestFormulaEvaluatorOnXSSF {
                    case FORMULA: // will never be used, since we will call method after formula evaluation
                        fail("Cannot expect formula as result of formula evaluation: " + msg);
                    case NUMERIC:
-                       assertEquals(msg, CellType.NUMERIC, actValue.getCellTypeEnum());
+                       assertEquals(msg, CellType.NUMERIC, actValue.getCellType());
                        TestMathX.assertEquals(msg, expValue.getNumericCellValue(), actValue.getNumberValue(), TestMathX.POS_ZERO, TestMathX.DIFF_TOLERANCE_FACTOR);
 //                   double delta = Math.abs(expValue.getNumericCellValue()-actValue.getNumberValue());
 //                   double pctExpValue = Math.abs(0.00001*expValue.getNumericCellValue());
 //                   assertTrue(msg, delta <= pctExpValue);
                        break;
                    case STRING:
-                       assertEquals(msg, CellType.STRING, actValue.getCellTypeEnum());
+                       assertEquals(msg, CellType.STRING, actValue.getCellType());
                        assertEquals(msg, expValue.getRichStringCellValue().getString(), actValue.getStringValue());
                        break;
                    default:
@@ -264,10 +264,10 @@ public final class TestFormulaEvaluatorOnXSSF {
             logger.log(POILogger.WARN, "Warning - Row " + r.getRowNum() + " has no cell " + SS.COLUMN_INDEX_FUNCTION_NAME + ", can't figure out function name");
                        return null;
                }
-               if(cell.getCellTypeEnum() == CellType.BLANK) {
+               if(cell.getCellType() == CellType.BLANK) {
                        return null;
                }
-               if(cell.getCellTypeEnum() == CellType.STRING) {
+               if(cell.getCellType() == CellType.STRING) {
                        return cell.getRichStringCellValue().getString();
                }
                
index 2b82e0fe4ed938a6775fdd19eb7b68dcc4246b43..15cede111dd192554713a6ab43a8dc3040182b05 100644 (file)
@@ -666,14 +666,14 @@ public final class TestXSSFBugs extends BaseTestBugzillaIssues {
         assertEquals(3.0, c.getNumericCellValue(), 0);
 
         FormulaEvaluator formulaEvaluator = wb.getCreationHelper().createFormulaEvaluator();
-        formulaEvaluator.evaluateFormulaCellEnum(c);
+        formulaEvaluator.evaluateFormulaCell(c);
 
         assertEquals("SUM(\n1,2\n)", c.getCellFormula());
         assertEquals(3.0, c.getNumericCellValue(), 0);
 
         // For 51875
         Cell b3 = s.getRow(2).getCell(1);
-        formulaEvaluator.evaluateFormulaCellEnum(b3);
+        formulaEvaluator.evaluateFormulaCell(b3);
         assertEquals("B1+B2", b3.getCellFormula()); // The newline is lost for shared formulas
         assertEquals(3.0, b3.getNumericCellValue(), 0);
 
@@ -1375,8 +1375,8 @@ public final class TestXSSFBugs extends BaseTestBugzillaIssues {
 
         // Try evaluating both
         XSSFFormulaEvaluator eval = new XSSFFormulaEvaluator(wb);
-        eval.evaluateFormulaCellEnum(c1);
-        eval.evaluateFormulaCellEnum(c2);
+        eval.evaluateFormulaCell(c1);
+        eval.evaluateFormulaCell(c2);
 
         assertEquals(20.0, c1.getNumericCellValue(), 0);
         assertEquals(20.0, c2.getNumericCellValue(), 0);
@@ -2935,7 +2935,7 @@ public final class TestXSSFBugs extends BaseTestBugzillaIssues {
         cell = row.getCell(1);
 
         assertEquals(CellType.BLANK, cell.getCellType());
-        assertEquals(CellType._NONE, evaluator.evaluateFormulaCellEnum(cell));
+        assertEquals(CellType._NONE, evaluator.evaluateFormulaCell(cell));
 
         // A3
         row = worksheet.getRow(2);
@@ -2943,7 +2943,7 @@ public final class TestXSSFBugs extends BaseTestBugzillaIssues {
 
         assertEquals(CellType.FORMULA, cell.getCellType());
         assertEquals("IF(ISBLANK(B3),\"\",B3)", cell.getCellFormula());
-        assertEquals(CellType.STRING, evaluator.evaluateFormulaCellEnum(cell));
+        assertEquals(CellType.STRING, evaluator.evaluateFormulaCell(cell));
         CellValue value = evaluator.evaluate(cell);
         assertEquals("", value.getStringValue());
 
@@ -2953,7 +2953,7 @@ public final class TestXSSFBugs extends BaseTestBugzillaIssues {
 
         assertEquals(CellType.FORMULA, cell.getCellType());
         assertEquals("COUNTBLANK(A1:A4)", cell.getCellFormula());
-        assertEquals(CellType.NUMERIC, evaluator.evaluateFormulaCellEnum(cell));
+        assertEquals(CellType.NUMERIC, evaluator.evaluateFormulaCell(cell));
         value = evaluator.evaluate(cell);
         assertEquals(1.0, value.getNumberValue(), 0.1);
 
index bbca6625edccc799192154114eec3aed1180c551..de571d4a1f64f146115dda06389a33140de02305 100644 (file)
@@ -135,13 +135,13 @@ public final class TestXSSFCell extends BaseTestXCell {
         assertNull(str.getString());
         cell_0.setCellValue(str);
         assertEquals(0, sst.getCount());
-        assertEquals(CellType.BLANK, cell_0.getCellTypeEnum());
+        assertEquals(CellType.BLANK, cell_0.getCellType());
 
         //case 2. cell.setCellValue((String)null);
         Cell cell_1 = row.createCell(1);
         cell_1.setCellValue((String)null);
         assertEquals(0, sst.getCount());
-        assertEquals(CellType.BLANK, cell_1.getCellTypeEnum());
+        assertEquals(CellType.BLANK, cell_1.getCellType());
         wb.close();
     }
 
@@ -153,7 +153,7 @@ public final class TestXSSFCell extends BaseTestXCell {
             CTCell ctCell = cell.getCTCell(); //low-level bean holding cell's xml
     
             cell.setCellFormula("A2");
-            assertEquals(CellType.FORMULA, cell.getCellTypeEnum());
+            assertEquals(CellType.FORMULA, cell.getCellType());
             assertEquals("A2", cell.getCellFormula());
             //the value is not set and cell's type='N' which means blank
             assertEquals(STCellType.N, ctCell.getT());
@@ -161,7 +161,7 @@ public final class TestXSSFCell extends BaseTestXCell {
             //set cached formula value
             cell.setCellValue("t='str'");
             //we are still of 'formula' type
-            assertEquals(CellType.FORMULA, cell.getCellTypeEnum());
+            assertEquals(CellType.FORMULA, cell.getCellType());
             assertEquals("A2", cell.getCellFormula());
             //cached formula value is set and cell's type='STR'
             assertEquals(STCellType.STR, ctCell.getT());
@@ -169,14 +169,14 @@ public final class TestXSSFCell extends BaseTestXCell {
     
             //now remove the formula, the cached formula result remains
             cell.setCellFormula(null);
-            assertEquals(CellType.STRING, cell.getCellTypeEnum());
+            assertEquals(CellType.STRING, cell.getCellType());
             assertEquals(STCellType.STR, ctCell.getT());
             //the line below failed prior to fix of Bug #47889
             assertEquals("t='str'", cell.getStringCellValue());
     
             //revert to a blank cell
             cell.setCellValue((String)null);
-            assertEquals(CellType.BLANK, cell.getCellTypeEnum());
+            assertEquals(CellType.BLANK, cell.getCellType());
             assertEquals(STCellType.N, ctCell.getT());
             assertEquals("", cell.getStringCellValue());
         } finally {
@@ -196,7 +196,7 @@ public final class TestXSSFCell extends BaseTestXCell {
 
         //try a string cell
         cell = sh.getRow(0).getCell(0);
-        assertEquals(CellType.STRING, cell.getCellTypeEnum());
+        assertEquals(CellType.STRING, cell.getCellType());
         assertEquals("a", cell.getStringCellValue());
         assertEquals("a", cell.toString());
         //Gnumeric produces spreadsheets without styles
@@ -205,7 +205,7 @@ public final class TestXSSFCell extends BaseTestXCell {
 
         //try a numeric cell
         cell = sh.getRow(1).getCell(0);
-        assertEquals(CellType.NUMERIC, cell.getCellTypeEnum());
+        assertEquals(CellType.NUMERIC, cell.getCellType());
         assertEquals(1.0, cell.getNumericCellValue(), 0);
         assertEquals("1.0", cell.toString());
         //Gnumeric produces spreadsheets without styles
@@ -515,7 +515,7 @@ public final class TestXSSFCell extends BaseTestXCell {
         final CellCopyPolicy policy = new CellCopyPolicy();
         destCell.copyCellFrom(srcCell, policy);
         
-        assertEquals(CellType.FORMULA, destCell.getCellTypeEnum());
+        assertEquals(CellType.FORMULA, destCell.getCellType());
         assertEquals("2+3", destCell.getCellFormula());
         assertEquals(srcCell.getCellStyle(), destCell.getCellStyle());
     }
@@ -527,7 +527,7 @@ public final class TestXSSFCell extends BaseTestXCell {
         // Paste values only
         final CellCopyPolicy policy = new CellCopyPolicy.Builder().cellFormula(false).build();
         destCell.copyCellFrom(srcCell, policy);
-        assertEquals(CellType.NUMERIC, destCell.getCellTypeEnum());
+        assertEquals(CellType.NUMERIC, destCell.getCellType());
     }
     
     @Test
@@ -554,8 +554,8 @@ public final class TestXSSFCell extends BaseTestXCell {
         assertEquals(srcCell.getCellStyle(), destCell.getCellStyle());
         
         // Old cell value should not have been overwritten
-        assertNotEquals(CellType.BLANK, destCell.getCellTypeEnum());
-        assertEquals(CellType.BOOLEAN, destCell.getCellTypeEnum());
+        assertNotEquals(CellType.BLANK, destCell.getCellType());
+        assertEquals(CellType.BOOLEAN, destCell.getCellType());
         assertEquals(true, destCell.getBooleanCellValue());
     }
     
index 70d02d01674c8abdb1fafe4f2e47e627926424bf..2c4fc7aa73bbec10a48094c72feb61774bf394e1 100644 (file)
@@ -488,7 +488,7 @@ public final class TestXSSFFormulaParser {
                 for (Cell cell : row) {
                     if (cell.getCellTypeEnum() == CellType.FORMULA) {
                         try {
-                            evaluator.evaluateFormulaCellEnum(cell);
+                            evaluator.evaluateFormulaCell(cell);
                         } catch (Exception e) {
                             CellReference cellRef = new CellReference(cell.getRowIndex(), cell.getColumnIndex());
                             throw new RuntimeException("error at: " + cellRef, e);
index 6b49d81c984e6ca84c2cc7acdd14bff95fb3b767..9db9171e1e0eef27dd89439b02ccafac425cf45e 100644 (file)
@@ -183,7 +183,7 @@ public final class TestXSSFRow extends BaseTestXRow {
         assertSame("existing references to externObserverRow are still valid", externObserverRow, sheet2.getRow(0));
         
         // Make sure copyRowFrom actually copied row (this is tested elsewhere)
-        assertEquals(CellType.STRING, destRow.getCell(0).getCellTypeEnum());
+        assertEquals(CellType.STRING, destRow.getCell(0).getCellType());
         assertEquals("hello", destRow.getCell(0).getStringCellValue());
         
         // We don't want #REF! errors if we copy a row that contains cells that are referred to by other cells outside of copied region
index 3b47dcb66f88a8fcaaabff9b009cb980ee4fd633..21ad59cbd58d6513f02a3388620b17b55a8e0601 100644 (file)
@@ -2424,7 +2424,7 @@ public final class TestBugs extends BaseTestBugzillaIssues {
 
         // Check the evaluated result
         HSSFFormulaEvaluator eval = new HSSFFormulaEvaluator(wb);
-        eval.evaluateFormulaCellEnum(c);
+        eval.evaluateFormulaCell(c);
         assertEquals(4.0, c.getNumericCellValue(), 0);
         wb.close();
     }
index a059f1f5659c9fc050a847ddea7d948855d37775..9e3d4c33a5fd7e925f31719a22fed5d047fe7aee 100644 (file)
@@ -59,7 +59,7 @@ public class TestExternalReferenceChange extends TestCase {
                                new String[]{MAIN_WORKBOOK_FILENAME, SOURCE_WORKBOOK_FILENAME}, 
                                new HSSFFormulaEvaluator[] {lMainWorkbookEvaluator, lSourceEvaluator});
                
-               assertEquals(CellType.NUMERIC, lMainWorkbookEvaluator.evaluateFormulaCellEnum(lA1Cell));
+               assertEquals(CellType.NUMERIC, lMainWorkbookEvaluator.evaluateFormulaCell(lA1Cell));
 
                assertEquals(20.0d, lA1Cell.getNumericCellValue(), 0.00001d);
 
index 1533f36ed15a5378c39ce8d23806ae09f6921db4..60d0ccfdec9d2d0f1f1d8df41aa904a1ea72e17b 100644 (file)
@@ -287,7 +287,7 @@ public final class TestFormulaEvaluatorBugs {
                 HSSFRow r = (HSSFRow)rows.next();
                 for (Iterator<Cell> cells = r.cellIterator(); cells.hasNext();) {
                     HSSFCell c = (HSSFCell)cells.next();
-                    eval.evaluateFormulaCellEnum(c);
+                    eval.evaluateFormulaCell(c);
                 }
             }
         }
@@ -568,7 +568,7 @@ public final class TestFormulaEvaluatorBugs {
         }
     }
     private Ptg[] getPtgs(HSSFCell cell) {
-        assertEquals(CellType.FORMULA, cell.getCellTypeEnum());
+        assertEquals(CellType.FORMULA, cell.getCellType());
         assertEquals(FormulaRecordAggregate.class, cell.getCellValueRecord().getClass());
         FormulaRecordAggregate agg = (FormulaRecordAggregate)cell.getCellValueRecord();
         FormulaRecord rec = agg.getFormulaRecord();
index 5e52a0c1490075a00c1997025e466b38f09684d6..10726fc27c9033119c16ee5178a8871f8a3a1fb7 100644 (file)
@@ -73,11 +73,11 @@ public final class TestFormulaEvaluatorDocs extends TestCase {
                        HSSFFormulaEvaluator evaluator = new HSSFFormulaEvaluator(wb);
                        for(Row r : sheet) {
                                for(Cell c : r) {
-                                       if(c.getCellTypeEnum() == CellType.FORMULA) {
-                                               evaluator.evaluateFormulaCellEnum(c);
+                                       if(c.getCellType() == CellType.FORMULA) {
+                                               evaluator.evaluateFormulaCell(c);
                                                
                                                // For testing - all should be numeric
-                                               assertEquals(CellType.NUMERIC, evaluator.evaluateFormulaCellEnum(c));
+                                               assertEquals(CellType.NUMERIC, evaluator.evaluateFormulaCell(c));
                                        }
                                }
                        }
@@ -86,15 +86,15 @@ public final class TestFormulaEvaluatorDocs extends TestCase {
                // Check now as expected
                assertEquals(55.7, wb.getSheetAt(0).getRow(0).getCell(2).getNumericCellValue(), 0);
                assertEquals("SUM(A1:B1)", wb.getSheetAt(0).getRow(0).getCell(2).getCellFormula());
-               assertEquals(CellType.FORMULA, wb.getSheetAt(0).getRow(0).getCell(2).getCellTypeEnum());
+               assertEquals(CellType.FORMULA, wb.getSheetAt(0).getRow(0).getCell(2).getCellType());
                
                assertEquals(-4.6, wb.getSheetAt(0).getRow(1).getCell(2).getNumericCellValue(), 0);
                assertEquals("SUM(A2:B2)", wb.getSheetAt(0).getRow(1).getCell(2).getCellFormula());
-               assertEquals(CellType.FORMULA, wb.getSheetAt(0).getRow(1).getCell(2).getCellTypeEnum());
+               assertEquals(CellType.FORMULA, wb.getSheetAt(0).getRow(1).getCell(2).getCellType());
                
                assertEquals(22.3, wb.getSheetAt(1).getRow(0).getCell(0).getNumericCellValue(), 0);
                assertEquals("'S1'!A1", wb.getSheetAt(1).getRow(0).getCell(0).getCellFormula());
-               assertEquals(CellType.FORMULA, wb.getSheetAt(1).getRow(0).getCell(0).getCellTypeEnum());
+               assertEquals(CellType.FORMULA, wb.getSheetAt(1).getRow(0).getCell(0).getCellType());
                
                
                // Now do the alternate call, which zaps the formulas
@@ -104,7 +104,7 @@ public final class TestFormulaEvaluatorDocs extends TestCase {
 
                        for(Row r : sheet) {
                                for(Cell c : r) {
-                                       if(c.getCellTypeEnum() == CellType.FORMULA) {
+                                       if(c.getCellType() == CellType.FORMULA) {
                                                evaluator.evaluateInCell(c);
                                        }
                                }
@@ -112,12 +112,12 @@ public final class TestFormulaEvaluatorDocs extends TestCase {
                }
                
                assertEquals(55.7, wb.getSheetAt(0).getRow(0).getCell(2).getNumericCellValue(), 0);
-               assertEquals(CellType.NUMERIC, wb.getSheetAt(0).getRow(0).getCell(2).getCellTypeEnum());
+               assertEquals(CellType.NUMERIC, wb.getSheetAt(0).getRow(0).getCell(2).getCellType());
                
                assertEquals(-4.6, wb.getSheetAt(0).getRow(1).getCell(2).getNumericCellValue(), 0);
-               assertEquals(CellType.NUMERIC, wb.getSheetAt(0).getRow(1).getCell(2).getCellTypeEnum());
+               assertEquals(CellType.NUMERIC, wb.getSheetAt(0).getRow(1).getCell(2).getCellType());
                
                assertEquals(22.3, wb.getSheetAt(1).getRow(0).getCell(0).getNumericCellValue(), 0);
-               assertEquals(CellType.NUMERIC, wb.getSheetAt(1).getRow(0).getCell(0).getCellTypeEnum());
+               assertEquals(CellType.NUMERIC, wb.getSheetAt(1).getRow(0).getCell(0).getCellType());
        }
 }
index 4c493ef060d3d02d50c8c214e50c6ef90581a628..229bf427c7cd2bd2e1e66c04117162a17ee4d013 100644 (file)
@@ -76,7 +76,7 @@ public final class TestHSSFFormulaEvaluator extends BaseTestFormulaEvaluator {
                HSSFFormulaEvaluator fe = new HSSFFormulaEvaluator(wb);
 
                cellA1.setCellErrorValue(FormulaError.NAME.getCode());
-               fe.evaluateFormulaCellEnum(cellB1);
+               fe.evaluateFormulaCell(cellB1);
 
                cellA1.setCellValue(2.5);
                fe.notifyUpdateCell(cellA1);
@@ -227,10 +227,10 @@ public final class TestHSSFFormulaEvaluator extends BaseTestFormulaEvaluator {
                   new HSSFFormulaEvaluator(wb2)
             }
       );
-      eval.evaluateFormulaCellEnum(
+      eval.evaluateFormulaCell(
             wb1.getSheetAt(0).getRow(1).getCell(2)
       );      
-      eval.evaluateFormulaCellEnum(
+      eval.evaluateFormulaCell(
             wb1.getSheetAt(0).getRow(1).getCell(4)
       );      
       
@@ -256,7 +256,7 @@ public final class TestHSSFFormulaEvaluator extends BaseTestFormulaEvaluator {
       assertEquals("Cost*[XRefCalcData.xls]MarkupSheet!$B$1", cell.getCellFormula());
       
       // Check it evaluates correctly
-      eval.evaluateFormulaCellEnum(cell);
+      eval.evaluateFormulaCell(cell);
       assertEquals(24.60*1.8, cell.getNumericCellValue(), 0);
       
       
@@ -291,7 +291,7 @@ public final class TestHSSFFormulaEvaluator extends BaseTestFormulaEvaluator {
                     new HSSFFormulaEvaluator(wb3)
               }
       );
-      eval.evaluateFormulaCellEnum(cell);
+      eval.evaluateFormulaCell(cell);
       assertEquals("In another workbook", cell.getStringCellValue());
       
       
@@ -310,13 +310,13 @@ public final class TestHSSFFormulaEvaluator extends BaseTestFormulaEvaluator {
       // Check the one referring to the previously existing workbook behaves
       cell = wb4.getSheetAt(0).getRow(1).getCell(40);
       assertEquals("Cost*[XRefCalcData.xls]MarkupSheet!$B$1", cell.getCellFormula());
-      eval.evaluateFormulaCellEnum(cell);
+      eval.evaluateFormulaCell(cell);
       assertEquals(24.60*1.8, cell.getNumericCellValue(), 0);
       
       // Now check the newly added reference
       cell = wb4.getSheetAt(0).getRow(1).getCell(42);
       assertEquals("[alt.xls]Sheet0!$A$1", cell.getCellFormula());
-      eval.evaluateFormulaCellEnum(cell);
+      eval.evaluateFormulaCell(cell);
       assertEquals("In another workbook", cell.getStringCellValue());
       
       wb4.close();
index 764201594ff7e009a0cbec491a98d946221192db..e2e8fc9e45a5b20b39dc23faa3cb94c1cc5522c1 100644 (file)
@@ -151,12 +151,12 @@ public abstract class BaseTestExternalFunctions {
         Cell cell2 = sh.getRow(2).getCell(1);
         assertEquals("ISODD(2)", cell2.getCellFormula());
         assertEquals(false, evaluator.evaluate(cell2).getBooleanValue());
-        assertEquals(CellType.BOOLEAN, evaluator.evaluateFormulaCellEnum(cell2));
+        assertEquals(CellType.BOOLEAN, evaluator.evaluateFormulaCell(cell2));
 
         Cell cell3 = sh.getRow(3).getCell(1);
         assertEquals("ISEVEN(2)", cell3.getCellFormula());
         assertEquals(true, evaluator.evaluate(cell3).getBooleanValue());
-        assertEquals(CellType.BOOLEAN, evaluator.evaluateFormulaCellEnum(cell3));
+        assertEquals(CellType.BOOLEAN, evaluator.evaluateFormulaCell(cell3));
 
         wb.close();
     }
index 923392a30c4e85e7a5d0e9a992528f06bcbb2335..98075938d3dfd4a08b447514b2b2ae73845f9d1b 100644 (file)
@@ -739,7 +739,7 @@ public class TestEvaluationCache extends TestCase {
 
         //calculate
         FormulaEvaluator evaluator = wb.getCreationHelper().createFormulaEvaluator();
-        evaluator.evaluateFormulaCellEnum(summaryCell);
+        evaluator.evaluateFormulaCell(summaryCell);
     }
 
 
@@ -779,7 +779,7 @@ public class TestEvaluationCache extends TestCase {
 
         //calculate
         FormulaEvaluator evaluator = wb.getCreationHelper().createFormulaEvaluator();
-        evaluator.evaluateFormulaCellEnum(summaryCell);
+        evaluator.evaluateFormulaCell(summaryCell);
         assertEquals(8394753.0, summaryCell.getNumericCellValue());
     }
 
index b9f09a1318755479326e0d911cb06aa5dade1643..1a8975c9b45d01f39e6166102b2f8853aa66b510 100644 (file)
@@ -67,9 +67,9 @@ public class TestMissingWorkbook extends TestCase {
                Row lARow = lSheet.getRow(0);
                Cell lA1Cell = lARow.getCell(0);
                
-               assertEquals(CellType.FORMULA, lA1Cell.getCellTypeEnum());
+               assertEquals(CellType.FORMULA, lA1Cell.getCellType());
                try {
-                       evaluator.evaluateFormulaCellEnum(lA1Cell);
+                       evaluator.evaluateFormulaCell(lA1Cell);
                        fail("Missing external workbook reference exception expected!");
                }catch(RuntimeException re) {
                        assertTrue("Unexpected exception: " + re, re.getMessage().indexOf(SOURCE_DUMMY_WORKBOOK_FILENAME) != -1);
@@ -82,9 +82,9 @@ public class TestMissingWorkbook extends TestCase {
                Cell lB1Cell = lSheet.getRow(1).getCell(0);
                Cell lC1Cell = lSheet.getRow(2).getCell(0);
                
-               assertEquals(CellType.FORMULA, lA1Cell.getCellTypeEnum());
-               assertEquals(CellType.FORMULA, lB1Cell.getCellTypeEnum());
-               assertEquals(CellType.FORMULA, lC1Cell.getCellTypeEnum());
+               assertEquals(CellType.FORMULA, lA1Cell.getCellType());
+               assertEquals(CellType.FORMULA, lB1Cell.getCellType());
+               assertEquals(CellType.FORMULA, lC1Cell.getCellType());
 
                // Check cached values
         assertEquals(10.0d, lA1Cell.getNumericCellValue(), 0.00001d);
@@ -95,9 +95,9 @@ public class TestMissingWorkbook extends TestCase {
                FormulaEvaluator evaluator = mainWorkbook.getCreationHelper().createFormulaEvaluator();
         evaluator.setIgnoreMissingWorkbooks(true);
 
-               assertEquals(CellType.NUMERIC, evaluator.evaluateFormulaCellEnum(lA1Cell));
-               assertEquals(CellType.STRING,  evaluator.evaluateFormulaCellEnum(lB1Cell));
-               assertEquals(CellType.BOOLEAN, evaluator.evaluateFormulaCellEnum(lC1Cell));
+               assertEquals(CellType.NUMERIC, evaluator.evaluateFormulaCell(lA1Cell));
+               assertEquals(CellType.STRING,  evaluator.evaluateFormulaCell(lB1Cell));
+               assertEquals(CellType.BOOLEAN, evaluator.evaluateFormulaCell(lC1Cell));
 
                assertEquals(10.0d, lA1Cell.getNumericCellValue(), 0.00001d);
                assertEquals("POI rocks!", lB1Cell.getStringCellValue());
@@ -111,9 +111,9 @@ public class TestMissingWorkbook extends TestCase {
                Cell lB1Cell = lSheet.getRow(1).getCell(0);
                Cell lC1Cell = lSheet.getRow(2).getCell(0);
                
-               assertEquals(CellType.FORMULA, lA1Cell.getCellTypeEnum());
-               assertEquals(CellType.FORMULA, lB1Cell.getCellTypeEnum());
-               assertEquals(CellType.FORMULA, lC1Cell.getCellTypeEnum());
+               assertEquals(CellType.FORMULA, lA1Cell.getCellType());
+               assertEquals(CellType.FORMULA, lB1Cell.getCellType());
+               assertEquals(CellType.FORMULA, lC1Cell.getCellType());
 
                FormulaEvaluator lMainWorkbookEvaluator = mainWorkbook.getCreationHelper().createFormulaEvaluator();
                FormulaEvaluator lSourceEvaluator = sourceWorkbook.getCreationHelper().createFormulaEvaluator();
@@ -122,9 +122,9 @@ public class TestMissingWorkbook extends TestCase {
                workbooks.put(SOURCE_DUMMY_WORKBOOK_FILENAME, lSourceEvaluator);
                lMainWorkbookEvaluator.setupReferencedWorkbooks(workbooks);
                
-               assertEquals(CellType.NUMERIC, lMainWorkbookEvaluator.evaluateFormulaCellEnum(lA1Cell));
-               assertEquals(CellType.STRING, lMainWorkbookEvaluator.evaluateFormulaCellEnum(lB1Cell));
-               assertEquals(CellType.BOOLEAN, lMainWorkbookEvaluator.evaluateFormulaCellEnum(lC1Cell));
+               assertEquals(CellType.NUMERIC, lMainWorkbookEvaluator.evaluateFormulaCell(lA1Cell));
+               assertEquals(CellType.STRING, lMainWorkbookEvaluator.evaluateFormulaCell(lB1Cell));
+               assertEquals(CellType.BOOLEAN, lMainWorkbookEvaluator.evaluateFormulaCell(lC1Cell));
 
                assertEquals(20.0d, lA1Cell.getNumericCellValue(), 0.00001d);
                assertEquals("Apache rocks!", lB1Cell.getStringCellValue());
index e6f9f1fc28eb76e62fbd0479336ad225fa663c45..4441a4fb535d7fe1ac57e0d0466e147c0f2bf6ff 100644 (file)
@@ -533,7 +533,7 @@ public class TestWorkbookEvaluator {
         Cell D1 = wb.getSheet("IFEquals").getRow(0).getCell(3);
         
         FormulaEvaluator eval = wb.getCreationHelper().createFormulaEvaluator();
-        CellType resultCellType = eval.evaluateFormulaCellEnum(D1);
+        CellType resultCellType = eval.evaluateFormulaCell(D1);
         
         // Call should modify the contents, but leave the formula intact
         assertEquals(CellType.FORMULA, D1.getCellType());
index 0401ffbdbe5b2487217b7b148e5b7b7a097ffe91..802b7d8b33176c3498aa451b506c74864bb88316 100644 (file)
@@ -66,11 +66,11 @@ public class TestRandBetween extends TestCase {
                
                evaluator.clearAllCachedResultValues();
                formulaCell.setCellFormula("RANDBETWEEN(1,1)");
-               evaluator.evaluateFormulaCellEnum(formulaCell);
+               evaluator.evaluateFormulaCell(formulaCell);
                assertEquals(1, formulaCell.getNumericCellValue(), 0);
                evaluator.clearAllCachedResultValues();
                formulaCell.setCellFormula("RANDBETWEEN(-1,-1)");
-               evaluator.evaluateFormulaCellEnum(formulaCell);
+               evaluator.evaluateFormulaCell(formulaCell);
                assertEquals(-1, formulaCell.getNumericCellValue(), 0);
 
        }
@@ -86,25 +86,25 @@ public class TestRandBetween extends TestCase {
                topValueCell.setCellValue(0.1);
                formulaCell.setCellFormula("RANDBETWEEN($A$1,$B$1)");
                evaluator.clearAllCachedResultValues();
-               evaluator.evaluateFormulaCellEnum(formulaCell);
+               evaluator.evaluateFormulaCell(formulaCell);
                assertEquals(1, formulaCell.getNumericCellValue(), 0);
                bottomValueCell.setCellValue(-0.1);             
                topValueCell.setCellValue(-0.05);
                formulaCell.setCellFormula("RANDBETWEEN($A$1,$B$1)");
                evaluator.clearAllCachedResultValues();
-               evaluator.evaluateFormulaCellEnum(formulaCell);
+               evaluator.evaluateFormulaCell(formulaCell);
                assertEquals(0, formulaCell.getNumericCellValue(), 0);
                bottomValueCell.setCellValue(-1.1);             
                topValueCell.setCellValue(-1.05);
                formulaCell.setCellFormula("RANDBETWEEN($A$1,$B$1)");
                evaluator.clearAllCachedResultValues();
-               evaluator.evaluateFormulaCellEnum(formulaCell);
+               evaluator.evaluateFormulaCell(formulaCell);
                assertEquals(-1, formulaCell.getNumericCellValue(), 0);
                bottomValueCell.setCellValue(-1.1);             
                topValueCell.setCellValue(-1.1);
                formulaCell.setCellFormula("RANDBETWEEN($A$1,$B$1)");
                evaluator.clearAllCachedResultValues();
-               evaluator.evaluateFormulaCellEnum(formulaCell);
+               evaluator.evaluateFormulaCell(formulaCell);
                assertEquals(-1, formulaCell.getNumericCellValue(), 0);
        }
        
@@ -117,7 +117,7 @@ public class TestRandBetween extends TestCase {
                topValueCell.setCellType(CellType.BLANK);
                formulaCell.setCellFormula("RANDBETWEEN($A$1,$B$1)");
                evaluator.clearAllCachedResultValues();
-               evaluator.evaluateFormulaCellEnum(formulaCell);
+               evaluator.evaluateFormulaCell(formulaCell);
                assertTrue(formulaCell.getNumericCellValue() == 0 || formulaCell.getNumericCellValue() == -1);
        
        }
@@ -130,7 +130,7 @@ public class TestRandBetween extends TestCase {
                topValueCell.setCellValue(1);
                formulaCell.setCellFormula("RANDBETWEEN($A$1,$B$1)");
                evaluator.clearAllCachedResultValues();
-               evaluator.evaluateFormulaCellEnum(formulaCell);
+               evaluator.evaluateFormulaCell(formulaCell);
                assertEquals(CellType.ERROR, formulaCell.getCachedFormulaResultType());
                assertEquals(ErrorEval.VALUE_INVALID.getErrorCode(), formulaCell.getErrorCellValue());
                
@@ -140,7 +140,7 @@ public class TestRandBetween extends TestCase {
                topValueCell.setCellValue("STRING");            
                formulaCell.setCellFormula("RANDBETWEEN($A$1,$B$1)");
                evaluator.clearAllCachedResultValues();
-               evaluator.evaluateFormulaCellEnum(formulaCell);
+               evaluator.evaluateFormulaCell(formulaCell);
                assertEquals(CellType.ERROR, formulaCell.getCachedFormulaResultType());
                assertEquals(ErrorEval.VALUE_INVALID.getErrorCode(), formulaCell.getErrorCellValue());
 
@@ -149,7 +149,7 @@ public class TestRandBetween extends TestCase {
                topValueCell.setCellValue("STRING");            
                formulaCell.setCellFormula("RANDBETWEEN($A$1,$B$1)");
                evaluator.clearAllCachedResultValues();
-               evaluator.evaluateFormulaCellEnum(formulaCell);
+               evaluator.evaluateFormulaCell(formulaCell);
                assertEquals(CellType.ERROR, formulaCell.getCachedFormulaResultType());
                assertEquals(ErrorEval.VALUE_INVALID.getErrorCode(), formulaCell.getErrorCellValue());
        
@@ -165,14 +165,14 @@ public class TestRandBetween extends TestCase {
                topValueCell.setCellValue(0);
                formulaCell.setCellFormula("RANDBETWEEN($A$1,$B$1)");
                evaluator.clearAllCachedResultValues();
-               evaluator.evaluateFormulaCellEnum(formulaCell);
+               evaluator.evaluateFormulaCell(formulaCell);
                assertEquals(CellType.ERROR, formulaCell.getCachedFormulaResultType());
                assertEquals(ErrorEval.NUM_ERROR.getErrorCode(), formulaCell.getErrorCellValue());              
                bottomValueCell.setCellValue(1);                
                topValueCell.setCellType(CellType.BLANK);
                formulaCell.setCellFormula("RANDBETWEEN($A$1,$B$1)");
                evaluator.clearAllCachedResultValues();
-               evaluator.evaluateFormulaCellEnum(formulaCell);
+               evaluator.evaluateFormulaCell(formulaCell);
                assertEquals(CellType.ERROR, formulaCell.getCachedFormulaResultType());
                assertEquals(ErrorEval.NUM_ERROR.getErrorCode(), formulaCell.getErrorCellValue());
        }
@@ -186,7 +186,7 @@ public class TestRandBetween extends TestCase {
                topValueCell.setCellValue(Double.MAX_VALUE);
                formulaCell.setCellFormula("RANDBETWEEN($A$1,$B$1)");
                evaluator.clearAllCachedResultValues();
-               evaluator.evaluateFormulaCellEnum(formulaCell);
+               evaluator.evaluateFormulaCell(formulaCell);
                assertTrue(formulaCell.getNumericCellValue() >= Double.MIN_VALUE && formulaCell.getNumericCellValue() <= Double.MAX_VALUE);             
                
        }
index 99f1b8a56e77d48df4ec034808576f3e093602fc..811ec649afd8909c69bf9a5a5b58ac7acce0bf1b 100644 (file)
@@ -174,7 +174,7 @@ public final class TestFormulasFromSpreadsheet {
        // iterate across the row for all the evaluation cases
        for (int colnum=SS.COLUMN_INDEX_FIRST_TEST_VALUE; colnum < endcolnum; colnum++) {
            Cell c = formulasRow.getCell(colnum);
-           if (c == null || c.getCellTypeEnum() != CellType.FORMULA) {
+           if (c == null || c.getCellType() != CellType.FORMULA) {
                continue;
            }
 
@@ -187,27 +187,27 @@ public final class TestFormulasFromSpreadsheet {
            assertNotNull(msg + " - Bad setup data expected value is null", expValue);
            assertNotNull(msg + " - actual value was null", actValue);
 
-           final CellType cellType = expValue.getCellTypeEnum();
+           final CellType cellType = expValue.getCellType();
            switch (cellType) {
                case BLANK:
-                   assertEquals(msg, CellType.BLANK, actValue.getCellTypeEnum());
+                   assertEquals(msg, CellType.BLANK, actValue.getCellType());
                    break;
                case BOOLEAN:
-                   assertEquals(msg, CellType.BOOLEAN, actValue.getCellTypeEnum());
+                   assertEquals(msg, CellType.BOOLEAN, actValue.getCellType());
                    assertEquals(msg, expValue.getBooleanCellValue(), actValue.getBooleanValue());
                    break;
                case ERROR:
-                   assertEquals(msg, CellType.ERROR, actValue.getCellTypeEnum());
+                   assertEquals(msg, CellType.ERROR, actValue.getCellType());
                    assertEquals(msg, ErrorEval.getText(expValue.getErrorCellValue()), ErrorEval.getText(actValue.getErrorValue()));
                    break;
                case FORMULA: // will never be used, since we will call method after formula evaluation
                    fail("Cannot expect formula as result of formula evaluation: " + msg);
                case NUMERIC:
-                   assertEquals(msg, CellType.NUMERIC, actValue.getCellTypeEnum());
+                   assertEquals(msg, CellType.NUMERIC, actValue.getCellType());
                    TestMathX.assertEquals(msg, expValue.getNumericCellValue(), actValue.getNumberValue(), TestMathX.POS_ZERO, TestMathX.DIFF_TOLERANCE_FACTOR);
                    break;
                case STRING:
-                   assertEquals(msg, CellType.STRING, actValue.getCellTypeEnum());
+                   assertEquals(msg, CellType.STRING, actValue.getCellType());
                    assertEquals(msg, expValue.getRichStringCellValue().getString(), actValue.getStringValue());
                    break;
                default:
@@ -228,14 +228,14 @@ public final class TestFormulasFromSpreadsheet {
                        System.err.println("Warning - Row " + r.getRowNum() + " has no cell " + SS.COLUMN_INDEX_FUNCTION_NAME + ", can't figure out function name");
                        return null;
                }
-               if(cell.getCellTypeEnum() == CellType.BLANK) {
+               if(cell.getCellType() == CellType.BLANK) {
                        return null;
                }
-               if(cell.getCellTypeEnum() == CellType.STRING) {
+               if(cell.getCellType() == CellType.STRING) {
                        return cell.getRichStringCellValue().getString();
                }
 
                throw new AssertionFailedError("Bad cell type for 'function name' column: ("
-                               + cell.getCellTypeEnum() + ") row (" + (r.getRowNum() +1) + ")");
+                               + cell.getCellType() + ") row (" + (r.getRowNum() +1) + ")");
        }
 }
index 72ab0b67db4e243beb05f5e53d489e453967296a..1747bb3620b65abfda9fbcb4e5da905baf1d8e3c 100644 (file)
@@ -123,7 +123,7 @@ public abstract class BaseTestFunctionsFromSpreadsheet {
                 currentGroupComment = newMarkerValue;
             }
             HSSFCell evalCell = r.getCell(SS.COLUMN_INDEX_EVALUATION);
-            if (evalCell == null || evalCell.getCellTypeEnum() != CellType.FORMULA) {
+            if (evalCell == null || evalCell.getCellType() != CellType.FORMULA) {
                 continue;
             }
             String rowComment = getCellTextValue(r, SS.COLUMN_ROW_COMMENT, "row comment");
@@ -153,9 +153,9 @@ public abstract class BaseTestFunctionsFromSpreadsheet {
         assertNotNull(msg + " - Bad setup data expected value is null", expectedCell);
         assertNotNull(msg + " - actual value was null", actualValue);
 
-        if (expectedCell.getCellTypeEnum() == CellType.ERROR) {
+        if (expectedCell.getCellType() == CellType.ERROR) {
             int expectedErrorCode = expectedCell.getErrorCellValue();
-            assertEquals(msg, CellType.ERROR, actualValue.getCellTypeEnum());
+            assertEquals(msg, CellType.ERROR, actualValue.getCellType());
             assertEquals(msg, ErrorEval.getText(expectedErrorCode), actualValue.formatAsString());
             assertEquals(msg, expectedErrorCode, actualValue.getErrorValue());
             assertEquals(msg, ErrorEval.getText(expectedErrorCode), ErrorEval.getText(actualValue.getErrorValue()));
@@ -163,13 +163,13 @@ public abstract class BaseTestFunctionsFromSpreadsheet {
         }
 
         // unexpected error
-        assertNotEquals(msg, CellType.ERROR, actualValue.getCellTypeEnum());
+        assertNotEquals(msg, CellType.ERROR, actualValue.getCellType());
         assertNotEquals(msg, formatValue(expectedCell), ErrorEval.getText(actualValue.getErrorValue()));
 
         // wrong type error
-        assertEquals(msg, expectedCell.getCellTypeEnum(), actualValue.getCellTypeEnum());
+        assertEquals(msg, expectedCell.getCellType(), actualValue.getCellType());
 
-        final CellType expectedCellType = expectedCell.getCellTypeEnum();
+        final CellType expectedCellType = expectedCell.getCellType();
         switch (expectedCellType) {
             case BOOLEAN:
                 assertEquals(msg, expectedCell.getBooleanCellValue(), actualValue.getBooleanValue());
@@ -212,25 +212,25 @@ public abstract class BaseTestFunctionsFromSpreadsheet {
         if(cell == null) {
             return null;
         }
-        if(cell.getCellTypeEnum() == CellType.BLANK) {
+        if(cell.getCellType() == CellType.BLANK) {
             return null;
         }
-        if(cell.getCellTypeEnum() == CellType.STRING) {
+        if(cell.getCellType() == CellType.STRING) {
             return cell.getRichStringCellValue().getString();
         }
 
         fail("Bad cell type for '" + columnName + "' column: ("
-                + cell.getCellTypeEnum() + ") row (" + (r.getRowNum() +1) + ")");
+                + cell.getCellType() + ") row (" + (r.getRowNum() +1) + ")");
         return "";
     }
 
     private static String formatValue(HSSFCell expecedCell) {
-        switch (expecedCell.getCellTypeEnum()) {
+        switch (expecedCell.getCellType()) {
             case BLANK: return "<blank>";
             case BOOLEAN: return Boolean.toString(expecedCell.getBooleanCellValue());
             case NUMERIC: return Double.toString(expecedCell.getNumericCellValue());
             case STRING: return expecedCell.getRichStringCellValue().getString();
-            default: fail("Unexpected cell type of expected value (" + expecedCell.getCellTypeEnum() + ")");
+            default: fail("Unexpected cell type of expected value (" + expecedCell.getCellType() + ")");
         }
         return "";
     }
index 45241f6afccd0890865c1f92b37815f9859f7412..b9f5224c8d5ebbe72129ff8e45406fea373c8411 100644 (file)
@@ -82,7 +82,7 @@ public final class TestDate extends TestCase {
         cell11.setCellFormula(formulaText);
         evaluator.clearAllCachedResultValues();
         CellValue cv = evaluator.evaluate(cell11);
-        if (cv.getCellTypeEnum() != CellType.NUMERIC) {
+        if (cv.getCellType() != CellType.NUMERIC) {
             throw new AssertionFailedError("Wrong result type: " + cv.formatAsString());
         }
         double actualValue = cv.getNumberValue();
index 5ac75d62ad04e27e9f7136ca979b2cfe9b20a4a3..0bfff626af54f21c13020047f8926308d71b9b7c 100644 (file)
@@ -66,7 +66,7 @@ public final class TestFind {
                cell.setCellFormula(formulaText);
                fe.notifyUpdateCell(cell);
                CellValue result = fe.evaluate(cell);
-               assertEquals(result.getCellTypeEnum(), CellType.NUMERIC);
+               assertEquals(result.getCellType(), CellType.NUMERIC);
                assertEquals(expectedResult, result.getNumberValue(), 0.0);
        }
 
@@ -75,7 +75,7 @@ public final class TestFind {
                cell.setCellFormula(formulaText);
                fe.notifyUpdateCell(cell);
                CellValue result = fe.evaluate(cell);
-               assertEquals(result.getCellTypeEnum(), CellType.ERROR);
+               assertEquals(result.getCellType(), CellType.ERROR);
                assertEquals(expectedErrorCode.getCode(), result.getErrorValue());
        }
 }
index f6e1f38093806f120f06d3ab8ee71a243bee3b8d..e14ea3c45b26598b66d4b353556dc38c4796db16 100644 (file)
@@ -117,7 +117,7 @@ public final class TestFixed {
         cell11.setCellFormula(formulaText);
         evaluator.clearAllCachedResultValues();
         CellValue cv = evaluator.evaluate(cell11);
-        assertEquals("Wrong result type: " + cv.formatAsString(), CellType.STRING, cv.getCellTypeEnum());
+        assertEquals("Wrong result type: " + cv.formatAsString(), CellType.STRING, cv.getCellType());
         String actualValue = cv.getStringValue();
         assertEquals(expectedResult, actualValue);
     }
@@ -127,7 +127,7 @@ public final class TestFixed {
         evaluator.clearAllCachedResultValues();
         CellValue cv = evaluator.evaluate(cell11);
         assertTrue("Wrong result type: " + cv.formatAsString(), 
-                cv.getCellTypeEnum() == CellType.ERROR
+                cv.getCellType() == CellType.ERROR
                 && cv.getErrorValue() == FormulaError.VALUE.getCode());
     }
 }
index 99d370bd6886700ff1d7b59e62d857c743890fc2..ea5ac9c7aa5d1a1aa25ba0b777d86e49013d32fe 100644 (file)
@@ -185,7 +185,7 @@ public final class TestIndirect {
         fe.clearAllCachedResultValues();
         cell.setCellFormula(formula);
         CellValue cv = fe.evaluate(cell);
-        if (cv.getCellTypeEnum() != CellType.NUMERIC) {
+        if (cv.getCellType() != CellType.NUMERIC) {
             fail("expected numeric cell type but got " + cv.formatAsString());
         }
         assertEquals(expectedResult, cv.getNumberValue(), 0.0);
@@ -196,7 +196,7 @@ public final class TestIndirect {
         fe.clearAllCachedResultValues();
         cell.setCellFormula(formula);
         CellValue cv = fe.evaluate(cell);
-        if (cv.getCellTypeEnum() != CellType.ERROR) {
+        if (cv.getCellType() != CellType.ERROR) {
             fail("expected error cell type but got " + cv.formatAsString());
         }
         int expCode = expectedResult.getErrorCode();
index a540857b014237449773878392fb3a2abac80f70..8800ef358f086daea5a89d0a9c2264a6441a09dc 100644 (file)
@@ -81,7 +81,7 @@ public final class TestIrr extends TestCase {
 
         HSSFFormulaEvaluator fe = new HSSFFormulaEvaluator(wb);
         fe.clearAllCachedResultValues();
-        fe.evaluateFormulaCellEnum(cell);
+        fe.evaluateFormulaCell(cell);
         double res = cell.getNumericCellValue();
         assertEquals(0.143d, Math.round(res * 1000d) / 1000d);
     }
index 32f078fe325905f0e9ef9d65b71db4ecc99e464e..43691de67535563c0f7608d36ceefd409d299f52 100644 (file)
@@ -121,7 +121,7 @@ public final class TestMirr extends TestCase {
 
         HSSFFormulaEvaluator fe = new HSSFFormulaEvaluator(wb);
         fe.clearAllCachedResultValues();
-        fe.evaluateFormulaCellEnum(cell);
+        fe.evaluateFormulaCell(cell);
         double res = cell.getNumericCellValue();
         assertEquals(0.18736225093, res, 0.00000001);
     }
@@ -162,7 +162,7 @@ public final class TestMirr extends TestCase {
     private static void assertFormulaResult(CellValue cv, HSSFCell cell) {
         double actualValue = cv.getNumberValue();
         double expectedValue = cell.getNumericCellValue(); // cached formula result calculated by Excel
-        assertEquals("Invalid formula result: " + cv, CellType.NUMERIC, cv.getCellTypeEnum());
+        assertEquals("Invalid formula result: " + cv, CellType.NUMERIC, cv.getCellType());
         assertEquals(expectedValue, actualValue, 1E-8);
     }
 }
index 34aa877723973f01835108f96188ba0538cc73ef..c3963cced7093b7020d5ad8a163ede19bdc9cce9 100644 (file)
@@ -50,7 +50,7 @@ public final class TestNpv extends TestCase {
         // Enumeration
         cell.setCellFormula("NPV(A2, A4,A5,A6,A7,A8)+A3");
         fe.clearAllCachedResultValues();
-        fe.evaluateFormulaCellEnum(cell);
+        fe.evaluateFormulaCell(cell);
         double res = cell.getNumericCellValue();
         assertEquals(1922.06d, Math.round(res * 100d) / 100d);
 
@@ -58,7 +58,7 @@ public final class TestNpv extends TestCase {
         cell.setCellFormula("NPV(A2, A4:A8)+A3");
 
         fe.clearAllCachedResultValues();
-        fe.evaluateFormulaCellEnum(cell);
+        fe.evaluateFormulaCell(cell);
         res = cell.getNumericCellValue();
         assertEquals(1922.06d, Math.round(res * 100d) / 100d);
     }
index 6fa94dfaff6b55629cac83df35183e93393b313d..16c77fdfb99a0ffd1fa4fba765651e8a79febc01 100644 (file)
@@ -96,9 +96,9 @@ public final class TestExternalNameReference extends TestCase {
                HSSFCell ccell = wb.getSheet(cellRef.getSheetName()).getRow(cellRef.getRow()).getCell((int)cellRef.getCol());
                cellRef = new CellReference(wb.getName("TOTALCOST").getRefersToFormula());
                HSSFCell tccell = wb.getSheet(cellRef.getSheetName()).getRow(cellRef.getRow()).getCell((int)cellRef.getCol());
-               evaluator.evaluateFormulaCellEnum(uccell);
-               evaluator.evaluateFormulaCellEnum(ccell);
-               evaluator.evaluateFormulaCellEnum(tccell);
+               evaluator.evaluateFormulaCell(uccell);
+               evaluator.evaluateFormulaCell(ccell);
+               evaluator.evaluateFormulaCell(tccell);
                assertEquals(NEW_PART_COST, uccell.getNumericCellValue());
                assertEquals(NEW_PART_COST*NEW_QUANT, ccell.getNumericCellValue());
                assertEquals(NEW_PART_COST*NEW_QUANT*MARKUP_COST_2, tccell.getNumericCellValue());
index a8d0b8f20fcd63735e839536c74b7269b84e0b10..e7deaf2feef48d6b3fce4154e5b4a8f633508e14 100644 (file)
@@ -864,7 +864,7 @@ public abstract class BaseTestBugzillaIssues {
 
     private Cell evaluateCell(Workbook wb, Cell c) {
         Sheet s = c.getSheet();
-        wb.getCreationHelper().createFormulaEvaluator().evaluateFormulaCellEnum(c);
+        wb.getCreationHelper().createFormulaEvaluator().evaluateFormulaCell(c);
         return s.getRow(c.getRowIndex()).getCell(c.getColumnIndex());
     }
 
@@ -945,8 +945,8 @@ public abstract class BaseTestBugzillaIssues {
 
 
         // Try to evaluate, with the other file
-        evaluator.evaluateFormulaCellEnum(c1);
-        evaluator.evaluateFormulaCellEnum(c2);
+        evaluator.evaluateFormulaCell(c1);
+        evaluator.evaluateFormulaCell(c2);
 
         assertEquals(otherCellText, c1.getStringCellValue());
         assertEquals(otherCellText, c2.getStringCellValue());
@@ -1153,8 +1153,8 @@ public abstract class BaseTestBugzillaIssues {
         FormulaEvaluator fe = wb.getCreationHelper().createFormulaEvaluator();
         assertEquals(CellType.NUMERIC, fe.evaluate(cfn).getCellType());
         assertEquals(CellType.STRING, fe.evaluate(cfs).getCellType());
-        fe.evaluateFormulaCellEnum(cfn);
-        fe.evaluateFormulaCellEnum(cfs);
+        fe.evaluateFormulaCell(cfn);
+        fe.evaluateFormulaCell(cfs);
 
         // Now test
         assertEquals(CellType.NUMERIC, cn.getCellType());
@@ -1282,17 +1282,17 @@ public abstract class BaseTestBugzillaIssues {
         // Check read ok, and re-evaluate fine
         cell = row.getCell(5);
         assertEquals("ab", cell.getStringCellValue());
-        ev.evaluateFormulaCellEnum(cell);
+        ev.evaluateFormulaCell(cell);
         assertEquals("ab", cell.getStringCellValue());
 
         cell = row.getCell(6);
         assertEquals("empty", cell.getStringCellValue());
-        ev.evaluateFormulaCellEnum(cell);
+        ev.evaluateFormulaCell(cell);
         assertEquals("empty", cell.getStringCellValue());
 
         cell = row.getCell(7);
         assertEquals("ab", cell.getStringCellValue());
-        ev.evaluateFormulaCellEnum(cell);
+        ev.evaluateFormulaCell(cell);
         assertEquals("ab", cell.getStringCellValue());
         wb2.close();
     }
index fa0ddde5601527aaeb89acc97bde0205987e5e80..03a6a8e0a43e0bbf13f58684eb23b2d63be7a74d 100644 (file)
@@ -503,7 +503,7 @@ public abstract class BaseTestCell {
 
         FormulaEvaluator fe = cellA1.getSheet().getWorkbook().getCreationHelper().createFormulaEvaluator();
 
-        fe.evaluateFormulaCellEnum(cellA1);
+        fe.evaluateFormulaCell(cellA1);
         assertEquals("abc", cellA1.getStringCellValue());
 
         fe.evaluateInCell(cellA1);
@@ -526,14 +526,14 @@ public abstract class BaseTestCell {
 
         cellA1.setCellFormula("\"DEF\"");
         fe.clearAllCachedResultValues();
-        fe.evaluateFormulaCellEnum(cellA1);
+        fe.evaluateFormulaCell(cellA1);
         assertEquals("DEF", cellA1.getStringCellValue());
         cellA1.setCellType(CellType.STRING);
         assertEquals("DEF", cellA1.getStringCellValue());
 
         cellA1.setCellFormula("25.061");
         fe.clearAllCachedResultValues();
-        fe.evaluateFormulaCellEnum(cellA1);
+        fe.evaluateFormulaCell(cellA1);
         confirmCannotReadString(cellA1);
         assertEquals(25.061, cellA1.getNumericCellValue(), 0.0);
         cellA1.setCellType(CellType.STRING);
@@ -541,7 +541,7 @@ public abstract class BaseTestCell {
 
         cellA1.setCellFormula("TRUE");
         fe.clearAllCachedResultValues();
-        fe.evaluateFormulaCellEnum(cellA1);
+        fe.evaluateFormulaCell(cellA1);
         confirmCannotReadString(cellA1);
         assertEquals(true, cellA1.getBooleanCellValue());
         cellA1.setCellType(CellType.STRING);
@@ -549,7 +549,7 @@ public abstract class BaseTestCell {
 
         cellA1.setCellFormula("#NAME?");
         fe.clearAllCachedResultValues();
-        fe.evaluateFormulaCellEnum(cellA1);
+        fe.evaluateFormulaCell(cellA1);
         confirmCannotReadString(cellA1);
         assertEquals(FormulaError.NAME, forInt(cellA1.getErrorCellValue()));
         cellA1.setCellType(CellType.STRING);
@@ -819,7 +819,7 @@ public abstract class BaseTestCell {
             Row row = sheet.createRow(0);
             Cell cell = row.createCell(0);
             cell.setCellFormula("SQRT(-1)");
-            wb.getCreationHelper().createFormulaEvaluator().evaluateFormulaCellEnum(cell);
+            wb.getCreationHelper().createFormulaEvaluator().evaluateFormulaCell(cell);
             assertEquals(36, cell.getErrorCellValue());
         } finally {
             wb.close();
index c4922a7c84e8bded9d014ae60a6deb990f931131..d928f58446386060b360e91adfd488d691d07ba2 100644 (file)
@@ -57,8 +57,8 @@ public abstract class BaseTestFormulaEvaluator {
 
         FormulaEvaluator fe = wb.getCreationHelper().createFormulaEvaluator();
 
-        fe.evaluateFormulaCellEnum(c1);
-        fe.evaluateFormulaCellEnum(c2);
+        fe.evaluateFormulaCell(c1);
+        fe.evaluateFormulaCell(c2);
 
         assertEquals(6.0, c1.getNumericCellValue(), 0.0001);
         assertEquals(5.0, c2.getNumericCellValue(), 0.0001);
@@ -98,10 +98,10 @@ public abstract class BaseTestFormulaEvaluator {
         // Evaluate and test
         FormulaEvaluator fe = wb.getCreationHelper().createFormulaEvaluator();
 
-        fe.evaluateFormulaCellEnum(c1);
-        fe.evaluateFormulaCellEnum(c2);
-        fe.evaluateFormulaCellEnum(c3);
-        fe.evaluateFormulaCellEnum(c4);
+        fe.evaluateFormulaCell(c1);
+        fe.evaluateFormulaCell(c2);
+        fe.evaluateFormulaCell(c3);
+        fe.evaluateFormulaCell(c4);
 
         assertEquals(3.6, c1.getNumericCellValue(), 0.0001);
         assertEquals(17.5, c2.getNumericCellValue(), 0.0001);
@@ -290,7 +290,7 @@ public abstract class BaseTestFormulaEvaluator {
         FormulaEvaluator fe = wb.getCreationHelper().createFormulaEvaluator();
 
         cellA1.setCellErrorValue(FormulaError.NAME.getCode());
-        fe.evaluateFormulaCellEnum(cellB1);
+        fe.evaluateFormulaCell(cellB1);
 
         cellA1.setCellValue(2.5);
         fe.notifyUpdateCell(cellA1);
index 92248698fd6e35e1ac579cfd89f206111a75559f..f587b640a3ae890fadd6a0730c1c974160cfea0d 100644 (file)
@@ -344,8 +344,8 @@ public abstract class BaseTestSheetAutosizeColumn {
             Sheet sheet = workbook.getSheetAt(i);
             for (Row r : sheet) {
                 for (Cell c : r) {
-                    if (c.getCellTypeEnum() == CellType.FORMULA){
-                        eval.evaluateFormulaCellEnum(c);
+                    if (c.getCellType() == CellType.FORMULA){
+                        eval.evaluateFormulaCell(c);
                     }
                 }
             }