]> source.dussan.org Git - vaadin-framework.git/commitdiff
Properly remove shadow event listeners to prevent IE8 memory leak (#13129)
authorTeppo Kurki <teppo.kurki@vaadin.com>
Mon, 30 Dec 2013 19:47:18 +0000 (21:47 +0200)
committerLeif Åstrand <leif@vaadin.com>
Fri, 3 Jan 2014 06:59:34 +0000 (06:59 +0000)
Change-Id: I98becf08f56ce35a3ee47650d0d4e204e7d18e73

client/src/com/vaadin/client/ui/VOverlay.java

index 2f5df6d4f36afbad5c891131c2efd6d341a84c85..e2c9001fed0e86ea27a39210faa4d7bb4a4165e1 100644 (file)
@@ -241,10 +241,10 @@ public class VOverlay extends PopupPanel implements CloseHandler<PopupPanel> {
 
     private void removeShadowIfPresent() {
         if (isShadowAttached()) {
-            shadow.removeFromParent();
-
             // Remove event listener from the shadow
             unsinkShadowEvents();
+
+            shadow.removeFromParent();
         }
     }