Fix update user (#18878)

diff --git a/models/user/user.go b/models/user/user.go
index d0f1d9d7477797d8a5c8e9cc57062fe1c059af50..e581067bbd5ac7dc1ada058a59ccbd3a8a5c1d39 100644 (file)
--- a/models/user/user.go
+++ b/models/user/user.go
@@ -868,13 +868,14 @@ func updateUser(ctx context.Context, u *User, changePrimaryEmail bool, cols ...s
                }
 
                if !primaryEmailExist {
-                       _, err = e.Insert(&EmailAddress{
+                       if _, err := e.Insert(&EmailAddress{
                                Email:       u.Email,
                                UID:         u.ID,
                                IsActivated: true,
                                IsPrimary:   true,
-                       })
-                       return err
+                       }); err != nil {
+                               return err
+                       }
                }
        }