]> source.dussan.org Git - vaadin-framework.git/commitdiff
Fixed the 'bouncing columns' issue introduced in the fix for #5066
authorJonatan Kronqvist <jonatan.kronqvist@itmill.com>
Tue, 30 Nov 2010 09:52:38 +0000 (09:52 +0000)
committerJonatan Kronqvist <jonatan.kronqvist@itmill.com>
Tue, 30 Nov 2010 09:52:38 +0000 (09:52 +0000)
svn changeset:16222/svn branch:6.5

src/com/vaadin/terminal/gwt/client/ui/VScrollTable.java
src/com/vaadin/ui/Table.java

index df31ca93517f7ad1910c4343554887b8b037a8e2..f743e8d7c6f1e94576064646927decb4353fec79 100644 (file)
@@ -895,6 +895,14 @@ public class VScrollTable extends FlowPanel implements Table, ScrollHandler,
 
         setProperTabIndex();
 
+        // Force recalculation of the captionContainer element inside the header
+        // cell to accomodate for the size of the sort arrow.
+        HeaderCell sortedHeader = tHead.getHeaderCell(sortColumn);
+        if (sortedHeader != null) {
+            sortedHeader.setWidth(sortedHeader.getWidth(),
+                    sortedHeader.isDefinedWidth());
+        }
+
         rendering = false;
         headerChangedDuringUpdate = false;
 
index 3932d258743b6ee88a49cdc3ea4b99126110dd61..56662112e3f82f1533d67ed9506bfc43e8ab1bfe 100644 (file)
@@ -390,8 +390,6 @@ public class Table extends AbstractSelect implements Action.Container,
 
     private MultiSelectMode multiSelectMode = MultiSelectMode.DEFAULT;
 
-    private boolean recalculateAllColumnWidths = false;
-
     /* Table constructors */
 
     /**
@@ -2054,7 +2052,6 @@ public class Table extends AbstractSelect implements Action.Container,
                 }
             }
             if (doSort) {
-                recalculateAllColumnWidths = true;
                 this.sort();
                 resetPageBuffer();
             }
@@ -2288,10 +2285,6 @@ public class Table extends AbstractSelect implements Action.Container,
                 target.addAttribute("recalcWidths", true);
             }
         }
-        if (recalculateAllColumnWidths) {
-            target.addAttribute("recalcWidths", true);
-            recalculateAllColumnWidths = false;
-        }
 
         if (!isNullSelectionAllowed() && getNullSelectionItemId() != null
                 && containsId(getNullSelectionItemId())) {