Fix quality flaws

diff --git a/sonar-core/src/main/java/org/sonar/core/util/DefaultHttpDownloader.java b/sonar-core/src/main/java/org/sonar/core/util/DefaultHttpDownloader.java
index d7a311a24c8c35fc46e37bad6ff2d6f1d042ee03..64a4a43942e1fdbadd15e862bb2faa83d437b3eb 100644 (file)
--- a/sonar-core/src/main/java/org/sonar/core/util/DefaultHttpDownloader.java
+++ b/sonar-core/src/main/java/org/sonar/core/util/DefaultHttpDownloader.java
@@ -60,8 +60,6 @@ import java.util.zip.GZIPInputStream;
  * @since 2.2
  */
 public class DefaultHttpDownloader extends HttpDownloader {
-  public static final int TIMEOUT_MILLISECONDS = 20 * 1000;
-
   private final BaseHttpDownloader downloader;
   private final Integer readTimeout;
 

diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/utils/HttpDownloader.java b/sonar-plugin-api/src/main/java/org/sonar/api/utils/HttpDownloader.java
index 2c0ae79479c3a87a54c02d3f885944ea26681df4..4965f14d3d4353419e528ccb0553acbeb87f9f47 100644 (file)
--- a/sonar-plugin-api/src/main/java/org/sonar/api/utils/HttpDownloader.java
+++ b/sonar-plugin-api/src/main/java/org/sonar/api/utils/HttpDownloader.java
@@ -31,6 +31,8 @@ import java.net.URI;
  * a constructor parameter. It is available in both batch and server.
  */
 public abstract class HttpDownloader extends UriReader.SchemeProcessor implements BatchComponent, ServerComponent {
+  public static final int TIMEOUT_MILLISECONDS = 20 * 1000;
+
   public abstract String downloadPlainText(URI uri, String encoding);
 
   public abstract byte[] download(URI uri);

diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/utils/dag/DirectAcyclicGraph.java b/sonar-plugin-api/src/main/java/org/sonar/api/utils/dag/DirectAcyclicGraph.java
index 6cd3b683af9c2f53cff6f09f5922cbca64439de7..76595f08550a6af2993bafcd4579db8aa913ae44 100644 (file)
--- a/sonar-plugin-api/src/main/java/org/sonar/api/utils/dag/DirectAcyclicGraph.java
+++ b/sonar-plugin-api/src/main/java/org/sonar/api/utils/dag/DirectAcyclicGraph.java
@@ -19,11 +19,13 @@
  */
 package org.sonar.api.utils.dag;
 
-import com.google.common.collect.Lists;
-
 import org.sonar.api.utils.SonarException;
 
-import java.util.*;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
 
 /**
  * <a href="http://en.wikipedia.org/wiki/Directed_acyclic_graph">http://en.wikipedia.org/wiki/Directed_acyclic_graph</a>