Fix quality flaws

diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/utils/internal/WorkDuration.java b/sonar-plugin-api/src/main/java/org/sonar/api/utils/internal/WorkDuration.java
index c6c0319495f1e4766c3db10c38e2433a2d9304b4..4fbdf272c65082d179e9ffab35a1b18806759cfd 100644 (file)
--- a/sonar-plugin-api/src/main/java/org/sonar/api/utils/internal/WorkDuration.java
+++ b/sonar-plugin-api/src/main/java/org/sonar/api/utils/internal/WorkDuration.java
@@ -100,7 +100,7 @@ public class WorkDuration implements Serializable {
   }
 
   static WorkDuration createFromMinutes(long duration, int hoursInDay) {
-    int days = ((Double) (duration / hoursInDay / 60d)).intValue();
+    int days = ((Double) ((double) duration / hoursInDay / 60d)).intValue();
     Long currentDurationInMinutes = duration - (60L * days * hoursInDay);
     int hours = ((Double) (currentDurationInMinutes / 60d)).intValue();
     currentDurationInMinutes = currentDurationInMinutes - (60L * hours);

diff --git a/sonar-server/src/main/java/org/sonar/server/rule/RuleRegistration.java b/sonar-server/src/main/java/org/sonar/server/rule/RuleRegistration.java
index e615bc7b138d4829933caf6cd8f2ddfd1afa9461..24fd9f7448c3ef1d7c8d82ed9f367622a3024723 100644 (file)
--- a/sonar-server/src/main/java/org/sonar/server/rule/RuleRegistration.java
+++ b/sonar-server/src/main/java/org/sonar/server/rule/RuleRegistration.java
@@ -258,6 +258,7 @@ public class RuleRegistration implements Startable {
     boolean changed = false;
 
     CharacteristicDto characteristic = findCharacteristic(characteristicDtos, def);
+    // Debt definitions are set to null if the characteristic is null or unknown
     Integer characteristicId = characteristic != null ? characteristic.getId() : null;
     RemediationFunction remediationFunction = characteristic != null ? def.remediationFunction() : null;
     String remediationFactor = characteristic != null ? def.remediationFactor() : null;