Add aria labels to issue rule and filter buttons in issue list. This is required...

text describing what they do so are announced as "button" when using Jaws screen reading software.

diff --git a/server/sonar-web/src/main/js/apps/issues/templates/issues-issue-filter.hbs b/server/sonar-web/src/main/js/apps/issues/templates/issues-issue-filter.hbs
index f7f1bd1b215b1df0e14d1d8ed6d28aa12aa93f1c..16a212ddd60d7c1998ddfa203e8d716adec74d21 100644 (file)
--- a/server/sonar-web/src/main/js/apps/issues/templates/issues-issue-filter.hbs
+++ b/server/sonar-web/src/main/js/apps/issues/templates/issues-issue-filter.hbs
@@ -1,5 +1,6 @@
 <li class="issue-meta">
-  <button class="button-link issue-action issue-action-with-options js-issue-filter">
+  <button class="button-link issue-action issue-action-with-options js-issue-filter"
+          aria-label="{{t "issue.filter_similar_issues"}}">
     <i class="icon-filter icon-half-transparent"></i>&nbsp;<i class="icon-dropdown"></i>
   </button>
 </li>

diff --git a/server/sonar-web/src/main/js/components/issue/templates/issue.hbs b/server/sonar-web/src/main/js/components/issue/templates/issue.hbs
index 3f4975d1f2782c8c0c2a76c8e3d80ff34271aa18..a828ecf5e3eb049e9be845bbbfc0d125a412aa9c 100644 (file)
--- a/server/sonar-web/src/main/js/components/issue/templates/issue.hbs
+++ b/server/sonar-web/src/main/js/components/issue/templates/issue.hbs
@@ -5,7 +5,8 @@
       <td>
         <div class="issue-message">
           {{message}}&nbsp;
-          <button class="button-link js-issue-rule issue-rule icon-ellipsis-h"></button>
+          <button class="button-link js-issue-rule issue-rule icon-ellipsis-h"
+                  aria-label="{{t 'issue.rule_details'}}"></button>
         </div>
       </td>
 

diff --git a/sonar-core/src/main/resources/org/sonar/l10n/core.properties b/sonar-core/src/main/resources/org/sonar/l10n/core.properties
index d3b386694dacbd442dc41e73a12090f361d17ffa..965682207f934f3846a9389788f15e1f533e7d22 100644 (file)
--- a/sonar-core/src/main/resources/org/sonar/l10n/core.properties
+++ b/sonar-core/src/main/resources/org/sonar/l10n/core.properties
@@ -601,6 +601,7 @@ issue.comment.delete_confirm_title=Delete Comment
 issue.comment.delete_confirm_message=Do you want to delete this comment?
 issue.comment.delete_confirm_button=Delete
 issue.details=Details
+issue.rule_details=Rule Details
 issue.send_notifications=Send Notifications
 issue.transition=Transition
 issue.transition.confirm=Confirm