Don't show referrer policy warning if fallback policy set.

Test-Set:

no-referrer-when-downgrade
no-referrer
strict-origin-when-cross-origin
same-origin
no-referrer, strict-origin-when-cross-origin
strict-origin-
unsafe-raw, same-origin
strict-origin-when-downgrade

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

diff --git a/core/js/setupchecks.js b/core/js/setupchecks.js
index 1e50644aa27f356673f55690aca8a029b121c421..95fb4f6b21348cdcb201976301301be10932cc76 100644 (file)
--- a/core/js/setupchecks.js
+++ b/core/js/setupchecks.js
@@ -573,12 +573,8 @@
                                        });
                                }
 
-                               if (!xhr.getResponseHeader('Referrer-Policy') ||
-                                       (xhr.getResponseHeader('Referrer-Policy').toLowerCase() !== 'no-referrer' &&
-                                       xhr.getResponseHeader('Referrer-Policy').toLowerCase() !== 'no-referrer-when-downgrade' &&
-                                       xhr.getResponseHeader('Referrer-Policy').toLowerCase() !== 'strict-origin' &&
-                                       xhr.getResponseHeader('Referrer-Policy').toLowerCase() !== 'strict-origin-when-cross-origin' &&
-                                       xhr.getResponseHeader('Referrer-Policy').toLowerCase() !== 'same-origin')) {
+                               const referrerPolicy = xhr.getResponseHeader('Referrer-Policy')
+                               if (referrerPolicy === null || !/(no-referrer(-when-downgrade)?|strict-origin(-when-cross-origin)?|same-origin)(,|$)/.test(referrerPolicy)) {
                                        messages.push({
                                                msg: t('core', 'The "{header}" HTTP header is not set to "{val1}", "{val2}", "{val3}", "{val4}" or "{val5}". This can leak referer information. See the <a target="_blank" rel="noreferrer noopener" href="{link}">W3C Recommendation ↗</a>.',
                                                        {
@@ -591,7 +587,7 @@
                                                                link: 'https://www.w3.org/TR/referrer-policy/'
                                                        }),
                                                type: OC.SetupChecks.MESSAGE_TYPE_INFO
-                                       });
+                                       })
                                }
                        } else {
                                messages.push({