Avoid issue info panic (#29625) (#29632)

Backport #29625 by wxiaoguang

Fix #29624

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>

diff --git a/models/activities/action.go b/models/activities/action.go
index bf56f27a8bc1c674ad4a68c5124b7ba4de02b16a..238c2f2e92c3f7ecd420de94dd51eb7b9cf471f8 100644 (file)
--- a/models/activities/action.go
+++ b/models/activities/action.go
@@ -393,10 +393,14 @@ func (a *Action) GetCreate() time.Time {
        return a.CreatedUnix.AsTime()
 }
 
-// GetIssueInfos returns a list of issues associated with
-// the action.
+// GetIssueInfos returns a list of associated information with the action.
 func (a *Action) GetIssueInfos() []string {
-       return strings.SplitN(a.Content, "|", 3)
+       // make sure it always returns 3 elements, because there are some access to the a[1] and a[2] without checking the length
+       ret := strings.SplitN(a.Content, "|", 3)
+       for len(ret) < 3 {
+               ret = append(ret, "")
+       }
+       return ret
 }
 
 // GetIssueTitle returns the title of first issue associated with the action.