]> source.dussan.org Git - redmine.git/commitdiff
code cleanup: rubocop: fix Style/ParenthesesAroundCondition in app/helpers/issues_hel...
authorToshi MARUYAMA <marutosijp2@yahoo.co.jp>
Tue, 24 Sep 2019 05:20:58 +0000 (05:20 +0000)
committerToshi MARUYAMA <marutosijp2@yahoo.co.jp>
Tue, 24 Sep 2019 05:20:58 +0000 (05:20 +0000)
git-svn-id: http://svn.redmine.org/redmine/trunk@18513 e93f8b46-1217-0410-a6f0-8f06a7374b81

.rubocop_todo.yml
app/helpers/issues_helper.rb

index 9394ab7700a7879c146f1c5b6f05bb25d6cf88af..d5b58b0602fa58120a1823011683478a5d068b8e 100644 (file)
@@ -1424,7 +1424,6 @@ Style/ParenthesesAroundCondition:
   Exclude:
     - 'app/controllers/context_menus_controller.rb'
     - 'app/helpers/application_helper.rb'
-    - 'app/helpers/issues_helper.rb'
     - 'app/models/project.rb'
     - 'app/models/query.rb'
     - 'app/models/repository/subversion.rb'
index 10c179550f1d64b68832782ab7afaa5d6539f0c0..0cc779bac2bd7c52f042c6c38f50acda002e256f 100644 (file)
@@ -24,7 +24,7 @@ module IssuesHelper
   def issue_list(issues, &block)
     ancestors = []
     issues.each do |issue|
-      while (ancestors.any? && !issue.is_descendant_of?(ancestors.last))
+      while ancestors.any? && !issue.is_descendant_of?(ancestors.last)
         ancestors.pop
       end
       yield issue, ancestors.size
@@ -35,7 +35,7 @@ module IssuesHelper
   def grouped_issue_list(issues, query, &block)
     ancestors = []
     grouped_query_results(issues, query) do |issue, group_name, group_count, group_totals|
-      while (ancestors.any? && !issue.is_descendant_of?(ancestors.last))
+      while ancestors.any? && !issue.is_descendant_of?(ancestors.last)
         ancestors.pop
       end
       yield issue, ancestors.size, group_name, group_count, group_totals