Improve repo/user/org search (#27030)

* Fix a regression from #26809 (the `data-org` is missing)
* Remove unnecessary style

Screenshots:

![image](https://github.com/go-gitea/gitea/assets/2114189/3f5cf628-db7f-4705-898a-7a4a1fbfbba8)

![image](https://github.com/go-gitea/gitea/assets/2114189/453d1fad-1090-4524-bf45-6c5da2465f04)

![image](https://github.com/go-gitea/gitea/assets/2114189/f14d9808-7596-42c8-84b4-0d57a0bf2278)

diff --git a/templates/repo/settings/collaboration.tmpl b/templates/repo/settings/collaboration.tmpl
index 4c6721eb24172783cf4f3b9c3a267b3d2f7dc8b1..c40265c6a61f70dafaaad3c11b9d527225e1b97e 100644 (file)
--- a/templates/repo/settings/collaboration.tmpl
+++ b/templates/repo/settings/collaboration.tmpl
@@ -89,7 +89,7 @@
                        {{if $allowedToChangeTeams}}
                                <form class="ui form" id="repo-collab-team-form" action="{{.Link}}/team" method="post">
                                        {{.CsrfTokenHtml}}
-                                       <div id="search-team-box" class="ui search input gt-vm">
+                                       <div id="search-team-box" class="ui search input gt-vm" data-org-name="{{.OrgName}}">
                                                <input class="prompt" name="team" placeholder="{{$.locale.Tr "repo.settings.search_team"}}" autocomplete="off" autofocus required>
                                        </div>
                                        <button class="ui green button">{{$.locale.Tr "repo.settings.add_team"}}</button>

diff --git a/web_src/css/repo.css b/web_src/css/repo.css
index 0693840c31e08f2dc38ea885462e8137bcc5ac7d..8ec9908f731c0ece98b5e36626d1392dcc8d6a1b 100644 (file)
--- a/web_src/css/repo.css
+++ b/web_src/css/repo.css
@@ -2154,21 +2154,15 @@
   margin-top: 5px;
 }
 
-#search-repo-box .results .result img,
-#search-user-box .results .result img {
+#search-user-box .results .result .image {
   float: left;
   margin-right: 8px;
   width: 2em;
   height: 2em;
 }
 
-#search-repo-box .results .result .content,
 #search-user-box .results .result .content {
-  margin: 6px 0;
-}
-
-#search-team-box .results .result .content {
-  margin: 6px 0;
+  margin: 6px 0; /* this trick is used to align with the sibling avatar image */
 }
 
 .ui.menu .item > img:not(.ui) {

diff --git a/web_src/js/features/repo-settings.js b/web_src/js/features/repo-settings.js
index 8cc016fdc27ea5e0e63b4ab04f559571ab90308e..dc2240c7c56fa8de3ced8b29c1bcc900f888edd3 100644 (file)
--- a/web_src/js/features/repo-settings.js
+++ b/web_src/js/features/repo-settings.js
@@ -47,7 +47,7 @@ export function initRepoSettingSearchTeamBox() {
   $searchTeamBox.search({
     minCharacters: 2,
     apiSettings: {
-      url: `${appSubUrl}/org/${$searchTeamBox.data('org')}/teams/-/search?q={query}`,
+      url: `${appSubUrl}/org/${$searchTeamBox.attr('data-org-name')}/teams/-/search?q={query}`,
       headers: {'X-Csrf-Token': csrfToken},
       onResponse(response) {
         const items = [];