SONAR-4996 Improve migrations by selecting only ids

diff --git a/sonar-server/src/main/java/org/sonar/server/db/migrations/debt/DevelopmentCostMeasuresMigration.java b/sonar-server/src/main/java/org/sonar/server/db/migrations/debt/DevelopmentCostMeasuresMigration.java
index 5d2f6479bdeb2b9fa8c330269f670814c645ac06..7cc893103662cb686fa94a62ce528ebbfe16edf5 100644 (file)
--- a/sonar-server/src/main/java/org/sonar/server/db/migrations/debt/DevelopmentCostMeasuresMigration.java
+++ b/sonar-server/src/main/java/org/sonar/server/db/migrations/debt/DevelopmentCostMeasuresMigration.java
@@ -54,8 +54,8 @@ public class DevelopmentCostMeasuresMigration implements DatabaseMigration {
 
   private static final String FAILURE_MESSAGE = "Fail to migrate data";
 
-  private static final String SQL_SELECT = "SELECT * FROM project_measures INNER JOIN metrics on metrics.id=project_measures.metric_id " +
-    "WHERE (metrics.name='development_cost')";
+  private static final String SQL_SELECT = "SELECT pm.id FROM project_measures pm INNER JOIN metrics m on m.id=pm.metric_id " +
+    "WHERE (m.name='development_cost')";
 
   private static final String SQL_UPDATE = "UPDATE project_measures SET value=NULL,text_value=? WHERE id=?";
 

diff --git a/sonar-server/src/main/java/org/sonar/server/db/migrations/debt/IssueChangelogMigration.java b/sonar-server/src/main/java/org/sonar/server/db/migrations/debt/IssueChangelogMigration.java
index 86be661db40d75dea77046cc7f3d15feec3e9798..628f9deabedee3e20dcb36a34a2938162b05863e 100644 (file)
--- a/sonar-server/src/main/java/org/sonar/server/db/migrations/debt/IssueChangelogMigration.java
+++ b/sonar-server/src/main/java/org/sonar/server/db/migrations/debt/IssueChangelogMigration.java
@@ -57,7 +57,7 @@ public class IssueChangelogMigration implements DatabaseMigration {
 
   private static final String FAILURE_MESSAGE = "Fail to migrate data";
 
-  private static final String SQL_SELECT = "SELECT * FROM issue_changes WHERE change_type = 'diff' and change_data LIKE '%technicalDebt%'";
+  private static final String SQL_SELECT = "SELECT ic.id FROM issue_changes ic WHERE ic.change_type = 'diff' and ic.change_data LIKE '%technicalDebt%'";
   private static final String SQL_UPDATE = "UPDATE issue_changes SET change_data=?,updated_at=? WHERE id=?";
 
   static final String SQL_SELECT_ALL;

diff --git a/sonar-server/src/main/java/org/sonar/server/db/migrations/debt/IssueMigration.java b/sonar-server/src/main/java/org/sonar/server/db/migrations/debt/IssueMigration.java
index 6713eed48faebcb61b4a71b442d2f261372688a4..983410934592b77dd30d0919fa6f8b1e435d590b 100644 (file)
--- a/sonar-server/src/main/java/org/sonar/server/db/migrations/debt/IssueMigration.java
+++ b/sonar-server/src/main/java/org/sonar/server/db/migrations/debt/IssueMigration.java
@@ -54,7 +54,7 @@ public class IssueMigration implements DatabaseMigration {
 
   private static final String FAILURE_MESSAGE = "Fail to convert issue debt from work duration to seconds";
 
-  private static final String SQL_SELECT = "SELECT id FROM issues WHERE technical_debt IS NOT NULL";
+  private static final String SQL_SELECT = "SELECT i.id FROM issues i WHERE i.technical_debt IS NOT NULL";
   private static final String SQL_UPDATE = "UPDATE issues SET technical_debt=?,updated_at=? WHERE id=?";
 
   static final String SQL_SELECT_ISSUES;

diff --git a/sonar-server/src/main/java/org/sonar/server/db/migrations/debt/TechnicalDebtMeasuresMigration.java b/sonar-server/src/main/java/org/sonar/server/db/migrations/debt/TechnicalDebtMeasuresMigration.java
index a8c871099c85468245e8770bc73ed00b9bc1e8a2..d68641bdf27f344028804a23847cbf12c81370d2 100644 (file)
--- a/sonar-server/src/main/java/org/sonar/server/db/migrations/debt/TechnicalDebtMeasuresMigration.java
+++ b/sonar-server/src/main/java/org/sonar/server/db/migrations/debt/TechnicalDebtMeasuresMigration.java
@@ -59,12 +59,12 @@ public class TechnicalDebtMeasuresMigration implements DatabaseMigration {
 
   private static final String FAILURE_MESSAGE = "Fail to migrate data";
 
-  private static final String SQL_SELECT = "SELECT * FROM project_measures INNER JOIN metrics on metrics.id=project_measures.metric_id " +
-    "WHERE (metrics.name='sqale_index' or metrics.name='new_technical_debt' " +
+  private static final String SQL_SELECT = "SELECT pm.id FROM project_measures pm INNER JOIN metrics m on m.id=pm.metric_id " +
+    "WHERE (m.name='sqale_index' or m.name='new_technical_debt' " +
     // SQALE measures
-    "or metrics.name='sqale_effort_to_grade_a' or metrics.name='sqale_effort_to_grade_b' or metrics.name='sqale_effort_to_grade_c' or metrics.name='sqale_effort_to_grade_d' " +
-    "or metrics.name='blocker_remediation_cost' or metrics.name='critical_remediation_cost' or metrics.name='major_remediation_cost' or metrics.name='minor_remediation_cost' " +
-    "or metrics.name='info_remediation_cost' " +
+    "or m.name='sqale_effort_to_grade_a' or m.name='sqale_effort_to_grade_b' or m.name='sqale_effort_to_grade_c' or m.name='sqale_effort_to_grade_d' " +
+    "or m.name='blocker_remediation_cost' or m.name='critical_remediation_cost' or m.name='major_remediation_cost' or m.name='minor_remediation_cost' " +
+    "or m.name='info_remediation_cost' " +
     ")";
 
   private static final String SQL_UPDATE = "UPDATE project_measures SET value=?," +