]> source.dussan.org Git - nextcloud-server.git/commitdiff
get only groupids in default share backend
authorRobin Appelman <robin@icewind.nl>
Mon, 4 May 2020 15:42:28 +0000 (17:42 +0200)
committerRobin Appelman <robin@icewind.nl>
Mon, 4 May 2020 15:42:28 +0000 (17:42 +0200)
instead of getting the full group object and then only using the id anyway

Signed-off-by: Robin Appelman <robin@icewind.nl>
lib/private/Share20/DefaultShareProvider.php

index ff46badee3b5a6b0058812928e4ba678a3630c97..c2de03ea689aa1207a60111f1b862cf260b3604f 100644 (file)
@@ -888,7 +888,7 @@ class DefaultShareProvider implements IShareProvider {
                        $cursor->closeCursor();
                } elseif ($shareType === \OCP\Share::SHARE_TYPE_GROUP) {
                        $user = $this->userManager->get($userId);
-                       $allGroups = $this->groupManager->getUserGroups($user);
+                       $allGroups = $this->groupManager->getUserGroupIds($user);
 
                        /** @var Share[] $shares2 */
                        $shares2 = [];
@@ -925,12 +925,7 @@ class DefaultShareProvider implements IShareProvider {
                                }
 
 
-                               $groups = array_filter($groups, function ($group) {
-                                       return $group instanceof IGroup;
-                               });
-                               $groups = array_map(function (IGroup $group) {
-                                       return $group->getGID();
-                               }, $groups);
+                               $groups = array_filter($groups);
 
                                $qb->andWhere($qb->expr()->eq('share_type', $qb->createNamedParameter(\OCP\Share::SHARE_TYPE_GROUP)))
                                        ->andWhere($qb->expr()->in('share_with', $qb->createNamedParameter(