Fixes style attributes remaining in DOM when swapping reverse positioning in SplitPanel.

svn changeset:15774/svn branch:6.5

diff --git a/src/com/vaadin/terminal/gwt/client/ui/VSplitPanel.java b/src/com/vaadin/terminal/gwt/client/ui/VSplitPanel.java
index 28feb6c1dbb3a0917026ea20b430fad9ba2bb120..37546eea07e29558cd0ee06728206ba535d372b9 100644 (file)
--- a/src/com/vaadin/terminal/gwt/client/ui/VSplitPanel.java
+++ b/src/com/vaadin/terminal/gwt/client/ui/VSplitPanel.java
@@ -217,9 +217,7 @@ public class VSplitPanel extends ComplexPanel implements Container,
 
         setLocked(uidl.getBooleanAttribute("locked"));
 
-        if (uidl.hasAttribute("reversed")) {
-            setPositionReversed(uidl.getBooleanAttribute("reversed"));
-        }
+        setPositionReversed(uidl.getBooleanAttribute("reversed"));
 
         setStylenames();
 
@@ -273,7 +271,11 @@ public class VSplitPanel extends ComplexPanel implements Container,
     }
 
     private void setPositionReversed(boolean reversed) {
-        positionReversed = reversed;
+        if (positionReversed != reversed) {
+            DOM.setStyleAttribute(splitter, "right", "");
+            DOM.setStyleAttribute(splitter, "left", "");
+            positionReversed = reversed;
+        }
     }
 
     private void setSplitPosition(String pos) {

diff --git a/src/com/vaadin/ui/SplitPanel.java b/src/com/vaadin/ui/SplitPanel.java
index cfa391f01013e4cbaef43c7d01b1ab90b8fa26d1..704b04c94cbfa115fe577fc9dbed87a4f7491349 100644 (file)
--- a/src/com/vaadin/ui/SplitPanel.java
+++ b/src/com/vaadin/ui/SplitPanel.java
@@ -470,7 +470,7 @@ public class SplitPanel extends AbstractLayout {
 
         if (variables.containsKey("position") && !isLocked()) {
             Integer newPos = (Integer) variables.get("position");
-            setSplitPosition(newPos, posUnit, false);
+            setSplitPosition(newPos, posUnit, posReversed);
         }
 
         if (variables.containsKey(SPLITTER_CLICK_EVENT)) {