]> source.dussan.org Git - jquery-ui.git/commitdiff
Spinner: Don't change value when changing min/max options
authorDavid Petersen <public@petersendidit.com>
Tue, 20 May 2014 00:29:45 +0000 (19:29 -0500)
committerDavid Petersen <public@petersendidit.com>
Mon, 26 May 2014 16:31:31 +0000 (11:31 -0500)
Fixes #9703
Closes gh-1252

tests/unit/spinner/spinner_events.js
ui/spinner.js

index 610f7a2ecddfd4a8ae31689761cbca20bb0b06e4..007d34cf77091b2a6b7d2efd3f238542a4dd1da1 100644 (file)
@@ -122,7 +122,7 @@ test( "stop", function() {
 });
 
 asyncTest( "change", function() {
-       expect( 14 );
+       expect( 12 );
        var element = $( "#spin" ).spinner();
 
        function shouldChange( expectation, msg ) {
@@ -239,13 +239,13 @@ asyncTest( "change", function() {
                shouldChange( false, "value, same value" );
                element.spinner( "value", 999 );
 
-               shouldChange( true, "max, value changed" );
+               shouldChange( false, "max, value not changed" );
                element.spinner( "option", "max", 900 );
 
                shouldChange( false, "max, value not changed" );
                element.spinner( "option", "max", 1000 );
 
-               shouldChange( true, "min, value changed" );
+               shouldChange( false, "min, value not changed" );
                element.spinner( "option", "min", 950 );
 
                shouldChange( false, "min, value not changed" );
index a8795f024ed27183e3d3ec268940060e632f9d57..263b29d3fbb23c5a414a462db4ad42a908dfec4b 100644 (file)
@@ -403,7 +403,6 @@ return $.widget( "ui.spinner", {
 
        _setOptions: spinner_modifier(function( options ) {
                this._super( options );
-               this._value( this.element.val() );
        }),
 
        _parse: function( val ) {